89655 2012-06-21 06:16:18 -0700 [EFL] Simplify SharedBuffer::createWithContentsOfFile() implementation 2012-06-26 05:11:20 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 cdumez cdumez gyuyoung.kim kenneth lucas.de.marchi rakuco tonikitoo webkit.review.bot oldest_to_newest 654435 0 cdumez 2012-06-21 06:16:18 -0700 The EFL implementation of SharedBuffer::createWithContentsOfFile() could benefit from a slight simplification. 654436 1 148779 cdumez 2012-06-21 06:18:17 -0700 Created attachment 148779 Patch 654733 2 148779 rakuco 2012-06-21 11:27:10 -0700 Comment on attachment 148779 Patch Looks nice, thanks for hunting down those C-isms. 655184 3 148779 gyuyoung.kim 2012-06-21 20:00:03 -0700 Comment on attachment 148779 Patch LGTM too. thanks. 657490 4 148779 ossy 2012-06-26 04:18:40 -0700 Comment on attachment 148779 Patch rs=me 657519 5 148779 webkit.review.bot 2012-06-26 05:11:15 -0700 Comment on attachment 148779 Patch Clearing flags on attachment: 148779 Committed r121254: <http://trac.webkit.org/changeset/121254> 657520 6 webkit.review.bot 2012-06-26 05:11:20 -0700 All reviewed patches have been landed. Closing bug. 148779 2012-06-21 06:18:17 -0700 2012-06-26 05:11:15 -0700 Patch 89655_sharedbuffer.patch text/plain 2237 cdumez ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBhYjU1YjgzLi5kM2UwYTRkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTgg QEAKKzIwMTItMDYtMjEgIENocmlzdG9waGUgRHVtZXogIDxjaHJpc3RvcGhlLmR1bWV6QGludGVs LmNvbT4KKworICAgICAgICBbRUZMXSBTaW1wbGlmeSBTaGFyZWRCdWZmZXI6OmNyZWF0ZVdpdGhD b250ZW50c09mRmlsZSgpIGltcGxlbWVudGF0aW9uCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD04OTY1NQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFNpbXBsaWZ5IHRoZSBpbXBsZW1lbnRhdGlvbiBvZiBTaGFy ZWRCdWZmZXI6OmNyZWF0ZVdpdGhDb250ZW50c09mRmlsZSgpCisgICAgICAgIGluIEVGTCBwb3J0 LgorCisgICAgICAgIE5vIG5ldyB0ZXN0LCBubyBiZWhhdmlvciBjaGFuZ2UuCisKKyAgICAgICAg KiBwbGF0Zm9ybS9lZmwvU2hhcmVkQnVmZmVyRWZsLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlNo YXJlZEJ1ZmZlcjo6Y3JlYXRlV2l0aENvbnRlbnRzT2ZGaWxlKToKKwogMjAxMi0wNi0yMCAgSGFu cyBXZW5uYm9yZyAgPGhhbnNAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFNwZWVjaCBKYXZhU2Ny aXB0IEFQSTogU3BlZWNoUmVjb2duaXRpb24gc2hvdWxkIGhvb2sgdXAgd2l0aCBBY3RpdmVET01P YmplY3QgbW9yZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZWZsL1NoYXJl ZEJ1ZmZlckVmbC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9lZmwvU2hhcmVkQnVmZmVy RWZsLmNwcAppbmRleCA5ZTc2NDZkLi44ZGI0NGE2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS9lZmwvU2hhcmVkQnVmZmVyRWZsLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9lZmwvU2hhcmVkQnVmZmVyRWZsLmNwcApAQCAtMzksMzIgKzM5LDI0IEBAIG5hbWVz cGFjZSBXZWJDb3JlIHsKIAogUGFzc1JlZlB0cjxTaGFyZWRCdWZmZXI+IFNoYXJlZEJ1ZmZlcjo6 Y3JlYXRlV2l0aENvbnRlbnRzT2ZGaWxlKGNvbnN0IFN0cmluZyYgZmlsZVBhdGgpCiB7Ci0gICAg RklMRSogZmlsZTsKLSAgICBzdHJ1Y3Qgc3RhdCBmaWxlU3RhdDsKLSAgICBSZWZQdHI8U2hhcmVk QnVmZmVyPiByZXN1bHQ7Ci0KICAgICBpZiAoZmlsZVBhdGguaXNFbXB0eSgpKQogICAgICAgICBy ZXR1cm4gMDsKIAotICAgIGlmICghKGZpbGUgPSBmb3BlbihmaWxlUGF0aC51dGY4KCkuZGF0YSgp LCAicmIiKSkpCisgICAgRklMRSogZmlsZSA9IGZvcGVuKGZpbGVQYXRoLnV0ZjgoKS5kYXRhKCks ICJyYiIpOworICAgIGlmICghZmlsZSkKICAgICAgICAgcmV0dXJuIDA7CiAKKyAgICBzdHJ1Y3Qg c3RhdCBmaWxlU3RhdDsKICAgICBpZiAoZnN0YXQoZmlsZW5vKGZpbGUpLCAmZmlsZVN0YXQpKSB7 CiAgICAgICAgIGZjbG9zZShmaWxlKTsKICAgICAgICAgcmV0dXJuIDA7CiAgICAgfQogCi0gICAg cmVzdWx0ID0gU2hhcmVkQnVmZmVyOjpjcmVhdGUoKTsKLSAgICByZXN1bHQtPm1fYnVmZmVyLnJl c2l6ZShmaWxlU3RhdC5zdF9zaXplKTsKLSAgICBpZiAocmVzdWx0LT5tX2J1ZmZlci5zaXplKCkg IT0gc3RhdGljX2Nhc3Q8dW5zaWduZWQ+KGZpbGVTdGF0LnN0X3NpemUpKSB7Ci0gICAgICAgIGZj bG9zZShmaWxlKTsKLSAgICAgICAgcmV0dXJuIDA7Ci0gICAgfQotCi0gICAgY29uc3Qgc2l6ZV90 IGJ5dGVzUmVhZCA9IGZyZWFkKHJlc3VsdC0+bV9idWZmZXIuZGF0YSgpLCAxLCBmaWxlU3RhdC5z dF9zaXplLCBmaWxlKTsKKyAgICBWZWN0b3I8Y2hhcj4gYnVmZmVyKGZpbGVTdGF0LnN0X3NpemUp OworICAgIGNvbnN0IHNpemVfdCBieXRlc1JlYWQgPSBmcmVhZChidWZmZXIuZGF0YSgpLCAxLCBi dWZmZXIuc2l6ZSgpLCBmaWxlKTsKICAgICBmY2xvc2UoZmlsZSk7CiAKLSAgICByZXR1cm4gYnl0 ZXNSZWFkID09IHN0YXRpY19jYXN0PHVuc2lnbmVkPihmaWxlU3RhdC5zdF9zaXplKSA/IHJlc3Vs dC5yZWxlYXNlKCkgOiAwOworICAgIHJldHVybiAoYnl0ZXNSZWFkID09IGJ1ZmZlci5zaXplKCkp ID8gU2hhcmVkQnVmZmVyOjphZG9wdFZlY3RvcihidWZmZXIpIDogMDsKIH0KIAogfSAvLyBuYW1l c3BhY2UgV2ViQ29yZQo=