89637 2012-06-20 23:50:17 -0700 [Chromium] keyDown event in JavaScript: event.shiftKey, event.ctrlKey and event.altKey are always false 2012-06-27 19:06:41 -0700 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) Unspecified Linux RESOLVED FIXED P2 Normal --- 1 yusukes yusukes code.vineet tony webkit.review.bot oldest_to_newest 654286 0 yusukes 2012-06-20 23:50:17 -0700 Chromium for Linux does not set .shiftKey, .ctrlKey, and .altKey correctly. For example, when Control key is pressed, the ctrlKey attribute of the event is false, and when it's released the attribute becomes true. Safari, Firefox, and Chrome for Windows/Mac/ChromeOS do the opposite, true on keyDown and false on keyUp, which should be correct. http://code.google.com/p/chromium/issues/detail?id=127142 655335 1 148988 yusukes 2012-06-22 02:56:00 -0700 Created attachment 148988 Patch 655605 2 148988 tony 2012-06-22 11:02:52 -0700 Comment on attachment 148988 Patch Can we write a layout test for this or does eventSender mock the events lower than this? 655611 3 148988 tony 2012-06-22 11:05:26 -0700 Comment on attachment 148988 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=148988&action=review > Source/WebKit/chromium/ChangeLog:8 > + This is a Gtk port of http://crrev.com/142209. > + > + Reviewed by NOBODY (OOPS!). The "Reviewed by..." line goes below the bug link. See the other entries in the ChangeLog. > Source/WebKit/chromium/src/gtk/WebInputEventFactory.cpp:277 > +// Normalizes event->state to make it Windows/Mac compatible. Since the way > +// of setting modifier mask on X is very different than Windows/Mac as shown > +// in http://crbug.com/127142#c8, the normalization is necessary. I would move this comment into the ChangeLog. 658534 4 yusukes 2012-06-27 04:44:28 -0700 Checked DumpRenderTree/chromium/EventSender.cpp. Since the sender mocks an event by directly setting event->modifiers, I think it's hard to write a layout test for my patch. 658536 5 149730 yusukes 2012-06-27 04:49:34 -0700 Created attachment 149730 Patch 659091 6 149730 webkit.review.bot 2012-06-27 19:06:30 -0700 Comment on attachment 149730 Patch Clearing flags on attachment: 149730 Committed r121397: <http://trac.webkit.org/changeset/121397> 659092 7 webkit.review.bot 2012-06-27 19:06:41 -0700 All reviewed patches have been landed. Closing bug. 148988 2012-06-22 02:56:00 -0700 2012-06-27 04:49:20 -0700 Patch bug-89637-20120622185559.patch text/plain 3043 yusukes U3VidmVyc2lvbiBSZXZpc2lvbjogMTIxMDEzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IDYzYmI4YWNhMTVmOGM3Mjc2OGI5MDE1NGU5NzdhYjU2MTE3ODQ1N2YuLjU2ZWMyZDc4ZjdmZTMz YWYyYTYxZTY4MTMxOWUxZDBjMDE5NDAxNWMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTcgQEAKKzIwMTItMDYtMjIgIFl1c3VrZSBTYXRvICA8eXVzdWtlc0BjaHJvbWl1 bS5vcmc+CisKKyAgICAgICAgW2Nocm9taXVtXSBJbXByb3ZlIGtleWJvYXJkRXZlbnQoKSBzbyBh IHdlYiBwYWdlIGNvdWxkIHJlY2VpdmUgYSBET00zIHNwZWMgY29tcGxpYW50IGtleWJvYXJkIGV2 ZW50LgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODk2 MzcKKworICAgICAgICBUaGlzIGlzIGEgR3RrIHBvcnQgb2YgaHR0cDovL2NycmV2LmNvbS8xNDIy MDkuCisgICAgICAgIAorICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICAqIHNyYy9ndGsvV2ViSW5wdXRFdmVudEZhY3RvcnkuY3BwOgorICAgICAgICAoV2ViS2l0 KToKKyAgICAgICAgKFdlYktpdDo6bm9ybWFsaXplRXZlbnRTdGF0ZSk6CisgICAgICAgIChXZWJL aXQ6OldlYklucHV0RXZlbnRGYWN0b3J5OjprZXlib2FyZEV2ZW50KToKKwogMjAxMi0wNi0yMiAg Sm9zZXBoIFBlY29yYXJvICA8cGVjb3Jhcm9AYXBwbGUuY29tPgogCiAgICAgICAgIFdlYiBJbnNw ZWN0b3I6IEluc3BlY3RvclN0YXRlOjp1cGRhdGVDb29raWUgc2hvdWxkIG5vdCBkbyBKU09OIHNl cmlhbGl6YXRpb24gaWYgdW5zdXBwb3J0ZWQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vc3JjL2d0ay9XZWJJbnB1dEV2ZW50RmFjdG9yeS5jcHAgYi9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL3NyYy9ndGsvV2ViSW5wdXRFdmVudEZhY3RvcnkuY3BwCmluZGV4IDcyZGI1MjFkNWJk Y2MxZDA5NWNmMzI3NDZjNzFmNzFmNDVjM2EyN2YuLjQzYzIzOGE2OWRlZWQyNTk0NzZlZjQzNjk2 M2ZhYzcyNzRmMDkwNzcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL2d0 ay9XZWJJbnB1dEV2ZW50RmFjdG9yeS5jcHAKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9z cmMvZ3RrL1dlYklucHV0RXZlbnRGYWN0b3J5LmNwcApAQCAtMjcyLDYgKzI3MiwzOSBAQCBzdGF0 aWMgaW50IGdka0V2ZW50VG9XaW5kb3dzS2V5Q29kZShjb25zdCBHZGtFdmVudEtleSogZXZlbnQp CiAgICAgcmV0dXJuIFdlYkNvcmU6OndpbmRvd3NLZXlDb2RlRm9yS2V5RXZlbnQoZXZlbnQtPmtl eXZhbCk7CiB9CiAKKy8vIE5vcm1hbGl6ZXMgZXZlbnQtPnN0YXRlIHRvIG1ha2UgaXQgV2luZG93 cy9NYWMgY29tcGF0aWJsZS4gU2luY2UgdGhlIHdheQorLy8gb2Ygc2V0dGluZyBtb2RpZmllciBt YXNrIG9uIFggaXMgdmVyeSBkaWZmZXJlbnQgdGhhbiBXaW5kb3dzL01hYyBhcyBzaG93bgorLy8g aW4gaHR0cDovL2NyYnVnLmNvbS8xMjcxNDIjYzgsIHRoZSBub3JtYWxpemF0aW9uIGlzIG5lY2Vz c2FyeS4KK3N0YXRpYyBndWludCBub3JtYWxpemVFdmVudFN0YXRlKGNvbnN0IEdka0V2ZW50S2V5 KiBldmVudCkKK3sKKyAgICBndWludCBtYXNrID0gMDsKKyAgICBzd2l0Y2ggKGdka0V2ZW50VG9X aW5kb3dzS2V5Q29kZShldmVudCkpIHsKKyAgICBjYXNlIFdlYkNvcmU6OlZLRVlfQ09OVFJPTDoK KyAgICBjYXNlIFdlYkNvcmU6OlZLRVlfTENPTlRST0w6CisgICAgY2FzZSBXZWJDb3JlOjpWS0VZ X1JDT05UUk9MOgorICAgICAgICBtYXNrID0gR0RLX0NPTlRST0xfTUFTSzsKKyAgICAgICAgYnJl YWs7CisgICAgY2FzZSBXZWJDb3JlOjpWS0VZX1NISUZUOgorICAgIGNhc2UgV2ViQ29yZTo6VktF WV9MU0hJRlQ6CisgICAgY2FzZSBXZWJDb3JlOjpWS0VZX1JTSElGVDoKKyAgICAgICAgbWFzayA9 IEdES19TSElGVF9NQVNLOworICAgICAgICBicmVhazsKKyAgICBjYXNlIFdlYkNvcmU6OlZLRVlf TUVOVToKKyAgICBjYXNlIFdlYkNvcmU6OlZLRVlfTE1FTlU6CisgICAgY2FzZSBXZWJDb3JlOjpW S0VZX1JNRU5VOgorICAgICAgICBtYXNrID0gR0RLX01PRDFfTUFTSzsKKyAgICAgICAgYnJlYWs7 CisgICAgY2FzZSBXZWJDb3JlOjpWS0VZX0NBUElUQUw6CisgICAgICAgIG1hc2sgPSBHREtfTE9D S19NQVNLOworICAgICAgICBicmVhazsKKyAgICBkZWZhdWx0OgorICAgICAgICByZXR1cm4gZXZl bnQtPnN0YXRlOworICAgIH0KKyAgICBpZiAoZXZlbnQtPnR5cGUgPT0gR0RLX0tFWV9QUkVTUykK KyAgICAgICAgcmV0dXJuIGV2ZW50LT5zdGF0ZSB8IG1hc2s7CisgICAgcmV0dXJuIGV2ZW50LT5z dGF0ZSAmIH5tYXNrOworfQorCiAvLyBHZXRzIHRoZSBjb3JyZXNwb25kaW5nIGNvbnRyb2wgY2hh cmFjdGVyIG9mIGEgc3BlY2lmaWVkIGtleSBjb2RlLiBTZWU6CiAvLyBodHRwOi8vZW4ud2lraXBl ZGlhLm9yZy93aWtpL0NvbnRyb2xfY2hhcmFjdGVycwogLy8gV2UgZW11bGF0ZSBXaW5kb3dzIGJl aGF2aW9yIGhlcmUuCkBAIC0zMjUsNyArMzU4LDcgQEAgV2ViS2V5Ym9hcmRFdmVudCBXZWJJbnB1 dEV2ZW50RmFjdG9yeTo6a2V5Ym9hcmRFdmVudChjb25zdCBHZGtFdmVudEtleSogZXZlbnQpCiAg ICAgV2ViS2V5Ym9hcmRFdmVudCByZXN1bHQ7CiAKICAgICByZXN1bHQudGltZVN0YW1wU2Vjb25k cyA9IGdka0V2ZW50VGltZVRvV2ViRXZlbnRUaW1lKGV2ZW50LT50aW1lKTsKLSAgICByZXN1bHQu bW9kaWZpZXJzID0gZ2RrU3RhdGVUb1dlYkV2ZW50TW9kaWZpZXJzKGV2ZW50LT5zdGF0ZSk7Cisg ICAgcmVzdWx0Lm1vZGlmaWVycyA9IGdka1N0YXRlVG9XZWJFdmVudE1vZGlmaWVycyhub3JtYWxp emVFdmVudFN0YXRlKGV2ZW50KSk7CiAKICAgICBzd2l0Y2ggKGV2ZW50LT50eXBlKSB7CiAgICAg Y2FzZSBHREtfS0VZX1JFTEVBU0U6Cg== 149730 2012-06-27 04:49:34 -0700 2012-06-27 19:06:29 -0700 Patch bug-89637-20120627204930.patch text/plain 3213 yusukes U3VidmVyc2lvbiBSZXZpc2lvbjogMTIxMzM1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IDM2NWQwZWIzY2NhNTFmMmVmYmM1MjVhMjE3YzFhMzYwZWI5YzU5ZTguLjY2NzFlNmUxMWNjNmJh MjEyZWJmMjA5MTA1NmY3MzQ0NTUzNDRhMzQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMjEgQEAKKzIwMTItMDYtMjYgIFl1c3VrZSBTYXRvICA8eXVzdWtlc0BjaHJvbWl1 bS5vcmc+CisKKyAgICAgICAgW2Nocm9taXVtXSBJbXByb3ZlIGtleWJvYXJkRXZlbnQoKSBzbyBh IHdlYiBwYWdlIGNvdWxkIHJlY2VpdmUgYSBET00zIHNwZWMgY29tcGxpYW50IGtleWJvYXJkIGV2 ZW50LgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODk2 MzcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGlz IGlzIGEgR3RrIHBvcnQgb2YgaHR0cDovL2NycmV2LmNvbS8xNDIyMDkuCisKKyAgICAgICAgTm9y bWFsaXplcyBldmVudC0+c3RhdGUgdG8gbWFrZSBpdCBXaW5kb3dzL01hYyBjb21wYXRpYmxlLiBT aW5jZSB0aGUKKyAgICAgICAgd2F5IG9mIHNldHRpbmcgbW9kaWZpZXIgbWFzayBvbiBYIGlzIHZl cnkgZGlmZmVyZW50IHRoYW4gV2luZG93cy9NYWMKKyAgICAgICAgYXMgc2hvd24gaW4gaHR0cDov L2NyYnVnLmNvbS8xMjcxNDIjYzgsIHRoZSBub3JtYWxpemF0aW9uIGlzIG5lY2Vzc2FyeS4KKwor ICAgICAgICAqIHNyYy9ndGsvV2ViSW5wdXRFdmVudEZhY3RvcnkuY3BwOgorICAgICAgICAoV2Vi S2l0KToKKyAgICAgICAgKFdlYktpdDo6bm9ybWFsaXplRXZlbnRTdGF0ZSk6CisgICAgICAgIChX ZWJLaXQ6OldlYklucHV0RXZlbnRGYWN0b3J5OjprZXlib2FyZEV2ZW50KToKKwogMjAxMi0wNi0y NiAgU2hlcmlmZiBCb3QgIDx3ZWJraXQucmV2aWV3LmJvdEBnbWFpbC5jb20+CiAKICAgICAgICAg VW5yZXZpZXdlZC4gIFJvbGxlZCBERVBTLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9jaHJv bWl1bS9zcmMvZ3RrL1dlYklucHV0RXZlbnRGYWN0b3J5LmNwcCBiL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vc3JjL2d0ay9XZWJJbnB1dEV2ZW50RmFjdG9yeS5jcHAKaW5kZXggNzJkYjUyMWQ1YmRj YzFkMDk1Y2YzMjc0NmM3MWY3MWY0NWMzYTI3Zi4uNDNjMjM4YTY5ZGVlZDI1OTQ3NmVmNDM2OTYz ZmFjNzI3NGYwOTA3NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvZ3Rr L1dlYklucHV0RXZlbnRGYWN0b3J5LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3Ny Yy9ndGsvV2ViSW5wdXRFdmVudEZhY3RvcnkuY3BwCkBAIC0yNzIsNiArMjcyLDM5IEBAIHN0YXRp YyBpbnQgZ2RrRXZlbnRUb1dpbmRvd3NLZXlDb2RlKGNvbnN0IEdka0V2ZW50S2V5KiBldmVudCkK ICAgICByZXR1cm4gV2ViQ29yZTo6d2luZG93c0tleUNvZGVGb3JLZXlFdmVudChldmVudC0+a2V5 dmFsKTsKIH0KIAorLy8gTm9ybWFsaXplcyBldmVudC0+c3RhdGUgdG8gbWFrZSBpdCBXaW5kb3dz L01hYyBjb21wYXRpYmxlLiBTaW5jZSB0aGUgd2F5CisvLyBvZiBzZXR0aW5nIG1vZGlmaWVyIG1h c2sgb24gWCBpcyB2ZXJ5IGRpZmZlcmVudCB0aGFuIFdpbmRvd3MvTWFjIGFzIHNob3duCisvLyBp biBodHRwOi8vY3JidWcuY29tLzEyNzE0MiNjOCwgdGhlIG5vcm1hbGl6YXRpb24gaXMgbmVjZXNz YXJ5Lgorc3RhdGljIGd1aW50IG5vcm1hbGl6ZUV2ZW50U3RhdGUoY29uc3QgR2RrRXZlbnRLZXkq IGV2ZW50KQoreworICAgIGd1aW50IG1hc2sgPSAwOworICAgIHN3aXRjaCAoZ2RrRXZlbnRUb1dp bmRvd3NLZXlDb2RlKGV2ZW50KSkgeworICAgIGNhc2UgV2ViQ29yZTo6VktFWV9DT05UUk9MOgor ICAgIGNhc2UgV2ViQ29yZTo6VktFWV9MQ09OVFJPTDoKKyAgICBjYXNlIFdlYkNvcmU6OlZLRVlf UkNPTlRST0w6CisgICAgICAgIG1hc2sgPSBHREtfQ09OVFJPTF9NQVNLOworICAgICAgICBicmVh azsKKyAgICBjYXNlIFdlYkNvcmU6OlZLRVlfU0hJRlQ6CisgICAgY2FzZSBXZWJDb3JlOjpWS0VZ X0xTSElGVDoKKyAgICBjYXNlIFdlYkNvcmU6OlZLRVlfUlNISUZUOgorICAgICAgICBtYXNrID0g R0RLX1NISUZUX01BU0s7CisgICAgICAgIGJyZWFrOworICAgIGNhc2UgV2ViQ29yZTo6VktFWV9N RU5VOgorICAgIGNhc2UgV2ViQ29yZTo6VktFWV9MTUVOVToKKyAgICBjYXNlIFdlYkNvcmU6OlZL RVlfUk1FTlU6CisgICAgICAgIG1hc2sgPSBHREtfTU9EMV9NQVNLOworICAgICAgICBicmVhazsK KyAgICBjYXNlIFdlYkNvcmU6OlZLRVlfQ0FQSVRBTDoKKyAgICAgICAgbWFzayA9IEdES19MT0NL X01BU0s7CisgICAgICAgIGJyZWFrOworICAgIGRlZmF1bHQ6CisgICAgICAgIHJldHVybiBldmVu dC0+c3RhdGU7CisgICAgfQorICAgIGlmIChldmVudC0+dHlwZSA9PSBHREtfS0VZX1BSRVNTKQor ICAgICAgICByZXR1cm4gZXZlbnQtPnN0YXRlIHwgbWFzazsKKyAgICByZXR1cm4gZXZlbnQtPnN0 YXRlICYgfm1hc2s7Cit9CisKIC8vIEdldHMgdGhlIGNvcnJlc3BvbmRpbmcgY29udHJvbCBjaGFy YWN0ZXIgb2YgYSBzcGVjaWZpZWQga2V5IGNvZGUuIFNlZToKIC8vIGh0dHA6Ly9lbi53aWtpcGVk aWEub3JnL3dpa2kvQ29udHJvbF9jaGFyYWN0ZXJzCiAvLyBXZSBlbXVsYXRlIFdpbmRvd3MgYmVo YXZpb3IgaGVyZS4KQEAgLTMyNSw3ICszNTgsNyBAQCBXZWJLZXlib2FyZEV2ZW50IFdlYklucHV0 RXZlbnRGYWN0b3J5OjprZXlib2FyZEV2ZW50KGNvbnN0IEdka0V2ZW50S2V5KiBldmVudCkKICAg ICBXZWJLZXlib2FyZEV2ZW50IHJlc3VsdDsKIAogICAgIHJlc3VsdC50aW1lU3RhbXBTZWNvbmRz ID0gZ2RrRXZlbnRUaW1lVG9XZWJFdmVudFRpbWUoZXZlbnQtPnRpbWUpOwotICAgIHJlc3VsdC5t b2RpZmllcnMgPSBnZGtTdGF0ZVRvV2ViRXZlbnRNb2RpZmllcnMoZXZlbnQtPnN0YXRlKTsKKyAg ICByZXN1bHQubW9kaWZpZXJzID0gZ2RrU3RhdGVUb1dlYkV2ZW50TW9kaWZpZXJzKG5vcm1hbGl6 ZUV2ZW50U3RhdGUoZXZlbnQpKTsKIAogICAgIHN3aXRjaCAoZXZlbnQtPnR5cGUpIHsKICAgICBj YXNlIEdES19LRVlfUkVMRUFTRToK