<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>89615</bug_id>
          
          <creation_ts>2012-06-20 16:41:42 -0700</creation_ts>
          <short_desc>Functions on global objects should be specializable</short_desc>
          <delta_ts>2012-06-20 16:55:39 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>JavaScriptCore</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>All</rep_platform>
          <op_sys>All</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          <dependson>33343</dependson>
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Filip Pizlo">fpizlo</reporter>
          <assigned_to name="Filip Pizlo">fpizlo</assigned_to>
          <cc>barraclough</cc>
    
    <cc>fpizlo</cc>
    
    <cc>ggaren</cc>
    
    <cc>oliver</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>654000</commentid>
    <comment_count>0</comment_count>
    <who name="Filip Pizlo">fpizlo</who>
    <bug_when>2012-06-20 16:41:42 -0700</bug_when>
    <thetext>This will allow us to better optimize things like &quot;new Array()&quot;.

Patch forthcoming.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>654001</commentid>
    <comment_count>1</comment_count>
    <who name="Filip Pizlo">fpizlo</who>
    <bug_when>2012-06-20 16:42:41 -0700</bug_when>
    <thetext>Note that this is related to bug https://bugs.webkit.org/show_bug.cgi?id=33343.

The fix for that bug involved both introducing a thrash limit and disabling specialization entirely for the global object.  I believe that we can reenable specialization, since the thrash limit is so low.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>654011</commentid>
    <comment_count>2</comment_count>
      <attachid>148679</attachid>
    <who name="Filip Pizlo">fpizlo</who>
    <bug_when>2012-06-20 16:53:00 -0700</bug_when>
    <thetext>Created attachment 148679
the patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>654015</commentid>
    <comment_count>3</comment_count>
    <who name="Filip Pizlo">fpizlo</who>
    <bug_when>2012-06-20 16:55:39 -0700</bug_when>
    <thetext>Landed in http://trac.webkit.org/changeset/120886</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>148679</attachid>
            <date>2012-06-20 16:53:00 -0700</date>
            <delta_ts>2012-06-20 16:54:22 -0700</delta_ts>
            <desc>the patch</desc>
            <filename>globalobjspec_patch_1.diff</filename>
            <type>text/plain</type>
            <size>1565</size>
            <attacher name="Filip Pizlo">fpizlo</attacher>
            
              <data encoding="base64">SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291
cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTIwODg1KQorKysgU291cmNl
L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBA
CisyMDEyLTA2LTIwICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CisKKyAgICAgICAg
RnVuY3Rpb25zIG9uIGdsb2JhbCBvYmplY3RzIHNob3VsZCBiZSBzcGVjaWFsaXphYmxlCisgICAg
ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04OTYxNQorCisgICAg
ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorICAgICAgICAKKyAgICAgICAgSSB0ZXN0
ZWQgdG8gc2VlIGlmIHRoaXMgYnJvdWdodCBiYWNrIHRoZSBidWcgaW4gaHR0cHM6Ly9idWdzLndl
YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTMzMzQzLAorICAgICAgICBhbmQgaXQgZGlkbid0LiBC
dWcgMzMzNDMgd2FzIHRoZSByZWFzb24gd2h5IHdlIGRpc2FibGVkIGdsb2JhbCBvYmplY3QgZnVu
Y3Rpb24gc3BlY2lhbGl6YXRpb24KKyAgICAgICAgdG8gYmVnaW4gd2l0aC4gU28gSSdtIGd1ZXNz
aW5nIHRoaXMgaXMgc2FmZS4KKworICAgICAgICAqIHJ1bnRpbWUvSlNHbG9iYWxPYmplY3QuY3Bw
OgorICAgICAgICAoSlNDOjpKU0dsb2JhbE9iamVjdDo6aW5pdCk6CisKIDIwMTItMDYtMjAgIEZp
bGlwIFBpemxvICA8ZnBpemxvQGFwcGxlLmNvbT4KIAogICAgICAgICBidWlsZC13ZWJraXQgZmFp
bHVyZSBkdWUgdG8gaWxsZWdhbCAzMi1iaXQgaW50ZWdlciBjb25zdGFudHMgaW4gY29kZQpJbmRl
eDogU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvSlNHbG9iYWxPYmplY3QuY3BwCj09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0pTR2xvYmFsT2JqZWN0LmNw
cAkocmV2aXNpb24gMTIwODc4KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvSlNH
bG9iYWxPYmplY3QuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xMzIsOCArMTMyLDYgQEAgdm9pZCBK
U0dsb2JhbE9iamVjdDo6aW5pdChKU09iamVjdCogdGhpcwogewogICAgIEFTU0VSVChKU0xvY2s6
OmN1cnJlbnRUaHJlYWRJc0hvbGRpbmdMb2NrKCkpOwogICAgIAotICAgIHN0cnVjdHVyZSgpLT5k
aXNhYmxlU3BlY2lmaWNGdW5jdGlvblRyYWNraW5nKCk7Ci0KICAgICBtX2dsb2JhbFNjb3BlQ2hh
aW4uc2V0KGdsb2JhbERhdGEoKSwgdGhpcywgU2NvcGVDaGFpbk5vZGU6OmNyZWF0ZSgwLCB0aGlz
LCAmZ2xvYmFsRGF0YSgpLCB0aGlzLCB0aGlzVmFsdWUpKTsKIAogICAgIEpTR2xvYmFsT2JqZWN0
OjpnbG9iYWxFeGVjKCktPmluaXQoMCwgMCwgbV9nbG9iYWxTY29wZUNoYWluLmdldCgpLCBDYWxs
RnJhbWU6Om5vQ2FsbGVyKCksIDAsIDApOwo=
</data>
<flag name="review"
          id="156486"
          type_id="1"
          status="+"
          setter="oliver"
    />
          </attachment>
      

    </bug>

</bugzilla>