89590 2012-06-20 11:45:45 -0700 showModalDialog message handling is flaky in WebKit2 2012-06-20 16:05:58 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 beidson beidson andersca jonlee webkit.review.bot oldest_to_newest 653721 0 beidson 2012-06-20 11:45:45 -0700 showModalDialog is flaky in WebKit2 The problem is that CoreIPC messages are randomly not handled while the modal dialog is displaying. Those messages are in the RunLoop's function queue to be handled, but they are blocked on WebPageProxy::runModal() returning. To fix this, we have to make two changes: 1 - Change RunLoop::performWork to not copy its queue to a temporary queue but rather to pull each function off the queue one at a time. 2 - Have WebPageProxy::runModal() wake up the runloop right before calling out to the UIClient so one the nested modal runloop has been entered there's a guarantee it will wake up to handle the remaining messages. In radar as <rdar://problem/11653784> 653736 1 148621 beidson 2012-06-20 12:00:28 -0700 Created attachment 148621 Patch v1 - Proposed fix I'm in the process of running layout tests on this but the only possible change in behavior should be limited to showing modal dialogs... and any changes should be progressions! 653741 2 webkit.review.bot 2012-06-20 12:02:59 -0700 Attachment 148621 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/platform/RunLoop.cpp:63: This { should be at the end of the previous line [whitespace/braces] [4] Source/WebCore/platform/RunLoop.h:36: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 2 in 8 files If any of these errors are false positives, please file a bug against check-webkit-style. 653744 3 jonlee 2012-06-20 12:05:06 -0700 r=me, if i had reviewer privileges. 653747 4 beidson 2012-06-20 12:06:53 -0700 (In reply to comment #2) > Attachment 148621 [details] did not pass style-queue: > > Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 > Source/WebCore/platform/RunLoop.cpp:63: This { should be at the end of the previous line [whitespace/braces] [4] > Source/WebCore/platform/RunLoop.h:36: Alphabetical sorting problem. [build/include_order] [4] > Total errors found: 2 in 8 files > > > If any of these errors are false positives, please file a bug against check-webkit-style. Filed bug 89591 on the bogus warning about RunLoop.cpp:63 - That is our standard MutexLocker idiom throughout the codebase. Will fix the alphabetical ordering before landing. 653762 5 148621 darin 2012-06-20 12:25:25 -0700 Comment on attachment 148621 Patch v1 - Proposed fix View in context: https://bugs.webkit.org/attachment.cgi?id=148621&action=review > Source/WebCore/platform/RunLoop.cpp:59 > void RunLoop::performWork() > { This function needs a why comment explaining the importance of only fetching one function from the queue at a time. The change log does say that this is needed to fix the bug, but the why comment could say something that specifically talks about the fact that during one of the functions we may make another call to RunLoop::performWork and that has to pick up where we left off. >> Source/WebCore/platform/RunLoop.cpp:63 >> + { > > This { should be at the end of the previous line [whitespace/braces] [4] This is a stylebot bug and should be reported to the stylebot folks. >> Source/WebCore/platform/RunLoop.h:36 >> +#include <wtf/Deque.h> > > Alphabetical sorting problem. [build/include_order] [4] Please sort this correctly. > Source/WebKit2/UIProcess/WebPageProxy.cpp:3625 > + process()->connection()->wakeUpRunLoop(); This needs a why comment. Even the change log doesn’t say why, and in fact, I don’t know why! I’m sure it’s easy to explain. 653776 6 beidson 2012-06-20 12:34:22 -0700 (In reply to comment #5) > (From update of attachment 148621 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=148621&action=review > > > Source/WebCore/platform/RunLoop.cpp:59 > > void RunLoop::performWork() > > { > > This function needs a why comment explaining the importance of only fetching one function from the queue at a time. > > The change log does say that this is needed to fix the bug, but the why comment could say something that specifically talks about the fact that during one of the functions we may make another call to RunLoop::performWork and that has to pick up where we left off. Will do! > > >> Source/WebCore/platform/RunLoop.cpp:63 > >> + { > > > > This { should be at the end of the previous line [whitespace/braces] [4] > > This is a stylebot bug and should be reported to the stylebot folks. Had already been filed as https://bugs.webkit.org/show_bug.cgi?id=89591 > > >> Source/WebCore/platform/RunLoop.h:36 > >> +#include <wtf/Deque.h> > > > > Alphabetical sorting problem. [build/include_order] [4] > > Please sort this correctly. Already done locally. > > > Source/WebKit2/UIProcess/WebPageProxy.cpp:3625 > > + process()->connection()->wakeUpRunLoop(); > > This needs a why comment. Even the change log doesn’t say why, and in fact, I don’t know why! I’m sure it’s easy to explain. The ChangeLog does say, actually! But I'll make it more clear both there and in a comment. Thanks for the review! 653966 7 beidson 2012-06-20 16:05:58 -0700 Landed in http://trac.webkit.org/changeset/120879 148621 2012-06-20 12:00:28 -0700 2012-06-20 12:25:25 -0700 Patch v1 - Proposed fix patch.txt text/plain 6743 beidson ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA4MmFjOGY5Li5mYWViODAzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjQg QEAKKzIwMTItMDYtMjAgIEJyYWR5IEVpZHNvbiAgPGJlaWRzb25AYXBwbGUuY29tPgorCisgICAg ICAgIDxyZGFyOi8vcHJvYmxlbS8xMTY1Mzc4ND4gYW5kIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD04OTU5MAorICAgICAgICBzaG93TW9kYWxEaWFsb2cgbWVzc2FnZSBo YW5kbGluZyBpcyBmbGFreSBpbiBXZWJLaXQyCisKKyAgICAgICAgQmVjYXVzZSBSdW5Mb29wOjpw ZXJmb3JtV29yaygpIHN3YXBzIHRoZSBmdW5jdGlvbiBxdWV1ZSB0byBhIHRlbXBvcmFyeSBWZWN0 b3IgYmVmb3JlIGNhbGxpbmcKKyAgICAgICAgdGhlIGZ1bmN0aW9ucyBhbiBpbm5lciBydW4tbG9v cCAtIHN1Y2ggYXMgd2Ugc2VlIHdpdGggcnVubmluZyBhIG1vZGFsIGRpYWxvZyAtIGRvZXMgbm90 IGhhdmUKKyAgICAgICAgYSBjaGFuZ2UgdG8gaGFuZGxlIGFueSBvZiB0aGUgZnVuY3Rpb25zIHRo YXQgd2VyZSBxdWV1ZWQgYWZ0ZXIgdGhlIFdlYlBhZ2VQcm94eTo6UnVuTW9kYWwgbWVzc2FnZS4K KworICAgICAgICBCeSBzZXJ2aWNpbmcgdGhlIGZ1bmN0aW9ucyBpbiB0aGUgcXVldWUgb25lIGF0 IGEgdGltZSBhbmQgc2lnbmFsaW5nIHRoZSBSdW5Mb29wIGJlZm9yZSBlbnRlcmluZworICAgICAg ICB0aGUgbW9kYWwgZGlhbG9nIHRoZXNlIG1lc3NhZ2VzIGdldCBoYW5kbGVkIGFzIGV4cGVjdGVk LgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogV2Vi Q29yZS5leHAuaW46CisgICAgICAgICogcGxhdGZvcm0vUnVuTG9vcC5jcHA6CisgICAgICAgIChX ZWJDb3JlOjpSdW5Mb29wOjpwZXJmb3JtV29yayk6IFRha2UgdGhlIGZpcnN0IGZ1bmN0aW9uIG9m ZiB0aGUgcXVldWUgb25lIGF0IGEgdGltZSBzbyBzdWJzZXF1ZW50CisgICAgICAgICAgZnVuY3Rp b25zIHJlbWFpbiBpbiB0aGUgcXVldWUgYW5kIGNhbiBiZSBoYW5kbGVkIGJ5IGFuIGlubmVyIG1v ZGFsIHJ1biBsb29wLgorICAgICAgICAqIHBsYXRmb3JtL1J1bkxvb3AuaDoKKyAgICAgICAgKFJ1 bkxvb3ApOiBDaGFuZ2UgdGhlIGZ1bmN0aW9uIHF1ZXVlIHRvIGJlIGEgRGVxdWUgdG8gZWZmaWNp ZW50bHkgc3VwcG9ydCAidGFrZUZpcnN0IiAKKwogMjAxMi0wNi0xOCAgTWFydGluIFJvYmluc29u ICA8bXJvYmluc29uQGlnYWxpYS5jb20+CiAKICAgICAgICAgW1RleHR1cmVNYXBwZXJdIFJlcGxh Y2UgdGhlIHNvdXJjZSB0cmFuc2Zvcm0gd2l0aCBhIGZsaXAgdW5pZm9ybQpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYkNvcmUvV2ViQ29yZS5leHAuaW4gYi9Tb3VyY2UvV2ViQ29yZS9XZWJDb3JlLmV4 cC5pbgppbmRleCBmYWRmNzYwLi44NDcyZDRmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9X ZWJDb3JlLmV4cC5pbgorKysgYi9Tb3VyY2UvV2ViQ29yZS9XZWJDb3JlLmV4cC5pbgpAQCAtODAw LDYgKzgwMCw3IEBAIF9fWk43V2ViQ29yZTdSdW5Mb29wMjFpbml0aWFsaXplTWFpblJ1bkxvb3BF dgogX19aTjdXZWJDb3JlN1J1bkxvb3AzcnVuRXYKIF9fWk43V2ViQ29yZTdSdW5Mb29wNG1haW5F dgogX19aTjdXZWJDb3JlN1J1bkxvb3A0c3RvcEV2CitfX1pON1dlYkNvcmU3UnVuTG9vcDZ3YWtl VXBFdgogX19aTjdXZWJDb3JlN1J1bkxvb3A3Y3VycmVudEV2CiBfX1pON1dlYkNvcmU3UnVuTG9v cDhkaXNwYXRjaEVSS04zV1RGOEZ1bmN0aW9uSUZ2dkVFRQogX19aTjdXZWJDb3JlN1J1bkxvb3A5 VGltZXJCYXNlNHN0b3BFdgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vUnVu TG9vcC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9SdW5Mb29wLmNwcAppbmRleCBjYmJj YTRjLi4yNzI2YjcxZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vUnVuTG9v cC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vUnVuTG9vcC5jcHAKQEAgLTU3LDE0 ICs1NywxOSBAQCBSdW5Mb29wKiBSdW5Mb29wOjptYWluKCkKIAogdm9pZCBSdW5Mb29wOjpwZXJm b3JtV29yaygpCiB7Ci0gICAgVmVjdG9yPEZ1bmN0aW9uPHZvaWQoKT4gPiBmdW5jdGlvblF1ZXVl OwotICAgIHsKLSAgICAgICAgTXV0ZXhMb2NrZXIgbG9ja2VyKG1fZnVuY3Rpb25RdWV1ZUxvY2sp OwotICAgICAgICBtX2Z1bmN0aW9uUXVldWUuc3dhcChmdW5jdGlvblF1ZXVlKTsKLSAgICB9Cisg ICAgRnVuY3Rpb248dm9pZCgpPiBmdW5jdGlvbjsKKyAgICAKKyAgICB3aGlsZSAodHJ1ZSkgewor ICAgICAgICB7CisgICAgICAgICAgICBNdXRleExvY2tlciBsb2NrZXIobV9mdW5jdGlvblF1ZXVl TG9jayk7CisgICAgICAgICAgICBpZiAobV9mdW5jdGlvblF1ZXVlLmlzRW1wdHkoKSkKKyAgICAg ICAgICAgICAgICBicmVhazsKIAotICAgIGZvciAoc2l6ZV90IGkgPSAwOyBpIDwgZnVuY3Rpb25R dWV1ZS5zaXplKCk7ICsraSkKLSAgICAgICAgZnVuY3Rpb25RdWV1ZVtpXSgpOworICAgICAgICAg ICAgZnVuY3Rpb24gPSBtX2Z1bmN0aW9uUXVldWUudGFrZUZpcnN0KCk7CisgICAgICAgIH0KKyAg ICAgICAgCisgICAgICAgIGZ1bmN0aW9uKCk7CisgICAgfQogfQogCiB2b2lkIFJ1bkxvb3A6OmRp c3BhdGNoKGNvbnN0IEZ1bmN0aW9uPHZvaWQoKT4mIGZ1bmN0aW9uKQpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vUnVuTG9vcC5oIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v UnVuTG9vcC5oCmluZGV4IDQwYjQxOTQuLmRmOTU5NTQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL1J1bkxvb3AuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9SdW5M b29wLmgKQEAgLTMzLDcgKzMzLDcgQEAKICNpbmNsdWRlIDx3dGYvSGFzaE1hcC5oPgogI2luY2x1 ZGUgPHd0Zi9UaHJlYWRTcGVjaWZpYy5oPgogI2luY2x1ZGUgPHd0Zi9UaHJlYWRpbmcuaD4KLSNp bmNsdWRlIDx3dGYvVmVjdG9yLmg+CisjaW5jbHVkZSA8d3RmL0RlcXVlLmg+CiAKICNpZiBQTEFU Rk9STShHVEspCiAjaW5jbHVkZSA8d3RmL2dvYmplY3QvR1JlZlB0ci5oPgpAQCAtNTgsNiArNTgs NyBAQCBwdWJsaWM6CiAKICAgICBzdGF0aWMgdm9pZCBydW4oKTsKICAgICB2b2lkIHN0b3AoKTsK KyAgICB2b2lkIHdha2VVcCgpOwogCiAjaWYgUExBVEZPUk0oTUFDKQogICAgIHZvaWQgcnVuRm9y RHVyYXRpb24oZG91YmxlIGR1cmF0aW9uKTsKQEAgLTEzMiwxMCArMTMzLDkgQEAgcHJpdmF0ZToK ICAgICB+UnVuTG9vcCgpOwogCiAgICAgdm9pZCBwZXJmb3JtV29yaygpOwotICAgIHZvaWQgd2Fr ZVVwKCk7CiAKICAgICBNdXRleCBtX2Z1bmN0aW9uUXVldWVMb2NrOwotICAgIFZlY3RvcjxGdW5j dGlvbjx2b2lkKCk+ID4gbV9mdW5jdGlvblF1ZXVlOworICAgIERlcXVlPEZ1bmN0aW9uPHZvaWQo KT4gPiBtX2Z1bmN0aW9uUXVldWU7CiAKICNpZiBQTEFURk9STShXSU4pCiAgICAgc3RhdGljIGJv b2wgcmVnaXN0ZXJSdW5Mb29wTWVzc2FnZVdpbmRvd0NsYXNzKCk7CmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViS2l0Mi9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggNDYz M2M3MS4uZjY2YjNjNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBi L1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI1IEBACisyMDEyLTA2LTIwICBC cmFkeSBFaWRzb24gIDxiZWlkc29uQGFwcGxlLmNvbT4KKworICAgICAgICA8cmRhcjovL3Byb2Js ZW0vMTE2NTM3ODQ+IGFuZCBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 ODk1OTAKKyAgICAgICAgc2hvd01vZGFsRGlhbG9nIG1lc3NhZ2UgaGFuZGxpbmcgaXMgZmxha3kg aW4gV2ViS2l0MgorCisgICAgICAgIEJlY2F1c2UgUnVuTG9vcDo6cGVyZm9ybVdvcmsoKSBzd2Fw cyB0aGUgZnVuY3Rpb24gcXVldWUgdG8gYSB0ZW1wb3JhcnkgVmVjdG9yIGJlZm9yZSBjYWxsaW5n CisgICAgICAgIHRoZSBmdW5jdGlvbnMgYW4gaW5uZXIgcnVuLWxvb3AgLSBzdWNoIGFzIHdlIHNl ZSB3aXRoIHJ1bm5pbmcgYSBtb2RhbCBkaWFsb2cgLSBkb2VzIG5vdCBoYXZlCisgICAgICAgIGEg Y2hhbmdlIHRvIGhhbmRsZSBhbnkgb2YgdGhlIGZ1bmN0aW9ucyB0aGF0IHdlcmUgcXVldWVkIGFm dGVyIHRoZSBXZWJQYWdlUHJveHk6OlJ1bk1vZGFsIG1lc3NhZ2UuCisKKyAgICAgICAgQnkgc2Vy dmljaW5nIHRoZSBmdW5jdGlvbnMgaW4gdGhlIHF1ZXVlIG9uZSBhdCBhIHRpbWUgYW5kIHNpZ25h bGluZyB0aGUgUnVuTG9vcCBiZWZvcmUgZW50ZXJpbmcKKyAgICAgICAgdGhlIG1vZGFsIGRpYWxv ZyB0aGVzZSBtZXNzYWdlcyBnZXQgaGFuZGxlZCBhcyBleHBlY3RlZC4KKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFBsYXRmb3JtL0NvcmVJUEMvQ29u bmVjdGlvbi5jcHA6CisgICAgICAgIChDb3JlSVBDOjpDb25uZWN0aW9uOjp3YWtlVXBSdW5Mb29w KTogQWRkZWQgc28gdGhlIFdlYlBhZ2VQcm94eSBjYW4gc2lnbmFsIHRoZSBydW5sb29wIHRvIGJl IHdva2VuIHVwCisgICAgICAgICAgYmVmb3JlIGl0IGVudGVycyB0aGUgbW9kYWwgZGlhbG9nIHJ1 biBsb29wLgorICAgICAgICAqIFBsYXRmb3JtL0NvcmVJUEMvQ29ubmVjdGlvbi5oOgorCisgICAg ICAgICogVUlQcm9jZXNzL1dlYlBhZ2VQcm94eS5jcHA6CisgICAgICAgIChXZWJLaXQ6OldlYlBh Z2VQcm94eTo6cnVuTW9kYWwpOiBDYWxsIHdha2VVcFJ1bkxvb3AoKSBiZWZvcmUgZW50ZXJpbmcg dGhlIG1vZGFsIGRpYWxvZyBydW4gbG9vcC4KKwogMjAxMi0wNi0xNiAgQWRhbSBCYXJ0aCAgPGFi YXJ0aEB3ZWJraXQub3JnPgogCiAgICAgICAgIFNldHRpbmdzOjpkZXZpY2VQaXhlbFJhdGlvIGRv ZXNuJ3QgZG8gYW55dGhpbmcgYW5kIGlzIGNvbmZ1c2luZwpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YktpdDIvUGxhdGZvcm0vQ29yZUlQQy9Db25uZWN0aW9uLmNwcCBiL1NvdXJjZS9XZWJLaXQyL1Bs YXRmb3JtL0NvcmVJUEMvQ29ubmVjdGlvbi5jcHAKaW5kZXggYTNhYTg4Yy4uZDIyYjhiNCAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYktpdDIvUGxhdGZvcm0vQ29yZUlQQy9Db25uZWN0aW9uLmNwcAor KysgYi9Tb3VyY2UvV2ViS2l0Mi9QbGF0Zm9ybS9Db3JlSVBDL0Nvbm5lY3Rpb24uY3BwCkBAIC03 MTcsNCArNzE3LDkgQEAgdm9pZCBDb25uZWN0aW9uOjpkaXNwYXRjaE9uZU1lc3NhZ2UoKQogICAg IGRpc3BhdGNoTWVzc2FnZShpbmNvbWluZ01lc3NhZ2UpOwogfQogCit2b2lkIENvbm5lY3Rpb246 Ondha2VVcFJ1bkxvb3AoKQoreworICAgIG1fY2xpZW50UnVuTG9vcC0+d2FrZVVwKCk7Cit9CisK IH0gLy8gbmFtZXNwYWNlIENvcmVJUEMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1BsYXRm b3JtL0NvcmVJUEMvQ29ubmVjdGlvbi5oIGIvU291cmNlL1dlYktpdDIvUGxhdGZvcm0vQ29yZUlQ Qy9Db25uZWN0aW9uLmgKaW5kZXggMzU0MWIwYS4uNzczZjZlMCAxMDA2NDQKLS0tIGEvU291cmNl L1dlYktpdDIvUGxhdGZvcm0vQ29yZUlQQy9Db25uZWN0aW9uLmgKKysrIGIvU291cmNlL1dlYktp dDIvUGxhdGZvcm0vQ29yZUlQQy9Db25uZWN0aW9uLmgKQEAgLTE2Nyw2ICsxNjcsOCBAQCBwdWJs aWM6CiAgICAgLy8gQWxsIGNsaWVudHMgc2hvdWxkIG1vdmUgdG8gdGhlIG92ZXJsb2FkcyB0aGF0 IHRha2UgYSBtZXNzYWdlIHR5cGUuCiAgICAgdGVtcGxhdGU8dHlwZW5hbWUgRSwgdHlwZW5hbWUg VD4gYm9vbCBkZXByZWNhdGVkU2VuZChFIG1lc3NhZ2VJRCwgdWludDY0X3QgZGVzdGluYXRpb25J RCwgY29uc3QgVCYgYXJndW1lbnRzKTsKICAgICB0ZW1wbGF0ZTx0eXBlbmFtZSBFLCB0eXBlbmFt ZSBULCB0eXBlbmFtZSBVPiBib29sIGRlcHJlY2F0ZWRTZW5kU3luYyhFIG1lc3NhZ2VJRCwgdWlu dDY0X3QgZGVzdGluYXRpb25JRCwgY29uc3QgVCYgYXJndW1lbnRzLCBjb25zdCBVJiByZXBseSwg ZG91YmxlIHRpbWVvdXQgPSBOb1RpbWVvdXQpOworICAgIAorICAgIHZvaWQgd2FrZVVwUnVuTG9v cCgpOwogCiBwcml2YXRlOgogICAgIHRlbXBsYXRlPHR5cGVuYW1lIFQ+IGNsYXNzIE1lc3NhZ2Ug ewpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL1dlYlBhZ2VQcm94eS5jcHAg Yi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvV2ViUGFnZVByb3h5LmNwcAppbmRleCAxNmQ0YTk4 Li43NDdiODJkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvV2ViUGFnZVBy b3h5LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvV2ViUGFnZVByb3h5LmNwcApA QCAtMzYyMiw2ICszNjIyLDcgQEAgdm9pZCBXZWJQYWdlUHJveHk6OnJ1bk1vZGFsKCkKICAgICAv LyBTaW5jZSBydW5Nb2RhbCgpIGNhbiAoYW5kIHByb2JhYmx5IHdpbGwpIHNwaW4gYSBuZXN0ZWQg cnVuIGxvb3Agd2UgbmVlZCB0byB0dXJuIG9mZiB0aGUgcmVzcG9uc2l2ZW5lc3MgdGltZXIuCiAg ICAgcHJvY2VzcygpLT5yZXNwb25zaXZlbmVzc1RpbWVyKCktPnN0b3AoKTsKIAorICAgIHByb2Nl c3MoKS0+Y29ubmVjdGlvbigpLT53YWtlVXBSdW5Mb29wKCk7CiAgICAgbV91aUNsaWVudC5ydW5N b2RhbCh0aGlzKTsKIH0KIAo=