89567 2012-06-20 06:32:38 -0700 Web Inspector: don't report context ids before DidCommitLoad 2012-06-20 23:56:54 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 yurys yurys apavlov bweinstein joepeck jyasskin keishi loislo pfeldman pmuellr rik timothy yurys oldest_to_newest 653410 0 yurys 2012-06-20 06:32:38 -0700 PageRuntimeAgent::restore() will unconditionally inspected page's frame tree and report context ids for all frames, this may trigger initialization of the contexts if DidCommitLoad event hasn't happened yet. This may lead to some unexpected results like the one described in http://crbug.com/131623 653414 1 148554 yurys 2012-06-20 06:36:24 -0700 Created attachment 148554 Patch 653417 2 148554 pfeldman 2012-06-20 06:39:23 -0700 Comment on attachment 148554 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=148554&action=review > Source/WebCore/inspector/PageRuntimeAgent.cpp:89 > + if (m_inspectorAgent->didCommitLoadFired()) { I would instead delegate original didCommitLoad instrumentation here and stored the state (i.e. copied the inspectorAgent's logic). 653440 3 148554 yurys 2012-06-20 07:19:21 -0700 Comment on attachment 148554 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=148554&action=review >> Source/WebCore/inspector/PageRuntimeAgent.cpp:89 >> + if (m_inspectorAgent->didCommitLoadFired()) { > > I would instead delegate original didCommitLoad instrumentation here and stored the state (i.e. copied the inspectorAgent's logic). This would require making this agent always enabled, otherwise we would miss didCommitLoad event. InspectorAgent is an agent that doesn't depend on other agents and is always enabled so it is a good place for storing the flag. 653443 4 pfeldman 2012-06-20 07:22:34 -0700 Ok, lets them simply move m_didCommitLoadFired into the InspectorPageAgent. It seems more appropriate and is only user there. It would remove the InspectorPageAgent->InspectorAgent dependency as well. 653475 5 yurys 2012-06-20 08:07:47 -0700 Committed r120822: <http://trac.webkit.org/changeset/120822> 653593 6 jyasskin 2012-06-20 10:18:26 -0700 Where's the test to make sure this doesn't regress in the future? 654289 7 yurys 2012-06-20 23:56:54 -0700 (In reply to comment #6) > Where's the test to make sure this doesn't regress in the future? A test will go downstream since we can only reproduce it with Chromium extensions at the moment. 148554 2012-06-20 06:36:24 -0700 2012-06-20 07:32:32 -0700 Patch bug-89567-20120620173623.patch text/plain 6152 yurys U3VidmVyc2lvbiBSZXZpc2lvbjogMTIwODA0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMzhjMmYyMzczYTU0YTlm MmYwZTE4NmVlMDA2YjU4NDQ1Zjc1NjYxMy4uNzM5ZDE3ODc2ZTFkM2U0NzlkYjYyMDcyNzg2OGQ1 ODhkZWQ4MmNhYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDEyLTA2LTIwICBZdXJ5 IFNlbWlraGF0c2t5ICA8eXVyeXNAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFdlYiBJbnNwZWN0 b3I6IGRvbid0IHJlcG9ydCBjb250ZXh0IGlkcyBiZWZvcmUgRGlkQ29tbWl0TG9hZAorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODk1NjcKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXaGVuIGluc3BlY3RvciBz dGF0ZSBpcyByZXN0b3JlZCBvbmx5IHJlcG9ydCBleGlzdGluZyBjb250ZXh0IGlkcworICAgICAg ICBpZiAiZGlkIGNvbW1pdCBsb2FkIiBldmVuIGhhcyBhbHJlYWR5IGJlZW4gZGlzcGF0Y2hlZC4K KworICAgICAgICAqIGluc3BlY3Rvci9JbnNwZWN0b3JDb250cm9sbGVyLmNwcDoKKyAgICAgICAg KFdlYkNvcmU6Okluc3BlY3RvckNvbnRyb2xsZXI6Okluc3BlY3RvckNvbnRyb2xsZXIpOgorICAg ICAgICAqIGluc3BlY3Rvci9QYWdlUnVudGltZUFnZW50LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6 OlBhZ2VSdW50aW1lQWdlbnQ6OlBhZ2VSdW50aW1lQWdlbnQpOgorICAgICAgICAoV2ViQ29yZTo6 UGFnZVJ1bnRpbWVBZ2VudDo6cmVzdG9yZSk6CisgICAgICAgICogaW5zcGVjdG9yL1BhZ2VSdW50 aW1lQWdlbnQuaDoKKyAgICAgICAgKFdlYkNvcmUpOgorICAgICAgICAoV2ViQ29yZTo6UGFnZVJ1 bnRpbWVBZ2VudDo6Y3JlYXRlKToKKyAgICAgICAgKFBhZ2VSdW50aW1lQWdlbnQpOgorCiAyMDEy LTA2LTE5ICBCZW5qYW1pbiBQb3VsYWluICA8YnBvdWxhaW5AYXBwbGUuY29tPgogCiAgICAgICAg IFJlZmFjdG9yaW5nOiBHZW9sb2NhdGlvbjo6c3RhcnRSZXF1ZXN0KCkgc2hvdWxkIG5vdCBjcmVh dGUgdGhlIEdlb05vdGlmaWVycwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9y L0luc3BlY3RvckNvbnRyb2xsZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL0luc3Bl Y3RvckNvbnRyb2xsZXIuY3BwCmluZGV4IDlkYWMyZmVhNDA0Yjc2NjAxZWEwMDU2Zjc0N2Y5YzMw ZmJmNzQwMzcuLjA5NWUxY2M1MWIzNTRhOGY4ZTA4MTQ2YTc5ZWY3MDhkYjdjZDQ5Y2UgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0b3JDb250cm9sbGVyLmNwcAor KysgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVjdG9yQ29udHJvbGxlci5jcHAKQEAg LTEyMSw3ICsxMjEsNyBAQCBJbnNwZWN0b3JDb250cm9sbGVyOjpJbnNwZWN0b3JDb250cm9sbGVy KFBhZ2UqIHBhZ2UsIEluc3BlY3RvckNsaWVudCogaW5zcGVjdG9yQwogICAgIG1fcmVzb3VyY2VB Z2VudCA9IHJlc291cmNlQWdlbnRQdHIuZ2V0KCk7CiAgICAgbV9hZ2VudHMuYXBwZW5kKHJlc291 cmNlQWdlbnRQdHIucmVsZWFzZSgpKTsKIAotICAgIE93blB0cjxJbnNwZWN0b3JSdW50aW1lQWdl bnQ+IHJ1bnRpbWVBZ2VudFB0cihQYWdlUnVudGltZUFnZW50OjpjcmVhdGUobV9pbnN0cnVtZW50 aW5nQWdlbnRzLmdldCgpLCBtX3N0YXRlLmdldCgpLCBtX2luamVjdGVkU2NyaXB0TWFuYWdlci5n ZXQoKSwgcGFnZSwgcGFnZUFnZW50KSk7CisgICAgT3duUHRyPEluc3BlY3RvclJ1bnRpbWVBZ2Vu dD4gcnVudGltZUFnZW50UHRyKFBhZ2VSdW50aW1lQWdlbnQ6OmNyZWF0ZShtX2luc3RydW1lbnRp bmdBZ2VudHMuZ2V0KCksIG1fc3RhdGUuZ2V0KCksIG1faW5qZWN0ZWRTY3JpcHRNYW5hZ2VyLmdl dCgpLCBwYWdlLCBwYWdlQWdlbnQsIG1faW5zcGVjdG9yQWdlbnQpKTsKICAgICBJbnNwZWN0b3JS dW50aW1lQWdlbnQqIHJ1bnRpbWVBZ2VudCA9IHJ1bnRpbWVBZ2VudFB0ci5nZXQoKTsKICAgICBt X2FnZW50cy5hcHBlbmQocnVudGltZUFnZW50UHRyLnJlbGVhc2UoKSk7CiAKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9QYWdlUnVudGltZUFnZW50LmNwcCBiL1NvdXJjZS9X ZWJDb3JlL2luc3BlY3Rvci9QYWdlUnVudGltZUFnZW50LmNwcAppbmRleCBiMjk2MmJkODM4MzQw NjE4ODcwMjgwNzZlZTEyZWE2NTg5ZWEwNTZiLi4zNWQ1NmY1Yzk5OWMwZjA4Y2E1YTg0ZDlhZWUy ODMyNDA3YWIxNTIyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvUGFnZVJ1 bnRpbWVBZ2VudC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL1BhZ2VSdW50aW1l QWdlbnQuY3BwCkBAIC0zOCw2ICszOCw3IEBACiAjaW5jbHVkZSAiRG9jdW1lbnQuaCIKICNpbmNs dWRlICJJbmplY3RlZFNjcmlwdC5oIgogI2luY2x1ZGUgIkluamVjdGVkU2NyaXB0TWFuYWdlci5o IgorI2luY2x1ZGUgIkluc3BlY3RvckFnZW50LmgiCiAjaW5jbHVkZSAiSW5zcGVjdG9yUGFnZUFn ZW50LmgiCiAjaW5jbHVkZSAiSW5zcGVjdG9yU3RhdGUuaCIKICNpbmNsdWRlICJJbnN0cnVtZW50 aW5nQWdlbnRzLmgiCkBAIC01MiwxMCArNTMsMTEgQEAgbmFtZXNwYWNlIFBhZ2VSdW50aW1lQWdl bnRTdGF0ZSB7CiBzdGF0aWMgY29uc3QgY2hhciByZXBvcnRFeGVjdXRpb25Db250ZXh0Q3JlYXRp b25bXSA9ICJyZXBvcnRFeGVjdXRpb25Db250ZXh0Q3JlYXRpb24iOwogfTsKIAotUGFnZVJ1bnRp bWVBZ2VudDo6UGFnZVJ1bnRpbWVBZ2VudChJbnN0cnVtZW50aW5nQWdlbnRzKiBpbnN0cnVtZW50 aW5nQWdlbnRzLCBJbnNwZWN0b3JTdGF0ZSogc3RhdGUsIEluamVjdGVkU2NyaXB0TWFuYWdlciog aW5qZWN0ZWRTY3JpcHRNYW5hZ2VyLCBQYWdlKiBwYWdlLCBJbnNwZWN0b3JQYWdlQWdlbnQqIHBh Z2VBZ2VudCkKK1BhZ2VSdW50aW1lQWdlbnQ6OlBhZ2VSdW50aW1lQWdlbnQoSW5zdHJ1bWVudGlu Z0FnZW50cyogaW5zdHJ1bWVudGluZ0FnZW50cywgSW5zcGVjdG9yU3RhdGUqIHN0YXRlLCBJbmpl Y3RlZFNjcmlwdE1hbmFnZXIqIGluamVjdGVkU2NyaXB0TWFuYWdlciwgUGFnZSogcGFnZSwgSW5z cGVjdG9yUGFnZUFnZW50KiBwYWdlQWdlbnQsIEluc3BlY3RvckFnZW50KiBpbnNwZWN0b3JBZ2Vu dCkKICAgICA6IEluc3BlY3RvclJ1bnRpbWVBZ2VudChpbnN0cnVtZW50aW5nQWdlbnRzLCBzdGF0 ZSwgaW5qZWN0ZWRTY3JpcHRNYW5hZ2VyKQogICAgICwgbV9pbnNwZWN0ZWRQYWdlKHBhZ2UpCiAg ICAgLCBtX3BhZ2VBZ2VudChwYWdlQWdlbnQpCisgICAgLCBtX2luc3BlY3RvckFnZW50KGluc3Bl Y3RvckFnZW50KQogICAgICwgbV9mcm9udGVuZCgwKQogewogfQpAQCAtODEsOCArODMsMTMgQEAg dm9pZCBQYWdlUnVudGltZUFnZW50OjpyZXN0b3JlKCkKIHsKICAgICBpZiAoIW1fc3RhdGUtPmdl dEJvb2xlYW4oUGFnZVJ1bnRpbWVBZ2VudFN0YXRlOjpyZXBvcnRFeGVjdXRpb25Db250ZXh0Q3Jl YXRpb24pKQogICAgICAgICByZXR1cm47Ci0gICAgU3RyaW5nIGVycm9yOwotICAgIHNldFJlcG9y dEV4ZWN1dGlvbkNvbnRleHRDcmVhdGlvbigmZXJyb3IsIHRydWUpOworICAgIC8vIE9ubHkgcmVw b3J0IGV4aXN0aW5nIGNvbnRleHRzIGlmIHRoZSBwYWdlIGRpZCBjb21taXQgbG9hZCwgb3RoZXJ3 aXNlIHdlIG1heQorICAgIC8vIHVuaW50ZW50aW9uYWxseSBpbml0aWFsaXplIGNvbnRleHRzIGlu IHRoZSBmcmFtZXMgd2hpY2ggbWF5IHRyaWdnZXIgc29tZSBsaXN0ZW5lcnMKKyAgICAvLyB0aGF0 IGFyZSBleHBlY3RlZCB0byBiZSB0cmlnZ2VyZWQgb25seSBhZnRlciB0aGUgbG9hZCBpcyBjb21t aXR0ZWQsIHNlZSBodHRwOi8vY3JidWcuY29tLzEzMTYyMworICAgIGlmIChtX2luc3BlY3RvckFn ZW50LT5kaWRDb21taXRMb2FkRmlyZWQoKSkgeworICAgICAgICBTdHJpbmcgZXJyb3I7CisgICAg ICAgIHNldFJlcG9ydEV4ZWN1dGlvbkNvbnRleHRDcmVhdGlvbigmZXJyb3IsIHRydWUpOworICAg IH0KIH0KIAogdm9pZCBQYWdlUnVudGltZUFnZW50OjpzZXRSZXBvcnRFeGVjdXRpb25Db250ZXh0 Q3JlYXRpb24oRXJyb3JTdHJpbmcqLCBib29sIGVuYWJsZSkKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJDb3JlL2luc3BlY3Rvci9QYWdlUnVudGltZUFnZW50LmggYi9Tb3VyY2UvV2ViQ29yZS9pbnNw ZWN0b3IvUGFnZVJ1bnRpbWVBZ2VudC5oCmluZGV4IDQ4MzIxN2Y0NGVkZDdmMjQzYjhlMjA2OTIx ZjliZGY3OWFjMjc3MzMuLjljOTJkODA3YTA1MjZmNGMyMjQ4YzU1ZDU1MWYwYWQ0YzQzM2VhNzcg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9QYWdlUnVudGltZUFnZW50LmgK KysrIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL1BhZ2VSdW50aW1lQWdlbnQuaApAQCAtNDAs MTUgKzQwLDE2IEBACiAKIG5hbWVzcGFjZSBXZWJDb3JlIHsKIAorY2xhc3MgSW5zcGVjdG9yQWdl bnQ7CiBjbGFzcyBJbnNwZWN0b3JQYWdlQWdlbnQ7CiBjbGFzcyBQYWdlOwogY2xhc3MgU2VjdXJp dHlPcmlnaW47CiAKIGNsYXNzIFBhZ2VSdW50aW1lQWdlbnQgOiBwdWJsaWMgSW5zcGVjdG9yUnVu dGltZUFnZW50IHsKIHB1YmxpYzoKLSAgICBzdGF0aWMgUGFzc093blB0cjxQYWdlUnVudGltZUFn ZW50PiBjcmVhdGUoSW5zdHJ1bWVudGluZ0FnZW50cyogaW5zdHJ1bWVudGluZ0FnZW50cywgSW5z cGVjdG9yU3RhdGUqIHN0YXRlLCBJbmplY3RlZFNjcmlwdE1hbmFnZXIqIGluamVjdGVkU2NyaXB0 TWFuYWdlciwgUGFnZSogcGFnZSwgSW5zcGVjdG9yUGFnZUFnZW50KiBwYWdlQWdlbnQpCisgICAg c3RhdGljIFBhc3NPd25QdHI8UGFnZVJ1bnRpbWVBZ2VudD4gY3JlYXRlKEluc3RydW1lbnRpbmdB Z2VudHMqIGluc3RydW1lbnRpbmdBZ2VudHMsIEluc3BlY3RvclN0YXRlKiBzdGF0ZSwgSW5qZWN0 ZWRTY3JpcHRNYW5hZ2VyKiBpbmplY3RlZFNjcmlwdE1hbmFnZXIsIFBhZ2UqIHBhZ2UsIEluc3Bl Y3RvclBhZ2VBZ2VudCogcGFnZUFnZW50LCBJbnNwZWN0b3JBZ2VudCogaW5zcGVjdG9yQWdlbnQp CiAgICAgewotICAgICAgICByZXR1cm4gYWRvcHRQdHIobmV3IFBhZ2VSdW50aW1lQWdlbnQoaW5z dHJ1bWVudGluZ0FnZW50cywgc3RhdGUsIGluamVjdGVkU2NyaXB0TWFuYWdlciwgcGFnZSwgcGFn ZUFnZW50KSk7CisgICAgICAgIHJldHVybiBhZG9wdFB0cihuZXcgUGFnZVJ1bnRpbWVBZ2VudChp bnN0cnVtZW50aW5nQWdlbnRzLCBzdGF0ZSwgaW5qZWN0ZWRTY3JpcHRNYW5hZ2VyLCBwYWdlLCBw YWdlQWdlbnQsIGluc3BlY3RvckFnZW50KSk7CiAgICAgfQogICAgIHZpcnR1YWwgflBhZ2VSdW50 aW1lQWdlbnQoKTsKICAgICB2aXJ0dWFsIHZvaWQgc2V0RnJvbnRlbmQoSW5zcGVjdG9yRnJvbnRl bmQqKTsKQEAgLTYwLDcgKzYxLDcgQEAgcHVibGljOgogICAgIHZvaWQgZGlkQ3JlYXRlSXNvbGF0 ZWRDb250ZXh0KEZyYW1lKiwgU2NyaXB0U3RhdGUqLCBTZWN1cml0eU9yaWdpbiopOwogCiBwcml2 YXRlOgotICAgIFBhZ2VSdW50aW1lQWdlbnQoSW5zdHJ1bWVudGluZ0FnZW50cyosIEluc3BlY3Rv clN0YXRlKiwgSW5qZWN0ZWRTY3JpcHRNYW5hZ2VyKiwgUGFnZSosIEluc3BlY3RvclBhZ2VBZ2Vu dCopOworICAgIFBhZ2VSdW50aW1lQWdlbnQoSW5zdHJ1bWVudGluZ0FnZW50cyosIEluc3BlY3Rv clN0YXRlKiwgSW5qZWN0ZWRTY3JpcHRNYW5hZ2VyKiwgUGFnZSosIEluc3BlY3RvclBhZ2VBZ2Vu dCosIEluc3BlY3RvckFnZW50Kik7CiAKICAgICB2aXJ0dWFsIEluamVjdGVkU2NyaXB0IGluamVj dGVkU2NyaXB0Rm9yRXZhbChFcnJvclN0cmluZyosIGNvbnN0IGludCogZXhlY3V0aW9uQ29udGV4 dElkKTsKICAgICB2aXJ0dWFsIHZvaWQgbXV0ZUNvbnNvbGUoKTsKQEAgLTY5LDYgKzcwLDcgQEAg cHJpdmF0ZToKIAogICAgIFBhZ2UqIG1faW5zcGVjdGVkUGFnZTsKICAgICBJbnNwZWN0b3JQYWdl QWdlbnQqIG1fcGFnZUFnZW50OworICAgIEluc3BlY3RvckFnZW50KiBtX2luc3BlY3RvckFnZW50 OwogICAgIEluc3BlY3RvckZyb250ZW5kOjpSdW50aW1lKiBtX2Zyb250ZW5kOwogfTsKIAo=