89563 2012-06-20 06:23:30 -0700 DRT/WTR python interface handles about:blank incorrectly 2012-06-21 16:32:25 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 zoltan zoltan abarth ap dpranke ojan rniwa webkit.review.bot oldest_to_newest 653394 0 zoltan 2012-06-20 06:23:30 -0700 WPR loads about:blank before every page load. In the case of loading about:blank we should not wait longer than 1 sec. 653396 1 148549 zoltan 2012-06-20 06:25:21 -0700 Created attachment 148549 proposed patch 653574 2 rniwa 2012-06-20 10:03:58 -0700 Why is this necessary? about:blank should be loaded in a few milliseconds, no? 653596 3 ap 2012-06-20 10:20:06 -0700 What is "WPR"? 653627 4 zoltan 2012-06-20 10:40:56 -0700 (In reply to comment #2) > Why is this necessary? about:blank should be loaded in a few milliseconds, no? On Qt's side server_process.py:217 (select.select(select_fds, [], select_fds, deadline - time.time())) hangs until the timeout ends what is 10 minutes by default. (In reply to comment #3) > What is "WPR"? Web Page Reply 653628 5 zoltan 2012-06-20 10:41:12 -0700 Web Page Replay 653712 6 rniwa 2012-06-20 11:41:33 -0700 (In reply to comment #4) > (In reply to comment #2) > > Why is this necessary? about:blank should be loaded in a few milliseconds, no? > > On Qt's side server_process.py:217 (select.select(select_fds, [], select_fds, deadline - time.time())) hangs until the timeout ends what is 10 minutes by default. !? That sounds like a bug of its own. We should fix that instead. 653854 7 zoltan 2012-06-20 13:45:56 -0700 (In reply to comment #6) > > !? That sounds like a bug of its own. We should fix that instead. Right! I might need some help. Could you check me two things on your port? 1. output of "DumpRenderTree about:blank" 2. webkitpy/layout_tests/port/webkit.py:564, please print command and share the first result with me (it will be about:blank somehow, for me it's /home/zoltan/prog/local/WebKit/LayoutTests/about:blank) I'm trying to figure out the problem related to Qt-port. 654427 8 zoltan 2012-06-21 05:59:55 -0700 I have the proper fix, I will upload and modify the patch later today. 654808 9 148867 zoltan 2012-06-21 12:45:42 -0700 Created attachment 148867 proposed patch Currently DRT/WTR python interface's _command_from_driver_input function puts the test directory path before about:blank. Remove this incorrect behavior. e.g. /home/zoltan/prog/local/WebKit/LayoutTests/about:blank Let it just use about:blank. :) 655008 10 148867 webkit.review.bot 2012-06-21 16:32:20 -0700 Comment on attachment 148867 proposed patch Clearing flags on attachment: 148867 Committed r120977: <http://trac.webkit.org/changeset/120977> 655009 11 webkit.review.bot 2012-06-21 16:32:25 -0700 All reviewed patches have been landed. Closing bug. 148549 2012-06-20 06:25:21 -0700 2012-06-21 12:45:42 -0700 proposed patch onesec.patch text/plain 1489 zoltan ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCBmOTgz MmY3Li5kNmM1ZTIyIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTItMDYtMjAgIFpvbHRhbiBIb3J2YXRoICA8em9s dGFuQHdlYmtpdC5vcmc+CisKKyAgICAgICAgTW9kaWZ5IHRoZSB0aW1lb3V0IHRvIDEgc2VjIGlu IGNhc2Ugb2YgV1BSIGFib3V0OmJsYW5rIGxvYWRpbmcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTg5NTYzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgV1BSIGZpcnN0IGxvYWRzIGFib3V0OmJsYW5rIGJlZm9y ZSBldmVyeSBwYWdlIGxvYWQuIEluIHRoZSBjYXNlIG9mCisgICAgICAgIGxvYWRpbmcgYWJvdXQ6 Ymxhbmsgd2Ugc2hvdWxkIG5vdCB3YWl0IGxvbmdlciB0aGFuIDEgc2VjLgorCisgICAgICAgICog U2NyaXB0cy93ZWJraXRweS9wZXJmb3JtYW5jZV90ZXN0cy9wZXJmdGVzdC5weToKKyAgICAgICAg KFJlcGxheVBlcmZUZXN0LnJ1bl9zaW5nbGUpOgorCiAyMDEyLTA2LTIwICBTaW1vbiBIYXVzbWFu biAgPHNpbW9uLmhhdXNtYW5uQG5va2lhLmNvbT4KIAogICAgICAgICBVbnJldmlld2VkIHRyaXZp YWwgcGVybWlzc2lvbnMgZml4LgpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9w ZXJmb3JtYW5jZV90ZXN0cy9wZXJmdGVzdC5weSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvcGVy Zm9ybWFuY2VfdGVzdHMvcGVyZnRlc3QucHkKb2xkIG1vZGUgMTAwNjQ0Cm5ldyBtb2RlIDEwMDc1 NQppbmRleCA4OTZiYWQ0Li5mZTMzYzI5Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvcGVy Zm9ybWFuY2VfdGVzdHMvcGVyZnRlc3QucHkKKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9w ZXJmb3JtYW5jZV90ZXN0cy9wZXJmdGVzdC5weQpAQCAtMzAyLDcgKzMwMiw3IEBAIGNsYXNzIFJl cGxheVBlcmZUZXN0KFBhZ2VMb2FkaW5nUGVyZlRlc3QpOgogICAgICAgICAgICAgICAgIF9sb2cu ZXJyb3IoIldlYiBwYWdlIHJlcGxheSBkaWRuJ3Qgc3RhcnQuIikKICAgICAgICAgICAgICAgICBy ZXR1cm4gTm9uZQogCi0gICAgICAgICAgICBzdXBlcihSZXBsYXlQZXJmVGVzdCwgc2VsZikucnVu X3NpbmdsZShkcml2ZXIsICJhYm91dDpibGFuayIsIHRpbWVfb3V0X21zKQorICAgICAgICAgICAg c3VwZXIoUmVwbGF5UGVyZlRlc3QsIHNlbGYpLnJ1bl9zaW5nbGUoZHJpdmVyLCAiYWJvdXQ6Ymxh bmsiLCAxMDAwKQogICAgICAgICAgICAgX2xvZy5kZWJ1ZygiTG9hZGluZyB0aGUgcGFnZSIpCiAK ICAgICAgICAgICAgIG91dHB1dCA9IHN1cGVyKFJlcGxheVBlcmZUZXN0LCBzZWxmKS5ydW5fc2lu Z2xlKGRyaXZlciwgc2VsZi5fdXJsLCB0aW1lX291dF9tcywgc2hvdWxkX3J1bl9waXhlbF90ZXN0 PVRydWUpCg== 148867 2012-06-21 12:45:42 -0700 2012-06-21 16:32:20 -0700 proposed patch beforapathremove.patch text/plain 1633 zoltan ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCA5ZDU0 ZmE0Li44ZDIzZjFiIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTItMDYtMjEgIFpvbHRhbiBIb3J2YXRoICA8em9s dGFuQHdlYmtpdC5vcmc+CisKKyAgICAgICAgRFJUL1dUUiBweXRob24gaW50ZXJmYWNlIGhhbmRs ZXMgYWJvdXQ6YmxhbmsgaW5jb3JyZWN0bHkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTg5NTYzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgQ3VycmVudGx5IERSVC9XVFIgcHl0aG9uIGludGVyZmFjZSdzIF9j b21tYW5kX2Zyb21fZHJpdmVyX2lucHV0IGZ1bmN0aW9uCisgICAgICAgIHB1dHMgdGhlIHRlc3Qg ZGlyZWN0b3J5IHBhdGggYmVmb3JlIGFib3V0OmJsYW5rLiBSZW1vdmUgdGhpcyBpbmNvcnJlY3Qg YmVoYXZpb3IuCisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0 L3dlYmtpdC5weToKKyAgICAgICAgKFdlYktpdERyaXZlci5fY29tbWFuZF9mcm9tX2RyaXZlcl9p bnB1dCk6CisKIDIwMTItMDYtMjEgIFNoZXJpZmYgQm90ICA8d2Via2l0LnJldmlldy5ib3RAZ21h aWwuY29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQsIHJvbGxpbmcgb3V0IHIxMjA5MzcuCmRpZmYg LS1naXQgYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L3dlYmtpdC5w eSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvd2Via2l0LnB5Cm9s ZCBtb2RlIDEwMDY0NApuZXcgbW9kZSAxMDA3NTUKaW5kZXggYWIzNWE2NC4uMmExZTZlOAotLS0g YS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L3dlYmtpdC5weQorKysg Yi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L3dlYmtpdC5weQpAQCAt NTI1LDcgKzUyNSw3IEBAIGNsYXNzIFdlYktpdERyaXZlcihEcml2ZXIpOgogCiAgICAgZGVmIF9j b21tYW5kX2Zyb21fZHJpdmVyX2lucHV0KHNlbGYsIGRyaXZlcl9pbnB1dCk6CiAgICAgICAgICMg RklYTUU6IHBlcmZvcm1hbmNlIHRlc3RzIHBhc3MgaW4gZnVsbCBVUkxzIGluc3RlYWQgb2YgdGVz dCBuYW1lcy4KLSAgICAgICAgaWYgZHJpdmVyX2lucHV0LnRlc3RfbmFtZS5zdGFydHN3aXRoKCdo dHRwOi8vJykgb3IgZHJpdmVyX2lucHV0LnRlc3RfbmFtZS5zdGFydHN3aXRoKCdodHRwczovLycp OgorICAgICAgICBpZiBkcml2ZXJfaW5wdXQudGVzdF9uYW1lLnN0YXJ0c3dpdGgoJ2h0dHA6Ly8n KSBvciBkcml2ZXJfaW5wdXQudGVzdF9uYW1lLnN0YXJ0c3dpdGgoJ2h0dHBzOi8vJykgIG9yIGRy aXZlcl9pbnB1dC50ZXN0X25hbWUgPT0gKCdhYm91dDpibGFuaycpOgogICAgICAgICAgICAgY29t bWFuZCA9IGRyaXZlcl9pbnB1dC50ZXN0X25hbWUKICAgICAgICAgZWxpZiBzZWxmLmlzX2h0dHBf dGVzdChkcml2ZXJfaW5wdXQudGVzdF9uYW1lKToKICAgICAgICAgICAgIGNvbW1hbmQgPSBzZWxm LnRlc3RfdG9fdXJpKGRyaXZlcl9pbnB1dC50ZXN0X25hbWUpCg==