89561 2012-06-20 04:54:33 -0700 [Cairo] Fix memory leak in GraphicsContext3DCairo.cpp 2012-06-20 09:07:55 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 naginenis naginenis mrobinson webkit.review.bot oldest_to_newest 653346 0 naginenis 2012-06-20 04:54:33 -0700 Memory leak found in GraphicsContext3D::getImageData() ==25464== 1,944 (24 direct, 1,920 indirect) bytes in 3 blocks are definitely lost in loss record 16,777 of 17,337 ==25464== at 0x4C2B1C7: operator new(unsigned long) (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so) ==25464== by 0x6C3E543: WebCore::ImageFrame::asNewNativeImage() const (ImageDecoderCairo.cpp:37) ==25464== by 0x6C01543: WebCore::ImageSource::createFrameAtIndex(unsigned long) (ImageSource.cpp:156) ==25464== by 0x71C52DE: WebCore::GraphicsContext3D::getImageData(WebCore::Image*, unsigned int, unsigned int, bool, bool, WTF::Vector<unsigned char, 0ul>&) (GraphicsContext3DCairo.cpp:162) ==25464== by 0x71B3CA7: WebCore::GraphicsContext3D::extractImageData(WebCore::Image*, unsigned int, unsigned int, bool, bool, bool, WTF::Vector<unsigned char, 0ul>&) (GraphicsContext3D.cpp:180) ==25464== by 0x719CC8F: WebCore::WebGLRenderingContext::texImage2DImpl(unsigned int, int, unsigned int, unsigned int, unsigned int, WebCore::Image*, bool, bool, int&) (WebGLRenderingContext.cpp:3548) ==25464== by 0x719D288: WebCore::WebGLRenderingContext::texImage2D(unsigned int, int, unsigned int, unsigned int, unsigned int, WebCore::HTMLImageElement*, int&) (WebGLRenderingContext.cpp:3620) ==25464== by 0x74BB08F: WebCore::jsWebGLRenderingContextPrototypeFunctionTexImage2D3(JSC::ExecState*) (JSWebGLRenderingContext.cpp:3239) ==25464== by 0x74BBB61: WebCore::jsWebGLRenderingContextPrototypeFunctionTexImage2D(JSC::ExecState*) (JSWebGLRenderingContext.cpp:3326) 653373 1 148542 naginenis 2012-06-20 05:51:41 -0700 Created attachment 148542 Patch Patch fixes a memory leak. 653529 2 148542 webkit.review.bot 2012-06-20 09:07:48 -0700 Comment on attachment 148542 Patch Clearing flags on attachment: 148542 Committed r120826: <http://trac.webkit.org/changeset/120826> 653530 3 webkit.review.bot 2012-06-20 09:07:55 -0700 All reviewed patches have been landed. Closing bug. 148542 2012-06-20 05:51:41 -0700 2012-06-20 09:07:48 -0700 Patch 89561.patch text/plain 1773 naginenis ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBjNTY1MWNmLi41NjNmYTA2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcg QEAKKzIwMTItMDYtMjAgIFN1ZGFyc2FuYSBOYWdpbmVuaSAgPHN1ZGFyc2FuYS5uYWdpbmVuaUBs aW51eC5pbnRlbC5jb20+CisKKyAgICAgICAgW0NhaXJvXSBGaXggbWVtb3J5IGxlYWsgaW4gR3Jh cGhpY3NDb250ZXh0M0RDYWlyby5jcHAKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTg5NTYxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgRml4IGEgbWVtb3J5IGxlYWsgaW4gR3JhcGhpY3NDb250ZXh0M0Q6Omdl dEltYWdlRGF0YSgpLgorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvY2Fpcm8vR3JhcGhp Y3NDb250ZXh0M0RDYWlyby5jcHA6CisgICAgICAgIChXZWJDb3JlOjpHcmFwaGljc0NvbnRleHQz RDo6Z2V0SW1hZ2VEYXRhKTogYXNOZXdOYXRpdmVJbWFnZSgpIHJldHVybnMgYQorICAgICAgICBj YWxsZXItb3duZWQgcG9pbnRlciB0byB0aGUgbmF0aXZlIGltYWdlIGRhdGEuIFNvLCB1c2luZyBP d25QdHIgdG8gbWFuYWdlCisgICAgICAgIG1lbW9yeSBhdXRvbWF0aWNhbGx5LgorCiAyMDEyLTA2 LTIwICBUYWthc2hpIFNha2Ftb3RvICA8dGFzYWtAZ29vZ2xlLmNvbT4KIAogICAgICAgICBhcHBs eUF1dGhvclN0eWxlcyBtYWtlcyBydWxlcyBkZWNsYXJlZCBpbiBhbGwgZW5jbG9zaW5nIHNoYWRv dyBkb20gc3VidHJlZXMgYXBwbGljYWJsZS4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL2dyYXBoaWNzL2NhaXJvL0dyYXBoaWNzQ29udGV4dDNEQ2Fpcm8uY3BwIGIvU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2Fpcm8vR3JhcGhpY3NDb250ZXh0M0RDYWlyby5j cHAKaW5kZXggNjY5ZWI5Yy4uYWMyOTJkMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vZ3JhcGhpY3MvY2Fpcm8vR3JhcGhpY3NDb250ZXh0M0RDYWlyby5jcHAKKysrIGIvU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2Fpcm8vR3JhcGhpY3NDb250ZXh0M0RDYWly by5jcHAKQEAgLTE1OSw3ICsxNTksOCBAQCBib29sIEdyYXBoaWNzQ29udGV4dDNEOjpnZXRJbWFn ZURhdGEoSW1hZ2UqIGltYWdlLCB1bnNpZ25lZCBpbnQgZm9ybWF0LCB1bnNpZ25lZAogICAgICAg ICBkZWNvZGVyLnNldERhdGEoaW1hZ2UtPmRhdGEoKSwgdHJ1ZSk7CiAgICAgICAgIGlmICghZGVj b2Rlci5mcmFtZUNvdW50KCkgfHwgIWRlY29kZXIuZnJhbWVJc0NvbXBsZXRlQXRJbmRleCgwKSkK ICAgICAgICAgICAgIHJldHVybiBmYWxzZTsKLSAgICAgICAgaW1hZ2VTdXJmYWNlID0gZGVjb2Rl ci5jcmVhdGVGcmFtZUF0SW5kZXgoMCktPnN1cmZhY2UoKTsKKyAgICAgICAgT3duUHRyPE5hdGl2 ZUltYWdlQ2Fpcm8+IG5hdGl2ZUltYWdlID0gYWRvcHRQdHIoZGVjb2Rlci5jcmVhdGVGcmFtZUF0 SW5kZXgoMCkpOworICAgICAgICBpbWFnZVN1cmZhY2UgPSBuYXRpdmVJbWFnZS0+c3VyZmFjZSgp OwogICAgIH0gZWxzZSB7CiAgICAgICAgIGltYWdlU3VyZmFjZSA9IGltYWdlLT5uYXRpdmVJbWFn ZUZvckN1cnJlbnRGcmFtZSgpLT5zdXJmYWNlKCk7CiAgICAgICAgIGlmICghcHJlbXVsdGlwbHlB bHBoYSkK