89559 2012-06-20 03:35:17 -0700 Web Inspector: duplicating selected text when Enter key is pressed. 2012-06-20 09:15:45 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 rogulenko webkit-unassigned apavlov bweinstein joepeck keishi loislo pfeldman pmuellr rik timothy vsevik webkit.review.bot yurys oldest_to_newest 653327 0 rogulenko 2012-06-20 03:35:17 -0700 If you open a file in Sources in inspector, select some text from bottom to top(!) and press Enter key, the selected text will not substitute with one new line. Also, if you try to undo this action, the respond will not bring you to initial state. 653386 1 148546 rogulenko 2012-06-20 06:12:25 -0700 Created attachment 148546 Patch 653428 2 148546 pfeldman 2012-06-20 06:55:55 -0700 Comment on attachment 148546 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=148546&action=review > Source/WebCore/ChangeLog:3 > + Fixing Bug 89559 - Web Inspector: handling enter key bug Patch should start with the bug title. > Source/WebCore/ChangeLog:5 > + Web Inspector: handling enter key bug This bug title is too vague, please be more specific > Source/WebCore/ChangeLog:12 > + The person who fixed Bug 71625 forgot to use result of his own method. We typically say "Regressed in rXXXX" where XXXX is a revision number. That should be mentioned in the bug description. > Source/WebCore/inspector/front-end/TextViewer.js:1254 > this._exitTextChangeMode(range, newRange); You should call exitTextChangeMode with exact newRange that editRange returned. 653463 3 148566 rogulenko 2012-06-20 07:48:57 -0700 Created attachment 148566 Patch 653537 4 148566 webkit.review.bot 2012-06-20 09:15:39 -0700 Comment on attachment 148566 Patch Clearing flags on attachment: 148566 Committed r120827: <http://trac.webkit.org/changeset/120827> 653538 5 webkit.review.bot 2012-06-20 09:15:45 -0700 All reviewed patches have been landed. Closing bug. 148546 2012-06-20 06:12:25 -0700 2012-06-20 07:48:48 -0700 Patch bug-89559-20120620171224.patch text/plain 1822 rogulenko U3VidmVyc2lvbiBSZXZpc2lvbjogMTIwODE1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZjk4NTdhNzBkMmY4MWIx NDdjZjQ0NGZiMDJkZTc4MzQ2YjllMGZlZS4uZGRjM2RiZDI3MjkyNGY1ZTlkYWRhZmI5ZjJkZGE0 MDI3MGJjYzlkNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEyLTA2LTIwICBTZXJn ZXkgUm9ndWxlbmtvICA8cm9ndWxlbmtvQGdvb2dsZS5jb20+CisKKyAgICAgICAgRml4aW5nIEJ1 ZyA4OTU1OSAtIFdlYiBJbnNwZWN0b3I6IGhhbmRsaW5nIGVudGVyIGtleSBidWcKKworICAgICAg ICBXZWIgSW5zcGVjdG9yOiBoYW5kbGluZyBlbnRlciBrZXkgYnVnCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04OTU1OQorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogaW5zcGVjdG9yL2Zyb250LWVuZC9UZXh0 Vmlld2VyLmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9yLlRleHRFZGl0b3JNYWluUGFuZWwucHJv dG90eXBlLmhhbmRsZUVudGVyS2V5KToKKyAgICAgICAgVGhlIHBlcnNvbiB3aG8gZml4ZWQgQnVn IDcxNjI1IGZvcmdvdCB0byB1c2UgcmVzdWx0IG9mIGhpcyBvd24gbWV0aG9kLgorCiAyMDEyLTA2 LTIwICBBbXkgT3VzdGVyaG91dCAgPGFvdXN0ZXJoQGNocm9taXVtLm9yZz4KIAogICAgICAgICBB ZGRzIERldmljZU1vdGlvbkNsaWVudE1vY2sKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2lu c3BlY3Rvci9mcm9udC1lbmQvVGV4dFZpZXdlci5qcyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rv ci9mcm9udC1lbmQvVGV4dFZpZXdlci5qcwppbmRleCBkODBkNmNjMDEzZDdhOGMxZTNjODM4NWUx Njg0MGI1ZmQ3MjQyOGIzLi43ZjM4ZmJlNzM5YTA4ODIzNjQwMjBlMWUwMWJlM2YwOTliYmYyNGU0 IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1RleHRWaWV3 ZXIuanMKKysrIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9UZXh0Vmlld2Vy LmpzCkBAIC0xMjE2LDcgKzEyMTYsNyBAQCBXZWJJbnNwZWN0b3IuVGV4dEVkaXRvck1haW5QYW5l bC5wcm90b3R5cGUgPSB7CiAgICAgICAgIGlmICghcmFuZ2UpCiAgICAgICAgICAgICByZXR1cm4g ZmFsc2U7CiAKLSAgICAgICAgcmFuZ2Uubm9ybWFsaXplKCk7CisgICAgICAgIHJhbmdlID0gcmFu Z2Uubm9ybWFsaXplKCk7CiAKICAgICAgICAgaWYgKHJhbmdlLmVuZENvbHVtbiA9PT0gMCkKICAg ICAgICAgICAgIHJldHVybiBmYWxzZTsKQEAgLTEyNDksOSArMTI0OSwxMSBAQCBXZWJJbnNwZWN0 b3IuVGV4dEVkaXRvck1haW5QYW5lbC5wcm90b3R5cGUgPSB7CiAgICAgICAgIH0gZWxzZQogICAg ICAgICAgICAgbmV3UmFuZ2UgPSB0aGlzLl9lZGl0UmFuZ2UocmFuZ2UsIGxpbmVCcmVhayArIGlu ZGVudCk7CiAKKyAgICAgICAgbmV3UmFuZ2UgPSBuZXdSYW5nZS5jb2xsYXBzZVRvRW5kKCk7CisK ICAgICAgICAgdGhpcy5fZXhpdFRleHRDaGFuZ2VNb2RlKHJhbmdlLCBuZXdSYW5nZSk7CiAgICAg ICAgIHRoaXMuZW5kVXBkYXRlcygpOwotICAgICAgICB0aGlzLl9yZXN0b3JlU2VsZWN0aW9uKG5l d1JhbmdlLmNvbGxhcHNlVG9FbmQoKSwgdHJ1ZSk7CisgICAgICAgIHRoaXMuX3Jlc3RvcmVTZWxl Y3Rpb24obmV3UmFuZ2UsIHRydWUpOwogCiAgICAgICAgIHJldHVybiB0cnVlOwogICAgIH0sCg== 148566 2012-06-20 07:48:57 -0700 2012-06-20 09:15:39 -0700 Patch bug-89559-20120620184856.patch text/plain 1341 rogulenko U3VidmVyc2lvbiBSZXZpc2lvbjogMTIwODE1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZjk4NTdhNzBkMmY4MWIx NDdjZjQ0NGZiMDJkZTc4MzQ2YjllMGZlZS4uZDE1NWQ0MWNmMDNiNjMwNWRjNTI2MWVjMGUyZDhh NDBiZjhjYzhhMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDEyLTA2LTIwICBTZXJn ZXkgUm9ndWxlbmtvICA8cm9ndWxlbmtvQGdvb2dsZS5jb20+CisKKyAgICAgICAgV2ViIEluc3Bl Y3RvcjogZHVwbGljYXRpbmcgc2VsZWN0ZWQgdGV4dCB3aGVuIEVudGVyIGtleSBpcyBwcmVzc2Vk IAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODk1NTkK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGluc3Bl Y3Rvci9mcm9udC1lbmQvVGV4dFZpZXdlci5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rvci5UZXh0 RWRpdG9yTWFpblBhbmVsLnByb3RvdHlwZS5oYW5kbGVFbnRlcktleSk6CisgICAgICAgIFRoZSBy ZXR1cm5lZCByZXN1bHQgb2YgbWV0aG9kIG5vcm1hbGl6ZSgpIHNob3VsZCBiZSB1c2VkLgorCiAy MDEyLTA2LTIwICBBbXkgT3VzdGVyaG91dCAgPGFvdXN0ZXJoQGNocm9taXVtLm9yZz4KIAogICAg ICAgICBBZGRzIERldmljZU1vdGlvbkNsaWVudE1vY2sKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD b3JlL2luc3BlY3Rvci9mcm9udC1lbmQvVGV4dFZpZXdlci5qcyBiL1NvdXJjZS9XZWJDb3JlL2lu c3BlY3Rvci9mcm9udC1lbmQvVGV4dFZpZXdlci5qcwppbmRleCBkODBkNmNjMDEzZDdhOGMxZTNj ODM4NWUxNjg0MGI1ZmQ3MjQyOGIzLi5lMzZlMTlkNjYzMDJjNTAyN2RmN2JhMDA1MmFmMzA4NTVj MDg5NzY0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1Rl eHRWaWV3ZXIuanMKKysrIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9UZXh0 Vmlld2VyLmpzCkBAIC0xMjE2LDcgKzEyMTYsNyBAQCBXZWJJbnNwZWN0b3IuVGV4dEVkaXRvck1h aW5QYW5lbC5wcm90b3R5cGUgPSB7CiAgICAgICAgIGlmICghcmFuZ2UpCiAgICAgICAgICAgICBy ZXR1cm4gZmFsc2U7CiAKLSAgICAgICAgcmFuZ2Uubm9ybWFsaXplKCk7CisgICAgICAgIHJhbmdl ID0gcmFuZ2Uubm9ybWFsaXplKCk7CiAKICAgICAgICAgaWYgKHJhbmdlLmVuZENvbHVtbiA9PT0g MCkKICAgICAgICAgICAgIHJldHVybiBmYWxzZTsK