89539 2012-06-19 18:37:32 -0700 Fix a form restore test broken by HTML5 parser 2012-06-19 21:28:17 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 88685 89409 1 tkent tkent abarth eric haraken morrita rafaelw webkit.review.bot oldest_to_newest 653076 0 tkent 2012-06-19 18:37:32 -0700 http://trac.webkit.org/changeset/66482 made fast/forms/restore-to-non-edited-controls.html nonsense. We fix the test in this bug. 653080 1 148481 tkent 2012-06-19 18:48:34 -0700 Created attachment 148481 Patch 653104 2 148481 haraken 2012-06-19 19:22:02 -0700 Comment on attachment 148481 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=148481&action=review > LayoutTests/ChangeLog:13 > + After HTML5 parser, we don't attach renderes during innerHTML Nit: renderes => renderers > LayoutTests/ChangeLog:15 > + built a form and the test haven't work since introducing HTML5 parser. Just a confirmation: What happens if innerHTML is used and <!DOCTYPE html> is omitted? I am asking this because I am not sure whether we should hide the difference by using document.write() (just like your patch) or we should test innerHTML for both <!DOCTYPE html> case and no-<!DOCTYPE html> case. 653106 3 148481 tkent 2012-06-19 19:23:57 -0700 Comment on attachment 148481 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=148481&action=review >> LayoutTests/ChangeLog:15 >> + built a form and the test haven't work since introducing HTML5 parser. > > Just a confirmation: What happens if innerHTML is used and <!DOCTYPE html> is omitted? > > I am asking this because I am not sure whether we should hide the difference by using document.write() (just like your patch) or we should test innerHTML for both <!DOCTYPE html> case and no-<!DOCTYPE html> case. DOCTYPE doesn't matter. We always use HTML5 parser. 653107 4 148487 tkent 2012-06-19 19:24:57 -0700 Created attachment 148487 Patch 2 typo 653109 5 148487 haraken 2012-06-19 19:28:27 -0700 Comment on attachment 148487 Patch 2 Thanks for the clarification. 653113 6 eric 2012-06-19 19:57:26 -0700 I'm confused. If we changed innerHTML behavior, was this a regression? Does our new innerHTML/form behavior match other browsers? It's good that we fixed the test, but there may be an underlying bug here that we're pasting over? 653128 7 tkent 2012-06-19 20:23:56 -0700 (In reply to comment #6) > I'm confused. If we changed innerHTML behavior, was this a regression? Does our new innerHTML/form behavior match other browsers? > > It's good that we fixed the test, but there may be an underlying bug here that we're pasting over? Yeah, HTML5 parser made a regression. We were able to restore form values for dynamically generated form with innerHTML, but now we can't. However I haven't seen bug reports for this regression. I guess this is not so important to users. I think there are no ways to observe whether a node is attached in Node::finishParsingChildren() in innerHTML case on other browsers, and this is not a compatibility issue. I have a plan to change the form restore timing. The regression will be resolved then. 653141 8 eric 2012-06-19 20:31:46 -0700 (In reply to comment #7) > (In reply to comment #6) > I have a plan to change the form restore timing. The regression will be resolved then. Do we have a bug to track that change. Seems useful to relate here. Thanks! 653143 9 tkent 2012-06-19 20:35:25 -0700 (In reply to comment #8) > (In reply to comment #7) > > (In reply to comment #6) > > I have a plan to change the form restore timing. The regression will be resolved then. > > Do we have a bug to track that change. Seems useful to relate here. Thanks! I explained the plan in https://bugs.webkit.org/show_bug.cgi?id=23346#c45 . I'll add a new blocker bug for the timing change to Bug 23346. 653169 10 tkent 2012-06-19 21:26:28 -0700 Committed r120796: <http://trac.webkit.org/changeset/120796> 148481 2012-06-19 18:48:34 -0700 2012-06-19 19:24:52 -0700 Patch bug-89539-20120620104833.patch text/plain 4730 tkent U3VidmVyc2lvbiBSZXZpc2lvbjogMTIwNjc5CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggYWJmZGJiMDkzODE0NDA4MzVjMmYw ZjY0MjlmMDE5Nzc0MGE3OThiYy4uYmU2ZDRmZTgzY2Y3ZWUwM2ViMTZjMGNkYzY1ODkyZWU4YTM0 MDc2NCAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDI3IEBACisyMDEyLTA2LTE5ICBLZW50IFRhbXVyYSAgPHRr ZW50QGNocm9taXVtLm9yZz4KKworICAgICAgICBGaXggYSBmb3JtIHJlc3RvcmUgdGVzdCBicm9r ZW4gYnkgSFRNTDUgcGFyc2VyCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD04OTUzOQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIEJlZm9yZSBIVE1MNSBwYXJzZXIsIHdlIHBhcnNlZCBpbm5lckhUTUwgaW5wdXQg dGV4dCBhbmQgd2UgYXR0YWNoZWQKKyAgICAgICAgcmVuZGVyZXJzIHRvIHBhcnNlZCBub2RlcyBh dCB0aGUgc2FtZSB0aW1lLiBUaGUgcGFyc2VkIG5vZGVzIGhhZAorICAgICAgICByZXN0b3JlZCBm b3JtIHZhbHVlcyBiZWNhdXNlIHdlIHJlc3RvcmUgZm9ybSB2YWx1ZXMgb25seSBmb3IgYXR0YWNo ZWQKKyAgICAgICAgZWxlbWVudHMuCisKKyAgICAgICAgQWZ0ZXIgSFRNTDUgcGFyc2VyLCB3ZSBk b24ndCBhdHRhY2ggcmVuZGVyZXMgZHVyaW5nIGlubmVySFRNTAorICAgICAgICBwYXJzaW5nLiBz dGF0ZS1yZXN0b3JlLXRvLW5vbmVkaXRlZC1jb250cm9scy5odG1sIHVzZWQgaW5uZXJIVE1MIHRv CisgICAgICAgIGJ1aWx0IGEgZm9ybSBhbmQgdGhlIHRlc3QgaGF2ZW4ndCB3b3JrIHNpbmNlIGlu dHJvZHVjaW5nIEhUTUw1IHBhcnNlci4KKworICAgICAgICBUaGlzIHBhdGNoIGNoYW5nZXMgdGhl IHRlc3Qgc28gdGhhdCBpdCB1c2VzIGRvY3VtZW50LndyaXRlKCkgaW5zdGVhZCBvZgorICAgICAg ICBpbm5lckhUTUwuCisKKyAgICAgICAgKiBmYXN0L2Zvcm1zL3N0YXRlLXJlc3RvcmUtdG8tbm9u LWVkaXRlZC1jb250cm9scy1leHBlY3RlZC50eHQ6CisgICAgICAgIE5vdGUgdGhhdCB0aGUgRkFJ TCBsaW5lIGlzIGV4cGVjdGVkLiBJdCdzIGR1ZSB0byBCdWcgODg2ODUuCisgICAgICAgICogZmFz dC9mb3Jtcy9zdGF0ZS1yZXN0b3JlLXRvLW5vbi1lZGl0ZWQtY29udHJvbHMuaHRtbDoKKyAgICAg ICAgVXNlIGRvY3VtZW50LndyaXRlKCkgaW5zdGVhZCBvZiBpbm5lckhUTUwuCisKIDIwMTItMDYt MTggIFphbiBEb2JlcnNlayAgPHphbmRvYmVyc2VrQGdtYWlsLmNvbT4KIAogICAgICAgICBVbnJl dmlld2VkIEdUSyBnYXJkZW5pbmcsIHVwZGF0aW5nIGJhc2VsaW5lcyBhZnRlciByb2xsb3V0cyBp biByMTIwNjI3LgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9mb3Jtcy9zdGF0ZS1yZXN0 b3JlLXRvLW5vbi1lZGl0ZWQtY29udHJvbHMtZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvZmFz dC9mb3Jtcy9zdGF0ZS1yZXN0b3JlLXRvLW5vbi1lZGl0ZWQtY29udHJvbHMtZXhwZWN0ZWQudHh0 CmluZGV4IDVhOTJjMTU5YjY5ZmFlZWEwZDc1ZmNkNmE3Yzc1ZGExNzVlYzA2NjkuLjJmZmVjMDA1 YmE5Y2RkOTFmOWNmMmQ4OTQyYWJiYjFmOWEzZGYyOGYgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3Rz L2Zhc3QvZm9ybXMvc3RhdGUtcmVzdG9yZS10by1ub24tZWRpdGVkLWNvbnRyb2xzLWV4cGVjdGVk LnR4dAorKysgYi9MYXlvdXRUZXN0cy9mYXN0L2Zvcm1zL3N0YXRlLXJlc3RvcmUtdG8tbm9uLWVk aXRlZC1jb250cm9scy1leHBlY3RlZC50eHQKQEAgLTEsMTEgKzEsMTEgQEAKIFRlc3QgdG8gTk9U IHNhdmUgc3RhdGUgZm9yIG5vbi1lZGl0ZWQgY29udHJvbHMKIAogUEFTUyBkb2N1bWVudC5nZXRF bGVtZW50QnlJZCgiYnV0dG9uIikudmFsdWUgaXMgIjIiCi1QQVNTIGRvY3VtZW50LmdldEVsZW1l bnRCeUlkKCJoaWRkZW4iKS52YWx1ZSBpcyAiMiIKK0ZBSUwgZG9jdW1lbnQuZ2V0RWxlbWVudEJ5 SWQoImhpZGRlbiIpLnZhbHVlIHNob3VsZCBiZSAyLiBXYXMgMS4KIFBBU1MgZG9jdW1lbnQuZ2V0 RWxlbWVudEJ5SWQoImltYWdlIikudmFsdWUgaXMgIjIiCiBQQVNTIGRvY3VtZW50LmdldEVsZW1l bnRCeUlkKCJyZXNldCIpLnZhbHVlIGlzICIyIgogUEFTUyBkb2N1bWVudC5nZXRFbGVtZW50QnlJ ZCgic3VibWl0MSIpLnZhbHVlIGlzICIyIgotUEFTUyBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgi dGV4dDEiKS52YWx1ZSBpcyAiMiIKK1BBU1MgZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoInRleHQx IikudmFsdWUgaXMgImVkaXQiCiBQQVNTIGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCJ0ZXh0MiIp LnZhbHVlIGlzICIyIgogUEFTUyBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgidGV4dGFyZWEiKS52 YWx1ZSBpcyAiMiIKIApkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9mb3Jtcy9zdGF0ZS1y ZXN0b3JlLXRvLW5vbi1lZGl0ZWQtY29udHJvbHMuaHRtbCBiL0xheW91dFRlc3RzL2Zhc3QvZm9y bXMvc3RhdGUtcmVzdG9yZS10by1ub24tZWRpdGVkLWNvbnRyb2xzLmh0bWwKaW5kZXggYzlkOGYx ZTI4NmYwNzcyZjE0ODc1YTdlYzgzYWI2N2I2MWE4NDRkMy4uYTQ0YzM1NGYzNTY0ODIzZmJhMzNj NzBhOGYzMDg2ZDAzZTI1MjI3ZiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvZmFzdC9mb3Jtcy9z dGF0ZS1yZXN0b3JlLXRvLW5vbi1lZGl0ZWQtY29udHJvbHMuaHRtbAorKysgYi9MYXlvdXRUZXN0 cy9mYXN0L2Zvcm1zL3N0YXRlLXJlc3RvcmUtdG8tbm9uLWVkaXRlZC1jb250cm9scy5odG1sCkBA IC0zLDcgKzMsNyBAQAogPGhlYWQ+CiA8c2NyaXB0IHNyYz0iLi4vLi4vZmFzdC9qcy9yZXNvdXJj ZXMvanMtdGVzdC1wcmUuanMiPjwvc2NyaXB0PgogPC9oZWFkPgotPGJvZHkgb25sb2FkPSJydW5U ZXN0KCkiPgorPGJvZHk+CiA8cD5UZXN0IHRvIE5PVCBzYXZlIHN0YXRlIGZvciBub24tZWRpdGVk IGNvbnRyb2xzPC9wPgogPGRpdiBpZD0iY29uc29sZSI+PC9kaXY+CiAKQEAgLTE0LDcgKzE0LDcg QEAKIDxzY3JpcHQ+CiAKIGZ1bmN0aW9uIG1ha2VGb3JtKHBhcmVudCwgYnV0dG9uVmFsdWUsIGhp ZGRlblZhbHVlLCBpbWFnZVZhbHVlLCByZXNldFZhbHVlLCBzdWJtaXRWYWx1ZSwgdGV4dFZhbHVl MSwgdGV4dFZhbHVlMiwgdGV4dEFyZWFWYWx1ZSkgewotICAgIHBhcmVudC5pbm5lckhUTUwgPSAn PGZvcm0gYWN0aW9uPSJkYXRhOnRleHQvaHRtbCw8c2NyaXB0Pmhpc3RvcnkuYmFjaygpJmx0Oy9z Y3JpcHQ+IiBpZD1mb3JtMT4nCisgICAgZG9jdW1lbnQud3JpdGUoJzxmb3JtIGFjdGlvbj0iZGF0 YTp0ZXh0L2h0bWwsPHNjcmlwdD5oaXN0b3J5LmJhY2soKSZsdDsvc2NyaXB0PiIgaWQ9Zm9ybTE+ JwogICAgICAgICArICc8aW5wdXQgbmFtZT1idXR0b24gaWQ9YnV0dG9uIHR5cGU9YnV0dG9uIHZh bHVlPSInICsgYnV0dG9uVmFsdWUgKyAnIj4nCiAgICAgICAgICsgJzxpbnB1dCBuYW1lPWhpZGRl biBpZD1oaWRkZW4gdHlwZT1oaWRkZW4gdmFsdWU9IicgKyBoaWRkZW5WYWx1ZSArICciPicKICAg ICAgICAgKyAnPGlucHV0IG5hbWU9aW1hZ2UgaWQ9aW1hZ2UgdHlwZT1pbWFnZSB2YWx1ZT0iJyAr IGltYWdlVmFsdWUgKyAnIj4nCkBAIC0yMyw3ICsyMyw3IEBAIGZ1bmN0aW9uIG1ha2VGb3JtKHBh cmVudCwgYnV0dG9uVmFsdWUsIGhpZGRlblZhbHVlLCBpbWFnZVZhbHVlLCByZXNldFZhbHVlLCBz dWJtCiAgICAgICAgICsgJzxpbnB1dCBuYW1lPXRleHQxIGlkPXRleHQxIHR5cGU9dGV4dCB2YWx1 ZT0iJyArIHRleHRWYWx1ZTEgKyAnIj4nCiAgICAgICAgICsgJzxpbnB1dCBuYW1lPXRleHQyIGlk PXRleHQyIHR5cGU9dGV4dCB2YWx1ZT0iJyArIHRleHRWYWx1ZTIgKyAnIj4nCiAgICAgICAgICsg Jzx0ZXh0YXJlYSBuYW1lPXRleHRhcmVhIGlkPXRleHRhcmVhPicgKyB0ZXh0QXJlYVZhbHVlICsg JzwvdGV4dGFyZWE+JwotICAgICAgICArICc8L2Zvcm0+JzsKKyAgICAgICAgKyAnPC9mb3JtPicp OwogfQogCiBmdW5jdGlvbiBydW5UZXN0KCkKQEAgLTQ5LDcgKzQ5LDcgQEAgZnVuY3Rpb24gcnVu VGVzdCgpCiAgICAgICAgIHNob3VsZEJlKCdkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgiaW1hZ2Ui KS52YWx1ZScsICciMiInKTsKICAgICAgICAgc2hvdWxkQmUoJ2RvY3VtZW50LmdldEVsZW1lbnRC eUlkKCJyZXNldCIpLnZhbHVlJywgJyIyIicpOwogICAgICAgICBzaG91bGRCZSgnZG9jdW1lbnQu Z2V0RWxlbWVudEJ5SWQoInN1Ym1pdDEiKS52YWx1ZScsICciMiInKTsKLSAgICAgICAgc2hvdWxk QmUoJ2RvY3VtZW50LmdldEVsZW1lbnRCeUlkKCJ0ZXh0MSIpLnZhbHVlJywgJyIyIicpOworICAg ICAgICBzaG91bGRCZSgnZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoInRleHQxIikudmFsdWUnLCAn ImVkaXQiJyk7CiAgICAgICAgIHNob3VsZEJlKCdkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgidGV4 dDIiKS52YWx1ZScsICciMiInKTsKICAgICAgICAgc2hvdWxkQmUoJ2RvY3VtZW50LmdldEVsZW1l bnRCeUlkKCJ0ZXh0YXJlYSIpLnZhbHVlJywgJyIyIicpOwogICAgIApAQCAtNTgsNSArNTgsNyBA QCBmdW5jdGlvbiBydW5UZXN0KCkKICAgICAgICAgICAgIGxheW91dFRlc3RDb250cm9sbGVyLm5v dGlmeURvbmUoKTsKICAgICB9CiB9CisKK3J1blRlc3QoKTsKIDwvc2NyaXB0PgogPC9ib2R5Pgo= 148487 2012-06-19 19:24:57 -0700 2012-06-19 21:28:17 -0700 Patch 2 bug-89539-20120620112456.patch text/plain 4733 tkent U3VidmVyc2lvbiBSZXZpc2lvbjogMTIwNjc5CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggYWJmZGJiMDkzODE0NDA4MzVjMmYw ZjY0MjlmMDE5Nzc0MGE3OThiYy4uNzkxMDk1YjE3NjI4YWVmZTdhOGFhMDBlOTFlNzUyMWYzNTc2 OTgxZCAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDI3IEBACisyMDEyLTA2LTE5ICBLZW50IFRhbXVyYSAgPHRr ZW50QGNocm9taXVtLm9yZz4KKworICAgICAgICBGaXggYSBmb3JtIHJlc3RvcmUgdGVzdCBicm9r ZW4gYnkgSFRNTDUgcGFyc2VyCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD04OTUzOQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIEJlZm9yZSBIVE1MNSBwYXJzZXIsIHdlIHBhcnNlZCBpbm5lckhUTUwgaW5wdXQg dGV4dCBhbmQgd2UgYXR0YWNoZWQKKyAgICAgICAgcmVuZGVyZXJzIHRvIHBhcnNlZCBub2RlcyBh dCB0aGUgc2FtZSB0aW1lLiBUaGUgcGFyc2VkIG5vZGVzIGhhZAorICAgICAgICByZXN0b3JlZCBm b3JtIHZhbHVlcyBiZWNhdXNlIHdlIHJlc3RvcmUgZm9ybSB2YWx1ZXMgb25seSBmb3IgYXR0YWNo ZWQKKyAgICAgICAgZWxlbWVudHMuCisKKyAgICAgICAgQWZ0ZXIgSFRNTDUgcGFyc2VyLCB3ZSBk b24ndCBhdHRhY2ggcmVuZGVyZXJzIGR1cmluZyBpbm5lckhUTUwKKyAgICAgICAgcGFyc2luZy4g c3RhdGUtcmVzdG9yZS10by1ub25lZGl0ZWQtY29udHJvbHMuaHRtbCB1c2VkIGlubmVySFRNTCB0 bworICAgICAgICBidWlsdCBhIGZvcm0gYW5kIHRoZSB0ZXN0IGhhdmVuJ3Qgd29ya2VkIHNpbmNl IGludHJvZHVjaW5nIEhUTUw1IHBhcnNlci4KKworICAgICAgICBUaGlzIHBhdGNoIGNoYW5nZXMg dGhlIHRlc3Qgc28gdGhhdCBpdCB1c2VzIGRvY3VtZW50LndyaXRlKCkgaW5zdGVhZCBvZgorICAg ICAgICBpbm5lckhUTUwuCisKKyAgICAgICAgKiBmYXN0L2Zvcm1zL3N0YXRlLXJlc3RvcmUtdG8t bm9uLWVkaXRlZC1jb250cm9scy1leHBlY3RlZC50eHQ6CisgICAgICAgIE5vdGUgdGhhdCB0aGUg RkFJTCBsaW5lIGlzIGV4cGVjdGVkLiBJdCdzIGR1ZSB0byBCdWcgODg2ODUuCisgICAgICAgICog ZmFzdC9mb3Jtcy9zdGF0ZS1yZXN0b3JlLXRvLW5vbi1lZGl0ZWQtY29udHJvbHMuaHRtbDoKKyAg ICAgICAgVXNlIGRvY3VtZW50LndyaXRlKCkgaW5zdGVhZCBvZiBpbm5lckhUTUwuCisKIDIwMTIt MDYtMTggIFphbiBEb2JlcnNlayAgPHphbmRvYmVyc2VrQGdtYWlsLmNvbT4KIAogICAgICAgICBV bnJldmlld2VkIEdUSyBnYXJkZW5pbmcsIHVwZGF0aW5nIGJhc2VsaW5lcyBhZnRlciByb2xsb3V0 cyBpbiByMTIwNjI3LgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9mb3Jtcy9zdGF0ZS1y ZXN0b3JlLXRvLW5vbi1lZGl0ZWQtY29udHJvbHMtZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMv ZmFzdC9mb3Jtcy9zdGF0ZS1yZXN0b3JlLXRvLW5vbi1lZGl0ZWQtY29udHJvbHMtZXhwZWN0ZWQu dHh0CmluZGV4IDVhOTJjMTU5YjY5ZmFlZWEwZDc1ZmNkNmE3Yzc1ZGExNzVlYzA2NjkuLjJmZmVj MDA1YmE5Y2RkOTFmOWNmMmQ4OTQyYWJiYjFmOWEzZGYyOGYgMTAwNjQ0Ci0tLSBhL0xheW91dFRl c3RzL2Zhc3QvZm9ybXMvc3RhdGUtcmVzdG9yZS10by1ub24tZWRpdGVkLWNvbnRyb2xzLWV4cGVj dGVkLnR4dAorKysgYi9MYXlvdXRUZXN0cy9mYXN0L2Zvcm1zL3N0YXRlLXJlc3RvcmUtdG8tbm9u LWVkaXRlZC1jb250cm9scy1leHBlY3RlZC50eHQKQEAgLTEsMTEgKzEsMTEgQEAKIFRlc3QgdG8g Tk9UIHNhdmUgc3RhdGUgZm9yIG5vbi1lZGl0ZWQgY29udHJvbHMKIAogUEFTUyBkb2N1bWVudC5n ZXRFbGVtZW50QnlJZCgiYnV0dG9uIikudmFsdWUgaXMgIjIiCi1QQVNTIGRvY3VtZW50LmdldEVs ZW1lbnRCeUlkKCJoaWRkZW4iKS52YWx1ZSBpcyAiMiIKK0ZBSUwgZG9jdW1lbnQuZ2V0RWxlbWVu dEJ5SWQoImhpZGRlbiIpLnZhbHVlIHNob3VsZCBiZSAyLiBXYXMgMS4KIFBBU1MgZG9jdW1lbnQu Z2V0RWxlbWVudEJ5SWQoImltYWdlIikudmFsdWUgaXMgIjIiCiBQQVNTIGRvY3VtZW50LmdldEVs ZW1lbnRCeUlkKCJyZXNldCIpLnZhbHVlIGlzICIyIgogUEFTUyBkb2N1bWVudC5nZXRFbGVtZW50 QnlJZCgic3VibWl0MSIpLnZhbHVlIGlzICIyIgotUEFTUyBkb2N1bWVudC5nZXRFbGVtZW50QnlJ ZCgidGV4dDEiKS52YWx1ZSBpcyAiMiIKK1BBU1MgZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoInRl eHQxIikudmFsdWUgaXMgImVkaXQiCiBQQVNTIGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCJ0ZXh0 MiIpLnZhbHVlIGlzICIyIgogUEFTUyBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgidGV4dGFyZWEi KS52YWx1ZSBpcyAiMiIKIApkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9mb3Jtcy9zdGF0 ZS1yZXN0b3JlLXRvLW5vbi1lZGl0ZWQtY29udHJvbHMuaHRtbCBiL0xheW91dFRlc3RzL2Zhc3Qv Zm9ybXMvc3RhdGUtcmVzdG9yZS10by1ub24tZWRpdGVkLWNvbnRyb2xzLmh0bWwKaW5kZXggYzlk OGYxZTI4NmYwNzcyZjE0ODc1YTdlYzgzYWI2N2I2MWE4NDRkMy4uYTQ0YzM1NGYzNTY0ODIzZmJh MzNjNzBhOGYzMDg2ZDAzZTI1MjI3ZiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvZmFzdC9mb3Jt cy9zdGF0ZS1yZXN0b3JlLXRvLW5vbi1lZGl0ZWQtY29udHJvbHMuaHRtbAorKysgYi9MYXlvdXRU ZXN0cy9mYXN0L2Zvcm1zL3N0YXRlLXJlc3RvcmUtdG8tbm9uLWVkaXRlZC1jb250cm9scy5odG1s CkBAIC0zLDcgKzMsNyBAQAogPGhlYWQ+CiA8c2NyaXB0IHNyYz0iLi4vLi4vZmFzdC9qcy9yZXNv dXJjZXMvanMtdGVzdC1wcmUuanMiPjwvc2NyaXB0PgogPC9oZWFkPgotPGJvZHkgb25sb2FkPSJy dW5UZXN0KCkiPgorPGJvZHk+CiA8cD5UZXN0IHRvIE5PVCBzYXZlIHN0YXRlIGZvciBub24tZWRp dGVkIGNvbnRyb2xzPC9wPgogPGRpdiBpZD0iY29uc29sZSI+PC9kaXY+CiAKQEAgLTE0LDcgKzE0 LDcgQEAKIDxzY3JpcHQ+CiAKIGZ1bmN0aW9uIG1ha2VGb3JtKHBhcmVudCwgYnV0dG9uVmFsdWUs IGhpZGRlblZhbHVlLCBpbWFnZVZhbHVlLCByZXNldFZhbHVlLCBzdWJtaXRWYWx1ZSwgdGV4dFZh bHVlMSwgdGV4dFZhbHVlMiwgdGV4dEFyZWFWYWx1ZSkgewotICAgIHBhcmVudC5pbm5lckhUTUwg PSAnPGZvcm0gYWN0aW9uPSJkYXRhOnRleHQvaHRtbCw8c2NyaXB0Pmhpc3RvcnkuYmFjaygpJmx0 Oy9zY3JpcHQ+IiBpZD1mb3JtMT4nCisgICAgZG9jdW1lbnQud3JpdGUoJzxmb3JtIGFjdGlvbj0i ZGF0YTp0ZXh0L2h0bWwsPHNjcmlwdD5oaXN0b3J5LmJhY2soKSZsdDsvc2NyaXB0PiIgaWQ9Zm9y bTE+JwogICAgICAgICArICc8aW5wdXQgbmFtZT1idXR0b24gaWQ9YnV0dG9uIHR5cGU9YnV0dG9u IHZhbHVlPSInICsgYnV0dG9uVmFsdWUgKyAnIj4nCiAgICAgICAgICsgJzxpbnB1dCBuYW1lPWhp ZGRlbiBpZD1oaWRkZW4gdHlwZT1oaWRkZW4gdmFsdWU9IicgKyBoaWRkZW5WYWx1ZSArICciPicK ICAgICAgICAgKyAnPGlucHV0IG5hbWU9aW1hZ2UgaWQ9aW1hZ2UgdHlwZT1pbWFnZSB2YWx1ZT0i JyArIGltYWdlVmFsdWUgKyAnIj4nCkBAIC0yMyw3ICsyMyw3IEBAIGZ1bmN0aW9uIG1ha2VGb3Jt KHBhcmVudCwgYnV0dG9uVmFsdWUsIGhpZGRlblZhbHVlLCBpbWFnZVZhbHVlLCByZXNldFZhbHVl LCBzdWJtCiAgICAgICAgICsgJzxpbnB1dCBuYW1lPXRleHQxIGlkPXRleHQxIHR5cGU9dGV4dCB2 YWx1ZT0iJyArIHRleHRWYWx1ZTEgKyAnIj4nCiAgICAgICAgICsgJzxpbnB1dCBuYW1lPXRleHQy IGlkPXRleHQyIHR5cGU9dGV4dCB2YWx1ZT0iJyArIHRleHRWYWx1ZTIgKyAnIj4nCiAgICAgICAg ICsgJzx0ZXh0YXJlYSBuYW1lPXRleHRhcmVhIGlkPXRleHRhcmVhPicgKyB0ZXh0QXJlYVZhbHVl ICsgJzwvdGV4dGFyZWE+JwotICAgICAgICArICc8L2Zvcm0+JzsKKyAgICAgICAgKyAnPC9mb3Jt PicpOwogfQogCiBmdW5jdGlvbiBydW5UZXN0KCkKQEAgLTQ5LDcgKzQ5LDcgQEAgZnVuY3Rpb24g cnVuVGVzdCgpCiAgICAgICAgIHNob3VsZEJlKCdkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgiaW1h Z2UiKS52YWx1ZScsICciMiInKTsKICAgICAgICAgc2hvdWxkQmUoJ2RvY3VtZW50LmdldEVsZW1l bnRCeUlkKCJyZXNldCIpLnZhbHVlJywgJyIyIicpOwogICAgICAgICBzaG91bGRCZSgnZG9jdW1l bnQuZ2V0RWxlbWVudEJ5SWQoInN1Ym1pdDEiKS52YWx1ZScsICciMiInKTsKLSAgICAgICAgc2hv dWxkQmUoJ2RvY3VtZW50LmdldEVsZW1lbnRCeUlkKCJ0ZXh0MSIpLnZhbHVlJywgJyIyIicpOwor ICAgICAgICBzaG91bGRCZSgnZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoInRleHQxIikudmFsdWUn LCAnImVkaXQiJyk7CiAgICAgICAgIHNob3VsZEJlKCdkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgi dGV4dDIiKS52YWx1ZScsICciMiInKTsKICAgICAgICAgc2hvdWxkQmUoJ2RvY3VtZW50LmdldEVs ZW1lbnRCeUlkKCJ0ZXh0YXJlYSIpLnZhbHVlJywgJyIyIicpOwogICAgIApAQCAtNTgsNSArNTgs NyBAQCBmdW5jdGlvbiBydW5UZXN0KCkKICAgICAgICAgICAgIGxheW91dFRlc3RDb250cm9sbGVy Lm5vdGlmeURvbmUoKTsKICAgICB9CiB9CisKK3J1blRlc3QoKTsKIDwvc2NyaXB0PgogPC9ib2R5 Pgo=