89533 2012-06-19 17:12:50 -0700 Refactoring: Geolocation::startRequest() should not create the GeoNotifiers 2012-06-19 23:04:02 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 benjamin benjamin ddkilzer joepeck oldest_to_newest 653017 0 benjamin 2012-06-19 17:12:50 -0700 Refactoring: Geolocation::startRequest() should not create the GeoNotifiers 653023 1 148467 benjamin 2012-06-19 17:20:25 -0700 Created attachment 148467 Patch 653183 2 148467 ddkilzer 2012-06-19 21:53:07 -0700 Comment on attachment 148467 Patch r=me 653229 3 benjamin 2012-06-19 23:04:02 -0700 Committed r120804: <http://trac.webkit.org/changeset/120804> 148467 2012-06-19 17:20:25 -0700 2012-06-19 21:53:07 -0700 Patch bug-89533-20120619172024.patch text/plain 4578 benjamin U3VidmVyc2lvbiBSZXZpc2lvbjogMTIwNzY5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYjEyNTA4MmE5OWU3YzMx ZjdmOThlNzc2MzYxZmRiMTU5OWM4Njk4Zi4uMzdlODYwNzExZjg0MjJiNzJkNzMzMDNkOWExMzMz MTY0Mzc5NWFjOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI0IEBACisyMDEyLTA2LTE5ICBCZW5q YW1pbiBQb3VsYWluICA8YnBvdWxhaW5AYXBwbGUuY29tPgorCisgICAgICAgIFJlZmFjdG9yaW5n OiBHZW9sb2NhdGlvbjo6c3RhcnRSZXF1ZXN0KCkgc2hvdWxkIG5vdCBjcmVhdGUgdGhlIEdlb05v dGlmaWVycworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 ODk1MzMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBJ dCB3YXMgb2RkIHRvIGNyZWF0ZSB0aGUgR2VvTm90aWZpZXJzIGluIEdlb2xvY2F0aW9uOjpzdGFy dFJlcXVlc3QoKSBhbmQgaGF2aW5nCisgICAgICAgIGFzc2VydGlvbnMgZnJvbSB0aGUgY2FsbCBz aXRlLgorCisgICAgICAgIFRoaXMgcGF0Y2ggbW92ZSB0aGVpciBpbml0aWFsaXphdGlvbiB0byB0 aGUgZXhwb3NlZCBtZXRob2QsIGFuZCBwYXNzIHRoZW0gdG8KKyAgICAgICAgc3RhcnRSZXF1ZXN0 KCkgYXMgbmVlZGVkLgorICAgICAgICBUaGlzIHdpbGwgYWxzbyBoZWxwIGFkZGluZyBzdXBwb3J0 IGZvciBkeW5hbWljIHBlcm1pc3Npb24gcmVzZXQgYW5kIHN1c3BlbmQvcmVzdW1lLgorCisgICAg ICAgICogTW9kdWxlcy9nZW9sb2NhdGlvbi9HZW9sb2NhdGlvbi5jcHA6CisgICAgICAgIChXZWJD b3JlOjpHZW9sb2NhdGlvbjo6Z2V0Q3VycmVudFBvc2l0aW9uKToKKyAgICAgICAgKFdlYkNvcmU6 Okdlb2xvY2F0aW9uOjp3YXRjaFBvc2l0aW9uKToKKyAgICAgICAgKFdlYkNvcmU6Okdlb2xvY2F0 aW9uOjpzdGFydFJlcXVlc3QpOgorICAgICAgICAqIE1vZHVsZXMvZ2VvbG9jYXRpb24vR2VvbG9j YXRpb24uaDoKKyAgICAgICAgKEdlb2xvY2F0aW9uKToKKwogMjAxMi0wNi0xOSAgQW5kcmV5IEFk YWlraW4gIDxhYW5kcmV5QGNocm9taXVtLm9yZz4KIAogICAgICAgICBXZWIgSW5zcGVjdG9yOiBF eHRyYWN0IEluamVjdGVkU2NyaXB0QmFzZSBjbGFzcyBmcm9tIHRoZSBJbmplY3RlZFNjcmlwdApk aWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9nZW9sb2NhdGlvbi9HZW9sb2NhdGlv bi5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL2dlb2xvY2F0aW9uL0dlb2xvY2F0aW9uLmNw cAppbmRleCBlMWMyYzlmMTJiODc1NTFjODc1ODg4YTY5Y2JlZGI2ZmFlMjE2YzZjLi41N2NhZjMx NTJhY2M4OWQ2OTdhYThmNjQ1Y2M4ZjAxMzU5YmNiMTUyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi Q29yZS9Nb2R1bGVzL2dlb2xvY2F0aW9uL0dlb2xvY2F0aW9uLmNwcAorKysgYi9Tb3VyY2UvV2Vi Q29yZS9Nb2R1bGVzL2dlb2xvY2F0aW9uL0dlb2xvY2F0aW9uLmNwcApAQCAtMjk3LDggKzI5Nyw4 IEBAIHZvaWQgR2VvbG9jYXRpb246OmdldEN1cnJlbnRQb3NpdGlvbihQYXNzUmVmUHRyPFBvc2l0 aW9uQ2FsbGJhY2s+IHN1Y2Nlc3NDYWxsYmFjCiAgICAgaWYgKCFmcmFtZSgpKQogICAgICAgICBy ZXR1cm47CiAKLSAgICBSZWZQdHI8R2VvTm90aWZpZXI+IG5vdGlmaWVyID0gc3RhcnRSZXF1ZXN0 KHN1Y2Nlc3NDYWxsYmFjaywgZXJyb3JDYWxsYmFjaywgb3B0aW9ucyk7Ci0gICAgQVNTRVJUKG5v dGlmaWVyKTsKKyAgICBSZWZQdHI8R2VvTm90aWZpZXI+IG5vdGlmaWVyID0gR2VvTm90aWZpZXI6 OmNyZWF0ZSh0aGlzLCBzdWNjZXNzQ2FsbGJhY2ssIGVycm9yQ2FsbGJhY2ssIG9wdGlvbnMpOwor ICAgIHN0YXJ0UmVxdWVzdChub3RpZmllci5nZXQoKSk7CiAKICAgICBtX29uZVNob3RzLmFkZChu b3RpZmllcik7CiB9CkBAIC0zMDgsOCArMzA4LDggQEAgaW50IEdlb2xvY2F0aW9uOjp3YXRjaFBv c2l0aW9uKFBhc3NSZWZQdHI8UG9zaXRpb25DYWxsYmFjaz4gc3VjY2Vzc0NhbGxiYWNrLCBQYXMK ICAgICBpZiAoIWZyYW1lKCkpCiAgICAgICAgIHJldHVybiAwOwogCi0gICAgUmVmUHRyPEdlb05v dGlmaWVyPiBub3RpZmllciA9IHN0YXJ0UmVxdWVzdChzdWNjZXNzQ2FsbGJhY2ssIGVycm9yQ2Fs bGJhY2ssIG9wdGlvbnMpOwotICAgIEFTU0VSVChub3RpZmllcik7CisgICAgUmVmUHRyPEdlb05v dGlmaWVyPiBub3RpZmllciA9IEdlb05vdGlmaWVyOjpjcmVhdGUodGhpcywgc3VjY2Vzc0NhbGxi YWNrLCBlcnJvckNhbGxiYWNrLCBvcHRpb25zKTsKKyAgICBzdGFydFJlcXVlc3Qobm90aWZpZXIu Z2V0KCkpOwogCiAgICAgc3RhdGljIGludCBuZXh0QXZhaWxhYmxlV2F0Y2hJZCA9IGZpcnN0QXZh aWxhYmxlV2F0Y2hJZDsKICAgICAvLyBJbiBjYXNlIG9mIG92ZXJmbG93LCBtYWtlIHN1cmUgdGhl IElEIHJlbWFpbnMgcG9zaXRpdmUsIGJ1dCByZXVzZSB0aGUgSUQgdmFsdWVzLgpAQCAtMzE5LDEw ICszMTksOCBAQCBpbnQgR2VvbG9jYXRpb246OndhdGNoUG9zaXRpb24oUGFzc1JlZlB0cjxQb3Np dGlvbkNhbGxiYWNrPiBzdWNjZXNzQ2FsbGJhY2ssIFBhcwogICAgIHJldHVybiBuZXh0QXZhaWxh YmxlV2F0Y2hJZCsrOwogfQogCi1QYXNzUmVmUHRyPEdlb2xvY2F0aW9uOjpHZW9Ob3RpZmllcj4g R2VvbG9jYXRpb246OnN0YXJ0UmVxdWVzdChQYXNzUmVmUHRyPFBvc2l0aW9uQ2FsbGJhY2s+IHN1 Y2Nlc3NDYWxsYmFjaywgUGFzc1JlZlB0cjxQb3NpdGlvbkVycm9yQ2FsbGJhY2s+IGVycm9yQ2Fs bGJhY2ssIFBhc3NSZWZQdHI8UG9zaXRpb25PcHRpb25zPiBvcHRpb25zKQordm9pZCBHZW9sb2Nh dGlvbjo6c3RhcnRSZXF1ZXN0KEdlb05vdGlmaWVyICpub3RpZmllcikKIHsKLSAgICBSZWZQdHI8 R2VvTm90aWZpZXI+IG5vdGlmaWVyID0gR2VvTm90aWZpZXI6OmNyZWF0ZSh0aGlzLCBzdWNjZXNz Q2FsbGJhY2ssIGVycm9yQ2FsbGJhY2ssIG9wdGlvbnMpOwotCiAgICAgLy8gQ2hlY2sgd2hldGhl ciBwZXJtaXNzaW9ucyBoYXZlIGFscmVhZHkgYmVlbiBkZW5pZWQuIE5vdGUgdGhhdCBpZiB0aGlz IGlzIHRoZSBjYXNlLAogICAgIC8vIHRoZSBwZXJtaXNzaW9uIHN0YXRlIGNhbiBub3QgY2hhbmdl IGFnYWluIGluIHRoZSBsaWZldGltZSBvZiB0aGlzIHBhZ2UuCiAgICAgaWYgKGlzRGVuaWVkKCkp CkBAIC0zMzUsMTIgKzMzMywxMCBAQCBQYXNzUmVmUHRyPEdlb2xvY2F0aW9uOjpHZW9Ob3RpZmll cj4gR2VvbG9jYXRpb246OnN0YXJ0UmVxdWVzdChQYXNzUmVmUHRyPFBvc2l0aQogICAgICAgICAv LyBpZiB3ZSBkb24ndCB5ZXQgaGF2ZSBwZXJtaXNzaW9uLCByZXF1ZXN0IGZvciBwZXJtaXNzaW9u IGJlZm9yZSBjYWxsaW5nIHN0YXJ0VXBkYXRpbmcoKQogICAgICAgICBtX3BlbmRpbmdGb3JQZXJt aXNzaW9uTm90aWZpZXJzLmFkZChub3RpZmllcik7CiAgICAgICAgIHJlcXVlc3RQZXJtaXNzaW9u KCk7Ci0gICAgfSBlbHNlIGlmIChzdGFydFVwZGF0aW5nKG5vdGlmaWVyLmdldCgpKSkKKyAgICB9 IGVsc2UgaWYgKHN0YXJ0VXBkYXRpbmcobm90aWZpZXIpKQogICAgICAgICBub3RpZmllci0+c3Rh cnRUaW1lcklmTmVlZGVkKCk7CiAgICAgZWxzZQogICAgICAgICBub3RpZmllci0+c2V0RmF0YWxF cnJvcihQb3NpdGlvbkVycm9yOjpjcmVhdGUoUG9zaXRpb25FcnJvcjo6UE9TSVRJT05fVU5BVkFJ TEFCTEUsIGZhaWxlZFRvU3RhcnRTZXJ2aWNlRXJyb3JNZXNzYWdlKSk7Ci0KLSAgICByZXR1cm4g bm90aWZpZXIucmVsZWFzZSgpOwogfQogCiB2b2lkIEdlb2xvY2F0aW9uOjpmYXRhbEVycm9yT2Nj dXJyZWQoR2VvbG9jYXRpb246Okdlb05vdGlmaWVyKiBub3RpZmllcikKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJDb3JlL01vZHVsZXMvZ2VvbG9jYXRpb24vR2VvbG9jYXRpb24uaCBiL1NvdXJjZS9X ZWJDb3JlL01vZHVsZXMvZ2VvbG9jYXRpb24vR2VvbG9jYXRpb24uaAppbmRleCA3ZjNjZjkzNjRk MjZhOTc5NDMwMjUzMGI1NGIxOGEyMjUwMDE4MmRjLi5mZmM5MDEwM2E4ODEwMWEyM2I1NTNjNTU5 OWRkODM2ZDBkYTFlOTJjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL2dlb2xv Y2F0aW9uL0dlb2xvY2F0aW9uLmgKKysrIGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9nZW9sb2Nh dGlvbi9HZW9sb2NhdGlvbi5oCkBAIC0xNTIsNyArMTUyLDcgQEAgcHJpdmF0ZToKIAogICAgIHZv aWQgaGFuZGxlUGVuZGluZ1Blcm1pc3Npb25Ob3RpZmllcnMoKTsKIAotICAgIFBhc3NSZWZQdHI8 R2VvTm90aWZpZXI+IHN0YXJ0UmVxdWVzdChQYXNzUmVmUHRyPFBvc2l0aW9uQ2FsbGJhY2s+LCBQ YXNzUmVmUHRyPFBvc2l0aW9uRXJyb3JDYWxsYmFjaz4sIFBhc3NSZWZQdHI8UG9zaXRpb25PcHRp b25zPik7CisgICAgdm9pZCBzdGFydFJlcXVlc3QoR2VvTm90aWZpZXIqKTsKIAogICAgIHZvaWQg ZmF0YWxFcnJvck9jY3VycmVkKEdlb05vdGlmaWVyKik7CiAgICAgdm9pZCByZXF1ZXN0VGltZWRP dXQoR2VvTm90aWZpZXIqKTsK