89532 2012-06-19 16:54:20 -0700 [V8] Fix issue where a callback got a null calling context 2012-06-19 18:04:20 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 arv arv abarth haraken japhet jochen webkit.review.bot oldest_to_newest 652989 0 arv 2012-06-19 16:54:20 -0700 [V8] Fix issue where a callback got a null calling context 652992 1 148459 arv 2012-06-19 16:56:04 -0700 Created attachment 148459 Patch 652995 2 arv 2012-06-19 16:57:18 -0700 See http://code.google.com/p/chromium/issues/detail?id=130462 for more details 653008 3 148459 haraken 2012-06-19 17:06:52 -0700 Comment on attachment 148459 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=148459&action=review The change looks OK. > Source/WebCore/bindings/v8/custom/V8DOMWindowCustom.cpp:309 > + return V8Proxy::throwTypeError(0, args.GetIsolate()); 0 will output "Type error". What error message does JSC throw? (We want to keep the error message consistent between JSC and V8.) 653032 4 arv 2012-06-19 17:30:08 -0700 (In reply to comment #3) > (From update of attachment 148459 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=148459&action=review > > The change looks OK. > > > Source/WebCore/bindings/v8/custom/V8DOMWindowCustom.cpp:309 > > + return V8Proxy::throwTypeError(0, args.GetIsolate()); > > 0 will output "Type error". What error message does JSC throw? (We want to keep the error message consistent between JSC and V8.) Yup. I wanted to use 0 to match JSC. 653034 5 148459 haraken 2012-06-19 17:30:45 -0700 Comment on attachment 148459 Patch Thanks for the clarification. 653064 6 148459 webkit.review.bot 2012-06-19 18:04:16 -0700 Comment on attachment 148459 Patch Clearing flags on attachment: 148459 Committed r120783: <http://trac.webkit.org/changeset/120783> 653065 7 webkit.review.bot 2012-06-19 18:04:20 -0700 All reviewed patches have been landed. Closing bug. 148459 2012-06-19 16:56:04 -0700 2012-06-19 18:04:16 -0700 Patch bug-89532-20120619165603.patch text/plain 3859 arv U3VidmVyc2lvbiBSZXZpc2lvbjogMTIwNjA1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNzk5Y2QyNmZiMTE2ZTk4 MGExMDUwZjY4OGI3OGE5MTc5NmU4ZDY3YS4uMWFkZGQyOTYyY2IxODlmY2YzMjNkMjMyYzRiNmY3 ZTI5ZGM0NDAxMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEyLTA2LTE5ICBFcmlr IEFydmlkc3NvbiAgPGFydkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgW1Y4XSBGaXggaXNzdWUg d2hlcmUgYSBjYWxsYmFjayBnb3QgYSBudWxsIGNhbGxpbmcgY29udGV4dAorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODk1MzIKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUZXN0OiBmYXN0L2RvbS9XaW5kb3cv cG9zdC1tZXNzYWdlLWNyYXNoLmh0bWwKKworICAgICAgICAqIGJpbmRpbmdzL3Y4L2N1c3RvbS9W OERPTVdpbmRvd0N1c3RvbS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpoYW5kbGVQb3N0TWVzc2Fn ZUNhbGxiYWNrKTogQ2hlY2sgdGhlIGNhbGxpbmcgY29udGV4dCBhbmQgdGhyb3cgYSB0eXBlIGVy cm9yIChsaWtlIEpTQykgaWYgaXQgaXMgbnVsbC4KKwogMjAxMi0wNi0xOCAgSnVsaWVuIENoYWZm cmFpeCAgPGpjaGFmZnJhaXhAd2Via2l0Lm9yZz4KIAogICAgICAgICBSZW5kZXJUYWJsZVNlY3Rp b24gd2FzdGVzIHZlY3RvciBjYXBhY2l0eQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvYmlu ZGluZ3MvdjgvY3VzdG9tL1Y4RE9NV2luZG93Q3VzdG9tLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2Jp bmRpbmdzL3Y4L2N1c3RvbS9WOERPTVdpbmRvd0N1c3RvbS5jcHAKaW5kZXggNWJlZGI4ZTI5ODQ3 NDM3MTRjZDI2ZDk3N2E3MzE3YTA4ZjYzNzE3YS4uMGVhODEzZWI1ZjdlMjAwZGIxMWQyZDI1OTI3 Y2VkZGFkOWI0YjBkOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvY3Vz dG9tL1Y4RE9NV2luZG93Q3VzdG9tLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92 OC9jdXN0b20vVjhET01XaW5kb3dDdXN0b20uY3BwCkBAIC0zMDQsNiArMzA0LDEwIEBAIHN0YXRp YyB2ODo6SGFuZGxlPHY4OjpWYWx1ZT4gaGFuZGxlUG9zdE1lc3NhZ2VDYWxsYmFjayhjb25zdCB2 ODo6QXJndW1lbnRzJiBhcmdzCiAgICAgRE9NV2luZG93KiB3aW5kb3cgPSBWOERPTVdpbmRvdzo6 dG9OYXRpdmUoYXJncy5Ib2xkZXIoKSk7CiAgICAgRE9NV2luZG93KiBzb3VyY2UgPSBWOFByb3h5 OjpyZXRyaWV2ZVdpbmRvd0ZvckNhbGxpbmdDb250ZXh0KCk7CiAKKyAgICAvLyBJZiBjYWxsZWQg ZGlyZWN0bHkgYnkgV2ViQ29yZSB3ZSBkb24ndCBoYXZlIGEgY2FsbGluZyBjb250ZXh0LgorICAg IGlmICghc291cmNlKQorICAgICAgICByZXR1cm4gVjhQcm94eTo6dGhyb3dUeXBlRXJyb3IoMCwg YXJncy5HZXRJc29sYXRlKCkpOworCiAgICAgLy8gVGhpcyBmdW5jdGlvbiBoYXMgdmFyaWFibGUg YXJndW1lbnRzIGFuZCBjYW4gYmU6CiAgICAgLy8gUGVyIGN1cnJlbnQgc3BlYzoKICAgICAvLyAg IHBvc3RNZXNzYWdlKG1lc3NhZ2UsIHRhcmdldE9yaWdpbikKZGlmZiAtLWdpdCBhL0xheW91dFRl c3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCBmODZmNWJjNDViOWMx NjNmOWRlNDdmOWFhOTk1YjRlNGNkZGQ0YzdkLi41M2UyYTA0MmYxZDQ1NmZkMTIyNWQ0ZDY4ZjZj NDM2NjZmZjUwOWYyIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5 b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTItMDYtMTkgIEVyaWsgQXJ2 aWRzc29uICA8YXJ2QGNocm9taXVtLm9yZz4KKworICAgICAgICBbVjhdIEZpeCBpc3N1ZSB3aGVy ZSBhIGNhbGxiYWNrIGdvdCBhIG51bGwgY2FsbGluZyBjb250ZXh0CisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04OTUzMgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogZmFzdC9kb20vV2luZG93L3Bvc3QtbWVz c2FnZS1jcmFzaC1leHBlY3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAqIGZhc3QvZG9tL1dpbmRv dy9wb3N0LW1lc3NhZ2UtY3Jhc2guaHRtbDogQWRkZWQuCisKIDIwMTItMDYtMTggIENocmlzdG9w aGUgRHVtZXogIDxjaHJpc3RvcGhlLmR1bWV6QGludGVsLmNvbT4KIAogICAgICAgICBbRUZMXSBS ZWJhc2VsaW5lIG1lZGlhIHRlc3RzIGFmdGVyIHIxMjA1OTYKZGlmZiAtLWdpdCBhL0xheW91dFRl c3RzL2Zhc3QvZG9tL1dpbmRvdy9wb3N0LW1lc3NhZ2UtY3Jhc2gtZXhwZWN0ZWQudHh0IGIvTGF5 b3V0VGVzdHMvZmFzdC9kb20vV2luZG93L3Bvc3QtbWVzc2FnZS1jcmFzaC1leHBlY3RlZC50eHQK bmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMC4uOTczMjE4OGQyNGQ1NDNjMzAwYzk0MmQ0ZGU5ZGExOWUzOTQyZDA2NwotLS0g L2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2Zhc3QvZG9tL1dpbmRvdy9wb3N0LW1lc3NhZ2Ut Y3Jhc2gtZXhwZWN0ZWQudHh0CkBAIC0wLDAgKzEsMyBAQAorVGhpcyBlbnN1cmVzIHRoYXQgcG9z dE1lc3NhZ2UgY2FsbGVkIGluIGEgY2FsbGJhY2sgZG9lcyBub3QgY3Jhc2guCisKK1BBU1MKZGlm ZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvZG9tL1dpbmRvdy9wb3N0LW1lc3NhZ2UtY3Jhc2gu aHRtbCBiL0xheW91dFRlc3RzL2Zhc3QvZG9tL1dpbmRvdy9wb3N0LW1lc3NhZ2UtY3Jhc2guaHRt bApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwLi4wNGE0MWY2YjI1NzQ5NmYwM2U2MzFmNGI3ZjkwNDllNDM2MmNiNDBiCi0t LSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9kb20vV2luZG93L3Bvc3QtbWVzc2Fn ZS1jcmFzaC5odG1sCkBAIC0wLDAgKzEsMzkgQEAKKzwhRE9DVFlQRSBodG1sPgorPGh0bWw+Cis8 Ym9keT4KKworPHA+VGhpcyBlbnN1cmVzIHRoYXQgcG9zdE1lc3NhZ2UgY2FsbGVkIGluIGEgY2Fs bGJhY2sgZG9lcyBub3QgY3Jhc2guCisKKzxwcmU+RkFJTDwvcHJlPgorCis8c2NyaXB0PgoraWYg KHdpbmRvdy50ZXN0UnVubmVyKSB7CisgICAgdGVzdFJ1bm5lci5kdW1wQXNUZXh0KCk7CisgICAg dGVzdFJ1bm5lci53YWl0VW50aWxEb25lKCk7Cit9CisKK3ZhciBuID0gMDsKKword2luZG93Lm9u ZXJyb3IgPSBmdW5jdGlvbigpIHsKKyAgICBpZiAoKytuID09PSAyKSB7CisgICAgICAgIGRvY3Vt ZW50LnF1ZXJ5U2VsZWN0b3IoJ3ByZScpLnRleHRDb250ZW50ID0gJ1BBU1MnOworICAgICAgICBp ZiAod2luZG93LnRlc3RSdW5uZXIpCisgICAgICAgICAgICB0ZXN0UnVubmVyLm5vdGlmeURvbmUo KTsKKyAgICB9CisgICAgcmV0dXJuIHRydWU7Cit9OworCit3ZWJraXRSZXF1ZXN0QW5pbWF0aW9u RnJhbWUod2Via2l0UG9zdE1lc3NhZ2UpOworc2V0VGltZW91dCh3ZWJraXRQb3N0TWVzc2FnZSk7 CisKK2lmICh3aW5kb3cudGVzdFJ1bm5lcikKKyAgICB0ZXN0UnVubmVyLmRpc3BsYXkoKTsKKwor c2V0VGltZW91dChmdW5jdGlvbigpIHsKKyAgICBpZiAod2luZG93LnRlc3RSdW5uZXIpCisgICAg ICAgIHRlc3RSdW5uZXIubm90aWZ5RG9uZSgpOworfSwgNTApOworCis8L3NjcmlwdD4KKzwvYm9k eT4KKzwvaHRtbD4KXCBObyBuZXdsaW5lIGF0IGVuZCBvZiBmaWxlCg==