8951 2006-05-16 23:12:52 -0700 REGRESSION: AtomicString hash corrupted by high-bit Latin-1 2006-05-16 23:46:39 -0700 1 1 1 Unclassified WebKit Platform 420+ Mac OS X 10.4 RESOLVED FIXED Regression P2 Normal --- 1 mitz webkit-unassigned oldest_to_newest 42677 0 mitz 2006-05-16 23:12:52 -0700 CStringTranslator::equal() is broken for high-bit C strings, which leads to duplicate entries in the AtomicString hash map. 42678 1 8361 mitz 2006-05-16 23:15:37 -0700 Created attachment 8361 Patch The test is for the fix in StringImpl.cpp. The hash map corruption can't be tested reliably in a normal debug build. I don't know if the corruption happens in shipping WebKit, but the test succeeds, so at least part of this bug is a regression. 42681 2 8361 mjs 2006-05-16 23:31:46 -0700 Comment on attachment 8361 Patch r=me 42683 3 darin 2006-05-16 23:42:16 -0700 I broke this when I converted from QChar to UChar! 42684 4 darin 2006-05-16 23:46:39 -0700 Committed revision 14434. 8361 2006-05-16 23:15:37 -0700 2006-05-16 23:31:46 -0700 Patch 8951_r1.patch text/plain 3400 mitz SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDE0NDI4KQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMDYtMDUtIyMgIE1pdHogUGV0dGVsICA8b3Bl bmRhcndpbi5vcmdAbWl0enBldHRlbC5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgLSB0ZXN0IGZvciBodHRwOi8vYnVnemlsbGEub3BlbmRhcndp bi5vcmcvc2hvd19idWcuY2dpP2lkPTg5NTEKKyAgICAgICAgICBBdG9taWNTdHJpbmcgaGFzaCBj b3JydXB0ZWQgYnkgaGlnaC1iaXQgTGF0aW4tMQorCisgICAgICAgICogZmFzdC9lbmNvZGluZy9o aWdoLWJpdC1sYXRpbjEtZXhwZWN0ZWQudHh0OiBBZGRlZC4KKyAgICAgICAgKiBmYXN0L2VuY29k aW5nL2hpZ2gtYml0LWxhdGluMS5odG1sOiBBZGRlZC4KKwogMjAwNi0wNS0xNiAgQW5kZXJzIENh cmxzc29uICA8YWNhcmxzc29uQGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBNYWNp ZWouCkluZGV4OiBMYXlvdXRUZXN0cy9mYXN0L2VuY29kaW5nL2hpZ2gtYml0LWxhdGluMS1leHBl Y3RlZC50eHQKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvZmFzdC9lbmNvZGluZy9oaWdoLWJp dC1sYXRpbjEtZXhwZWN0ZWQudHh0CShyZXZpc2lvbiAwKQorKysgTGF5b3V0VGVzdHMvZmFzdC9l bmNvZGluZy9oaWdoLWJpdC1sYXRpbjEtZXhwZWN0ZWQudHh0CShyZXZpc2lvbiAwKQpAQCAtMCww ICsxLDUgQEAKK1Rlc3QgTGF0aW4tMSBjb252ZXJzaW9uIHRvIFN0cmluZworCitQQVNTCisKKwpJ bmRleDogTGF5b3V0VGVzdHMvZmFzdC9lbmNvZGluZy9oaWdoLWJpdC1sYXRpbjEuaHRtbAo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9mYXN0L2VuY29kaW5nL2hpZ2gtYml0LWxhdGluMS5odG1s CShyZXZpc2lvbiAwKQorKysgTGF5b3V0VGVzdHMvZmFzdC9lbmNvZGluZy9oaWdoLWJpdC1sYXRp bjEuaHRtbAkocmV2aXNpb24gMCkKQEAgLTAsMCArMSwxOCBAQAorPGh0bWw+Cis8aGVhZD4KKyAg ICA8dGl0bGU+PC90aXRsZT4KKzwvaGVhZD4KKzxib2R5PgorICAgIDxwPgorICAgICAgICBUZXN0 IExhdGluLTEgY29udmVyc2lvbiB0byBTdHJpbmcKKyAgICA8L3A+CisgICAgPGEgaWQ9InQiIOA+ PC9hPgorICAgIDxwPgorICAgIDxzY3JpcHQgdHlwZT0idGV4dC9qYXZhc2NyaXB0Ij4KKyAgICAg ICAgaWYgKHdpbmRvdy5sYXlvdXRUZXN0Q29udHJvbGxlcikKKyAgICAgICAgICAgIGxheW91dFRl c3RDb250cm9sbGVyLmR1bXBBc1RleHQoKTsKKyAgICAgICAgZG9jdW1lbnQud3JpdGUoZG9jdW1l bnQuZ2V0RWxlbWVudEJ5SWQoInQiKS5hdHRyaWJ1dGVzWzFdLm5hbWUgPT0gIlx1MDBlMCIgPyAi UEFTUyIgOiAiRkFJTCIpOworICAgIDwvc2NyaXB0PgorICAgIDwvcD4KKzwvYm9keT4KKzwvaHRt bD4KSW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdl TG9nCShyZXZpc2lvbiAxNDQyOCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkp CkBAIC0xLDMgKzEsMTcgQEAKKzIwMDYtMDUtIyMgIE1pdHogUGV0dGVsICA8b3BlbmRhcndpbi5v cmdAbWl0enBldHRlbC5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgLSBmaXggaHR0cDovL2J1Z3ppbGxhLm9wZW5kYXJ3aW4ub3JnL3Nob3dfYnVn LmNnaT9pZD04OTUxCisgICAgICAgICAgQXRvbWljU3RyaW5nIGhhc2ggY29ycnVwdGVkIGJ5IGhp Z2gtYml0IExhdGluLTEKKworICAgICAgICBUZXN0OiBmYXN0L2VuY29kaW5nL2hpZ2gtYml0LWxh dGluMS5odG1sCisKKyAgICAgICAgKiBwbGF0Zm9ybS9BdG9taWNTdHJpbmcuY3BwOgorICAgICAg ICAoV2ViQ29yZTo6Q1N0cmluZ1RyYW5zbGF0b3I6OmVxdWFsKTogQ2FzdCB0byB1bnNpZ25lZCBj aGFyCisgICAgICAgICogcGxhdGZvcm0vU3RyaW5nSW1wbC5jcHA6CisgICAgICAgIChXZWJDb3Jl OjpTdHJpbmdJbXBsOjppbml0KTogQ2FzdCB0byB1bnNpZ25lZCBjaGFyCisKIDIwMDYtMDUtMTcg IEFuZGVycyBDYXJsc3NvbiAgPGFjYXJsc3NvbkBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3 ZWQgYnkgRGFyaW4uCkluZGV4OiBXZWJDb3JlL3BsYXRmb3JtL1N0cmluZ0ltcGwuY3BwCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFdlYkNvcmUvcGxhdGZvcm0vU3RyaW5nSW1wbC5jcHAJKHJldmlzaW9uIDE0NDI4 KQorKysgV2ViQ29yZS9wbGF0Zm9ybS9TdHJpbmdJbXBsLmNwcAkod29ya2luZyBjb3B5KQpAQCAt OTcsNyArOTcsNyBAQCB2b2lkIFN0cmluZ0ltcGw6OmluaXQoY29uc3QgY2hhciogc3RyLCB1CiAg ICAgaW50IGkgPSBtX2xlbmd0aDsKICAgICBVQ2hhciogcHRyID0gbV9kYXRhOwogICAgIHdoaWxl IChpLS0pCi0gICAgICAgICpwdHIrKyA9ICpzdHIrKzsKKyAgICAgICAgKnB0cisrID0gKih1bnNp Z25lZCBjaGFyKilzdHIrKzsKIH0KIAogdm9pZCBTdHJpbmdJbXBsOjppbml0KGNvbnN0IFVDaGFy KiBzdHIsIHVuc2lnbmVkIGxlbikKSW5kZXg6IFdlYkNvcmUvcGxhdGZvcm0vQXRvbWljU3RyaW5n LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL3BsYXRmb3JtL0F0b21pY1N0cmluZy5jcHAJKHJl dmlzaW9uIDE0NDI4KQorKysgV2ViQ29yZS9wbGF0Zm9ybS9BdG9taWNTdHJpbmcuY3BwCSh3b3Jr aW5nIGNvcHkpCkBAIC01Myw3ICs1Myw3IEBAIHN0cnVjdCBDU3RyaW5nVHJhbnNsYXRvciAKICAg ICAgICAgaW50IGxlbmd0aCA9IHItPmxlbmd0aCgpOwogICAgICAgICBjb25zdCBVQ2hhciogZCA9 IHItPmNoYXJhY3RlcnMoKTsKICAgICAgICAgZm9yIChpbnQgaSA9IDA7IGkgIT0gbGVuZ3RoOyAr K2kpCi0gICAgICAgICAgICBpZiAoZFtpXSAhPSBzW2ldKQorICAgICAgICAgICAgaWYgKGRbaV0g IT0gKHVuc2lnbmVkIGNoYXIpc1tpXSkKICAgICAgICAgICAgICAgICByZXR1cm4gZmFsc2U7CiAg ICAgICAgIHJldHVybiBzW2xlbmd0aF0gPT0gMDsKICAgICB9Cg==