89509 2012-06-19 13:36:04 -0700 Web Inspector: extensionPanel.onSearch `action` strings should be enumerated 2012-06-19 15:30:31 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED https://code.google.com/chrome/extensions/trunk/devtools.panels.html#event-ExtensionPanel-onSearch P2 Normal --- 0 janx webkit-unassigned apavlov bweinstein joepeck keishi loislo pfeldman pmuellr rik timothy webkit.review.bot yurys oldest_to_newest 652739 0 janx 2012-06-19 13:36:04 -0700 Cross-report from https://code.google.com/p/chromium/issues/detail?id=121094 From https://code.google.com/chrome/extensions/trunk/devtools.panels.html#event-ExtensionPanel-onSearch > extensionPanel.onSearch.addListener(function(string action, string queryString) {...}); The possible values for `action` are: - "cancelSearch" - "performSearch" - "nextSearchResult" - "previousSearchResult" They should be enumerated in the `chrome.devtools.panels.SearchAction` API. 652758 1 148410 janx 2012-06-19 13:47:41 -0700 Created attachment 148410 Patch 652766 2 148410 caseq 2012-06-19 13:53:11 -0700 Comment on attachment 148410 Patch LGTM 652884 3 148410 webkit.review.bot 2012-06-19 15:30:26 -0700 Comment on attachment 148410 Patch Clearing flags on attachment: 148410 Committed r120760: <http://trac.webkit.org/changeset/120760> 652885 4 webkit.review.bot 2012-06-19 15:30:31 -0700 All reviewed patches have been landed. Closing bug. 148410 2012-06-19 13:47:41 -0700 2012-06-19 15:30:26 -0700 Patch bug-89509-20120619134741.patch text/plain 6407 janx U3VidmVyc2lvbiBSZXZpc2lvbjogMTIwMzI2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNzA0ZTk4OTQyMDc0YTU3 MmM1ZWU5NTEyNDJiYTkwZGU0YWQ4ODBlYi4uNjFmZWEzZWEwNTcxN2UzMTRiMDRlY2FhM2M3Njc2 Y2ZlNmNlMTVmMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI0IEBACisyMDEyLTA2LTE5ICBKYW4g S2Vyb21uZXMgIDxqYW54QGxpbnV4LmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBleHRl bnNpb25QYW5lbC5vblNlYXJjaCBgYWN0aW9uYCBzdHJpbmdzIHNob3VsZCBiZQorICAgICAgICBl bnVtZXJhdGVkLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9ODk1MDkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBGaXhlZCBMYXlvdXRUZXN0cy9pbnNwZWN0b3IvZXh0ZW5zaW9ucy9leHRlbnNpb25zLWFwaS1l eHBlY3RlZC50eHQKKyAgICAgICAgYWNjb3JkaW5nbHkuCisKKyAgICAgICAgKiBpbnNwZWN0b3Iv ZnJvbnQtZW5kL0V4dGVuc2lvbkFQSS5qczoKKyAgICAgICAgKGRlZmluZUNvbW1vbkV4dGVuc2lv blN5bWJvbHMpOgorICAgICAgICAoaW5qZWN0ZWRFeHRlbnNpb25BUEkuUGFuZWxzLnByb3RvdHlw ZS5zZXRPcGVuUmVzb3VyY2VIYW5kbGVyKToKKyAgICAgICAgKGluamVjdGVkRXh0ZW5zaW9uQVBJ LlBhbmVscy5wcm90b3R5cGUuZ2V0IFNlYXJjaEFjdGlvbik6CisgICAgICAgICogaW5zcGVjdG9y L2Zyb250LWVuZC9FeHRlbnNpb25QYW5lbC5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rvci5FeHRl bnNpb25QYW5lbC5wcm90b3R5cGUuc2VhcmNoQ2FuY2VsZWQpOgorICAgICAgICAoV2ViSW5zcGVj dG9yLkV4dGVuc2lvblBhbmVsLnByb3RvdHlwZS5wZXJmb3JtU2VhcmNoKToKKyAgICAgICAgKFdl Ykluc3BlY3Rvci5FeHRlbnNpb25QYW5lbC5wcm90b3R5cGUuanVtcFRvTmV4dFNlYXJjaFJlc3Vs dCk6CisgICAgICAgIChXZWJJbnNwZWN0b3IuRXh0ZW5zaW9uUGFuZWwucHJvdG90eXBlLmp1bXBU b1ByZXZpb3VzU2VhcmNoUmVzdWx0KToKKwogMjAxMi0wNi0xNCAgRXJpYyBQZW5uZXIgIDxlcGVu bmVyQGdvb2dsZS5jb20+CiAKICAgICAgICAgW2Nocm9taXVtXSBGaXggcmFjZSBjb25kaXRpb24g d2hlcmUgYW5pbWF0aW9ucyBzdGFydCwgZmluaXNoIGFuZCBhcmUgZGVsZXRlZCBvbiB0aGUgY29t cG9zaXRlIHRocmVhZCwgYWxsIGJlZm9yZSB0aGUgc3RhcnQgZXZlbiBhcnJpdmVzIG9uIHRoZSBt YWluIHRocmVhZC4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1l bmQvRXh0ZW5zaW9uQVBJLmpzIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9F eHRlbnNpb25BUEkuanMKaW5kZXggODVjNDMzNGI4NTBkMjk3NjgxZmQ4NjQxMTQ0MGQ3YzNlNzk0 YmI1Mi4uOWNiMmMzMWY4NzFkN2Q3YTJjODNjZjJkOGJiMmQzNWI5OWI5OGEwNiAxMDA2NDQKLS0t IGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9FeHRlbnNpb25BUEkuanMKKysr IGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9FeHRlbnNpb25BUEkuanMKQEAg LTMyLDcgKzMyLDYgQEAgZnVuY3Rpb24gZGVmaW5lQ29tbW9uRXh0ZW5zaW9uU3ltYm9scyhhcGlQ cml2YXRlKQogewogICAgIGlmICghYXBpUHJpdmF0ZS5hdWRpdHMpCiAgICAgICAgIGFwaVByaXZh dGUuYXVkaXRzID0ge307Ci0KICAgICBhcGlQcml2YXRlLmF1ZGl0cy5TZXZlcml0eSA9IHsKICAg ICAgICAgSW5mbzogImluZm8iLAogICAgICAgICBXYXJuaW5nOiAid2FybmluZyIsCkBAIC00OCw2 ICs0NywxNiBAQCBmdW5jdGlvbiBkZWZpbmVDb21tb25FeHRlbnNpb25TeW1ib2xzKGFwaVByaXZh dGUpCiAgICAgICAgIFdhcm5pbmc6ICJ3YXJuaW5nIiwKICAgICAgICAgRXJyb3I6ICJlcnJvciIK ICAgICB9OworCisgICAgaWYgKCFhcGlQcml2YXRlLnBhbmVscykKKyAgICAgICAgYXBpUHJpdmF0 ZS5wYW5lbHMgPSB7fTsKKyAgICBhcGlQcml2YXRlLnBhbmVscy5TZWFyY2hBY3Rpb24gPSB7Cisg ICAgICAgIENhbmNlbFNlYXJjaDogImNhbmNlbFNlYXJjaCIsCisgICAgICAgIFBlcmZvcm1TZWFy Y2g6ICJwZXJmb3JtU2VhcmNoIiwKKyAgICAgICAgTmV4dFNlYXJjaFJlc3VsdDogIm5leHRTZWFy Y2hSZXN1bHQiLAorICAgICAgICBQcmV2aW91c1NlYXJjaFJlc3VsdDogInByZXZpb3VzU2VhcmNo UmVzdWx0IgorICAgIH07CisKICAgICBhcGlQcml2YXRlLkV2ZW50cyA9IHsKICAgICAgICAgQXVk aXRTdGFydGVkOiAiYXVkaXQtc3RhcnRlZC0iLAogICAgICAgICBCdXR0b25DbGlja2VkOiAiYnV0 dG9uLWNsaWNrZWQtIiwKQEAgLTY0LDYgKzczLDcgQEAgZnVuY3Rpb24gZGVmaW5lQ29tbW9uRXh0 ZW5zaW9uU3ltYm9scyhhcGlQcml2YXRlKQogICAgICAgICBWaWV3U2hvd246ICJ2aWV3LXNob3du LSIsCiAgICAgICAgIFZpZXdIaWRkZW46ICJ2aWV3LWhpZGRlbi0iCiAgICAgfTsKKwogICAgIGFw aVByaXZhdGUuQ29tbWFuZHMgPSB7CiAgICAgICAgIEFkZEF1ZGl0Q2F0ZWdvcnk6ICJhZGRBdWRp dENhdGVnb3J5IiwKICAgICAgICAgQWRkQXVkaXRSZXN1bHQ6ICJhZGRBdWRpdFJlc3VsdCIsCkBA IC0zMjAsNiArMzMwLDExIEBAIFBhbmVscy5wcm90b3R5cGUgPSB7CiAgICAgICAgIC8vIE9ubHkg c2VuZCBjb21tYW5kIGlmIHdlIGVpdGhlciByZW1vdmVkIGFuIGV4aXN0aW5nIGhhbmRsZXIgb3Ig YWRkZWQgaGFuZGxlciBhbmQgaGFkIG5vbmUgYmVmb3JlLgogICAgICAgICBpZiAoaGFkSGFuZGxl ciA9PT0gIWNhbGxiYWNrKQogICAgICAgICAgICAgZXh0ZW5zaW9uU2VydmVyLnNlbmRSZXF1ZXN0 KHsgY29tbWFuZDogY29tbWFuZHMuU2V0T3BlblJlc291cmNlSGFuZGxlciwgImhhbmRsZXJQcmVz ZW50IjogISFjYWxsYmFjayB9KTsKKyAgICB9LAorCisgICAgZ2V0IFNlYXJjaEFjdGlvbigpCisg ICAgeworICAgICAgICByZXR1cm4gYXBpUHJpdmF0ZS5wYW5lbHMuU2VhcmNoQWN0aW9uOwogICAg IH0KIH0KIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9F eHRlbnNpb25QYW5lbC5qcyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvRXh0 ZW5zaW9uUGFuZWwuanMKaW5kZXggY2Q5MDQ4NmU2ZTZhNDM0NmE4MjY5MjQwMzJlZmY2NDI5Mjc2 ZGZhNy4uZDFjMjgxY2Q4YmI0NjNjMDljZGU1N2Y4OWU3NDNhNDBmYWNiYzI1ZSAxMDA2NDQKLS0t IGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9FeHRlbnNpb25QYW5lbC5qcwor KysgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0V4dGVuc2lvblBhbmVsLmpz CkBAIC0xNDcsMjUgKzE0NywyNSBAQCBXZWJJbnNwZWN0b3IuRXh0ZW5zaW9uUGFuZWwucHJvdG90 eXBlID0gewogCiAgICAgc2VhcmNoQ2FuY2VsZWQ6IGZ1bmN0aW9uKHN0YXJ0aW5nTmV3U2VhcmNo KQogICAgIHsKLSAgICAgICAgV2ViSW5zcGVjdG9yLmV4dGVuc2lvblNlcnZlci5ub3RpZnlTZWFy Y2hBY3Rpb24odGhpcy5faWQsICJjYW5jZWxTZWFyY2giKTsKKyAgICAgICAgV2ViSW5zcGVjdG9y LmV4dGVuc2lvblNlcnZlci5ub3RpZnlTZWFyY2hBY3Rpb24odGhpcy5faWQsIFdlYkluc3BlY3Rv ci5leHRlbnNpb25BUEkucGFuZWxzLlNlYXJjaEFjdGlvbi5DYW5jZWxTZWFyY2gpOwogICAgICAg ICBXZWJJbnNwZWN0b3IuUGFuZWwucHJvdG90eXBlLnNlYXJjaENhbmNlbGVkLmFwcGx5KHRoaXMs IGFyZ3VtZW50cyk7CiAgICAgfSwKIAogICAgIHBlcmZvcm1TZWFyY2g6IGZ1bmN0aW9uKHF1ZXJ5 KQogICAgIHsKLSAgICAgICAgV2ViSW5zcGVjdG9yLmV4dGVuc2lvblNlcnZlci5ub3RpZnlTZWFy Y2hBY3Rpb24odGhpcy5faWQsICJwZXJmb3JtU2VhcmNoIiwgcXVlcnkpOworICAgICAgICBXZWJJ bnNwZWN0b3IuZXh0ZW5zaW9uU2VydmVyLm5vdGlmeVNlYXJjaEFjdGlvbih0aGlzLl9pZCwgV2Vi SW5zcGVjdG9yLmV4dGVuc2lvbkFQSS5wYW5lbHMuU2VhcmNoQWN0aW9uLlBlcmZvcm1TZWFyY2gs IHF1ZXJ5KTsKICAgICAgICAgV2ViSW5zcGVjdG9yLlBhbmVsLnByb3RvdHlwZS5wZXJmb3JtU2Vh cmNoLmFwcGx5KHRoaXMsIGFyZ3VtZW50cyk7CiAgICAgfSwKIAogICAgIGp1bXBUb05leHRTZWFy Y2hSZXN1bHQ6IGZ1bmN0aW9uKCkKICAgICB7Ci0gICAgICAgIFdlYkluc3BlY3Rvci5leHRlbnNp b25TZXJ2ZXIubm90aWZ5U2VhcmNoQWN0aW9uKHRoaXMuX2lkLCAibmV4dFNlYXJjaFJlc3VsdCIp OworICAgICAgICBXZWJJbnNwZWN0b3IuZXh0ZW5zaW9uU2VydmVyLm5vdGlmeVNlYXJjaEFjdGlv bih0aGlzLl9pZCwgV2ViSW5zcGVjdG9yLmV4dGVuc2lvbkFQSS5wYW5lbHMuU2VhcmNoQWN0aW9u Lk5leHRTZWFyY2hSZXN1bHQpOwogICAgICAgICBXZWJJbnNwZWN0b3IuUGFuZWwucHJvdG90eXBl Lmp1bXBUb05leHRTZWFyY2hSZXN1bHQuY2FsbCh0aGlzKTsKICAgICB9LAogCiAgICAganVtcFRv UHJldmlvdXNTZWFyY2hSZXN1bHQ6IGZ1bmN0aW9uKCkKICAgICB7Ci0gICAgICAgIFdlYkluc3Bl Y3Rvci5leHRlbnNpb25TZXJ2ZXIubm90aWZ5U2VhcmNoQWN0aW9uKHRoaXMuX2lkLCAicHJldmlv dXNTZWFyY2hSZXN1bHQiKTsKKyAgICAgICAgV2ViSW5zcGVjdG9yLmV4dGVuc2lvblNlcnZlci5u b3RpZnlTZWFyY2hBY3Rpb24odGhpcy5faWQsIFdlYkluc3BlY3Rvci5leHRlbnNpb25BUEkucGFu ZWxzLlNlYXJjaEFjdGlvbi5QcmV2aW91c1NlYXJjaFJlc3VsdCk7CiAgICAgICAgIFdlYkluc3Bl Y3Rvci5QYW5lbC5wcm90b3R5cGUuanVtcFRvUHJldmlvdXNTZWFyY2hSZXN1bHQuY2FsbCh0aGlz KTsKICAgICB9LAogCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cgYi9MYXlvdXRU ZXN0cy9DaGFuZ2VMb2cKaW5kZXggNGY1Y2IyMzljNjZmNTMyNzIxM2I2ZDc5Y2U0NTQyNzI3ZTRi OWM2My4uOTQ3NTg4ZmI2OGYxMDIxYjU2YjY4YWRkMGU4NGVkYmNjNGE5MTRhNyAxMDA2NDQKLS0t IGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwpAQCAt MSwzICsxLDEyIEBACisyMDEyLTA2LTE5ICBKYW4gS2Vyb21uZXMgIDxqYW54QGxpbnV4LmNvbT4K KworICAgICAgICBXZWIgSW5zcGVjdG9yOiBleHRlbnNpb25QYW5lbC5vblNlYXJjaCBgYWN0aW9u YCBzdHJpbmdzIHNob3VsZCBiZSBlbnVtZXJhdGVkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD04OTUwOQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgICogaW5zcGVjdG9yL2V4dGVuc2lvbnMvZXh0ZW5zaW9ucy1h cGktZXhwZWN0ZWQudHh0OgorCiAyMDEyLTA2LTE0ICBNaWtoYWlsIFBvemRueWFrb3YgIDxtaWto YWlsLnBvemRueWFrb3ZAaW50ZWwuY29tPgogCiAgICAgICAgIFtFRkxdIFRlc3RzIHJlYmFzZWxp bmluZyBhZnRlciByMTIwMTY3LCByMTIwMjQ2CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9pbnNw ZWN0b3IvZXh0ZW5zaW9ucy9leHRlbnNpb25zLWFwaS1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0 cy9pbnNwZWN0b3IvZXh0ZW5zaW9ucy9leHRlbnNpb25zLWFwaS1leHBlY3RlZC50eHQKaW5kZXgg NzRjZTBlMWIwZjA3MTc2ZTk1YWYxMjFhYTA1YTUwMGFkZGIwYWU4Mi4uMjgzYjBhM2EwZjBkNjA4 ODM5OGEzMTdiZTJlOWExOWY4NTZjODAwZSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvaW5zcGVj dG9yL2V4dGVuc2lvbnMvZXh0ZW5zaW9ucy1hcGktZXhwZWN0ZWQudHh0CisrKyBiL0xheW91dFRl c3RzL2luc3BlY3Rvci9leHRlbnNpb25zL2V4dGVuc2lvbnMtYXBpLWV4cGVjdGVkLnR4dApAQCAt MzAsNiArMzAsMTIgQEAgUlVOTklORyBURVNUOiBleHRlbnNpb25fdGVzdEFQSQogICAgICAgICB9 CiAgICAgICAgIGNyZWF0ZSA6IDxmdW5jdGlvbj4KICAgICAgICAgc2V0T3BlblJlc291cmNlSGFu ZGxlciA6IDxmdW5jdGlvbj4KKyAgICAgICAgU2VhcmNoQWN0aW9uIDogeworICAgICAgICAgICAg Q2FuY2VsU2VhcmNoIDogImNhbmNlbFNlYXJjaCIKKyAgICAgICAgICAgIFBlcmZvcm1TZWFyY2gg OiAicGVyZm9ybVNlYXJjaCIKKyAgICAgICAgICAgIE5leHRTZWFyY2hSZXN1bHQgOiAibmV4dFNl YXJjaFJlc3VsdCIKKyAgICAgICAgICAgIFByZXZpb3VzU2VhcmNoUmVzdWx0IDogInByZXZpb3Vz U2VhcmNoUmVzdWx0IgorICAgICAgICB9CiAgICAgfQogICAgIG5ldHdvcmsgOiB7CiAgICAgICAg IG9uUmVxdWVzdEZpbmlzaGVkIDogewo=