<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>89500</bug_id>
          
          <creation_ts>2012-06-19 12:53:13 -0700</creation_ts>
          <short_desc>[BlackBerry] Should check the return value of fromUTF8() before executing it.</short_desc>
          <delta_ts>2012-06-22 11:07:08 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKit BlackBerry</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Yong Li">yong.li.webkit</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>tonikitoo</cc>
    
    <cc>webkit.review.bot</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>652699</commentid>
    <comment_count>0</comment_count>
    <who name="Yong Li">yong.li.webkit</who>
    <bug_when>2012-06-19 12:53:13 -0700</bug_when>
    <thetext>WebPagePrivate::executeJavaScript() should check the return value of fromUTF8() before executing it to avoid potential crash.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>652705</commentid>
    <comment_count>1</comment_count>
      <attachid>148397</attachid>
    <who name="Yong Li">yong.li.webkit</who>
    <bug_when>2012-06-19 12:58:17 -0700</bug_when>
    <thetext>Created attachment 148397
the patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>652707</commentid>
    <comment_count>2</comment_count>
      <attachid>148398</attachid>
    <who name="Yong Li">yong.li.webkit</who>
    <bug_when>2012-06-19 13:02:53 -0700</bug_when>
    <thetext>Created attachment 148398
again</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>652745</commentid>
    <comment_count>3</comment_count>
      <attachid>148408</attachid>
    <who name="Yong Li">yong.li.webkit</who>
    <bug_when>2012-06-19 13:40:16 -0700</bug_when>
    <thetext>Created attachment 148408
Another try</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>652754</commentid>
    <comment_count>4</comment_count>
      <attachid>148408</attachid>
    <who name="Rob Buis">rwlbuis</who>
    <bug_when>2012-06-19 13:46:10 -0700</bug_when>
    <thetext>Comment on attachment 148408
Another try

View in context: https://bugs.webkit.org/attachment.cgi?id=148408&amp;action=review

LGTM.

&gt; Source/WebKit/blackberry/ChangeLog:9
&gt; +        before executing the script to avoid potential crash on invalid script source.

Probably needs PR mention.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>652759</commentid>
    <comment_count>5</comment_count>
      <attachid>148411</attachid>
    <who name="Yong Li">yong.li.webkit</who>
    <bug_when>2012-06-19 13:49:08 -0700</bug_when>
    <thetext>Created attachment 148411
to commit</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>652843</commentid>
    <comment_count>6</comment_count>
      <attachid>148411</attachid>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2012-06-19 14:46:25 -0700</bug_when>
    <thetext>Comment on attachment 148411
to commit

Rejecting attachment 148411 from commit-queue.

Failed to run &quot;[&apos;/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch&apos;, &apos;--status-host=queues.webkit.org&apos;, &apos;-...&quot; exit_code: 2

Last 500 characters of output:
ipts/svn-apply&apos;, u&apos;--force&apos;]&quot; exit_code: 2 cwd: /mnt/git/webkit-commit-queue/

Parsed 2 diffs from patch file(s).
patching file Source/WebKit/blackberry/Api/WebPage.cpp
Hunk #1 succeeded at 703 (offset 2 lines).
patching file Source/WebKit/blackberry/ChangeLog
patch: **** malformed patch at line 22:          [Blackberry] add a new Api named setAllowNotification


Failed to run &quot;[u&apos;/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply&apos;, u&apos;--force&apos;]&quot; exit_code: 2 cwd: /mnt/git/webkit-commit-queue/

Full output: http://queues.webkit.org/results/12982521</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>652865</commentid>
    <comment_count>7</comment_count>
      <attachid>148437</attachid>
    <who name="Yong Li">yong.li.webkit</who>
    <bug_when>2012-06-19 15:05:40 -0700</bug_when>
    <thetext>Created attachment 148437
Changelog again!</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>652984</commentid>
    <comment_count>8</comment_count>
      <attachid>148437</attachid>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2012-06-19 16:50:47 -0700</bug_when>
    <thetext>Comment on attachment 148437
Changelog again!

Clearing flags on attachment: 148437

Committed r120774: &lt;http://trac.webkit.org/changeset/120774&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>148397</attachid>
            <date>2012-06-19 12:58:17 -0700</date>
            <delta_ts>2012-06-19 13:01:25 -0700</delta_ts>
            <desc>the patch</desc>
            <filename>89500.patch</filename>
            <type>text/plain</type>
            <size>1774</size>
            <attacher name="Yong Li">yong.li.webkit</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9BcGkvV2ViUGFnZS5jcHAgYi9T
b3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvQXBpL1dlYlBhZ2UuY3BwCmluZGV4IDllNzdjZGEuLjEx
OTg5ZGUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9BcGkvV2ViUGFnZS5j
cHAKKysrIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0FwaS9XZWJQYWdlLmNwcApAQCAtNzAz
LDcgKzcwMywxNCBAQCB2b2lkIFdlYlBhZ2U6OmxvYWRTdHJpbmcoY29uc3QgY2hhciogc3RyaW5n
LCBjb25zdCBjaGFyKiBiYXNlVVJMLCBjb25zdCBjaGFyKiBtaQogCiBib29sIFdlYlBhZ2VQcml2
YXRlOjpleGVjdXRlSmF2YVNjcmlwdChjb25zdCBjaGFyKiBzY3JpcHQsIEphdmFTY3JpcHREYXRh
VHlwZSYgcmV0dXJuVHlwZSwgV2ViU3RyaW5nJiByZXR1cm5WYWx1ZSkKIHsKLSAgICBTY3JpcHRW
YWx1ZSByZXN1bHQgPSBtX21haW5GcmFtZS0+c2NyaXB0KCktPmV4ZWN1dGVTY3JpcHQoU3RyaW5n
Ojpmcm9tVVRGOChzY3JpcHQpLCBmYWxzZSk7CisgICAgU3RyaW5nIHNjcmlwdCA9IFN0cmluZzo6
ZnJvbVVURjgoc2NyaXB0VVRGOCk7CisgICAgaWYgKHNjcmlwdC5pc051bGwoKSkgeworICAgICAg
ICByZXR1cm5WYWx1ZSA9ICJGYWlsZWQgdG8gZGVjb2RlIHRoZSBzb3VyY2UuIFVURjggZXhwZWN0
ZWQiOworICAgICAgICByZXR1cm5UeXBlID0gSlNFeGNlcHRpb247CisgICAgICAgIHJldHVybiBm
YWxzZTsKKyAgICB9CisKKyAgICBTY3JpcHRWYWx1ZSByZXN1bHQgPSBtX21haW5GcmFtZS0+c2Ny
aXB0KCktPmV4ZWN1dGVTY3JpcHQoc2NyaXB0LCBmYWxzZSk7CiAgICAgSlNDOjpKU1ZhbHVlIHZh
bHVlID0gcmVzdWx0LmpzVmFsdWUoKTsKICAgICBpZiAoIXZhbHVlKSB7CiAgICAgICAgIHJldHVy
blR5cGUgPSBKU0V4Y2VwdGlvbjsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJy
eS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvQ2hhbmdlTG9nCmluZGV4IDE3
NWJkNDMuLjZhMDMyNDcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFu
Z2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZwpAQCAtMSwzICsx
LDE2IEBACisyMDEyLTA2LTE5ICBZb25nIExpICA8eW9saUByaW0uY29tPgorCisgICAgICAgIFtC
bGFja0JlcnJ5XSBTaG91bGQgY2hlY2sgdGhlIHJldHVybiB2YWx1ZSBvZiBmcm9tVVRGOCgpIGJl
Zm9yZSBleGVjdXRpbmcgdGhlIHNjcmlwdC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v
cmcvc2hvd19idWcuY2dpP2lkPTg5NTAwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP
T1BTISkuCisKKyAgICAgICAgV2ViUGFnZVByaXZhdGU6OmV4ZWN1dGVKYXZhU2NyaXB0KCkgc2hv
dWxkIGNoZWNrIHRoZSByZXR1cm4gdmFsdWUgb2YgZnJvbVVURjgoKQorICAgICAgICBiZWZvcmUg
ZXhlY3V0aW5nIHRoZSBzY3JpcHQgdG8gYXZvaWQgcG90ZW50aWFsIGNyYXNoIG9uIGludmFsaWQg
c2NyaXB0IHNvdXJjZS4KKworICAgICAgICAqIEFwaS9XZWJQYWdlLmNwcDoKKyAgICAgICAgKEJs
YWNrQmVycnk6OldlYktpdDo6V2ViUGFnZVByaXZhdGU6OmV4ZWN1dGVKYXZhU2NyaXB0KToKKwog
MjAxMi0wNi0xNCAgQ2hyaXMgR3VhbiAgPGNocmlzLmd1YW5AdG9yY2htb2JpbGUuY29tLmNuPgog
CiAgICAgICAgIFtCbGFja2JlcnJ5XSBhZGQgYSBuZXcgQXBpIG5hbWVkIHNldEFsbG93Tm90aWZp
Y2F0aW9uCg==
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>148398</attachid>
            <date>2012-06-19 13:02:53 -0700</date>
            <delta_ts>2012-06-19 13:32:58 -0700</delta_ts>
            <desc>again</desc>
            <filename>89500.patch</filename>
            <type>text/plain</type>
            <size>1956</size>
            <attacher name="Yong Li">yong.li.webkit</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9BcGkvV2ViUGFnZS5jcHAgYi9T
b3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvQXBpL1dlYlBhZ2UuY3BwCmluZGV4IDllNzdjZGEuLjQw
YTMxY2IgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9BcGkvV2ViUGFnZS5j
cHAKKysrIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0FwaS9XZWJQYWdlLmNwcApAQCAtNzAx
LDkgKzcwMSwxNiBAQCB2b2lkIFdlYlBhZ2U6OmxvYWRTdHJpbmcoY29uc3QgY2hhciogc3RyaW5n
LCBjb25zdCBjaGFyKiBiYXNlVVJMLCBjb25zdCBjaGFyKiBtaQogICAgIGQtPmxvYWRTdHJpbmco
c3RyaW5nLCBiYXNlVVJMLCBtaW1lVHlwZSwgZmFpbGluZ1VSTCk7CiB9CiAKLWJvb2wgV2ViUGFn
ZVByaXZhdGU6OmV4ZWN1dGVKYXZhU2NyaXB0KGNvbnN0IGNoYXIqIHNjcmlwdCwgSmF2YVNjcmlw
dERhdGFUeXBlJiByZXR1cm5UeXBlLCBXZWJTdHJpbmcmIHJldHVyblZhbHVlKQorYm9vbCBXZWJQ
YWdlUHJpdmF0ZTo6ZXhlY3V0ZUphdmFTY3JpcHQoY29uc3QgY2hhciogc2NyaXB0VVRGOCwgSmF2
YVNjcmlwdERhdGFUeXBlJiByZXR1cm5UeXBlLCBXZWJTdHJpbmcmIHJldHVyblZhbHVlKQogewot
ICAgIFNjcmlwdFZhbHVlIHJlc3VsdCA9IG1fbWFpbkZyYW1lLT5zY3JpcHQoKS0+ZXhlY3V0ZVNj
cmlwdChTdHJpbmc6OmZyb21VVEY4KHNjcmlwdCksIGZhbHNlKTsKKyAgICBTdHJpbmcgc2NyaXB0
ID0gU3RyaW5nOjpmcm9tVVRGOChzY3JpcHRVVEY4KTsKKyAgICBpZiAoc2NyaXB0LmlzTnVsbCgp
KSB7CisgICAgICAgIHJldHVyblZhbHVlID0gIkZhaWxlZCB0byBkZWNvZGUgdGhlIHNvdXJjZS4g
VVRGOCBleHBlY3RlZCI7CisgICAgICAgIHJldHVyblR5cGUgPSBKU0V4Y2VwdGlvbjsKKyAgICAg
ICAgcmV0dXJuIGZhbHNlOworICAgIH0KKworICAgIFNjcmlwdFZhbHVlIHJlc3VsdCA9IG1fbWFp
bkZyYW1lLT5zY3JpcHQoKS0+ZXhlY3V0ZVNjcmlwdChzY3JpcHQsIGZhbHNlKTsKICAgICBKU0M6
OkpTVmFsdWUgdmFsdWUgPSByZXN1bHQuanNWYWx1ZSgpOwogICAgIGlmICghdmFsdWUpIHsKICAg
ICAgICAgcmV0dXJuVHlwZSA9IEpTRXhjZXB0aW9uOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktp
dC9ibGFja2JlcnJ5L0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFuZ2VM
b2cKaW5kZXggMTc1YmQ0My4uNmEwMzI0NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9ibGFj
a2JlcnJ5L0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvQ2hhbmdlTG9n
CkBAIC0xLDMgKzEsMTYgQEAKKzIwMTItMDYtMTkgIFlvbmcgTGkgIDx5b2xpQHJpbS5jb20+CisK
KyAgICAgICAgW0JsYWNrQmVycnldIFNob3VsZCBjaGVjayB0aGUgcmV0dXJuIHZhbHVlIG9mIGZy
b21VVEY4KCkgYmVmb3JlIGV4ZWN1dGluZyB0aGUgc2NyaXB0LgorICAgICAgICBodHRwczovL2J1
Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODk1MDAKKworICAgICAgICBSZXZpZXdlZCBi
eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXZWJQYWdlUHJpdmF0ZTo6ZXhlY3V0ZUphdmFT
Y3JpcHQoKSBzaG91bGQgY2hlY2sgdGhlIHJldHVybiB2YWx1ZSBvZiBmcm9tVVRGOCgpCisgICAg
ICAgIGJlZm9yZSBleGVjdXRpbmcgdGhlIHNjcmlwdCB0byBhdm9pZCBwb3RlbnRpYWwgY3Jhc2gg
b24gaW52YWxpZCBzY3JpcHQgc291cmNlLgorCisgICAgICAgICogQXBpL1dlYlBhZ2UuY3BwOgor
ICAgICAgICAoQmxhY2tCZXJyeTo6V2ViS2l0OjpXZWJQYWdlUHJpdmF0ZTo6ZXhlY3V0ZUphdmFT
Y3JpcHQpOgorCiAyMDEyLTA2LTE0ICBDaHJpcyBHdWFuICA8Y2hyaXMuZ3VhbkB0b3JjaG1vYmls
ZS5jb20uY24+CiAKICAgICAgICAgW0JsYWNrYmVycnldIGFkZCBhIG5ldyBBcGkgbmFtZWQgc2V0
QWxsb3dOb3RpZmljYXRpb24K
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>148408</attachid>
            <date>2012-06-19 13:40:16 -0700</date>
            <delta_ts>2012-06-19 13:46:10 -0700</delta_ts>
            <desc>Another try</desc>
            <filename>89500.patch</filename>
            <type>text/plain</type>
            <size>1984</size>
            <attacher name="Yong Li">yong.li.webkit</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9BcGkvV2ViUGFnZS5jcHAgYi9T
b3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvQXBpL1dlYlBhZ2UuY3BwCmluZGV4IDllNzdjZGEuLmEw
ZDNkMDggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9BcGkvV2ViUGFnZS5j
cHAKKysrIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0FwaS9XZWJQYWdlLmNwcApAQCAtNzAx
LDkgKzcwMSwyMSBAQCB2b2lkIFdlYlBhZ2U6OmxvYWRTdHJpbmcoY29uc3QgY2hhciogc3RyaW5n
LCBjb25zdCBjaGFyKiBiYXNlVVJMLCBjb25zdCBjaGFyKiBtaQogICAgIGQtPmxvYWRTdHJpbmco
c3RyaW5nLCBiYXNlVVJMLCBtaW1lVHlwZSwgZmFpbGluZ1VSTCk7CiB9CiAKLWJvb2wgV2ViUGFn
ZVByaXZhdGU6OmV4ZWN1dGVKYXZhU2NyaXB0KGNvbnN0IGNoYXIqIHNjcmlwdCwgSmF2YVNjcmlw
dERhdGFUeXBlJiByZXR1cm5UeXBlLCBXZWJTdHJpbmcmIHJldHVyblZhbHVlKQorYm9vbCBXZWJQ
YWdlUHJpdmF0ZTo6ZXhlY3V0ZUphdmFTY3JpcHQoY29uc3QgY2hhciogc2NyaXB0VVRGOCwgSmF2
YVNjcmlwdERhdGFUeXBlJiByZXR1cm5UeXBlLCBXZWJTdHJpbmcmIHJldHVyblZhbHVlKQogewot
ICAgIFNjcmlwdFZhbHVlIHJlc3VsdCA9IG1fbWFpbkZyYW1lLT5zY3JpcHQoKS0+ZXhlY3V0ZVNj
cmlwdChTdHJpbmc6OmZyb21VVEY4KHNjcmlwdCksIGZhbHNlKTsKKyAgICBTdHJpbmcgc2NyaXB0
ID0gU3RyaW5nOjpmcm9tVVRGOChzY3JpcHRVVEY4KTsKKworICAgIGlmIChzY3JpcHQuaXNOdWxs
KCkpIHsKKyAgICAgICAgcmV0dXJuVHlwZSA9IEpTRXhjZXB0aW9uOworICAgICAgICByZXR1cm4g
ZmFsc2U7CisgICAgfQorCisgICAgaWYgKHNjcmlwdC5pc0VtcHR5KCkpIHsKKyAgICAgICAgcmV0
dXJuVHlwZSA9IEpTVW5kZWZpbmVkOworICAgICAgICByZXR1cm4gdHJ1ZTsKKyAgICB9CisKKyAg
ICBTY3JpcHRWYWx1ZSByZXN1bHQgPSBtX21haW5GcmFtZS0+c2NyaXB0KCktPmV4ZWN1dGVTY3Jp
cHQoc2NyaXB0LCBmYWxzZSk7CiAgICAgSlNDOjpKU1ZhbHVlIHZhbHVlID0gcmVzdWx0LmpzVmFs
dWUoKTsKICAgICBpZiAoIXZhbHVlKSB7CiAgICAgICAgIHJldHVyblR5cGUgPSBKU0V4Y2VwdGlv
bjsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFuZ2VMb2cgYi9Tb3Vy
Y2UvV2ViS2l0L2JsYWNrYmVycnkvQ2hhbmdlTG9nCmluZGV4IDE3NWJkNDMuLjZhMDMyNDcgMTAw
NjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFuZ2VMb2cKKysrIGIvU291cmNl
L1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEyLTA2LTE5
ICBZb25nIExpICA8eW9saUByaW0uY29tPgorCisgICAgICAgIFtCbGFja0JlcnJ5XSBTaG91bGQg
Y2hlY2sgdGhlIHJldHVybiB2YWx1ZSBvZiBmcm9tVVRGOCgpIGJlZm9yZSBleGVjdXRpbmcgdGhl
IHNjcmlwdC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk
PTg5NTAwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg
V2ViUGFnZVByaXZhdGU6OmV4ZWN1dGVKYXZhU2NyaXB0KCkgc2hvdWxkIGNoZWNrIHRoZSByZXR1
cm4gdmFsdWUgb2YgZnJvbVVURjgoKQorICAgICAgICBiZWZvcmUgZXhlY3V0aW5nIHRoZSBzY3Jp
cHQgdG8gYXZvaWQgcG90ZW50aWFsIGNyYXNoIG9uIGludmFsaWQgc2NyaXB0IHNvdXJjZS4KKwor
ICAgICAgICAqIEFwaS9XZWJQYWdlLmNwcDoKKyAgICAgICAgKEJsYWNrQmVycnk6OldlYktpdDo6
V2ViUGFnZVByaXZhdGU6OmV4ZWN1dGVKYXZhU2NyaXB0KToKKwogMjAxMi0wNi0xNCAgQ2hyaXMg
R3VhbiAgPGNocmlzLmd1YW5AdG9yY2htb2JpbGUuY29tLmNuPgogCiAgICAgICAgIFtCbGFja2Jl
cnJ5XSBhZGQgYSBuZXcgQXBpIG5hbWVkIHNldEFsbG93Tm90aWZpY2F0aW9uCg==
</data>
<flag name="review"
          id="156128"
          type_id="1"
          status="+"
          setter="rwlbuis"
    />
          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>148411</attachid>
            <date>2012-06-19 13:49:08 -0700</date>
            <delta_ts>2012-06-19 15:05:40 -0700</delta_ts>
            <desc>to commit</desc>
            <filename>89500.patch</filename>
            <type>text/plain</type>
            <size>1999</size>
            <attacher name="Yong Li">yong.li.webkit</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9BcGkvV2ViUGFnZS5jcHAgYi9T
b3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvQXBpL1dlYlBhZ2UuY3BwCmluZGV4IDllNzdjZGEuLmEw
ZDNkMDggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9BcGkvV2ViUGFnZS5j
cHAKKysrIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0FwaS9XZWJQYWdlLmNwcApAQCAtNzAx
LDkgKzcwMSwyMSBAQCB2b2lkIFdlYlBhZ2U6OmxvYWRTdHJpbmcoY29uc3QgY2hhciogc3RyaW5n
LCBjb25zdCBjaGFyKiBiYXNlVVJMLCBjb25zdCBjaGFyKiBtaQogICAgIGQtPmxvYWRTdHJpbmco
c3RyaW5nLCBiYXNlVVJMLCBtaW1lVHlwZSwgZmFpbGluZ1VSTCk7CiB9CiAKLWJvb2wgV2ViUGFn
ZVByaXZhdGU6OmV4ZWN1dGVKYXZhU2NyaXB0KGNvbnN0IGNoYXIqIHNjcmlwdCwgSmF2YVNjcmlw
dERhdGFUeXBlJiByZXR1cm5UeXBlLCBXZWJTdHJpbmcmIHJldHVyblZhbHVlKQorYm9vbCBXZWJQ
YWdlUHJpdmF0ZTo6ZXhlY3V0ZUphdmFTY3JpcHQoY29uc3QgY2hhciogc2NyaXB0VVRGOCwgSmF2
YVNjcmlwdERhdGFUeXBlJiByZXR1cm5UeXBlLCBXZWJTdHJpbmcmIHJldHVyblZhbHVlKQogewot
ICAgIFNjcmlwdFZhbHVlIHJlc3VsdCA9IG1fbWFpbkZyYW1lLT5zY3JpcHQoKS0+ZXhlY3V0ZVNj
cmlwdChTdHJpbmc6OmZyb21VVEY4KHNjcmlwdCksIGZhbHNlKTsKKyAgICBTdHJpbmcgc2NyaXB0
ID0gU3RyaW5nOjpmcm9tVVRGOChzY3JpcHRVVEY4KTsKKworICAgIGlmIChzY3JpcHQuaXNOdWxs
KCkpIHsKKyAgICAgICAgcmV0dXJuVHlwZSA9IEpTRXhjZXB0aW9uOworICAgICAgICByZXR1cm4g
ZmFsc2U7CisgICAgfQorCisgICAgaWYgKHNjcmlwdC5pc0VtcHR5KCkpIHsKKyAgICAgICAgcmV0
dXJuVHlwZSA9IEpTVW5kZWZpbmVkOworICAgICAgICByZXR1cm4gdHJ1ZTsKKyAgICB9CisKKyAg
ICBTY3JpcHRWYWx1ZSByZXN1bHQgPSBtX21haW5GcmFtZS0+c2NyaXB0KCktPmV4ZWN1dGVTY3Jp
cHQoc2NyaXB0LCBmYWxzZSk7CiAgICAgSlNDOjpKU1ZhbHVlIHZhbHVlID0gcmVzdWx0LmpzVmFs
dWUoKTsKICAgICBpZiAoIXZhbHVlKSB7CiAgICAgICAgIHJldHVyblR5cGUgPSBKU0V4Y2VwdGlv
bjsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFuZ2VMb2cgYi9Tb3Vy
Y2UvV2ViS2l0L2JsYWNrYmVycnkvQ2hhbmdlTG9nCmluZGV4IDE3NWJkNDMuLjZhMDMyNDcgMTAw
NjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFuZ2VMb2cKKysrIGIvU291cmNl
L1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEyLTA2LTE5
ICBZb25nIExpICA8eW9saUByaW0uY29tPgorCisgICAgICAgIFtCbGFja0JlcnJ5XSBTaG91bGQg
Y2hlY2sgdGhlIHJldHVybiB2YWx1ZSBvZiBmcm9tVVRGOCgpIGJlZm9yZSBleGVjdXRpbmcgdGhl
IHNjcmlwdC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk
PTg5NTAwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgUm9iIEJ1aXMuCisKKyAgICAgICAgUFIjIDE2
NjYyMy4KKyAgICAgICAgV2ViUGFnZVByaXZhdGU6OmV4ZWN1dGVKYXZhU2NyaXB0KCkgc2hvdWxk
IGNoZWNrIHRoZSByZXR1cm4gdmFsdWUgb2YgZnJvbVVURjgoKQorICAgICAgICBiZWZvcmUgZXhl
Y3V0aW5nIHRoZSBzY3JpcHQgdG8gYXZvaWQgcG90ZW50aWFsIGNyYXNoIG9uIGludmFsaWQgc2Ny
aXB0IHNvdXJjZS4KKworICAgICAgICAqIEFwaS9XZWJQYWdlLmNwcDoKKyAgICAgICAgKEJsYWNr
QmVycnk6OldlYktpdDo6V2ViUGFnZVByaXZhdGU6OmV4ZWN1dGVKYXZhU2NyaXB0KToKKwogMjAx
Mi0wNi0xNCAgQ2hyaXMgR3VhbiAgPGNocmlzLmd1YW5AdG9yY2htb2JpbGUuY29tLmNuPgogCiAg
ICAgICAgIFtCbGFja2JlcnJ5XSBhZGQgYSBuZXcgQXBpIG5hbWVkIHNldEFsbG93Tm90aWZpY2F0
aW9uCg==
</data>
<flag name="commit-queue"
          id="156132"
          type_id="3"
          status="-"
          setter="webkit.review.bot"
    />
          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>148437</attachid>
            <date>2012-06-19 15:05:40 -0700</date>
            <delta_ts>2012-06-19 16:50:47 -0700</delta_ts>
            <desc>Changelog again!</desc>
            <filename>89500.patch</filename>
            <type>text/plain</type>
            <size>2031</size>
            <attacher name="Yong Li">yong.li.webkit</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9BcGkvV2ViUGFnZS5jcHAgYi9T
b3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvQXBpL1dlYlBhZ2UuY3BwCmluZGV4IDQ3MzY1Y2EuLjhl
MzhhNzAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9BcGkvV2ViUGFnZS5j
cHAKKysrIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0FwaS9XZWJQYWdlLmNwcApAQCAtNzAz
LDkgKzcwMywyMSBAQCB2b2lkIFdlYlBhZ2U6OmxvYWRTdHJpbmcoY29uc3QgY2hhciogc3RyaW5n
LCBjb25zdCBjaGFyKiBiYXNlVVJMLCBjb25zdCBjaGFyKiBtaQogICAgIGQtPmxvYWRTdHJpbmco
c3RyaW5nLCBiYXNlVVJMLCBtaW1lVHlwZSwgZmFpbGluZ1VSTCk7CiB9CiAKLWJvb2wgV2ViUGFn
ZVByaXZhdGU6OmV4ZWN1dGVKYXZhU2NyaXB0KGNvbnN0IGNoYXIqIHNjcmlwdCwgSmF2YVNjcmlw
dERhdGFUeXBlJiByZXR1cm5UeXBlLCBXZWJTdHJpbmcmIHJldHVyblZhbHVlKQorYm9vbCBXZWJQ
YWdlUHJpdmF0ZTo6ZXhlY3V0ZUphdmFTY3JpcHQoY29uc3QgY2hhciogc2NyaXB0VVRGOCwgSmF2
YVNjcmlwdERhdGFUeXBlJiByZXR1cm5UeXBlLCBXZWJTdHJpbmcmIHJldHVyblZhbHVlKQogewot
ICAgIFNjcmlwdFZhbHVlIHJlc3VsdCA9IG1fbWFpbkZyYW1lLT5zY3JpcHQoKS0+ZXhlY3V0ZVNj
cmlwdChTdHJpbmc6OmZyb21VVEY4KHNjcmlwdCksIGZhbHNlKTsKKyAgICBTdHJpbmcgc2NyaXB0
ID0gU3RyaW5nOjpmcm9tVVRGOChzY3JpcHRVVEY4KTsKKworICAgIGlmIChzY3JpcHQuaXNOdWxs
KCkpIHsKKyAgICAgICAgcmV0dXJuVHlwZSA9IEpTRXhjZXB0aW9uOworICAgICAgICByZXR1cm4g
ZmFsc2U7CisgICAgfQorCisgICAgaWYgKHNjcmlwdC5pc0VtcHR5KCkpIHsKKyAgICAgICAgcmV0
dXJuVHlwZSA9IEpTVW5kZWZpbmVkOworICAgICAgICByZXR1cm4gdHJ1ZTsKKyAgICB9CisKKyAg
ICBTY3JpcHRWYWx1ZSByZXN1bHQgPSBtX21haW5GcmFtZS0+c2NyaXB0KCktPmV4ZWN1dGVTY3Jp
cHQoc2NyaXB0LCBmYWxzZSk7CiAgICAgSlNDOjpKU1ZhbHVlIHZhbHVlID0gcmVzdWx0LmpzVmFs
dWUoKTsKICAgICBpZiAoIXZhbHVlKSB7CiAgICAgICAgIHJldHVyblR5cGUgPSBKU0V4Y2VwdGlv
bjsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFuZ2VMb2cgYi9Tb3Vy
Y2UvV2ViS2l0L2JsYWNrYmVycnkvQ2hhbmdlTG9nCmluZGV4IDVjZGU5OGQuLmY5MWZkNGEgMTAw
NjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFuZ2VMb2cKKysrIGIvU291cmNl
L1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEyLTA2LTE5
ICBZb25nIExpICA8eW9saUByaW0uY29tPgorCisgICAgICAgIFtCbGFja0JlcnJ5XSBTaG91bGQg
Y2hlY2sgdGhlIHJldHVybiB2YWx1ZSBvZiBmcm9tVVRGOCgpIGJlZm9yZSBleGVjdXRpbmcgdGhl
IHNjcmlwdC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk
PTg5NTAwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgUm9iIEJ1aXMuCisgICAgICAgIFBSIyAxNjY2
MjMuCisKKyAgICAgICAgV2ViUGFnZVByaXZhdGU6OmV4ZWN1dGVKYXZhU2NyaXB0KCkgc2hvdWxk
IGNoZWNrIHRoZSByZXR1cm4gdmFsdWUgb2YgZnJvbVVURjgoKQorICAgICAgICBiZWZvcmUgZXhl
Y3V0aW5nIHRoZSBzY3JpcHQgdG8gYXZvaWQgcG90ZW50aWFsIGNyYXNoIG9uIGludmFsaWQgc2Ny
aXB0IHNvdXJjZS4KKworICAgICAgICAqIEFwaS9XZWJQYWdlLmNwcDoKKyAgICAgICAgKEJsYWNr
QmVycnk6OldlYktpdDo6V2ViUGFnZVByaXZhdGU6OmV4ZWN1dGVKYXZhU2NyaXB0KToKKwogMjAx
Mi0wNi0xOSAgU2VyZ2lvIFZpbGxhciBTZW5pbiAgPHN2aWxsYXJAaWdhbGlhLmNvbT4KIAogICAg
ICAgICBDYWxsaW5nIG5hdGl2ZUltYWdlRm9yQ3VycmVudEZyYW1lKCkgY2F1c2VzIGFzc2VydGlv
biBmYWlsdXJlOiBtX3ZlcmlmaWVyLmlzU2FmZVRvVXNlKCkK
</data>

          </attachment>
      

    </bug>

</bugzilla>