89497 2012-06-19 12:21:31 -0700 webkitpy: Simplify fetch_bugs_matching_search() 2012-06-19 18:31:48 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 tmpsantos tmpsantos abarth dpranke ojan webkit.review.bot oldest_to_newest 652680 0 tmpsantos 2012-06-19 12:21:31 -0700 The author_email parameter is being used wrongly: urllib.quote(search_string) instead of urllib.quote(author_email). But I realized that it is only working because the parameter is not being used at all. 652683 1 148390 tmpsantos 2012-06-19 12:26:26 -0700 Created attachment 148390 Patch 653052 2 148390 abarth 2012-06-19 17:51:10 -0700 Comment on attachment 148390 Patch Do you need to update an test-webkitpy tests? 653073 3 148390 webkit.review.bot 2012-06-19 18:31:43 -0700 Comment on attachment 148390 Patch Clearing flags on attachment: 148390 Committed r120785: <http://trac.webkit.org/changeset/120785> 653074 4 webkit.review.bot 2012-06-19 18:31:48 -0700 All reviewed patches have been landed. Closing bug. 148390 2012-06-19 12:26:26 -0700 2012-06-19 18:31:43 -0700 Patch bug-89497-20120619222625.patch text/plain 2965 tmpsantos U3VidmVyc2lvbiBSZXZpc2lvbjogMTIwNzI4CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggOWJiOWUxMWE0YjhmOGNjZmE2NGY1YmU3MmM3NGYxYzhl Y2MyOWMxMS4uMTVhM2NjNzUwY2U0MzE4MTA1MDU5MDdhOTk1NTY5NzAyMjUxZjZmMiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIw IEBACiAyMDEyLTA2LTE5ICBUaGlhZ28gTWFyY29zIFAuIFNhbnRvcyAgPHRoaWFnby5zYW50b3NA aW50ZWwuY29tPgogCisgICAgICAgIHdlYmtpdHB5OiBTaW1wbGlmeSBmZXRjaF9idWdzX21hdGNo aW5nX3NlYXJjaCgpCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD04OTQ5NworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIFJlbW92ZWQgcGFyYW1ldGVyIHdpdGggZGVmYXVsdCB2YWx1ZS4gSXQncyBub3QgYmVpbmcg dXNlZAorICAgICAgICBhbmQgdGhlIGhhbmRsaW5nIG9mIHRoZSBwYXJhbWV0ZXIgd2FzIHdyb25n LiBTYXZlcyBhIGNoZWNrLgorCisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS9jb21tb24vbmV0 L2J1Z3ppbGxhL2J1Z3ppbGxhLnB5OgorICAgICAgICAoQnVnemlsbGFRdWVyaWVzLmZldGNoX2J1 Z3NfbWF0Y2hpbmdfc2VhcmNoKToKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9u ZXQvYnVnemlsbGEvYnVnemlsbGFfbW9jay5weToKKyAgICAgICAgKE1vY2tCdWd6aWxsYVF1ZXJp ZXMuZmV0Y2hfYnVnc19tYXRjaGluZ19zZWFyY2gpOgorCisyMDEyLTA2LTE5ICBUaGlhZ28gTWFy Y29zIFAuIFNhbnRvcyAgPHRoaWFnby5zYW50b3NAaW50ZWwuY29tPgorCiAgICAgICAgIHdlYmtp dHB5OiBNYWtlIHdlYmtpdC1wYXRjaCBwYXRjaGVzLXRvLXJldmlldyB1c2VmdWwKICAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTg5NDcwCiAKZGlmZiAtLWdp dCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL25ldC9idWd6aWxsYS9idWd6aWxsYS5w eSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL25ldC9idWd6aWxsYS9idWd6aWxsYS5w eQppbmRleCBlMzRhNTMwYTA4NjUyNTVmNGY2OGRiNTIwODg2ZDNmOTQ1MzlmMTVmLi5lNDgyOTNi ODk5ZWVhOWIwYjgxYWFmMWFmOWM4MzAxYjdlOWM3OTM1IDEwMDY0NAotLS0gYS9Ub29scy9TY3Jp cHRzL3dlYmtpdHB5L2NvbW1vbi9uZXQvYnVnemlsbGEvYnVnemlsbGEucHkKKysrIGIvVG9vbHMv U2NyaXB0cy93ZWJraXRweS9jb21tb24vbmV0L2J1Z3ppbGxhL2J1Z3ppbGxhLnB5CkBAIC0yMDks MTIgKzIwOSwxMCBAQCBjbGFzcyBCdWd6aWxsYVF1ZXJpZXMob2JqZWN0KToKIAogICAgICMgQ3Vy cmVudGx5IHRoaXMgcmV0dXJucyBhbGwgYnVncyBhY3Jvc3MgYWxsIGNvbXBvbmVudHMuCiAgICAg IyBJbiB0aGUgZnV0dXJlIHdlIG1heSB3aXNoIHRvIGV4dGVuZCB0aGlzIEFQSSB0byBjb25zdHJ1 Y3QgbW9yZSByZXN0cmljdGVkIHNlYXJjaGVzLgotICAgIGRlZiBmZXRjaF9idWdzX21hdGNoaW5n X3NlYXJjaChzZWxmLCBzZWFyY2hfc3RyaW5nLCBhdXRob3JfZW1haWw9Tm9uZSk6CisgICAgZGVm IGZldGNoX2J1Z3NfbWF0Y2hpbmdfc2VhcmNoKHNlbGYsIHNlYXJjaF9zdHJpbmcpOgogICAgICAg ICBxdWVyeSA9ICJidWdsaXN0LmNnaT9xdWVyeV9mb3JtYXQ9YWR2YW5jZWQiCiAgICAgICAgIGlm IHNlYXJjaF9zdHJpbmc6CiAgICAgICAgICAgICBxdWVyeSArPSAiJnNob3J0X2Rlc2NfdHlwZT1h bGx3b3Jkc3N1YnN0ciZzaG9ydF9kZXNjPSVzIiAlIHVybGxpYi5xdW90ZShzZWFyY2hfc3RyaW5n KQotICAgICAgICBpZiBhdXRob3JfZW1haWw6Ci0gICAgICAgICAgICBxdWVyeSArPSAiJmVtYWls cmVwb3J0ZXIxPTEmZW1haWx0eXBlMT1zdWJzdHJpbmcmZW1haWwxPSVzIiAlIHVybGxpYi5xdW90 ZShzZWFyY2hfc3RyaW5nKQogICAgICAgICByZXR1cm4gc2VsZi5fZmV0Y2hfYnVnc19mcm9tX2Fk dmFuY2VkX3F1ZXJ5KHF1ZXJ5KQogCiAgICAgZGVmIGZldGNoX3BhdGNoZXNfZnJvbV9wZW5kaW5n X2NvbW1pdF9saXN0KHNlbGYpOgpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9j b21tb24vbmV0L2J1Z3ppbGxhL2J1Z3ppbGxhX21vY2sucHkgYi9Ub29scy9TY3JpcHRzL3dlYmtp dHB5L2NvbW1vbi9uZXQvYnVnemlsbGEvYnVnemlsbGFfbW9jay5weQppbmRleCA5NjU1YjAxZmE4 N2U4MzQ4ZjIyNDFjYjI1OWI2NDU1NzcxMDJlNzM2Li5jZDEyYzgwMzNlNDAzMGJmMzk1NzlkZmYw YjdlYjk3YjM2Mzk0ODY5IDEwMDY0NAotLS0gYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1v bi9uZXQvYnVnemlsbGEvYnVnemlsbGFfbW9jay5weQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtp dHB5L2NvbW1vbi9uZXQvYnVnemlsbGEvYnVnemlsbGFfbW9jay5weQpAQCAtMjc5LDcgKzI3OSw3 IEBAIGNsYXNzIE1vY2tCdWd6aWxsYVF1ZXJpZXMob2JqZWN0KToKICAgICBkZWYgZmV0Y2hfcGF0 Y2hlc19mcm9tX3BlbmRpbmdfY29tbWl0X2xpc3Qoc2VsZik6CiAgICAgICAgIHJldHVybiBzdW0o W2J1Zy5yZXZpZXdlZF9wYXRjaGVzKCkgZm9yIGJ1ZyBpbiBzZWxmLl9hbGxfYnVncygpXSwgW10p CiAKLSAgICBkZWYgZmV0Y2hfYnVnc19tYXRjaGluZ19zZWFyY2goc2VsZiwgc2VhcmNoX3N0cmlu ZywgYXV0aG9yX2VtYWlsPU5vbmUpOgorICAgIGRlZiBmZXRjaF9idWdzX21hdGNoaW5nX3NlYXJj aChzZWxmLCBzZWFyY2hfc3RyaW5nKToKICAgICAgICAgcmV0dXJuIFtzZWxmLl9idWd6aWxsYS5m ZXRjaF9idWcoNTAwMDQpLCBzZWxmLl9idWd6aWxsYS5mZXRjaF9idWcoNTAwMDMpXQogCiAgICAg ZGVmIGZldGNoX2J1Z3NfbWF0Y2hpbmdfcXVpY2tzZWFyY2goc2VsZiwgc2VhcmNoX3N0cmluZyk6 Cg==