89491 2012-06-19 11:41:02 -0700 ThreadingWin: Silence GCC compiler warnings 2012-06-28 12:15:51 -0700 1 1 1 Unclassified WebKit Web Template Framework 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 kalevlember webkit-unassigned aroben eric hausmann webkit.review.bot oldest_to_newest 652650 0 kalevlember 2012-06-19 11:41:02 -0700 ThreadingWin.cpp: In member function 'bool WTF::PlatformCondition::timedWait(WTF::PlatformMutex&, DWORD)': ThreadingWin.cpp:346:11: warning: variable 'res' set but not used [-Wunused-but-set-variable] ThreadingWin.cpp: In member function 'void WTF::PlatformCondition::signal(bool)': ThreadingWin.cpp:395:11: warning: variable 'res' set but not used [-Wunused-but-set-variable] ThreadingWin.cpp: In function 'WTF::ThreadIdentifier WTF::createThreadInternal(WTF::ThreadFunction, void*, const char*)': ThreadingWin.cpp:247:25: warning: ignoring return value of 'WTF::OwnPtr<T>::ValueType* WTF::OwnPtr<T>::leakPtr() [with T = WTF::ThreadFunctionInvocation; WTF::OwnPtr<T>::PtrType = WTF::ThreadFunctionInvocation*; WTF::OwnPtr<T>::ValueType = WTF::ThreadFunctionInvocation]', declared with attribute warn_unused_result [-Wunused-result] 652655 1 148378 kalevlember 2012-06-19 11:43:44 -0700 Created attachment 148378 Patch 659621 2 kalevlember 2012-06-28 11:00:56 -0700 Adding a few people to CC who have reviewed Windows threading patches before. The patch should be just a trivial warning cleanup. 659680 3 148378 webkit.review.bot 2012-06-28 12:15:46 -0700 Comment on attachment 148378 Patch Clearing flags on attachment: 148378 Committed r121448: <http://trac.webkit.org/changeset/121448> 659681 4 webkit.review.bot 2012-06-28 12:15:51 -0700 All reviewed patches have been landed. Closing bug. 148378 2012-06-19 11:43:44 -0700 2012-06-28 12:15:46 -0700 Patch 0001-ThreadingWin-Silence-GCC-compiler-warnings.patch text/plain 5680 kalevlember RnJvbSBmM2QxZTIwOTllZWNhNzgwYjljYWQ4YTAxZGJjZTE1MjNiYjhmZmNmIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBLYWxldiBMZW1iZXIgPGthbGV2bGVtYmVyQGdtYWlsLmNvbT4K RGF0ZTogVHVlLCAxOSBKdW4gMjAxMiAxNzoyOTo1OSArMDMwMApTdWJqZWN0OiBbUEFUQ0hdIFRo cmVhZGluZ1dpbjogU2lsZW5jZSBHQ0MgY29tcGlsZXIgd2FybmluZ3MKClRocmVhZGluZ1dpbi5j cHA6IEluIG1lbWJlciBmdW5jdGlvbiAnYm9vbCBXVEY6OlBsYXRmb3JtQ29uZGl0aW9uOjp0aW1l ZFdhaXQoV1RGOjpQbGF0Zm9ybU11dGV4JiwgRFdPUkQpJzoKVGhyZWFkaW5nV2luLmNwcDozNDY6 MTE6IHdhcm5pbmc6IHZhcmlhYmxlICdyZXMnIHNldCBidXQgbm90IHVzZWQgWy1XdW51c2VkLWJ1 dC1zZXQtdmFyaWFibGVdClRocmVhZGluZ1dpbi5jcHA6IEluIG1lbWJlciBmdW5jdGlvbiAndm9p ZCBXVEY6OlBsYXRmb3JtQ29uZGl0aW9uOjpzaWduYWwoYm9vbCknOgpUaHJlYWRpbmdXaW4uY3Bw OjM5NToxMTogd2FybmluZzogdmFyaWFibGUgJ3Jlcycgc2V0IGJ1dCBub3QgdXNlZCBbLVd1bnVz ZWQtYnV0LXNldC12YXJpYWJsZV0KClRocmVhZGluZ1dpbi5jcHA6IEluIGZ1bmN0aW9uICdXVEY6 OlRocmVhZElkZW50aWZpZXIgV1RGOjpjcmVhdGVUaHJlYWRJbnRlcm5hbChXVEY6OlRocmVhZEZ1 bmN0aW9uLCB2b2lkKiwgY29uc3QgY2hhciopJzoKVGhyZWFkaW5nV2luLmNwcDoyNDc6MjU6IHdh cm5pbmc6IGlnbm9yaW5nIHJldHVybiB2YWx1ZSBvZiAnV1RGOjpPd25QdHI8VD46OlZhbHVlVHlw ZSogV1RGOjpPd25QdHI8VD46OmxlYWtQdHIoKSBbd2l0aCBUID0gV1RGOjpUaHJlYWRGdW5jdGlv bkludm9jYXRpb247IFdURjo6T3duUHRyPFQ+OjpQdHJUeXBlID0gV1RGOjpUaHJlYWRGdW5jdGlv bkludm9jYXRpb24qOyBXVEY6Ok93blB0cjxUPjo6VmFsdWVUeXBlID0gV1RGOjpUaHJlYWRGdW5j dGlvbkludm9jYXRpb25dJywgZGVjbGFyZWQgd2l0aCBhdHRyaWJ1dGUgd2Fybl91bnVzZWRfcmVz dWx0IFstV3VudXNlZC1yZXN1bHRdCi0tLQogU291cmNlL1dURi9DaGFuZ2VMb2cgICAgICAgICAg ICB8ICAgMTMgKysrKysrKysrKysrKwogU291cmNlL1dURi93dGYvVGhyZWFkaW5nV2luLmNwcCB8 ICAgMjkgKysrKysrKysrKysrKysrLS0tLS0tLS0tLS0tLS0KIDIgZmlsZXMgY2hhbmdlZCwgMjgg aW5zZXJ0aW9ucygrKSwgMTQgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvU291cmNlL1dURi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV1RGL0NoYW5nZUxvZwppbmRleCA2YTA2ZTg5Li41ZDcyNTBhIDEw MDY0NAotLS0gYS9Tb3VyY2UvV1RGL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV1RGL0NoYW5nZUxv ZwpAQCAtMSwzICsxLDE2IEBACisyMDEyLTA2LTE5ICBLYWxldiBMZW1iZXIgIDxrYWxldmxlbWJl ckBnbWFpbC5jb20+CisKKyAgICAgICAgVGhyZWFkaW5nV2luOiBTaWxlbmNlIEdDQyBjb21waWxl ciB3YXJuaW5ncworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9ODk0OTEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICAqIHd0Zi9UaHJlYWRpbmdXaW4uY3BwOgorICAgICAgICAoV1RGOjpjcmVhdGVUaHJlYWRJbnRl cm5hbCk6CisgICAgICAgIChXVEY6OlBsYXRmb3JtQ29uZGl0aW9uOjp0aW1lZFdhaXQpOgorICAg ICAgICAoV1RGOjpQbGF0Zm9ybUNvbmRpdGlvbjo6c2lnbmFsKTogRml4IHVudXNlZC1idXQtc2V0 LXZhcmlhYmxlCisgICAgICAgIHdhcm5pbmdzLgorCiAyMDEyLTA2LTE5ICBKb24gSG9uZXljdXR0 ICA8amhvbmV5Y3V0dEBhcHBsZS5jb20+CiAKICAgICAgICAgUkVHUkVTU0lPTihyMTIwNTUyKTog TWFueSB0ZXN0cyB0aW1pbmcgb3V0IG9uIFdpbmRvd3MKZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYv d3RmL1RocmVhZGluZ1dpbi5jcHAgYi9Tb3VyY2UvV1RGL3d0Zi9UaHJlYWRpbmdXaW4uY3BwCmlu ZGV4IDQ0NDQ4MjcuLmQzMzk3M2QgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvd3RmL1RocmVhZGlu Z1dpbi5jcHAKKysrIGIvU291cmNlL1dURi93dGYvVGhyZWFkaW5nV2luLmNwcApAQCAtMjQ0LDcg KzI0NCw4IEBAIFRocmVhZElkZW50aWZpZXIgY3JlYXRlVGhyZWFkSW50ZXJuYWwoVGhyZWFkRnVu Y3Rpb24gZW50cnlQb2ludCwgdm9pZCogZGF0YSwgY29uCiAgICAgfQogCiAgICAgLy8gVGhlIHRo cmVhZCB3aWxsIHRha2Ugb3duZXJzaGlwIG9mIGludm9jYXRpb24uCi0gICAgaW52b2NhdGlvbi5s ZWFrUHRyKCk7CisgICAgVGhyZWFkRnVuY3Rpb25JbnZvY2F0aW9uKiBsZWFrZWRJbnZvY2F0aW9u ID0gaW52b2NhdGlvbi5sZWFrUHRyKCk7CisgICAgVU5VU0VEX1BBUkFNKGxlYWtlZEludm9jYXRp b24pOwogCiAgICAgdGhyZWFkSUQgPSBzdGF0aWNfY2FzdDxUaHJlYWRJZGVudGlmaWVyPih0aHJl YWRJZGVudGlmaWVyKTsKICAgICBzdG9yZVRocmVhZEhhbmRsZUJ5SWRlbnRpZmllcih0aHJlYWRJ ZGVudGlmaWVyLCB0aHJlYWRIYW5kbGUpOwpAQCAtMzQ0LDEwICszNDUsMTAgQEAgYm9vbCBQbGF0 Zm9ybUNvbmRpdGlvbjo6dGltZWRXYWl0KFBsYXRmb3JtTXV0ZXgmIG11dGV4LCBEV09SRCBkdXJh dGlvbk1pbGxpc2Vjb24KIHsKICAgICAvLyBFbnRlciB0aGUgd2FpdCBzdGF0ZS4KICAgICBEV09S RCByZXMgPSBXYWl0Rm9yU2luZ2xlT2JqZWN0KG1fYmxvY2tMb2NrLCBJTkZJTklURSk7Ci0gICAg QVNTRVJUKHJlcyA9PSBXQUlUX09CSkVDVF8wKTsKKyAgICBBU1NFUlRfVU5VU0VEKHJlcywgcmVz ID09IFdBSVRfT0JKRUNUXzApOwogICAgICsrbV93YWl0ZXJzQmxvY2tlZDsKICAgICByZXMgPSBS ZWxlYXNlU2VtYXBob3JlKG1fYmxvY2tMb2NrLCAxLCAwKTsKLSAgICBBU1NFUlQocmVzKTsKKyAg ICBBU1NFUlRfVU5VU0VEKHJlcywgcmVzKTsKIAogICAgIC0tbXV0ZXgubV9yZWN1cnNpb25Db3Vu dDsKICAgICBMZWF2ZUNyaXRpY2FsU2VjdGlvbigmbXV0ZXgubV9pbnRlcm5hbE11dGV4KTsKQEAg LTM1Niw3ICszNTcsNyBAQCBib29sIFBsYXRmb3JtQ29uZGl0aW9uOjp0aW1lZFdhaXQoUGxhdGZv cm1NdXRleCYgbXV0ZXgsIERXT1JEIGR1cmF0aW9uTWlsbGlzZWNvbgogICAgIGJvb2wgdGltZWRP dXQgPSAoV2FpdEZvclNpbmdsZU9iamVjdChtX2Jsb2NrUXVldWUsIGR1cmF0aW9uTWlsbGlzZWNv bmRzKSA9PSBXQUlUX1RJTUVPVVQpOwogCiAgICAgcmVzID0gV2FpdEZvclNpbmdsZU9iamVjdCht X3VuYmxvY2tMb2NrLCBJTkZJTklURSk7Ci0gICAgQVNTRVJUKHJlcyA9PSBXQUlUX09CSkVDVF8w KTsKKyAgICBBU1NFUlRfVU5VU0VEKHJlcywgcmVzID09IFdBSVRfT0JKRUNUXzApOwogCiAgICAg aW50IHNpZ25hbHNMZWZ0ID0gbV93YWl0ZXJzVG9VbmJsb2NrOwogCkBAIC0zNjcsMTkgKzM2OCwx OSBAQCBib29sIFBsYXRmb3JtQ29uZGl0aW9uOjp0aW1lZFdhaXQoUGxhdGZvcm1NdXRleCYgbXV0 ZXgsIERXT1JEIGR1cmF0aW9uTWlsbGlzZWNvbgogICAgICAgICAvLyB0aGlzIG1heSBvY2N1ciBp ZiBtYW55IGNhbGxzIHRvIHdhaXQgd2l0aCBhIHRpbWVvdXQgYXJlIG1hZGUgYW5kCiAgICAgICAg IC8vIG5vIGNhbGwgdG8gbm90aWZ5XyogaXMgbWFkZQogICAgICAgICByZXMgPSBXYWl0Rm9yU2lu Z2xlT2JqZWN0KG1fYmxvY2tMb2NrLCBJTkZJTklURSk7Ci0gICAgICAgIEFTU0VSVChyZXMgPT0g V0FJVF9PQkpFQ1RfMCk7CisgICAgICAgIEFTU0VSVF9VTlVTRUQocmVzLCByZXMgPT0gV0FJVF9P QkpFQ1RfMCk7CiAgICAgICAgIG1fd2FpdGVyc0Jsb2NrZWQgLT0gbV93YWl0ZXJzR29uZTsKICAg ICAgICAgcmVzID0gUmVsZWFzZVNlbWFwaG9yZShtX2Jsb2NrTG9jaywgMSwgMCk7Ci0gICAgICAg IEFTU0VSVChyZXMpOworICAgICAgICBBU1NFUlRfVU5VU0VEKHJlcywgcmVzKTsKICAgICAgICAg bV93YWl0ZXJzR29uZSA9IDA7CiAgICAgfQogCiAgICAgcmVzID0gUmVsZWFzZU11dGV4KG1fdW5i bG9ja0xvY2spOwotICAgIEFTU0VSVChyZXMpOworICAgIEFTU0VSVF9VTlVTRUQocmVzLCByZXMp OwogCiAgICAgaWYgKHNpZ25hbHNMZWZ0ID09IDEpIHsKICAgICAgICAgcmVzID0gUmVsZWFzZVNl bWFwaG9yZShtX2Jsb2NrTG9jaywgMSwgMCk7IC8vIE9wZW4gdGhlIGdhdGUuCi0gICAgICAgIEFT U0VSVChyZXMpOworICAgICAgICBBU1NFUlRfVU5VU0VEKHJlcywgcmVzKTsKICAgICB9CiAKICAg ICBFbnRlckNyaXRpY2FsU2VjdGlvbiAoJm11dGV4Lm1faW50ZXJuYWxNdXRleCk7CkBAIC0zOTMs MTIgKzM5NCwxMiBAQCB2b2lkIFBsYXRmb3JtQ29uZGl0aW9uOjpzaWduYWwoYm9vbCB1bmJsb2Nr QWxsKQogICAgIHVuc2lnbmVkIHNpZ25hbHNUb0lzc3VlID0gMDsKIAogICAgIERXT1JEIHJlcyA9 IFdhaXRGb3JTaW5nbGVPYmplY3QobV91bmJsb2NrTG9jaywgSU5GSU5JVEUpOwotICAgIEFTU0VS VChyZXMgPT0gV0FJVF9PQkpFQ1RfMCk7CisgICAgQVNTRVJUX1VOVVNFRChyZXMsIHJlcyA9PSBX QUlUX09CSkVDVF8wKTsKIAogICAgIGlmIChtX3dhaXRlcnNUb1VuYmxvY2spIHsgLy8gdGhlIGdh dGUgaXMgYWxyZWFkeSBjbG9zZWQKICAgICAgICAgaWYgKCFtX3dhaXRlcnNCbG9ja2VkKSB7IC8v IG5vLW9wCiAgICAgICAgICAgICByZXMgPSBSZWxlYXNlTXV0ZXgobV91bmJsb2NrTG9jayk7Ci0g ICAgICAgICAgICBBU1NFUlQocmVzKTsKKyAgICAgICAgICAgIEFTU0VSVF9VTlVTRUQocmVzLCBy ZXMpOwogICAgICAgICAgICAgcmV0dXJuOwogICAgICAgICB9CiAKQEAgLTQxMyw3ICs0MTQsNyBA QCB2b2lkIFBsYXRmb3JtQ29uZGl0aW9uOjpzaWduYWwoYm9vbCB1bmJsb2NrQWxsKQogICAgICAg ICB9CiAgICAgfSBlbHNlIGlmIChtX3dhaXRlcnNCbG9ja2VkID4gbV93YWl0ZXJzR29uZSkgewog ICAgICAgICByZXMgPSBXYWl0Rm9yU2luZ2xlT2JqZWN0KG1fYmxvY2tMb2NrLCBJTkZJTklURSk7 IC8vIENsb3NlIHRoZSBnYXRlLgotICAgICAgICBBU1NFUlQocmVzID09IFdBSVRfT0JKRUNUXzAp OworICAgICAgICBBU1NFUlRfVU5VU0VEKHJlcywgcmVzID09IFdBSVRfT0JKRUNUXzApOwogICAg ICAgICBpZiAobV93YWl0ZXJzR29uZSAhPSAwKSB7CiAgICAgICAgICAgICBtX3dhaXRlcnNCbG9j a2VkIC09IG1fd2FpdGVyc0dvbmU7CiAgICAgICAgICAgICBtX3dhaXRlcnNHb25lID0gMDsKQEAg LTQyOSwxNiArNDMwLDE2IEBAIHZvaWQgUGxhdGZvcm1Db25kaXRpb246OnNpZ25hbChib29sIHVu YmxvY2tBbGwpCiAgICAgICAgIH0KICAgICB9IGVsc2UgeyAvLyBOby1vcC4KICAgICAgICAgcmVz ID0gUmVsZWFzZU11dGV4KG1fdW5ibG9ja0xvY2spOwotICAgICAgICBBU1NFUlQocmVzKTsKKyAg ICAgICAgQVNTRVJUX1VOVVNFRChyZXMsIHJlcyk7CiAgICAgICAgIHJldHVybjsKICAgICB9CiAK ICAgICByZXMgPSBSZWxlYXNlTXV0ZXgobV91bmJsb2NrTG9jayk7Ci0gICAgQVNTRVJUKHJlcyk7 CisgICAgQVNTRVJUX1VOVVNFRChyZXMsIHJlcyk7CiAKICAgICBpZiAoc2lnbmFsc1RvSXNzdWUp IHsKICAgICAgICAgcmVzID0gUmVsZWFzZVNlbWFwaG9yZShtX2Jsb2NrUXVldWUsIHNpZ25hbHNU b0lzc3VlLCAwKTsKLSAgICAgICAgQVNTRVJUKHJlcyk7CisgICAgICAgIEFTU0VSVF9VTlVTRUQo cmVzLCByZXMpOwogICAgIH0KIH0KIAotLSAKMS43LjEwLjQKCg==