89490 2012-06-19 11:38:04 -0700 CodeBlock::needsCallReturnIndices() is no longer needed. 2012-06-19 14:06:28 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 mark.lam webkit-unassigned webkit.review.bot oldest_to_newest 652647 0 mark.lam 2012-06-19 11:38:04 -0700 CodeBlock::needsCallReturnIndices() now always returns true. We should remove it and clean up the code. 652662 1 148383 mark.lam 2012-06-19 11:48:51 -0700 Created attachment 148383 Fix 652675 2 148383 ggaren 2012-06-19 12:17:05 -0700 Comment on attachment 148383 Fix r=me 652786 3 148383 webkit.review.bot 2012-06-19 14:06:23 -0700 Comment on attachment 148383 Fix Clearing flags on attachment: 148383 Committed r120751: <http://trac.webkit.org/changeset/120751> 652787 4 webkit.review.bot 2012-06-19 14:06:28 -0700 All reviewed patches have been landed. Closing bug. 148383 2012-06-19 11:48:51 -0700 2012-06-19 14:06:23 -0700 Fix bug-89490.patch text/plain 4703 mark.lam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTIwNzQwKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBA CisyMDEyLTA2LTE5ICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICBD b2RlQmxvY2s6Om5lZWRzQ2FsbFJldHVybkluZGljZXMoKSBpcyBubyBsb25nZXIgbmVlZGVkLgor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODk0OTAKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGJ5dGVjb2Rl L0NvZGVCbG9jay5oOgorICAgICAgICAoSlNDOjpDb2RlQmxvY2s6Om5lZWRzQ2FsbFJldHVybklu ZGljZXMpOiByZW1vdmVkLgorICAgICAgICAqIGRmZy9ERkdKSVRDb21waWxlci5jcHA6CisgICAg ICAgIChKU0M6OkRGRzo6SklUQ29tcGlsZXI6OmxpbmspOgorICAgICAgICAqIGppdC9KSVQuY3Bw OgorICAgICAgICAoSlNDOjpKSVQ6OnByaXZhdGVDb21waWxlKToKKwogMjAxMi0wNi0xOSAgTWlr ZSBXZXN0ICA8bWt3c3RAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIEludHJvZHVjZSBFTkFCTEVf Q1NQX05FWFQgY29uZmlndXJhdGlvbiBmbGFnLgpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3Jl L2J5dGVjb2RlL0NvZGVCbG9jay5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29y ZS9ieXRlY29kZS9Db2RlQmxvY2suaAkocmV2aXNpb24gMTIwNzQwKQorKysgU291cmNlL0phdmFT Y3JpcHRDb3JlL2J5dGVjb2RlL0NvZGVCbG9jay5oCSh3b3JraW5nIGNvcHkpCkBAIC03MTksMTMg KzcxOSw2IEBAIG5hbWVzcGFjZSBKU0MgewogICAgICAgICB9CiAKICAgICAgICAgYm9vbCBoYXNF eHByZXNzaW9uSW5mbygpIHsgcmV0dXJuIG1fcmFyZURhdGEgJiYgbV9yYXJlRGF0YS0+bV9leHBy ZXNzaW9uSW5mby5zaXplKCk7IH0KLSAgICAgICAgLy8gIFdlIG9ubHkgZ2VuZXJhdGUgZXhjZXB0 aW9uIGhhbmRsaW5nIGluZm8gaWYgdGhlIHVzZXIgaXMgZGVidWdnaW5nCi0gICAgICAgIC8vIChh bmQgbWF5IHdhbnQgbGluZSBudW1iZXIgaW5mbyksIG9yIGlmIHRoZSBmdW5jdGlvbiBjb250YWlu cyBleGNlcHRpb24gaGFuZGxlci4KLSAgICAgICAgYm9vbCBuZWVkc0NhbGxSZXR1cm5JbmRpY2Vz KCkKLSAgICAgICAgewotICAgICAgICAgICAgcmV0dXJuIHRydWUgfHwgKG1fcmFyZURhdGEKLSAg ICAgICAgICAgICAgICAmJiAobV9yYXJlRGF0YS0+bV9leHByZXNzaW9uSW5mby5zaXplKCkgfHwg bV9yYXJlRGF0YS0+bV9leGNlcHRpb25IYW5kbGVycy5zaXplKCkpKTsKLSAgICAgICAgfQogCiAj aWYgRU5BQkxFKEpJVCkKICAgICAgICAgVmVjdG9yPENhbGxSZXR1cm5PZmZzZXRUb0J5dGVjb2Rl T2Zmc2V0PiYgY2FsbFJldHVybkluZGV4VmVjdG9yKCkKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0 Q29yZS9kZmcvREZHSklUQ29tcGlsZXIuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2Ny aXB0Q29yZS9kZmcvREZHSklUQ29tcGlsZXIuY3BwCShyZXZpc2lvbiAxMjA3NDApCisrKyBTb3Vy Y2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR0pJVENvbXBpbGVyLmNwcAkod29ya2luZyBjb3B5KQpA QCAtMTI4LDE2ICsxMjgsMTQgQEAgdm9pZCBKSVRDb21waWxlcjo6bGluayhMaW5rQnVmZmVyJiBs aW5rQgogICAgIGZvciAodW5zaWduZWQgaSA9IDA7IGkgPCBtX2NhbGxzLnNpemUoKTsgKytpKQog ICAgICAgICBsaW5rQnVmZmVyLmxpbmsobV9jYWxsc1tpXS5tX2NhbGwsIG1fY2FsbHNbaV0ubV9m dW5jdGlvbik7CiAKLSAgICBpZiAobV9jb2RlQmxvY2stPm5lZWRzQ2FsbFJldHVybkluZGljZXMo KSkgewotICAgICAgICBtX2NvZGVCbG9jay0+Y2FsbFJldHVybkluZGV4VmVjdG9yKCkucmVzZXJ2 ZUNhcGFjaXR5KG1fZXhjZXB0aW9uQ2hlY2tzLnNpemUoKSk7Ci0gICAgICAgIGZvciAodW5zaWdu ZWQgaSA9IDA7IGkgPCBtX2V4Y2VwdGlvbkNoZWNrcy5zaXplKCk7ICsraSkgewotICAgICAgICAg ICAgdW5zaWduZWQgcmV0dXJuQWRkcmVzc09mZnNldCA9IGxpbmtCdWZmZXIucmV0dXJuQWRkcmVz c09mZnNldChtX2V4Y2VwdGlvbkNoZWNrc1tpXS5tX2NhbGwpOwotICAgICAgICAgICAgQ29kZU9y aWdpbiBjb2RlT3JpZ2luID0gbV9leGNlcHRpb25DaGVja3NbaV0ubV9jb2RlT3JpZ2luOwotICAg ICAgICAgICAgd2hpbGUgKGNvZGVPcmlnaW4uaW5saW5lQ2FsbEZyYW1lKQotICAgICAgICAgICAg ICAgIGNvZGVPcmlnaW4gPSBjb2RlT3JpZ2luLmlubGluZUNhbGxGcmFtZS0+Y2FsbGVyOwotICAg ICAgICAgICAgdW5zaWduZWQgZXhjZXB0aW9uSW5mbyA9IGNvZGVPcmlnaW4uYnl0ZWNvZGVJbmRl eDsKLSAgICAgICAgICAgIG1fY29kZUJsb2NrLT5jYWxsUmV0dXJuSW5kZXhWZWN0b3IoKS5hcHBl bmQoQ2FsbFJldHVybk9mZnNldFRvQnl0ZWNvZGVPZmZzZXQocmV0dXJuQWRkcmVzc09mZnNldCwg ZXhjZXB0aW9uSW5mbykpOwotICAgICAgICB9CisgICAgbV9jb2RlQmxvY2stPmNhbGxSZXR1cm5J bmRleFZlY3RvcigpLnJlc2VydmVDYXBhY2l0eShtX2V4Y2VwdGlvbkNoZWNrcy5zaXplKCkpOwor ICAgIGZvciAodW5zaWduZWQgaSA9IDA7IGkgPCBtX2V4Y2VwdGlvbkNoZWNrcy5zaXplKCk7ICsr aSkgeworICAgICAgICB1bnNpZ25lZCByZXR1cm5BZGRyZXNzT2Zmc2V0ID0gbGlua0J1ZmZlci5y ZXR1cm5BZGRyZXNzT2Zmc2V0KG1fZXhjZXB0aW9uQ2hlY2tzW2ldLm1fY2FsbCk7CisgICAgICAg IENvZGVPcmlnaW4gY29kZU9yaWdpbiA9IG1fZXhjZXB0aW9uQ2hlY2tzW2ldLm1fY29kZU9yaWdp bjsKKyAgICAgICAgd2hpbGUgKGNvZGVPcmlnaW4uaW5saW5lQ2FsbEZyYW1lKQorICAgICAgICAg ICAgY29kZU9yaWdpbiA9IGNvZGVPcmlnaW4uaW5saW5lQ2FsbEZyYW1lLT5jYWxsZXI7CisgICAg ICAgIHVuc2lnbmVkIGV4Y2VwdGlvbkluZm8gPSBjb2RlT3JpZ2luLmJ5dGVjb2RlSW5kZXg7Cisg ICAgICAgIG1fY29kZUJsb2NrLT5jYWxsUmV0dXJuSW5kZXhWZWN0b3IoKS5hcHBlbmQoQ2FsbFJl dHVybk9mZnNldFRvQnl0ZWNvZGVPZmZzZXQocmV0dXJuQWRkcmVzc09mZnNldCwgZXhjZXB0aW9u SW5mbykpOwogICAgIH0KIAogICAgIFZlY3RvcjxDb2RlT3JpZ2luQXRDYWxsUmV0dXJuT2Zmc2V0 PiYgY29kZU9yaWdpbnMgPSBtX2NvZGVCbG9jay0+Y29kZU9yaWdpbnMoKTsKSW5kZXg6IFNvdXJj ZS9KYXZhU2NyaXB0Q29yZS9qaXQvSklULmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNj cmlwdENvcmUvaml0L0pJVC5jcHAJKHJldmlzaW9uIDEyMDc0MCkKKysrIFNvdXJjZS9KYXZhU2Ny aXB0Q29yZS9qaXQvSklULmNwcAkod29ya2luZyBjb3B5KQpAQCAtNzE4LDExICs3MTgsOSBAQCBK SVRDb2RlIEpJVDo6cHJpdmF0ZUNvbXBpbGUoQ29kZVB0ciogZnVuCiAgICAgICAgICAgICBwYXRj aEJ1ZmZlci5saW5rKGl0ZXItPmZyb20sIEZ1bmN0aW9uUHRyKGl0ZXItPnRvKSk7CiAgICAgfQog Ci0gICAgaWYgKG1fY29kZUJsb2NrLT5uZWVkc0NhbGxSZXR1cm5JbmRpY2VzKCkpIHsKLSAgICAg ICAgbV9jb2RlQmxvY2stPmNhbGxSZXR1cm5JbmRleFZlY3RvcigpLnJlc2VydmVDYXBhY2l0eSht X2NhbGxzLnNpemUoKSk7Ci0gICAgICAgIGZvciAoVmVjdG9yPENhbGxSZWNvcmQ+OjppdGVyYXRv ciBpdGVyID0gbV9jYWxscy5iZWdpbigpOyBpdGVyICE9IG1fY2FsbHMuZW5kKCk7ICsraXRlcikK LSAgICAgICAgICAgIG1fY29kZUJsb2NrLT5jYWxsUmV0dXJuSW5kZXhWZWN0b3IoKS5hcHBlbmQo Q2FsbFJldHVybk9mZnNldFRvQnl0ZWNvZGVPZmZzZXQocGF0Y2hCdWZmZXIucmV0dXJuQWRkcmVz c09mZnNldChpdGVyLT5mcm9tKSwgaXRlci0+Ynl0ZWNvZGVPZmZzZXQpKTsKLSAgICB9CisgICAg bV9jb2RlQmxvY2stPmNhbGxSZXR1cm5JbmRleFZlY3RvcigpLnJlc2VydmVDYXBhY2l0eShtX2Nh bGxzLnNpemUoKSk7CisgICAgZm9yIChWZWN0b3I8Q2FsbFJlY29yZD46Oml0ZXJhdG9yIGl0ZXIg PSBtX2NhbGxzLmJlZ2luKCk7IGl0ZXIgIT0gbV9jYWxscy5lbmQoKTsgKytpdGVyKQorICAgICAg ICBtX2NvZGVCbG9jay0+Y2FsbFJldHVybkluZGV4VmVjdG9yKCkuYXBwZW5kKENhbGxSZXR1cm5P ZmZzZXRUb0J5dGVjb2RlT2Zmc2V0KHBhdGNoQnVmZmVyLnJldHVybkFkZHJlc3NPZmZzZXQoaXRl ci0+ZnJvbSksIGl0ZXItPmJ5dGVjb2RlT2Zmc2V0KSk7CiAKICAgICBtX2NvZGVCbG9jay0+c2V0 TnVtYmVyT2ZTdHJ1Y3R1cmVTdHViSW5mb3MobV9wcm9wZXJ0eUFjY2Vzc0NvbXBpbGF0aW9uSW5m by5zaXplKCkpOwogICAgIGZvciAodW5zaWduZWQgaSA9IDA7IGkgPCBtX3Byb3BlcnR5QWNjZXNz Q29tcGlsYXRpb25JbmZvLnNpemUoKTsgKytpKQo=