89489 2012-06-19 11:36:34 -0700 Account for device scale factor when creating image for dragging. 2012-06-20 15:49:33 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 varunjain varunjain abarth bdakin simon.fraser webkit.review.bot oldest_to_newest 652645 0 varunjain 2012-06-19 11:36:34 -0700 Account for device scale factor when creating image for dragging. 652649 1 148376 varunjain 2012-06-19 11:39:39 -0700 Created attachment 148376 Patch 652907 2 148376 abarth 2012-06-19 15:53:26 -0700 Comment on attachment 148376 Patch I've asked varunjain to add a ManualTest for this bug. 652947 3 148455 varunjain 2012-06-19 16:29:21 -0700 Created attachment 148455 Patch 652948 4 varunjain 2012-06-19 16:29:56 -0700 (In reply to comment #2) > (From update of attachment 148376 [details]) > I've asked varunjain to add a ManualTest for this bug. Added ManualTest. PTAL. 653680 5 bdakin 2012-06-20 11:22:45 -0700 Can you please provide reproducible steps for this bug? I don't see any problems with drag images using Safari on a Retina MacBook Pro. 653685 6 bdakin 2012-06-20 11:26:48 -0700 Oh, I see. Looks like we fixed this in Mac-only code: https://bugs.webkit.org/show_bug.cgi?id=67779 653686 7 bdakin 2012-06-20 11:27:31 -0700 Also: https://bugs.webkit.org/show_bug.cgi?id=67802 653792 8 abarth 2012-06-20 12:52:34 -0700 Beth, will this patch cause a problem for the apple-mac port? If so, should we move the conversion from apple-mac specific code to cross-platform code? 653818 9 bdakin 2012-06-20 13:11:40 -0700 No, this should not cause any problems for Apple Mac. It looks like all of the functions that are patched here are inside this ifdef: #if !PLATFORM(MAC) && !PLATFORM(WIN) So we're all set. I think this is a fine way to go. 653867 10 abarth 2012-06-20 14:06:02 -0700 Beth, do you agree? 653912 11 abarth 2012-06-20 14:52:32 -0700 I fail at reading. Sorry for the noise. 653953 12 148455 webkit.review.bot 2012-06-20 15:49:27 -0700 Comment on attachment 148455 Patch Clearing flags on attachment: 148455 Committed r120876: <http://trac.webkit.org/changeset/120876> 653954 13 webkit.review.bot 2012-06-20 15:49:33 -0700 All reviewed patches have been landed. Closing bug. 148376 2012-06-19 11:39:39 -0700 2012-06-19 16:29:18 -0700 Patch bug-89489-20120619143938.patch text/plain 2625 varunjain U3VidmVyc2lvbiBSZXZpc2lvbjogMTIwNzM2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZGIyYTcyMGUxMWQzMDY2 MDMyNWQwOGRiZDk1NzcxMTVlZmFmYWFiNy4uY2ZkOTU5NDU0NGE0OTdmYjU5MWFhMmJhNzdkNDFk NGM3YTUyNTIwNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEyLTA2LTE5ICBWYXJ1 biBKYWluICA8dmFydW5qYWluQGNocm9taXVtLm9yZz4KKworICAgICAgICBBY2NvdW50IGZvciBk ZXZpY2Ugc2NhbGUgZmFjdG9yIHdoZW4gY3JlYXRpbmcgaW1hZ2UgZm9yIGRyYWdnaW5nLgorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODk0ODkKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBNYW51YWxseSB0ZXN0 ZWQgYnkgbG9va2luZyBhdCB0aGUgZHJhZyBpbWFnZS4KKworICAgICAgICAqIHBhZ2UvRnJhbWUu Y3BwOgorICAgICAgICAoV2ViQ29yZTo6RnJhbWU6Om5vZGVJbWFnZSk6CisgICAgICAgIChXZWJD b3JlOjpGcmFtZTo6ZHJhZ0ltYWdlRm9yU2VsZWN0aW9uKToKKwogMjAxMi0wNi0xOSAgQW5kcmVh cyBLbGluZyAgPGtsaW5nQHdlYmtpdC5vcmc+CiAKICAgICAgICAgUmVtb3ZlIHRoZSAtd2Via2l0 LW1hdGNoLW5lYXJlc3QtbWFpbC1ibG9ja3F1b3RlLWNvbG9yIHByb3BlcnR5LgpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYkNvcmUvcGFnZS9GcmFtZS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL0Zy YW1lLmNwcAppbmRleCA5MWQzMWUzYmZkMTQ3YTg5MGY3NmE3MzkwMDBkM2IwMDI1MzRmOGI0Li5l YTU3YmI0ZjFkODUyY2YwMDUxMDlmMDE3MDg3YmVmNDBjMmI5OWE3IDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9wYWdlL0ZyYW1lLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL0ZyYW1l LmNwcApAQCAtMTA4OSw5ICsxMDg5LDE2IEBAIERyYWdJbWFnZVJlZiBGcmFtZTo6bm9kZUltYWdl KE5vZGUqIG5vZGUpCiAgICAgTGF5b3V0UmVjdCB0b3BMZXZlbFJlY3Q7CiAgICAgSW50UmVjdCBw YWludGluZ1JlY3QgPSBwaXhlbFNuYXBwZWRJbnRSZWN0KHJlbmRlcmVyLT5wYWludGluZ1Jvb3RS ZWN0KHRvcExldmVsUmVjdCkpOwogCisgICAgZmxvYXQgZGV2aWNlU2NhbGVGYWN0b3IgPSAxOwor ICAgIGlmIChtX3BhZ2UpCisgICAgICAgIGRldmljZVNjYWxlRmFjdG9yID0gbV9wYWdlLT5kZXZp Y2VTY2FsZUZhY3RvcigpOworICAgIHBhaW50aW5nUmVjdC5zZXRXaWR0aChwYWludGluZ1JlY3Qu d2lkdGgoKSAqIGRldmljZVNjYWxlRmFjdG9yKTsKKyAgICBwYWludGluZ1JlY3Quc2V0SGVpZ2h0 KHBhaW50aW5nUmVjdC5oZWlnaHQoKSAqIGRldmljZVNjYWxlRmFjdG9yKTsKKwogICAgIE93blB0 cjxJbWFnZUJ1ZmZlcj4gYnVmZmVyKEltYWdlQnVmZmVyOjpjcmVhdGUocGFpbnRpbmdSZWN0LnNp emUoKSwgMSwgQ29sb3JTcGFjZURldmljZVJHQikpOwogICAgIGlmICghYnVmZmVyKQogICAgICAg ICByZXR1cm4gMDsKKyAgICBidWZmZXItPmNvbnRleHQoKS0+c2NhbGUoRmxvYXRTaXplKGRldmlj ZVNjYWxlRmFjdG9yLCBkZXZpY2VTY2FsZUZhY3RvcikpOwogICAgIGJ1ZmZlci0+Y29udGV4dCgp LT50cmFuc2xhdGUoLXBhaW50aW5nUmVjdC54KCksIC1wYWludGluZ1JlY3QueSgpKTsKICAgICBi dWZmZXItPmNvbnRleHQoKS0+Y2xpcChGbG9hdFJlY3QoMCwgMCwgcGFpbnRpbmdSZWN0Lm1heFgo KSwgcGFpbnRpbmdSZWN0Lm1heFkoKSkpOwogCkBAIC0xMTEyLDkgKzExMTksMTYgQEAgRHJhZ0lt YWdlUmVmIEZyYW1lOjpkcmFnSW1hZ2VGb3JTZWxlY3Rpb24oKQogCiAgICAgSW50UmVjdCBwYWlu dGluZ1JlY3QgPSBlbmNsb3NpbmdJbnRSZWN0KHNlbGVjdGlvbigpLT5ib3VuZHMoKSk7CiAKKyAg ICBmbG9hdCBkZXZpY2VTY2FsZUZhY3RvciA9IDE7CisgICAgaWYgKG1fcGFnZSkKKyAgICAgICAg ZGV2aWNlU2NhbGVGYWN0b3IgPSBtX3BhZ2UtPmRldmljZVNjYWxlRmFjdG9yKCk7CisgICAgcGFp bnRpbmdSZWN0LnNldFdpZHRoKHBhaW50aW5nUmVjdC53aWR0aCgpICogZGV2aWNlU2NhbGVGYWN0 b3IpOworICAgIHBhaW50aW5nUmVjdC5zZXRIZWlnaHQocGFpbnRpbmdSZWN0LmhlaWdodCgpICog ZGV2aWNlU2NhbGVGYWN0b3IpOworCiAgICAgT3duUHRyPEltYWdlQnVmZmVyPiBidWZmZXIoSW1h Z2VCdWZmZXI6OmNyZWF0ZShwYWludGluZ1JlY3Quc2l6ZSgpLCAxLCBDb2xvclNwYWNlRGV2aWNl UkdCKSk7CiAgICAgaWYgKCFidWZmZXIpCiAgICAgICAgIHJldHVybiAwOworICAgIGJ1ZmZlci0+ Y29udGV4dCgpLT5zY2FsZShGbG9hdFNpemUoZGV2aWNlU2NhbGVGYWN0b3IsIGRldmljZVNjYWxl RmFjdG9yKSk7CiAgICAgYnVmZmVyLT5jb250ZXh0KCktPnRyYW5zbGF0ZSgtcGFpbnRpbmdSZWN0 LngoKSwgLXBhaW50aW5nUmVjdC55KCkpOwogICAgIGJ1ZmZlci0+Y29udGV4dCgpLT5jbGlwKEZs b2F0UmVjdCgwLCAwLCBwYWludGluZ1JlY3QubWF4WCgpLCBwYWludGluZ1JlY3QubWF4WSgpKSk7 CiAK 148455 2012-06-19 16:29:21 -0700 2012-06-20 15:49:27 -0700 Patch bug-89489-20120619192920.patch text/plain 4288 varunjain U3VidmVyc2lvbiBSZXZpc2lvbjogMTIwNzM2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZGIyYTcyMGUxMWQzMDY2 MDMyNWQwOGRiZDk1NzcxMTVlZmFmYWFiNy4uMmRiNmIxMjUzNjVmZDhjNjJhYmM5OWM0YWMxNTYw NjRkYWZlYmQ1ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEyLTA2LTE5ICBWYXJ1 biBKYWluICA8dmFydW5qYWluQGNocm9taXVtLm9yZz4KKworICAgICAgICBBY2NvdW50IGZvciBk ZXZpY2Ugc2NhbGUgZmFjdG9yIHdoZW4gY3JlYXRpbmcgaW1hZ2UgZm9yIGRyYWdnaW5nLgorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODk0ODkKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBNYW51YWwgVGVzdDog TWFudWFsVGVzdHMvY2hyb21pdW0vZHJhZy1pbWFnZS1hY2NvdW50cy1mb3ItZGV2aWNlLXNjYWxl Lmh0bWwKKworICAgICAgICAqIHBhZ2UvRnJhbWUuY3BwOgorICAgICAgICAoV2ViQ29yZTo6RnJh bWU6Om5vZGVJbWFnZSk6CisgICAgICAgIChXZWJDb3JlOjpGcmFtZTo6ZHJhZ0ltYWdlRm9yU2Vs ZWN0aW9uKToKKwogMjAxMi0wNi0xOSAgQW5kcmVhcyBLbGluZyAgPGtsaW5nQHdlYmtpdC5vcmc+ CiAKICAgICAgICAgUmVtb3ZlIHRoZSAtd2Via2l0LW1hdGNoLW5lYXJlc3QtbWFpbC1ibG9ja3F1 b3RlLWNvbG9yIHByb3BlcnR5LgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGFnZS9GcmFt ZS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL0ZyYW1lLmNwcAppbmRleCA5MWQzMWUzYmZkMTQ3 YTg5MGY3NmE3MzkwMDBkM2IwMDI1MzRmOGI0Li5lYTU3YmI0ZjFkODUyY2YwMDUxMDlmMDE3MDg3 YmVmNDBjMmI5OWE3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL0ZyYW1lLmNwcAor KysgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL0ZyYW1lLmNwcApAQCAtMTA4OSw5ICsxMDg5LDE2IEBA IERyYWdJbWFnZVJlZiBGcmFtZTo6bm9kZUltYWdlKE5vZGUqIG5vZGUpCiAgICAgTGF5b3V0UmVj dCB0b3BMZXZlbFJlY3Q7CiAgICAgSW50UmVjdCBwYWludGluZ1JlY3QgPSBwaXhlbFNuYXBwZWRJ bnRSZWN0KHJlbmRlcmVyLT5wYWludGluZ1Jvb3RSZWN0KHRvcExldmVsUmVjdCkpOwogCisgICAg ZmxvYXQgZGV2aWNlU2NhbGVGYWN0b3IgPSAxOworICAgIGlmIChtX3BhZ2UpCisgICAgICAgIGRl dmljZVNjYWxlRmFjdG9yID0gbV9wYWdlLT5kZXZpY2VTY2FsZUZhY3RvcigpOworICAgIHBhaW50 aW5nUmVjdC5zZXRXaWR0aChwYWludGluZ1JlY3Qud2lkdGgoKSAqIGRldmljZVNjYWxlRmFjdG9y KTsKKyAgICBwYWludGluZ1JlY3Quc2V0SGVpZ2h0KHBhaW50aW5nUmVjdC5oZWlnaHQoKSAqIGRl dmljZVNjYWxlRmFjdG9yKTsKKwogICAgIE93blB0cjxJbWFnZUJ1ZmZlcj4gYnVmZmVyKEltYWdl QnVmZmVyOjpjcmVhdGUocGFpbnRpbmdSZWN0LnNpemUoKSwgMSwgQ29sb3JTcGFjZURldmljZVJH QikpOwogICAgIGlmICghYnVmZmVyKQogICAgICAgICByZXR1cm4gMDsKKyAgICBidWZmZXItPmNv bnRleHQoKS0+c2NhbGUoRmxvYXRTaXplKGRldmljZVNjYWxlRmFjdG9yLCBkZXZpY2VTY2FsZUZh Y3RvcikpOwogICAgIGJ1ZmZlci0+Y29udGV4dCgpLT50cmFuc2xhdGUoLXBhaW50aW5nUmVjdC54 KCksIC1wYWludGluZ1JlY3QueSgpKTsKICAgICBidWZmZXItPmNvbnRleHQoKS0+Y2xpcChGbG9h dFJlY3QoMCwgMCwgcGFpbnRpbmdSZWN0Lm1heFgoKSwgcGFpbnRpbmdSZWN0Lm1heFkoKSkpOwog CkBAIC0xMTEyLDkgKzExMTksMTYgQEAgRHJhZ0ltYWdlUmVmIEZyYW1lOjpkcmFnSW1hZ2VGb3JT ZWxlY3Rpb24oKQogCiAgICAgSW50UmVjdCBwYWludGluZ1JlY3QgPSBlbmNsb3NpbmdJbnRSZWN0 KHNlbGVjdGlvbigpLT5ib3VuZHMoKSk7CiAKKyAgICBmbG9hdCBkZXZpY2VTY2FsZUZhY3RvciA9 IDE7CisgICAgaWYgKG1fcGFnZSkKKyAgICAgICAgZGV2aWNlU2NhbGVGYWN0b3IgPSBtX3BhZ2Ut PmRldmljZVNjYWxlRmFjdG9yKCk7CisgICAgcGFpbnRpbmdSZWN0LnNldFdpZHRoKHBhaW50aW5n UmVjdC53aWR0aCgpICogZGV2aWNlU2NhbGVGYWN0b3IpOworICAgIHBhaW50aW5nUmVjdC5zZXRI ZWlnaHQocGFpbnRpbmdSZWN0LmhlaWdodCgpICogZGV2aWNlU2NhbGVGYWN0b3IpOworCiAgICAg T3duUHRyPEltYWdlQnVmZmVyPiBidWZmZXIoSW1hZ2VCdWZmZXI6OmNyZWF0ZShwYWludGluZ1Jl Y3Quc2l6ZSgpLCAxLCBDb2xvclNwYWNlRGV2aWNlUkdCKSk7CiAgICAgaWYgKCFidWZmZXIpCiAg ICAgICAgIHJldHVybiAwOworICAgIGJ1ZmZlci0+Y29udGV4dCgpLT5zY2FsZShGbG9hdFNpemUo ZGV2aWNlU2NhbGVGYWN0b3IsIGRldmljZVNjYWxlRmFjdG9yKSk7CiAgICAgYnVmZmVyLT5jb250 ZXh0KCktPnRyYW5zbGF0ZSgtcGFpbnRpbmdSZWN0LngoKSwgLXBhaW50aW5nUmVjdC55KCkpOwog ICAgIGJ1ZmZlci0+Y29udGV4dCgpLT5jbGlwKEZsb2F0UmVjdCgwLCAwLCBwYWludGluZ1JlY3Qu bWF4WCgpLCBwYWludGluZ1JlY3QubWF4WSgpKSk7CiAKZGlmZiAtLWdpdCBhL0NoYW5nZUxvZyBi L0NoYW5nZUxvZwppbmRleCA3YmU0YWQ0NmI1NGJmM2YyNGNhMjA0YmNjYzBiYmU1MGUxMThkOTVk Li43NTUwOTEyYzk1MjMzNTJmYmUxNmQ4MDNmYjY5YzIzMjJlMWFjNGZkIDEwMDY0NAotLS0gYS9D aGFuZ2VMb2cKKysrIGIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTItMDYtMTkgIFZh cnVuIEphaW4gIDx2YXJ1bmphaW5AY2hyb21pdW0ub3JnPgorCisgICAgICAgIEFjY291bnQgZm9y IGRldmljZSBzY2FsZSBmYWN0b3Igd2hlbiBjcmVhdGluZyBpbWFnZSBmb3IgZHJhZ2dpbmcuCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04OTQ4OQorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogTWFudWFsVGVz dHMvY2hyb21pdW0vZHJhZy1pbWFnZS1hY2NvdW50cy1mb3ItZGV2aWNlLXNjYWxlLmh0bWw6IEFk ZGVkLgorCiAyMDEyLTA2LTE5ICBKb2NlbHluIFR1cmNvdHRlICA8am9jZWx5bi50dXJjb3R0ZUBu b2tpYS5jb20+CiAKICAgICAgICAgW1F0XSBGaXggdGhlIFdpbmRvd3MgYnVpbGQgd2hlbiBRdCBp cyBidWlsdCB3aXRob3V0IC1yZWxlYXNlIG9yIC1kZWJ1ZwpkaWZmIC0tZ2l0IGEvTWFudWFsVGVz dHMvY2hyb21pdW0vZHJhZy1pbWFnZS1hY2NvdW50cy1mb3ItZGV2aWNlLXNjYWxlLmh0bWwgYi9N YW51YWxUZXN0cy9jaHJvbWl1bS9kcmFnLWltYWdlLWFjY291bnRzLWZvci1kZXZpY2Utc2NhbGUu aHRtbApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwLi4xNTY0Y2FlZWRkOTA3ZDNmOGQ2OGFmNTJhYjFhNWJiMTM4YmNlNmU4 Ci0tLSAvZGV2L251bGwKKysrIGIvTWFudWFsVGVzdHMvY2hyb21pdW0vZHJhZy1pbWFnZS1hY2Nv dW50cy1mb3ItZGV2aWNlLXNjYWxlLmh0bWwKQEAgLTAsMCArMSwxMCBAQAorPGh0bWw+Cis8Ym9k eT4KKyAgICA8cD5UbyB0ZXN0IGRldmljZSBzY2FsZSwgcnVuIGNocm9tZSB3aXRoIC0tZm9yY2Ut ZGV2aWNlLXNjYWxlLWZhY3Rvcj0yIChvciBydW4gY2hyb21lIG9uIGEgZGV2aWNlIHdpdGggPiAx IGRldmljZSBzY2FsZSwgc3VjaCBhcyBhIG1hY2Jvb2sgcnVubmluZyBpbiBoaWdoIGRwaSBtb2Rl KTwvcD4KKyAgICA8cD5TZWxlY3Qgc29tZSB0ZXh0IGFuZCBzdGFydCBkcmFnZ2luZy4gSWYgdGhl IHRleHQgaW4gdGhlIGRyYWcgaW1hZ2UgaXMgcmVuZGVyZWQgYXQgdGhlIHNhbWUgc2l6ZSBhcyB0 aGUgdGV4dCBvbiB0aGUgcGFnZSBhbmQgaXMgbm90IGJsdXJyeSAoZHVlIHRvIHNjYWxpbmcpLCAx c3QgcGFydCBvZiB0aGlzIHRlc3QgcGFzc2VzLjwvcD4KKyAgICA8cD5Gb3IgMm5kIHBhcnQsIHRy eSBkcmFnZ2luZyAiRHJhZyBtZSIgYmVsb3cuIEFnYWluLCBpZiB0aGUgdGV4dCBpbiB0aGUgZHJh ZyBpbWFnZSBpcyByZW5kZXJlZCBhdCB0aGUgc2FtZSBzaXplIGFzIHRoZSB0ZXh0IG9uIHRoZSBw YWdlIGlzIG5vdCBibHVycnksIHRoZSB0ZXN0IHBhc3Nlcy48L3A+CisgICAgPGRpdiBkcmFnZ2Fi bGU9J3RydWUnIGlkPSdkcmFnbWUnPgorICAgICAgICBEcmFnIG1lCisgICAgPC9kaXY+Cis8L2Jv ZHk+Cis8L2h0bWw+Cg==