89464 2012-06-19 05:51:04 -0700 Web Inspector: Clicking "Clear all profiles" while ongoing recording should reset the ProfileLauncherView 2012-06-19 23:51:58 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 vivekgalatage vivekgalatage apavlov bweinstein joepeck keishi loislo pfeldman pmuellr rik timothy webkit.review.bot yurys oldest_to_newest 652350 0 vivekgalatage 2012-06-19 05:51:04 -0700 Steps: 1. Launch inspector and navigate to Profiles panel 2. Click on start button to start a profiling session 3. Now click on "Clear all profiles" button at the bottom while the recording is ongoing. Expected Outcome: The profiles view should be reset Actual outcome: The buttons on the panel still shows Stop and the status bar record button still shows red. 652352 1 148318 vivekgalatage 2012-06-19 05:53:49 -0700 Created attachment 148318 Patch 652358 2 148318 yurys 2012-06-19 06:04:43 -0700 Comment on attachment 148318 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=148318&action=review > Source/WebCore/inspector/front-end/ProfilesPanel.js:381 > + this.recordButton.title = ""; Could you call toggleRecordButton instead if we are currently profiling the page to leave correct button title? 652366 3 vivekgalatage 2012-06-19 06:17:14 -0700 (In reply to comment #2) > (From update of attachment 148318 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=148318&action=review > > > Source/WebCore/inspector/front-end/ProfilesPanel.js:381 > > + this.recordButton.title = ""; > > Could you call toggleRecordButton instead if we are currently profiling the page to leave correct button title? Thank you Yury for the review. I tried calling toggleRecordButton before this fix but this will result in calling the takeHeapSnapshot for HeapSnapshotView.js as toggleRecordButton invokes buttonClicked method. Hence have done some corrections to setting the correct tooltip after reset. Uploading it again for your review. 652367 4 148322 vivekgalatage 2012-06-19 06:19:53 -0700 Created attachment 148322 Patch 653248 5 148322 webkit.review.bot 2012-06-19 23:51:51 -0700 Comment on attachment 148322 Patch Clearing flags on attachment: 148322 Committed r120809: <http://trac.webkit.org/changeset/120809> 653249 6 webkit.review.bot 2012-06-19 23:51:58 -0700 All reviewed patches have been landed. Closing bug. 148318 2012-06-19 05:53:49 -0700 2012-06-19 06:19:46 -0700 Patch bug-89464-20120619182420.patch text/plain 1532 vivekgalatage SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEyMDcwNSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDEyLTA2LTE5ICBWaXZlayBH YWxhdGFnZSAgPHZpdmVrZ2FsYXRhZ2VAZ21haWwuY29tPgorCisgICAgICAgIFdlYiBJbnNwZWN0 b3I6IENsaWNraW5nICJDbGVhciBhbGwgcHJvZmlsZXMiIHdoaWxlIG9uZ29pbmcgcmVjb3JkaW5n IHNob3VsZCByZXNldCB0aGUgUHJvZmlsZUxhdW5jaGVyVmlldworICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODk0NjQKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBSZXNldHRpbmcgdGhlIFByb2ZpbGVMYXVuY2hl clZpZXcgaW4gb3JkZXIgdG8gcmVmbGVjdCB0aGUgY29ycmVjdCBzdGF0ZXMgb2YgYnV0dG9ucwor CisgICAgICAgIE5vIG5ldyB0ZXN0cyBhcyBVSSByZWxhdGVkIG1pbm9yIGZpeC4KKworICAgICAg ICAqIGluc3BlY3Rvci9mcm9udC1lbmQvUHJvZmlsZXNQYW5lbC5qczoKKyAgICAgICAgKFdlYklu c3BlY3Rvci5Qcm9maWxlc1BhbmVsLnByb3RvdHlwZS5fcmVzZXQpOgorCiAyMDEyLTA2LTE5ICBD c2FiYSBPc3p0cm9nb27DoWMgIDxvc3N5QHdlYmtpdC5vcmc+CiAKICAgICAgICAgW1F0XSBCdWls ZGZpeCBmb3IgbmV3ZXIgUXQ1LCB1c2UgUVBvaW50ZXIgaW5zdGVhZCBvZiB0aGUgZGVwcmVjYXRl ZCBRV2Vha1BvaW50ZXIuCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5k L1Byb2ZpbGVzUGFuZWwuanMKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvaW5zcGVjdG9y L2Zyb250LWVuZC9Qcm9maWxlc1BhbmVsLmpzCShyZXZpc2lvbiAxMjA1MjcpCisrKyBTb3VyY2Uv V2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1Byb2ZpbGVzUGFuZWwuanMJKHdvcmtpbmcgY29w eSkKQEAgLTM3Nyw2ICszNzcsOSBAQCBXZWJJbnNwZWN0b3IuUHJvZmlsZXNQYW5lbC5wcm90b3R5 cGUgPSB7CiAgICAgICAgIHRoaXMuX3Byb2ZpbGVHcm91cHMgPSB7fTsKICAgICAgICAgdGhpcy5f cHJvZmlsZUdyb3Vwc0ZvckxpbmtzID0ge307CiAgICAgICAgIHRoaXMuX3Byb2ZpbGVzV2VyZVJl cXVlc3RlZCA9IGZhbHNlOworICAgICAgICB0aGlzLnJlY29yZEJ1dHRvbi50b2dnbGVkID0gZmFs c2U7CisgICAgICAgIHRoaXMucmVjb3JkQnV0dG9uLnRpdGxlID0gIiI7CisgICAgICAgIHRoaXMu X2xhdW5jaGVyVmlldy5wcm9maWxlRmluaXNoZWQoKTsKIAogICAgICAgICB0aGlzLnNpZGViYXJU cmVlRWxlbWVudC5yZW1vdmVTdHlsZUNsYXNzKCJzb21lLWV4cGFuZGFibGUiKTsKIAo= 148322 2012-06-19 06:19:53 -0700 2012-06-19 23:51:50 -0700 Patch bug-89464-20120619185025.patch text/plain 1614 vivekgalatage SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEyMDcwNSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDEyLTA2LTE5ICBWaXZlayBH YWxhdGFnZSAgPHZpdmVrZ2FsYXRhZ2VAZ21haWwuY29tPgorCisgICAgICAgIFdlYiBJbnNwZWN0 b3I6IENsaWNraW5nICJDbGVhciBhbGwgcHJvZmlsZXMiIHdoaWxlIG9uZ29pbmcgcmVjb3JkaW5n IHNob3VsZCByZXNldCB0aGUgUHJvZmlsZUxhdW5jaGVyVmlldworICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODk0NjQKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBSZXNldHRpbmcgdGhlIFByb2ZpbGVMYXVuY2hl clZpZXcgaW4gb3JkZXIgdG8gcmVmbGVjdCB0aGUgY29ycmVjdCBzdGF0ZXMgb2YgYnV0dG9ucwor CisgICAgICAgIE5vIG5ldyB0ZXN0cyBhcyBVSSByZWxhdGVkIG1pbm9yIGZpeC4KKworICAgICAg ICAqIGluc3BlY3Rvci9mcm9udC1lbmQvUHJvZmlsZXNQYW5lbC5qczoKKyAgICAgICAgKFdlYklu c3BlY3Rvci5Qcm9maWxlc1BhbmVsLnByb3RvdHlwZS5fcmVzZXQpOgorCiAyMDEyLTA2LTE5ICBD c2FiYSBPc3p0cm9nb27DoWMgIDxvc3N5QHdlYmtpdC5vcmc+CiAKICAgICAgICAgW1F0XSBCdWls ZGZpeCBmb3IgbmV3ZXIgUXQ1LCB1c2UgUVBvaW50ZXIgaW5zdGVhZCBvZiB0aGUgZGVwcmVjYXRl ZCBRV2Vha1BvaW50ZXIuCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5k L1Byb2ZpbGVzUGFuZWwuanMKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvaW5zcGVjdG9y L2Zyb250LWVuZC9Qcm9maWxlc1BhbmVsLmpzCShyZXZpc2lvbiAxMjA1MjcpCisrKyBTb3VyY2Uv V2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1Byb2ZpbGVzUGFuZWwuanMJKHdvcmtpbmcgY29w eSkKQEAgLTM3Nyw2ICszNzcsMTAgQEAgV2ViSW5zcGVjdG9yLlByb2ZpbGVzUGFuZWwucHJvdG90 eXBlID0gewogICAgICAgICB0aGlzLl9wcm9maWxlR3JvdXBzID0ge307CiAgICAgICAgIHRoaXMu X3Byb2ZpbGVHcm91cHNGb3JMaW5rcyA9IHt9OwogICAgICAgICB0aGlzLl9wcm9maWxlc1dlcmVS ZXF1ZXN0ZWQgPSBmYWxzZTsKKyAgICAgICAgdGhpcy5yZWNvcmRCdXR0b24udG9nZ2xlZCA9IGZh bHNlOworICAgICAgICBpZiAodGhpcy5fc2VsZWN0ZWRQcm9maWxlVHlwZSkKKyAgICAgICAgICAg IHRoaXMucmVjb3JkQnV0dG9uLnRpdGxlID0gdGhpcy5fc2VsZWN0ZWRQcm9maWxlVHlwZS5idXR0 b25Ub29sdGlwOworICAgICAgICB0aGlzLl9sYXVuY2hlclZpZXcucHJvZmlsZUZpbmlzaGVkKCk7 CiAKICAgICAgICAgdGhpcy5zaWRlYmFyVHJlZUVsZW1lbnQucmVtb3ZlU3R5bGVDbGFzcygic29t ZS1leHBhbmRhYmxlIik7CiAK