89463 2012-06-19 05:18:49 -0700 Buildfix for newer Qt5 with C++11 support 2012-06-20 09:08:48 -0700 1 1 1 Unclassified WebKit Web Template Framework 528+ (Nightly build) All All RESOLVED DUPLICATE 88721 Qt, QtTriaged P1 Blocker --- 1 ossy kbalazs abecsi ap hausmann kbalazs ossy webkit.review.bot oldest_to_newest 652339 0 ossy 2012-06-19 05:18:49 -0700 After bf84d1a1fe1550fb7cb86d686bf0138c1c41e87b in qtbase "Qt is compiled with C++11 support enabled by default, provided the compiler supports C++11." But unfortunately building WebKit with -std=c++0x doesn't work: In file included from /home/webkitbuildbot/slaves/release64bitWebKit2_EC2/buildslave/qt-linux-64-release-webkit2/build/Source/WebCore/platform/graphics/IntPoint.h:30:0, from /home/webkitbuildbot/slaves/release64bitWebKit2_EC2/buildslave/qt-linux-64-release-webkit2/build/Source/WebKit/qt/Api/qwebpage_p.h:35, from /home/webkitbuildbot/slaves/release64bitWebKit2_EC2/buildslave/qt-linux-64-release-webkit2/build/Source/WebKit/qt/Api/qwebsettings.cpp:24: /home/webkitbuildbot/slaves/release64bitWebKit2_EC2/buildslave/qt-linux-64-release-webkit2/build/Source/WTF/wtf/MathExtras.h: In function ‘bool std::wtf_isinf(float)’: /home/webkitbuildbot/slaves/release64bitWebKit2_EC2/buildslave/qt-linux-64-release-webkit2/build/Source/WTF/wtf/MathExtras.h:285:63: error: ‘bool std::isinf(float)’ is not ‘constexpr’ /home/webkitbuildbot/slaves/release64bitWebKit2_EC2/buildslave/qt-linux-64-release-webkit2/build/Source/WTF/wtf/MathExtras.h: In function ‘bool std::wtf_isinf(double)’: /home/webkitbuildbot/slaves/release64bitWebKit2_EC2/buildslave/qt-linux-64-release-webkit2/build/Source/WTF/wtf/MathExtras.h:286:64: error: ‘bool std::isinf(double)’ is not ‘constexpr’ /home/webkitbuildbot/slaves/release64bitWebKit2_EC2/buildslave/qt-linux-64-release-webkit2/build/Source/WTF/wtf/MathExtras.h: In function ‘bool std::wtf_isnan(float)’: /home/webkitbuildbot/slaves/release64bitWebKit2_EC2/buildslave/qt-linux-64-release-webkit2/build/Source/WTF/wtf/MathExtras.h:287:63: error: ‘bool std::isnan(float)’ is not ‘constexpr’ /home/webkitbuildbot/slaves/release64bitWebKit2_EC2/buildslave/qt-linux-64-release-webkit2/build/Source/WTF/wtf/MathExtras.h: In function ‘bool std::wtf_isnan(double)’: /home/webkitbuildbot/slaves/release64bitWebKit2_EC2/buildslave/qt-linux-64-release-webkit2/build/Source/WTF/wtf/MathExtras.h:288:64: error: ‘bool std::isnan(double)’ is not ‘constexpr’ ... What should we do? Fix the -std=c++0x build of WebKit (I have no idea how) or build Qt with -no-c++11? 652347 1 kbalazs 2012-06-19 05:47:54 -0700 WebKit should (and partially do) support c++ 11, so I think we should fix this. 652348 2 ossy 2012-06-19 05:49:58 -0700 (In reply to comment #1) > WebKit should (and partially do) support c++ 11, so I think we should fix this. Could you pick up this bug? As far as I remember you are c++11 expert. ;-) 652360 3 kbalazs 2012-06-19 06:09:58 -0700 (In reply to comment #2) > (In reply to comment #1) > > WebKit should (and partially do) support c++ 11, so I think we should fix this. > > Could you pick up this bug? As far as I remember you are c++11 expert. ;-) You should be kidding that I'm an expert :) But yes, I can pick this up. 652456 4 148335 kbalazs 2012-06-19 08:05:19 -0700 Created attachment 148335 Patch 652459 5 webkit.review.bot 2012-06-19 08:07:13 -0700 Attachment 148335 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WTF/ChangeLog', u'Source/WTF/wtf/Ma..." exit_code: 1 Source/WTF/wtf/MathExtras.h:285: Code inside a namespace should not be indented. [whitespace/indent] [4] Source/WTF/wtf/MathExtras.h:285: wtf_isinf is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Source/WTF/wtf/MathExtras.h:286: wtf_isinf is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Source/WTF/wtf/MathExtras.h:287: wtf_isnan is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Source/WTF/wtf/MathExtras.h:288: wtf_isnan is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Total errors found: 5 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 652460 6 kbalazs 2012-06-19 08:08:34 -0700 (In reply to comment #5) > Attachment 148335 [details] did not pass style-queue: > > Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WTF/ChangeLog', u'Source/WTF/wtf/Ma..." exit_code: 1 > Source/WTF/wtf/MathExtras.h:285: Code inside a namespace should not be indented. [whitespace/indent] [4] > Source/WTF/wtf/MathExtras.h:285: wtf_isinf is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] > Source/WTF/wtf/MathExtras.h:286: wtf_isinf is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] > Source/WTF/wtf/MathExtras.h:287: wtf_isnan is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] > Source/WTF/wtf/MathExtras.h:288: wtf_isnan is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] > Total errors found: 5 in 2 files > > > If any of these errors are false positives, please file a bug against check-webkit-style. This is the style used in this file for such functions. 652585 7 ap 2012-06-19 10:45:03 -0700 Duplicate of 88721. This patch is for cross platform code. Please do not ever use [Qt] prefix for such bugs. *** This bug has been marked as a duplicate of bug 88721 *** 652589 8 148335 ap 2012-06-19 10:45:32 -0700 Comment on attachment 148335 Patch Clearing r? because this will be tracked in another bug. 652592 9 148335 allan.jensen 2012-06-19 10:48:16 -0700 Comment on attachment 148335 Patch The patch looks good, but resubmit to bug #88721, and don't mind the style warnings. 652797 10 ossy 2012-06-19 14:13:06 -0700 (In reply to comment #8) > (From update of attachment 148335 [details]) > Clearing r? because this will be tracked in another bug. Why this one did you mark as duplicated when there were proposed fix in this bug, and there wasn't in the another one? Is there a rule that the younger bug should be the duplicated one? 653326 11 kbalazs 2012-06-20 03:32:17 -0700 (In reply to comment #7) > Duplicate of 88721. > > This patch is for cross platform code. Please do not ever use [Qt] prefix for such bugs. > > *** This bug has been marked as a duplicate of bug 88721 *** Resubmitted to 88721. 653532 12 ap 2012-06-20 09:08:48 -0700 > Why this one did you mark as duplicated when there were proposed fix in this bug, and there wasn't in the another one? Three reasons: 1. This bug had a misleading [Qt] prefix, so reviewers who are C++ experts have likely skipped over the patch in review queue already. 2. EWS was unhappy (purple bubbles for cr-linux and efl), so it looked like patch needed to be updated and resubmitted anyway. 3. The older bug had more discussion of the issue. > Is there a rule that the younger bug should be the duplicated one? Generally, it is indeed best to dupe to older bug, mainly to show respect to the person who found the problem first, but also to keep better history of when the problem started, and besides, having such a rule is better than no rule. We sometimes do reverse duping to a newer bug to make sure that the active bug is the one with the most productive discussion, and is nearing resolution. In this case, the choice of which direction to dupe in was not very clear. 148335 2012-06-19 08:05:19 -0700 2012-06-19 10:48:16 -0700 Patch bug-89463-20120619170517.patch text/plain 1744 kbalazs U3VidmVyc2lvbiBSZXZpc2lvbjogMTIwNjg4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDhiYjY5NWY5MDQzZmRhOTQ5MTUxYmMx YjAxOGM4Mzk2NTA4NDExYjQuLmI0Y2M5MDhmMGM3N2ZlZDBhOWI5YmNlNTYyYzAxNWQxOWJiMDRk MDAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTItMDYtMTkgIEJhbGF6cyBLZWxlbWVuICA8a2Jh bGF6c0B3ZWJraXQub3JnPgorCisgICAgICAgIFtRdF0gQnVpbGRmaXggZm9yIG5ld2VyIFF0NSB3 aXRoIEMrKzExIHN1cHBvcnQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTg5NDYzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgRG9uJ3QgZGVmaW5lIHRoZXNlIGFzIGNvbnNleHByIGJlY2F1c2Ugd2l0aCBnY2Mg NC42CisgICAgICAgIHRoZXkgY2FsbCBub24gY29uc3RleHByIGZ1bmN0aW9ucy4KKyAgICAgICAg KiB3dGYvTWF0aEV4dHJhcy5oOgorICAgICAgICAoc3RkOjp3dGZfaXNpbmYpOgorICAgICAgICAo c3RkOjp3dGZfaXNuYW4pOgorCiAyMDEyLTA2LTE4ICBUb255IFBheW5lICA8dHBheW5lQGNocm9t aXVtLm9yZz4KIAogICAgICAgICBbY2hyb21pdW1dIEFkZCBpY2NqcGVnIGFuZCBxY21zIHRvIGNo cm9taXVtIHBvcnQuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL3d0Zi9NYXRoRXh0cmFzLmggYi9T b3VyY2UvV1RGL3d0Zi9NYXRoRXh0cmFzLmgKaW5kZXggM2NjOTQ3NDQ3NmQ3ZDQwY2IwN2JjNmU5 ZWI0ZjdhYTE3N2IyNDNjZi4uZTQ0YWI2YzZiOGQ4OWE2NWIwNzljMjZiM2IxMDFmOGUxZDgxMjVk MCAxMDA2NDQKLS0tIGEvU291cmNlL1dURi93dGYvTWF0aEV4dHJhcy5oCisrKyBiL1NvdXJjZS9X VEYvd3RmL01hdGhFeHRyYXMuaApAQCAtMjgyLDEwICsyODIsMTAgQEAgdXNpbmcgc3RkOjpzaWdu Yml0OwogI2lmIENPTVBJTEVSX1FVSVJLKEdDQzExX0dMT0JBTF9JU0lORl9JU05BTikKIC8vIEEg d29ya2Fyb3VuZCB0byBhdm9pZCBjb25mbGljdGluZyBkZWNsYXJhdGlvbnMgb2YgaXNpbmYgYW5k IGlzbmFuIHdoZW4gY29tcGlsaW5nIHdpdGggR0NDIGluIEMrKzExIG1vZGUuCiBuYW1lc3BhY2Ug c3RkIHsKLSAgICBjb25zdGV4cHIgYm9vbCB3dGZfaXNpbmYoZmxvYXQgZikgeyByZXR1cm4gc3Rk Ojppc2luZihmKTsgfQotICAgIGNvbnN0ZXhwciBib29sIHd0Zl9pc2luZihkb3VibGUgZCkgeyBy ZXR1cm4gc3RkOjppc2luZihkKTsgfQotICAgIGNvbnN0ZXhwciBib29sIHd0Zl9pc25hbihmbG9h dCBmKSB7IHJldHVybiBzdGQ6OmlzbmFuKGYpOyB9Ci0gICAgY29uc3RleHByIGJvb2wgd3RmX2lz bmFuKGRvdWJsZSBkKSB7IHJldHVybiBzdGQ6OmlzbmFuKGQpOyB9CisgICAgaW5saW5lIGJvb2wg d3RmX2lzaW5mKGZsb2F0IGYpIHsgcmV0dXJuIHN0ZDo6aXNpbmYoZik7IH0KKyAgICBpbmxpbmUg Ym9vbCB3dGZfaXNpbmYoZG91YmxlIGQpIHsgcmV0dXJuIHN0ZDo6aXNpbmYoZCk7IH0KKyAgICBp bmxpbmUgYm9vbCB3dGZfaXNuYW4oZmxvYXQgZikgeyByZXR1cm4gc3RkOjppc25hbihmKTsgfQor ICAgIGlubGluZSBib29sIHd0Zl9pc25hbihkb3VibGUgZCkgeyByZXR1cm4gc3RkOjppc25hbihk KTsgfQogfTsKIAogdXNpbmcgc3RkOjp3dGZfaXNpbmY7Cg==