89460 2012-06-19 04:31:20 -0700 [WK2] Properly encode/decode service in IntentData 2012-06-21 11:15:10 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 88303 1 cdumez cdumez andersca kenneth laszlo.gombos webkit.review.bot oldest_to_newest 652322 0 cdumez 2012-06-19 04:31:20 -0700 IntentData now has a "service" member but the IntentData::encode() and IntentData::decode() methods were not updated accordingly. 652324 1 148312 cdumez 2012-06-19 04:34:30 -0700 Created attachment 148312 Patch I forgot to update the encode()/decode() methods when I added the "service" member in Bug 89206. This patch fixes it. 654717 2 148312 webkit.review.bot 2012-06-21 11:15:01 -0700 Comment on attachment 148312 Patch Clearing flags on attachment: 148312 Committed r120948: <http://trac.webkit.org/changeset/120948> 654718 3 webkit.review.bot 2012-06-21 11:15:10 -0700 All reviewed patches have been landed. Closing bug. 148312 2012-06-19 04:34:30 -0700 2012-06-21 11:15:01 -0700 Patch 89460_encode_service.patch text/plain 1598 cdumez ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCA1Njg4YWU4Li4zZDlhNDIxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTgg QEAKKzIwMTItMDYtMTkgIENocmlzdG9waGUgRHVtZXogIDxjaHJpc3RvcGhlLmR1bWV6QGludGVs LmNvbT4KKworICAgICAgICBbV0syXSBQcm9wZXJseSBlbmNvZGUvZGVjb2RlIHNlcnZpY2UgaW4g SW50ZW50RGF0YQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9ODk0NjAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBVcGRhdGUgSW50ZW50RGF0YTo6ZW5jb2RlKCkgYW5kIEludGVudERhdGE6OmRlY29kZSgpCisg ICAgICAgIHNvIHRoYXQgdGhlICJzZXJ2aWNlIiBtZW1iZXIgaXMgcHJvcGVybHkgZW5jb2RlZAor ICAgICAgICBhbmQgZGVjb2RlZC4KKworICAgICAgICAqIFNoYXJlZC9JbnRlbnREYXRhLmNwcDoK KyAgICAgICAgKFdlYktpdDo6SW50ZW50RGF0YTo6ZW5jb2RlKToKKyAgICAgICAgKFdlYktpdDo6 SW50ZW50RGF0YTo6ZGVjb2RlKToKKwogMjAxMi0wNi0xOSAgTWlrZSBXZXN0ICA8bWt3c3RAY2hy b21pdW0ub3JnPgogCiAgICAgICAgIEludHJvZHVjZSBFTkFCTEVfQ1NQX05FWFQgY29uZmlndXJh dGlvbiBmbGFnLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvU2hhcmVkL0ludGVudERhdGEu Y3BwIGIvU291cmNlL1dlYktpdDIvU2hhcmVkL0ludGVudERhdGEuY3BwCmluZGV4IGFlMGFmYmQu LjM4OGEzYTUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1NoYXJlZC9JbnRlbnREYXRhLmNw cAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9TaGFyZWQvSW50ZW50RGF0YS5jcHAKQEAgLTQwLDYgKzQw LDcgQEAgdm9pZCBJbnRlbnREYXRhOjplbmNvZGUoQ29yZUlQQzo6QXJndW1lbnRFbmNvZGVyKiBl bmNvZGVyKSBjb25zdAogewogICAgIGVuY29kZXItPmVuY29kZShhY3Rpb24pOwogICAgIGVuY29k ZXItPmVuY29kZSh0eXBlKTsKKyAgICBlbmNvZGVyLT5lbmNvZGUoc2VydmljZSk7CiAgICAgZW5j b2Rlci0+ZW5jb2RlKENvcmVJUEM6OkRhdGFSZWZlcmVuY2UoZGF0YSkpOwogICAgIGVuY29kZXIt PmVuY29kZShleHRyYXMpOwogICAgIGVuY29kZXItPmVuY29kZShzdWdnZXN0aW9ucyk7CkBAIC01 MSw2ICs1Miw4IEBAIGJvb2wgSW50ZW50RGF0YTo6ZGVjb2RlKENvcmVJUEM6OkFyZ3VtZW50RGVj b2RlciogZGVjb2RlciwgSW50ZW50RGF0YSYgaW50ZW50RGF0CiAgICAgICAgIHJldHVybiBmYWxz ZTsKICAgICBpZiAoIWRlY29kZXItPmRlY29kZShpbnRlbnREYXRhLnR5cGUpKQogICAgICAgICBy ZXR1cm4gZmFsc2U7CisgICAgaWYgKCFkZWNvZGVyLT5kZWNvZGUoaW50ZW50RGF0YS5zZXJ2aWNl KSkKKyAgICAgICAgcmV0dXJuIGZhbHNlOwogICAgIENvcmVJUEM6OkRhdGFSZWZlcmVuY2UgZGF0 YTsKICAgICBpZiAoIWRlY29kZXItPmRlY29kZShkYXRhKSkKICAgICAgICAgcmV0dXJuIGZhbHNl Owo=