89433 2012-06-18 23:38:16 -0700 REGRESSION(120552): Many tests timing out on Windows 2012-06-19 02:21:34 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Windows 7 RESOLVED FIXED MakingBotsRed, PlatformOnly P2 Normal --- 1 jhoneycutt jhoneycutt bfulgham jberlin jhoneycutt paroga oldest_to_newest 652098 0 jhoneycutt 2012-06-18 23:38:16 -0700 I think that any test using layoutTestController.waitUntilDone() is timing out on Windows after <http://trac.webkit.org/changeset/120552>. 652189 1 148281 jhoneycutt 2012-06-19 01:10:59 -0700 Created attachment 148281 Patch 652227 2 148281 aestes 2012-06-19 01:52:03 -0700 Comment on attachment 148281 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=148281&action=review > Source/WTF/ChangeLog:3 > + REGRESSION(120552): Many tests timing out on Windows "REGRESSION (r120552): ...", for consistency. > Source/WTF/wtf/CurrentTime.cpp:74 > +static const double hundredsOfNanosecondsPerMillisecond = 10000.0; No need for the .0 652253 3 jhoneycutt 2012-06-19 02:21:34 -0700 Thanks for the review! Landed in <http://trac.webkit.org/changeset/120697>. 148281 2012-06-19 01:10:59 -0700 2012-06-19 01:52:34 -0700 Patch 89433.patch text/plain 1792 jhoneycutt SW5kZXg6IFNvdXJjZS9XVEYvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvQ2hh bmdlTG9nCShyZXZpc2lvbiAxMjA2ODEpCisrKyBTb3VyY2UvV1RGL0NoYW5nZUxvZwkod29ya2lu ZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBACisyMDEyLTA2LTE5ICBKb24gSG9uZXljdXR0ICA8amhv bmV5Y3V0dEBhcHBsZS5jb20+CisKKyAgICAgICAgUkVHUkVTU0lPTigxMjA1NTIpOiBNYW55IHRl c3RzIHRpbWluZyBvdXQgb24gV2luZG93cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9ODk0MzMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICAqIHd0Zi9DdXJyZW50VGltZS5jcHA6CisgICAgICAgIChXVEY6Omxv d1Jlc1VUQ1RpbWUpOgorICAgICAgICBJdCBsb29rcyBsaWtlIHRoZXJlIHdlcmUgdHdvIGJ1Z3M6 CisgICAgICAgIDEpIHRoZSBmdW5jdGlvbiB3YXMgY29udmVydGluZyBmcm9tIDEwMHRocyBvZiBu YW5vc2Vjb25kcyB0byBzZWNvbmRzCisgICAgICAgICAgIHJhdGhlciB0aGFuIDEwMHMgb2YgbmFu b3NlY29uZHMgdG8gc2Vjb25kcyBieSBkaXZpZGluZyBieQorICAgICAgICAgICAobnNQZXJTZWNv bmQgKiAxMDApIHJhdGhlciB0aGFuIChuc1BlclNlY29uZCAvIDEwMCkKKyAgICAgICAgMikgdGhl IGZ1bmN0aW9uIHNob3VsZCd2ZSBiZWVuIHJldHVybmluZyBtaWxsaXNlY29uZHMsIG5vdCBzZWNv bmRzCisKIDIwMTItMDYtMTggIFRvbnkgUGF5bmUgIDx0cGF5bmVAY2hyb21pdW0ub3JnPgogCiAg ICAgICAgIFtjaHJvbWl1bV0gQWRkIGljY2pwZWcgYW5kIHFjbXMgdG8gY2hyb21pdW0gcG9ydC4K SW5kZXg6IFNvdXJjZS9XVEYvd3RmL0N1cnJlbnRUaW1lLmNwcAo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3Vy Y2UvV1RGL3d0Zi9DdXJyZW50VGltZS5jcHAJKHJldmlzaW9uIDEyMDY2OCkKKysrIFNvdXJjZS9X VEYvd3RmL0N1cnJlbnRUaW1lLmNwcAkod29ya2luZyBjb3B5KQpAQCAtNzEsNyArNzEsNyBAQCBu YW1lc3BhY2UgV1RGIHsKIAogLy8gTnVtYmVyIG9mIDEwMCBuYW5vc2Vjb25kIGJldHdlZW4gSmFu dWFyeSAxLCAxNjAxIGFuZCBKYW51YXJ5IDEsIDE5NzAuCiBzdGF0aWMgY29uc3QgVUxPTkdMT05H IGVwb2NoQmlhcyA9IDExNjQ0NDczNjAwMDAwMDAwMFVMTDsKLXN0YXRpYyBjb25zdCBkb3VibGUg bnNQZXJTZWNvbmQgPSAxMDAwMDAwMDAwLjA7CitzdGF0aWMgY29uc3QgZG91YmxlIGh1bmRyZWRz T2ZOYW5vc2Vjb25kc1Blck1pbGxpc2Vjb25kID0gMTAwMDAuMDsKIAogc3RhdGljIGRvdWJsZSBs b3dSZXNVVENUaW1lKCkKIHsKQEAgLTkxLDcgKzkxLDcgQEAgc3RhdGljIGRvdWJsZSBsb3dSZXNV VENUaW1lKCkKICAgICBtZW1jcHkoJmRhdGVUaW1lLCAmZmlsZVRpbWUsIHNpemVvZihkYXRlVGlt ZSkpOwogCiAgICAgLy8gV2luZG93cyBmaWxlIHRpbWVzIGFyZSBpbiAxMDBzIG9mIG5hbm9zZWNv bmRzLgotICAgIHJldHVybiAoZGF0ZVRpbWUuUXVhZFBhcnQgLSBlcG9jaEJpYXMpIC8gKDEwMCAq IG5zUGVyU2Vjb25kKTsKKyAgICByZXR1cm4gKGRhdGVUaW1lLlF1YWRQYXJ0IC0gZXBvY2hCaWFz KSAvIGh1bmRyZWRzT2ZOYW5vc2Vjb25kc1Blck1pbGxpc2Vjb25kOwogfQogCiAjaWYgVVNFKFFV RVJZX1BFUkZPUk1BTkNFX0NPVU5URVIpCg==