89424 2012-06-18 22:58:33 -0700 [Mac] Editor::fontAttributesForSelectionStart() leaks a NSShadow 2012-06-18 23:35:22 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 aestes aestes oldest_to_newest 652056 0 aestes 2012-06-18 22:58:33 -0700 [Mac] Editor::fontAttributesForSelectionStart() leaks a NSShadow 652057 1 148252 aestes 2012-06-18 23:00:04 -0700 Created attachment 148252 Patch 652069 2 148252 mitz 2012-06-18 23:09:08 -0700 Comment on attachment 148252 Patch Could have used a RetainPtr here. 652090 3 aestes 2012-06-18 23:33:53 -0700 Committed r120680: <http://trac.webkit.org/changeset/120680> 652095 4 aestes 2012-06-18 23:35:22 -0700 (In reply to comment #2) > (From update of attachment 148252 [details]) > Could have used a RetainPtr here. Landed with a RetainPtr. 148252 2012-06-18 23:00:04 -0700 2012-06-18 23:34:59 -0700 Patch bug-89424-20120618230003.patch text/plain 1397 aestes U3VidmVyc2lvbiBSZXZpc2lvbjogMTIwNjY0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYTBmZmFmM2FkYTI3ZmFh MWYyNWNlNDZmN2UyYWUwZWE0NzhhYzM4NS4uZDY3NWJiNTVkMGYzNTA4OTlmMzdmODUxMGUyZjdk YTYwNzNlOTFkNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDEyLTA2LTE4ICBBbmR5 IEVzdGVzICA8YWVzdGVzQGFwcGxlLmNvbT4KKworICAgICAgICBbTWFjXSBFZGl0b3I6OmZvbnRB dHRyaWJ1dGVzRm9yU2VsZWN0aW9uU3RhcnQoKSBsZWFrcyBhIE5TU2hhZG93CisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04OTQyNAorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogZWRpdGluZy9tYWMvRWRpdG9y TWFjLm1tOgorICAgICAgICAoV2ViQ29yZTo6RWRpdG9yOjpmb250QXR0cmlidXRlc0ZvclNlbGVj dGlvblN0YXJ0KTogUmVsZWFzZSB0aGUKKyAgICAgICAgTlNTaGFkb3cgb25jZSB3ZSBvYnRhaW5l ZCBmcm9tIGNhbGxpbmcgYWxsb2MvaW5pdCBvbmNlIHdlJ3JlIGRvbmUgd2l0aCBpdC4KKwogMjAx Mi0wNi0xOCAgTWlrZSBMYXd0aGVyICA8bWlrZWxhd3RoZXJAY2hyb21pdW0ub3JnPgogCiAgICAg ICAgIENyYXNoIHdoZW4gc2V0dGluZyB0aXRsZSBkeW5hbWljYWxseQpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYkNvcmUvZWRpdGluZy9tYWMvRWRpdG9yTWFjLm1tIGIvU291cmNlL1dlYkNvcmUvZWRp dGluZy9tYWMvRWRpdG9yTWFjLm1tCmluZGV4IDJjNjNhMjRlZWMyMGNjOTg1MzIyZDE0NGE3YTFk N2EyMTI4NGM0MWMuLjViNzMxZjRkNmFiODIzZGE4MWYzMmNlMjg2ZDQyMzYwYWE2YWY3YWEgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2VkaXRpbmcvbWFjL0VkaXRvck1hYy5tbQorKysgYi9T b3VyY2UvV2ViQ29yZS9lZGl0aW5nL21hYy9FZGl0b3JNYWMubW0KQEAgLTIwOSw2ICsyMDksNyBA QCBOU0RpY3Rpb25hcnkqIEVkaXRvcjo6Zm9udEF0dHJpYnV0ZXNGb3JTZWxlY3Rpb25TdGFydCgp IGNvbnN0CiAgICAgICAgIFtzIHNldFNoYWRvd0JsdXJSYWRpdXM6c2hhZG93LT5ibHVyKCldOwog ICAgICAgICBbcyBzZXRTaGFkb3dDb2xvcjpuc0NvbG9yKHNoYWRvdy0+Y29sb3IoKSldOwogICAg ICAgICBbcmVzdWx0IHNldE9iamVjdDpzIGZvcktleTpOU1NoYWRvd0F0dHJpYnV0ZU5hbWVdOwor ICAgICAgICBbcyByZWxlYXNlXTsKICAgICB9CiAKICAgICBpbnQgZGVjb3JhdGlvbiA9IHN0eWxl LT50ZXh0RGVjb3JhdGlvbnNJbkVmZmVjdCgpOwo=