89408 2012-06-18 18:42:43 -0700 Provide bug links for suspicious commits 2012-06-18 19:06:19 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 simon.fraser simon.fraser abarth dglazkov simon.fraser webkit.review.bot oldest_to_newest 651956 0 simon.fraser 2012-06-18 18:42:43 -0700 Provide bug links for suspicious commits 651957 1 148220 simon.fraser 2012-06-18 18:44:28 -0700 Created attachment 148220 Patch 651965 2 simon.fraser 2012-06-18 19:06:19 -0700 http://trac.webkit.org/changeset/120657 148220 2012-06-18 18:44:28 -0700 2012-06-18 19:01:01 -0700 Patch bug-89408-20120618184428.patch text/plain 4605 simon.fraser U3VidmVyc2lvbiBSZXZpc2lvbjogMTIwNjQ5CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMzZmMWFkOTA5NmE4NzVkOGU3MWE2NDgwMDM1OTcyNDky YTVlNWYyNi4uZDdkMTgwYTg1ZDA0YTQ1MTg4OTFiMTE3YzU2MDQ3MzNjN2FjZDYwMSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIw IEBACiAyMDEyLTA2LTE4ICBTaW1vbiBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgog CisgICAgICAgIFByb3ZpZGUgYnVnIGxpbmtzIGZvciBzdXNwaWNpb3VzIGNvbW1pdHMKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTg5NDA4CisgICAgICAg IAorICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGQgbGlu a3MgdG8gYnVncyBmb3IgdGhlIHN1c3BpY2lvdXMgY29tbWl0cyBpZiB3ZSBoYXZlIGJ1ZyBkYXRh LgorCisgICAgICAgICogQnVpbGRTbGF2ZVN1cHBvcnQvYnVpbGQud2Via2l0Lm9yZy1jb25maWcv cHVibGljX2h0bWwvVGVzdEZhaWx1cmVzL3NjcmlwdHMvQnVnemlsbGEuanM6CisgICAgICAgICog QnVpbGRTbGF2ZVN1cHBvcnQvYnVpbGQud2Via2l0Lm9yZy1jb25maWcvcHVibGljX2h0bWwvVGVz dEZhaWx1cmVzL3NjcmlwdHMvdWkvbm90aWZpY2F0aW9ucy5qczoKKyAgICAgICAgKiBCdWlsZFNs YXZlU3VwcG9ydC9idWlsZC53ZWJraXQub3JnLWNvbmZpZy9wdWJsaWNfaHRtbC9UZXN0RmFpbHVy ZXMvc3R5bGVzL25vdGlmaWNhdGlvbnMuY3NzOgorICAgICAgICAob2wubm90aWZpY2F0aW9ucz5s aSB1bC5jYXVzZXM+bGk+ZGl2LmRlc2NyaXB0aW9uPnNwYW4+c3Bhbi5idWdJRDo6YmVmb3JlKToK KyAgICAgICAgKG9sLm5vdGlmaWNhdGlvbnM+bGkgdWwuY2F1c2VzPmxpPmRpdi5kZXNjcmlwdGlv bj5zcGFuPnNwYW4uYnVnSUQ+YSk6CisKKzIwMTItMDYtMTggIFNpbW9uIEZyYXNlciAgPHNpbW9u LmZyYXNlckBhcHBsZS5jb20+CisKICAgICAgICAgTWlub3IgZml4IHN1Z2dlc3RlZCBieSBBZGFt IEJhcnRoLgogCiAgICAgICAgIFVzZSAkKHRoaXMuX3doYXQpLmVtcHR5KCk7IHJhdGhlciB0aGFu IHJlbW92aW5nIGNoaWxkcmVuIG9uZSBhdCBhIHRpbWUuCmRpZmYgLS1naXQgYS9Ub29scy9CdWls ZFNsYXZlU3VwcG9ydC9idWlsZC53ZWJraXQub3JnLWNvbmZpZy9wdWJsaWNfaHRtbC9UZXN0RmFp bHVyZXMvc2NyaXB0cy9CdWd6aWxsYS5qcyBiL1Rvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2J1aWxk LndlYmtpdC5vcmctY29uZmlnL3B1YmxpY19odG1sL1Rlc3RGYWlsdXJlcy9zY3JpcHRzL0J1Z3pp bGxhLmpzCmluZGV4IGE4OTlmYmM4OWQ0NWMxMjc2MTg4NWEwYWFjNGU2MzAxZWEwNTI5ZWIuLjJj NDQxZmI1OTM0ZTM5MzFmOGExZjM5NmFjZWZmY2UxYjAzM2Y2NmQgMTAwNjQ0Ci0tLSBhL1Rvb2xz L0J1aWxkU2xhdmVTdXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29uZmlnL3B1YmxpY19odG1sL1Rl c3RGYWlsdXJlcy9zY3JpcHRzL0J1Z3ppbGxhLmpzCisrKyBiL1Rvb2xzL0J1aWxkU2xhdmVTdXBw b3J0L2J1aWxkLndlYmtpdC5vcmctY29uZmlnL3B1YmxpY19odG1sL1Rlc3RGYWlsdXJlcy9zY3Jp cHRzL0J1Z3ppbGxhLmpzCkBAIC03MCw2ICs3MCwxMSBAQCB2YXIgZ19zZWFyY2hDYWNoZSA9IG5l dyBiYXNlLkFzeW5jaHJvbm91c0NhY2hlKGZ1bmN0aW9uKHF1ZXJ5LCBjYWxsYmFjaykgewogICAg IH0pOwogfSk7CiAKK2J1Z3ppbGxhLmJ1Z1VSTCA9IGZ1bmN0aW9uKGJ1Z051bWJlcikKK3sKKyAg ICByZXR1cm4gY29uZmlnLmtCdWd6aWxsYVVSTCArICcvc2hvd19idWcuY2dpP2lkPScgKyBidWdO dW1iZXI7Cit9OworCiBidWd6aWxsYS5xdWlja1NlYXJjaCA9IGZ1bmN0aW9uKHF1ZXJ5LCBjYWxs YmFjaykKIHsKICAgICBnX3NlYXJjaENhY2hlLmdldChxdWVyeSwgY2FsbGJhY2spOwpkaWZmIC0t Z2l0IGEvVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvYnVpbGQud2Via2l0Lm9yZy1jb25maWcvcHVi bGljX2h0bWwvVGVzdEZhaWx1cmVzL3NjcmlwdHMvdWkvbm90aWZpY2F0aW9ucy5qcyBiL1Rvb2xz L0J1aWxkU2xhdmVTdXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29uZmlnL3B1YmxpY19odG1sL1Rl c3RGYWlsdXJlcy9zY3JpcHRzL3VpL25vdGlmaWNhdGlvbnMuanMKaW5kZXggZDE4ODljMGJlNWJh NDI4ZTQ2NWY3NjgyODM4ZDI3NWIxZDc5MTMwNS4uNzdkMmNlYTI4ZTE5M2IxNjFhNzI1MjNlMjBm MDc4YjJiYjQ4ZGE4NyAxMDA2NDQKLS0tIGEvVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvYnVpbGQu d2Via2l0Lm9yZy1jb25maWcvcHVibGljX2h0bWwvVGVzdEZhaWx1cmVzL3NjcmlwdHMvdWkvbm90 aWZpY2F0aW9ucy5qcworKysgYi9Ub29scy9CdWlsZFNsYXZlU3VwcG9ydC9idWlsZC53ZWJraXQu b3JnLWNvbmZpZy9wdWJsaWNfaHRtbC9UZXN0RmFpbHVyZXMvc2NyaXB0cy91aS9ub3RpZmljYXRp b25zLmpzCkBAIC0xMTcsMTIgKzExNywxMyBAQCB1aS5ub3RpZmljYXRpb25zLlN1c3BpY2lvdXND b21taXQgPSBiYXNlLmV4dGVuZHMoQ2F1c2UsIHsKICAgICAgICAgdGhpcy5fYWRkRGV0YWlsKCdz dW1tYXJ5JywgY29tbWl0RGF0YSk7CiAgICAgICAgIHRoaXMuX2FkZERldGFpbCgnYXV0aG9yJywg Y29tbWl0RGF0YSk7CiAgICAgICAgIHRoaXMuX2FkZERldGFpbCgncmV2aWV3ZXInLCBjb21taXRE YXRhKTsKKyAgICAgICAgdGhpcy5fYWRkRGV0YWlsKCdidWdJRCcsIGNvbW1pdERhdGEsIGJ1Z3pp bGxhLmJ1Z1VSTCk7CiAgICAgfSwKICAgICBoYXNSZXZpc2lvbjogZnVuY3Rpb24ocmV2aXNpb24p CiAgICAgewogICAgICAgICByZXR1cm4gdGhpcy5fcmV2aXNpb24gPT0gcmV2aXNpb247CiAgICAg fSwKLSAgICBfYWRkRGV0YWlsOiBmdW5jdGlvbihwYXJ0LCBjb21taXREYXRhKQorICAgIF9hZGRE ZXRhaWw6IGZ1bmN0aW9uKHBhcnQsIGNvbW1pdERhdGEsIGxpbmtGdW5jdGlvbikKICAgICB7CiAg ICAgICAgIHZhciBjb250ZW50ID0gY29tbWl0RGF0YVtwYXJ0XTsKICAgICAgICAgaWYgKCFjb250 ZW50KQpAQCAtMTMwLDcgKzEzMSwxMiBAQCB1aS5ub3RpZmljYXRpb25zLlN1c3BpY2lvdXNDb21t aXQgPSBiYXNlLmV4dGVuZHMoQ2F1c2UsIHsKIAogICAgICAgICB2YXIgc3BhbiA9IHRoaXMuX2Rl dGFpbHMuYXBwZW5kQ2hpbGQoZG9jdW1lbnQuY3JlYXRlRWxlbWVudCgnc3BhbicpKTsKICAgICAg ICAgc3Bhbi5jbGFzc05hbWUgPSBwYXJ0OwotICAgICAgICBzcGFuLnRleHRDb250ZW50ID0gY29u dGVudDsKKyAgICAgICAgCisgICAgICAgIGlmIChsaW5rRnVuY3Rpb24pIHsKKyAgICAgICAgICAg IHZhciBsaW5rID0gYmFzZS5jcmVhdGVMaW5rTm9kZShsaW5rRnVuY3Rpb24oY29udGVudCksIGNv bnRlbnQsICdfYmxhbmsnKTsKKyAgICAgICAgICAgIHNwYW4uYXBwZW5kQ2hpbGQobGluayk7Cisg ICAgICAgIH0gZWxzZQorICAgICAgICAgICAgc3Bhbi50ZXh0Q29udGVudCA9IGNvbnRlbnQ7CiAg ICAgfQogfSk7CiAKZGlmZiAtLWdpdCBhL1Rvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2J1aWxkLndl YmtpdC5vcmctY29uZmlnL3B1YmxpY19odG1sL1Rlc3RGYWlsdXJlcy9zdHlsZXMvbm90aWZpY2F0 aW9ucy5jc3MgYi9Ub29scy9CdWlsZFNsYXZlU3VwcG9ydC9idWlsZC53ZWJraXQub3JnLWNvbmZp Zy9wdWJsaWNfaHRtbC9UZXN0RmFpbHVyZXMvc3R5bGVzL25vdGlmaWNhdGlvbnMuY3NzCmluZGV4 IGY2N2ZjYWUwZDQwYTVmYzQ2MTRiNjNlZDVhODIyNzIwNTQxMTFmZWYuLmVlZGUxODk2YTMyMDIw NjcwYTVhYmI5ZGE4ZGJmMDliOGY3MTg4MDcgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0J1aWxkU2xhdmVT dXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29uZmlnL3B1YmxpY19odG1sL1Rlc3RGYWlsdXJlcy9z dHlsZXMvbm90aWZpY2F0aW9ucy5jc3MKKysrIGIvVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvYnVp bGQud2Via2l0Lm9yZy1jb25maWcvcHVibGljX2h0bWwvVGVzdEZhaWx1cmVzL3N0eWxlcy9ub3Rp ZmljYXRpb25zLmNzcwpAQCAtMTQ2LDYgKzE0NiwxNiBAQCBvbC5ub3RpZmljYXRpb25zPmxpIHVs LmNhdXNlcz5saT51bC5hY3Rpb25zIHsKICAgICAgICAgICAgIGNvbG9yOiBHcmF5OwogICAgICAg ICB9CiAKKyAgICAgICAgb2wubm90aWZpY2F0aW9ucz5saSB1bC5jYXVzZXM+bGk+ZGl2LmRlc2Ny aXB0aW9uPnNwYW4+c3Bhbi5idWdJRDo6YmVmb3JlIHsKKyAgICAgICAgICAgIGNvbnRlbnQ6ICdi dWcgJzsKKyAgICAgICAgICAgIHBhZGRpbmctbGVmdDogOHB4OworICAgICAgICB9CisKKyAgICAg ICAgb2wubm90aWZpY2F0aW9ucz5saSB1bC5jYXVzZXM+bGk+ZGl2LmRlc2NyaXB0aW9uPnNwYW4+ c3Bhbi5idWdJRD5hIHsKKyAgICAgICAgICAgIGN1cnNvcjogaGFuZDsKKyAgICAgICAgICAgIHBv aW50ZXItZXZlbnRzOiBhdXRvOworICAgICAgICB9CisKICAgICAgICAgb2wubm90aWZpY2F0aW9u cz5saSB1bC5jYXVzZXM+bGk+ZGl2LmRlc2NyaXB0aW9uPnNwYW4+c3Bhbi5yZXZpZXdlcjo6YmVm b3JlIHsKICAgICAgICAgICAgIGNvbnRlbnQ6ICcgKCc7CiAgICAgICAgIH0K