89405 2012-06-18 17:31:01 -0700 West-panning cursor does not match resize cursor, unlike all other directions 2013-01-16 09:57:18 -0800 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 avi avi ap darin webkit.review.bot oldest_to_newest 651904 0 avi 2012-06-18 17:31:01 -0700 In WebCore/platform/mac/CursorMac.mm, the panning and resize cursors all match, except for west. With the west panning cursor, it's mapped to EastWestResize. 651914 1 148212 avi 2012-06-18 17:36:24 -0700 Created attachment 148212 Patch 652654 2 ap 2012-06-19 11:43:38 -0700 Do you have a test case showing this in action? 652665 3 avi 2012-06-19 11:56:41 -0700 There are two ways to get the west panning cursor. One is to explicitly call Cursor::westPanningCursor, which is only called from EventHandler::updatePanScrollState. Since PAN_SCROLLING isn't enabled on the Mac, this case is never seen. The other way to get that cursor is Cursor::fromType(Cursor::WestPanning), which is only called from WebKit2/Shared/WebCoreArgumentCoders.cpp, ArgumentCoder<Cursor>::decode. I'm not sure how to trace that back. 671462 4 avi 2012-07-17 11:53:05 -0700 I don't see what the issue is here. Panning cursors aren't usually compiled into the Mac build, so if we have them in CursorMac at all, we might as well get them right. 807762 5 148212 webkit.review.bot 2013-01-15 15:43:06 -0800 Comment on attachment 148212 Patch Rejecting attachment 148212 from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 cwd: /mnt/git/webkit-commit-queue Last 500 characters of output: : /mnt/git/webkit-commit-queue Parsed 2 diffs from patch file(s). patching file Source/WebCore/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Source/WebCore/platform/mac/CursorMac.mm Hunk #1 FAILED at 188. Hunk #2 FAILED at 204. 2 out of 2 hunks FAILED -- saving rejects to file Source/WebCore/platform/mac/CursorMac.mm.rej Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', '--force', '--reviewer', 'Darin Adler']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue Full output: http://queues.webkit.org/results/15901149 808046 6 avi 2013-01-15 22:02:38 -0800 Darin, Thank you for the r+; I will upload a new version of this patch tomorrow. 808378 7 182984 avi 2013-01-16 08:11:50 -0800 Created attachment 182984 updated version 808445 8 182984 ap 2013-01-16 09:47:19 -0800 Comment on attachment 182984 updated version This was already reviewed, so you could have updated ChangeLog with Darin's name, and only requested cq? flag. 808448 9 182984 webkit.review.bot 2013-01-16 09:50:28 -0800 Comment on attachment 182984 updated version Clearing flags on attachment: 182984 Committed r139889: <http://trac.webkit.org/changeset/139889> 808449 10 webkit.review.bot 2013-01-16 09:50:32 -0800 All reviewed patches have been landed. Closing bug. 808460 11 avi 2013-01-16 09:57:18 -0800 (In reply to comment #8) > (From update of attachment 182984 [details]) > This was already reviewed, so you could have updated ChangeLog with Darin's name, and only requested cq? flag. OK. I'm not that familiar with the WebKit review process, so the next time I will keep that in mind. 148212 2012-06-18 17:36:24 -0700 2013-01-16 08:11:50 -0800 Patch cursor.patch text/plain 1485 avi SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEyMDY0NCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDEyLTA2LTE4ICBBdmkgRHJp c3NtYW4gIDxhdmlAZ29vZ2xlLmNvbT4KKworICAgICAgICBXZXN0LXBhbm5pbmcgY3Vyc29yIGRv ZXMgbm90IG1hdGNoIHJlc2l6ZSBjdXJzb3IsIHVubGlrZSBhbGwgb3RoZXIgZGlyZWN0aW9ucwor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODk0MDUKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBFeGlzdGluZyBt YW51YWwgdGVzdHMuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9tYWMvQ3Vyc29yTWFjLm1tOgorICAg ICAgICAoV2ViQ29yZTo6Q3Vyc29yOjplbnN1cmVQbGF0Zm9ybUN1cnNvcik6CisKIDIwMTItMDYt MTQgIEphbWVzIFJvYmluc29uICA8amFtZXNyQGNocm9taXVtLm9yZz4KIAogICAgICAgICBbY2hy b21pdW1dIFVzZSBXZWJJbWFnZUxheWVyIGluIEdyYXBoaWNzTGF5ZXJDaHJvbWl1bSBmb3IgaW1h Z2UgbGF5ZXJzCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9tYWMvQ3Vyc29yTWFjLm1t Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21hYy9DdXJzb3JNYWMubW0J KHJldmlzaW9uIDEyMDYyNSkKKysrIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21hYy9DdXJzb3JN YWMubW0JKHdvcmtpbmcgY29weSkKQEAgLTE4OCw2ICsxODgsNyBAQCB2b2lkIEN1cnNvcjo6ZW5z dXJlUGxhdGZvcm1DdXJzb3IoKSBjb25zCiAgICAgICAgIGJyZWFrOwogCiAgICAgY2FzZSBDdXJz b3I6Oldlc3RSZXNpemU6CisgICAgY2FzZSBDdXJzb3I6Oldlc3RQYW5uaW5nOgogI2lmICFkZWZp bmVkKEJVSUxESU5HX09OX0xFT1BBUkQpICYmICFkZWZpbmVkKEJVSUxESU5HX09OX1NOT1dfTEVP UEFSRCkKICAgICAgICAgbV9wbGF0Zm9ybUN1cnNvciA9IHdrQ3Vyc29yKCJSZXNpemVXZXN0Iik7 CiAjZWxzZQpAQCAtMjA0LDcgKzIwNSw2IEBAIHZvaWQgQ3Vyc29yOjplbnN1cmVQbGF0Zm9ybUN1 cnNvcigpIGNvbnMKICAgICAgICAgYnJlYWs7CiAKICAgICBjYXNlIEN1cnNvcjo6RWFzdFdlc3RS ZXNpemU6Ci0gICAgY2FzZSBDdXJzb3I6Oldlc3RQYW5uaW5nOgogI2lmICFkZWZpbmVkKEJVSUxE SU5HX09OX0xFT1BBUkQpICYmICFkZWZpbmVkKEJVSUxESU5HX09OX1NOT1dfTEVPUEFSRCkKICAg ICAgICAgbV9wbGF0Zm9ybUN1cnNvciA9IHdrQ3Vyc29yKCJSZXNpemVFYXN0V2VzdCIpOwogI2Vs c2UK 182984 2013-01-16 08:11:50 -0800 2013-01-16 09:50:28 -0800 updated version cursor.patch text/plain 1421 avi SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEzOTg4MykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDEzLTAxLTE2ICBBdmkgRHJp c3NtYW4gIDxhdmlAZ29vZ2xlLmNvbT4KKworICAgICAgICBXZXN0LXBhbm5pbmcgY3Vyc29yIGRv ZXMgbm90IG1hdGNoIHJlc2l6ZSBjdXJzb3IsIHVubGlrZSBhbGwgb3RoZXIgZGlyZWN0aW9ucwor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODk0MDUKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBFeGlzdGluZyBt YW51YWwgdGVzdHMuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9tYWMvQ3Vyc29yTWFjLm1tOgorICAg ICAgICAoV2ViQ29yZTo6Q3Vyc29yOjplbnN1cmVQbGF0Zm9ybUN1cnNvcik6CisKIDIwMTMtMDEt MTYgIEFuZHJleSBLb3N5YWtvdiAgPGNhc2VxQGNocm9taXVtLm9yZz4KIAogICAgICAgICBXZWIg SW5zcGVjdG9yOiBjb29raWVzIHdpdGggZW1wdHkgdmFsdWUgYXJlIHBhcnNlZCBpbmNvcnJlY3Rs eQpJbmRleDogU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbWFjL0N1cnNvck1hYy5tbQo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9tYWMvQ3Vyc29yTWFjLm1tCShyZXZpc2lv biAxMzk4ODIpCisrKyBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9tYWMvQ3Vyc29yTWFjLm1tCSh3 b3JraW5nIGNvcHkpCkBAIC0xODcsNiArMTg3LDcgQEAgdm9pZCBDdXJzb3I6OmVuc3VyZVBsYXRm b3JtQ3Vyc29yKCkgY29ucwogICAgICAgICBicmVhazsKIAogICAgIGNhc2UgQ3Vyc29yOjpXZXN0 UmVzaXplOgorICAgIGNhc2UgQ3Vyc29yOjpXZXN0UGFubmluZzoKICNpZiBfX01BQ19PU19YX1ZF UlNJT05fTUlOX1JFUVVJUkVEID49IDEwNzAKICAgICAgICAgbV9wbGF0Zm9ybUN1cnNvciA9IHdr Q3Vyc29yKCJSZXNpemVXZXN0Iik7CiAjZWxzZQpAQCAtMjAzLDcgKzIwNCw2IEBAIHZvaWQgQ3Vy c29yOjplbnN1cmVQbGF0Zm9ybUN1cnNvcigpIGNvbnMKICAgICAgICAgYnJlYWs7CiAKICAgICBj YXNlIEN1cnNvcjo6RWFzdFdlc3RSZXNpemU6Ci0gICAgY2FzZSBDdXJzb3I6Oldlc3RQYW5uaW5n OgogI2lmIF9fTUFDX09TX1hfVkVSU0lPTl9NSU5fUkVRVUlSRUQgPj0gMTA3MAogICAgICAgICBt X3BsYXRmb3JtQ3Vyc29yID0gd2tDdXJzb3IoIlJlc2l6ZUVhc3RXZXN0Iik7CiAjZWxzZQo=