89403 2012-06-18 16:48:02 -0700 The CSS_WRAP_SHAPE CSSWrapShape::Type is no longer needed 2012-06-21 09:37:16 -0700 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 89671 1 giles_joplin giles_joplin cmarcelo macpherson menard webkit.review.bot oldest_to_newest 651873 0 giles_joplin 2012-06-18 16:48:02 -0700 The CSS_WRAP_SHAPE_PATH definition should be removed from CSSWrapShapes.h. It's no longer required by the CSS Exclusions spec - http://dev.w3.org/csswg/css3-exclusions/#shapes. 651879 1 giles_joplin 2012-06-18 16:55:17 -0700 I will upload a patch shortly. 651973 2 148227 giles_joplin 2012-06-18 19:36:25 -0700 Created attachment 148227 Patch 651975 3 webkit.review.bot 2012-06-18 19:40:34 -0700 Attachment 148227 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/ChangeLog:9: Line contains tab character. [whitespace/tab] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 652033 4 148247 giles_joplin 2012-06-18 22:11:35 -0700 Created attachment 148247 Patch 652554 5 148247 eric 2012-06-19 10:14:22 -0700 Comment on attachment 148247 Patch LGTM. 652557 6 148247 webkit.review.bot 2012-06-19 10:16:27 -0700 Comment on attachment 148247 Patch Rejecting attachment 148247 from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1 ERROR: /mnt/git/webkit-commit-queue/Source/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://queues.webkit.org/results/12991034 652570 7 148247 eric 2012-06-19 10:29:31 -0700 Comment on attachment 148247 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=148247&action=review You'll need to upload a new patch or wait until bug 67935 is resolved. :) > Source/WebCore/ChangeLog:5 > + Looks like you remove the Reviewed by Nobody (OOPS!). line which prepare-ChangeLog inserts (and the commit-queue/webkit-patch knows to look for and fill-in when landing patches for you). Without that line, the commit-queue won't work for you. :( Bug 67935 exists to solve this common error. :( Sorry! 652571 8 148247 eric 2012-06-19 10:31:04 -0700 Comment on attachment 148247 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=148247&action=review > Source/WebCore/ChangeLog:1 > +2012-06-18 Hans Muller <hmuller@adobe.com> The ChangeLog should be able to handle ü if your last name actually contains one. :) You might want to chat with Tor Arne Vestø to check the current status of our tools unicode support though. :) 652577 9 148357 giles_joplin 2012-06-19 10:39:05 -0700 Created attachment 148357 Patch 652581 10 giles_joplin 2012-06-19 10:42:23 -0700 Restored the 'Reviewed by NOBODY (OOPS!)' line I'd inadvertently deleted from the ChangeLog. Perfection still eludes me :-). 652857 11 148357 eric 2012-06-19 14:59:52 -0700 Comment on attachment 148357 Patch LGTM. 652901 12 148357 webkit.review.bot 2012-06-19 15:49:34 -0700 Comment on attachment 148357 Patch Clearing flags on attachment: 148357 Committed r120764: <http://trac.webkit.org/changeset/120764> 652902 13 webkit.review.bot 2012-06-19 15:49:40 -0700 All reviewed patches have been landed. Closing bug. 148227 2012-06-18 19:36:25 -0700 2012-06-18 22:11:31 -0700 Patch bug-89403-20120618193643.patch text/plain 1308 giles_joplin U3VidmVyc2lvbiBSZXZpc2lvbjogMTIwNjM2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMTUxZjI5NmQyMzRlNTE2 NWMwN2Q3YTE1M2U2ZTQ0YzdhZjRkZjU5Yi4uOWJiNTk2MDhkN2ExYzRlZGM5MGJjZjYyMzc5ZDI4 NjQ1MjU1YzlmMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDEyLTA2LTE4ICBIYW5z IE11bGxlciAgPGhtdWxsZXJAYWRvYmUuY29tPgorCisgICAgICAgIFRoZSBDU1NfV1JBUF9TSEFQ RSBDU1NXcmFwU2hhcGU6OlR5cGUgaXMgbm8gbG9uZ2VyIG5lZWRlZAorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODk0MDMKKworICAgICAgICBSZW1vdmVk IENTU19XUkFQX1NIQVBFX1BBVEggZGVmaW5pdGlvbiBmcm9tIENTU1dyYXBTaGFwZXMuaC4KKyAg ICAgICAgSXQncyBubyBsb25nZXIgcmVxdWlyZWQuIFRoaXMgZGVmaW5pdGlvbiB3YXMgbmV2ZXIg dXNlZCBvciAKKyAgICAgICAgdGVzdGVkLCBubyBuZXcgdGVzdHMgYXJlIHJlcXVpcmVkLgorCQor ICAgICAgICAqIGNzcy9DU1NXcmFwU2hhcGVzLmg6CisKIDIwMTItMDYtMTggIFpoZW55YW8gTW8g IDx6bW9AZ29vZ2xlLmNvbT4KIAogICAgICAgICBGaXggZnJhbWVidWZmZXItb2JqZWN0LWF0dGFj aG1lbnQuaHRtbCBmYWlsdXJlcwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvY3NzL0NTU1dy YXBTaGFwZXMuaCBiL1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NXcmFwU2hhcGVzLmgKaW5kZXggY2Ez NzI4OWU1YTFkYTE5Njg1NTQxM2FjZjhhNWFjOWQ1ZWJmMmJkNC4uYzg3N2EyNzBmMjQyZGYwNmE1 M2I0ODE2MzNkOTRlNTgwNTc2MGYwZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvY3NzL0NT U1dyYXBTaGFwZXMuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9jc3MvQ1NTV3JhcFNoYXBlcy5oCkBA IC00NCw4ICs0NCw3IEBAIHB1YmxpYzoKICAgICAgICAgQ1NTX1dSQVBfU0hBUEVfUkVDVEFOR0xF ID0gMSwKICAgICAgICAgQ1NTX1dSQVBfU0hBUEVfQ0lSQ0xFID0gMiwKICAgICAgICAgQ1NTX1dS QVBfU0hBUEVfRUxMSVBTRSA9IDMsCi0gICAgICAgIENTU19XUkFQX1NIQVBFX1BPTFlHT04gPSA0 LAotICAgICAgICBDU1NfV1JBUF9TSEFQRV9QQVRIID0gNQorICAgICAgICBDU1NfV1JBUF9TSEFQ RV9QT0xZR09OID0gNAogICAgIH07CiAKICAgICB2aXJ0dWFsIFR5cGUgdHlwZSgpID0gMDsK 148247 2012-06-18 22:11:35 -0700 2012-06-19 10:39:00 -0700 Patch bug-89403-20120618221152.patch text/plain 1306 giles_joplin U3VidmVyc2lvbiBSZXZpc2lvbjogMTIwNjM2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMTUxZjI5NmQyMzRlNTE2 NWMwN2Q3YTE1M2U2ZTQ0YzdhZjRkZjU5Yi4uOTFmNWNjMTdmM2M2OTZlZDIyM2VmNGVhMzgyNDVi YTM2YTg0ZmIxMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDEyLTA2LTE4ICBIYW5z IE11bGxlciAgPGhtdWxsZXJAYWRvYmUuY29tPgorCisgICAgICAgIFRoZSBDU1NfV1JBUF9TSEFQ RSBDU1NXcmFwU2hhcGU6OlR5cGUgaXMgbm8gbG9uZ2VyIG5lZWRlZAorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODk0MDMKKworICAgICAgICBSZW1vdmVk IENTU19XUkFQX1NIQVBFX1BBVEggZGVmaW5pdGlvbiBmcm9tIENTU1dyYXBTaGFwZXMuaC4KKyAg ICAgICAgSXQncyBubyBsb25nZXIgcmVxdWlyZWQuIFRoaXMgZGVmaW5pdGlvbiB3YXMgbmV2ZXIg dXNlZCBvcgorICAgICAgICB0ZXN0ZWQsIG5vIG5ldyB0ZXN0cyBhcmUgcmVxdWlyZWQuCisKKyAg ICAgICAgKiBjc3MvQ1NTV3JhcFNoYXBlcy5oOgorCiAyMDEyLTA2LTE4ICBaaGVueWFvIE1vICA8 em1vQGdvb2dsZS5jb20+CiAKICAgICAgICAgRml4IGZyYW1lYnVmZmVyLW9iamVjdC1hdHRhY2ht ZW50Lmh0bWwgZmFpbHVyZXMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NXcmFw U2hhcGVzLmggYi9Tb3VyY2UvV2ViQ29yZS9jc3MvQ1NTV3JhcFNoYXBlcy5oCmluZGV4IGNhMzcy ODllNWExZGExOTY4NTU0MTNhY2Y4YTVhYzlkNWViZjJiZDQuLmM4NzdhMjcwZjI0MmRmMDZhNTNi NDgxNjMzZDk0ZTU4MDU3NjBmMGQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NX cmFwU2hhcGVzLmgKKysrIGIvU291cmNlL1dlYkNvcmUvY3NzL0NTU1dyYXBTaGFwZXMuaApAQCAt NDQsOCArNDQsNyBAQCBwdWJsaWM6CiAgICAgICAgIENTU19XUkFQX1NIQVBFX1JFQ1RBTkdMRSA9 IDEsCiAgICAgICAgIENTU19XUkFQX1NIQVBFX0NJUkNMRSA9IDIsCiAgICAgICAgIENTU19XUkFQ X1NIQVBFX0VMTElQU0UgPSAzLAotICAgICAgICBDU1NfV1JBUF9TSEFQRV9QT0xZR09OID0gNCwK LSAgICAgICAgQ1NTX1dSQVBfU0hBUEVfUEFUSCA9IDUKKyAgICAgICAgQ1NTX1dSQVBfU0hBUEVf UE9MWUdPTiA9IDQKICAgICB9OwogCiAgICAgdmlydHVhbCBUeXBlIHR5cGUoKSA9IDA7Cg== 148357 2012-06-19 10:39:05 -0700 2012-06-19 15:49:34 -0700 Patch bug-89403-20120619103924.patch text/plain 1345 giles_joplin U3VidmVyc2lvbiBSZXZpc2lvbjogMTIwNjM2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMTUxZjI5NmQyMzRlNTE2 NWMwN2Q3YTE1M2U2ZTQ0YzdhZjRkZjU5Yi4uYmU5OTc4YTFjY2E1NjUyM2U0NGI5N2Q5MjA0NTdj YjI1YzhiZjkzOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEyLTA2LTE5ICBIYW5z IE11bGxlciAgPGhtdWxsZXJAYWRvYmUuY29tPgorCisgICAgICAgIFRoZSBDU1NfV1JBUF9TSEFQ RSBDU1NXcmFwU2hhcGU6OlR5cGUgaXMgbm8gbG9uZ2VyIG5lZWRlZAorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODk0MDMKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBSZW1vdmVkIENTU19XUkFQX1NIQVBFX1BB VEggZGVmaW5pdGlvbiBmcm9tIENTU1dyYXBTaGFwZXMuaC4KKyAgICAgICAgSXQncyBubyBsb25n ZXIgcmVxdWlyZWQuIFRoaXMgZGVmaW5pdGlvbiB3YXMgbmV2ZXIgdXNlZCBvcgorICAgICAgICB0 ZXN0ZWQsIG5vIG5ldyB0ZXN0cyBhcmUgcmVxdWlyZWQuCisKKyAgICAgICAgKiBjc3MvQ1NTV3Jh cFNoYXBlcy5oOgorCiAyMDEyLTA2LTE4ICBaaGVueWFvIE1vICA8em1vQGdvb2dsZS5jb20+CiAK ICAgICAgICAgRml4IGZyYW1lYnVmZmVyLW9iamVjdC1hdHRhY2htZW50Lmh0bWwgZmFpbHVyZXMK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NXcmFwU2hhcGVzLmggYi9Tb3VyY2Uv V2ViQ29yZS9jc3MvQ1NTV3JhcFNoYXBlcy5oCmluZGV4IGNhMzcyODllNWExZGExOTY4NTU0MTNh Y2Y4YTVhYzlkNWViZjJiZDQuLmM4NzdhMjcwZjI0MmRmMDZhNTNiNDgxNjMzZDk0ZTU4MDU3NjBm MGQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NXcmFwU2hhcGVzLmgKKysrIGIv U291cmNlL1dlYkNvcmUvY3NzL0NTU1dyYXBTaGFwZXMuaApAQCAtNDQsOCArNDQsNyBAQCBwdWJs aWM6CiAgICAgICAgIENTU19XUkFQX1NIQVBFX1JFQ1RBTkdMRSA9IDEsCiAgICAgICAgIENTU19X UkFQX1NIQVBFX0NJUkNMRSA9IDIsCiAgICAgICAgIENTU19XUkFQX1NIQVBFX0VMTElQU0UgPSAz LAotICAgICAgICBDU1NfV1JBUF9TSEFQRV9QT0xZR09OID0gNCwKLSAgICAgICAgQ1NTX1dSQVBf U0hBUEVfUEFUSCA9IDUKKyAgICAgICAgQ1NTX1dSQVBfU0hBUEVfUE9MWUdPTiA9IDQKICAgICB9 OwogCiAgICAgdmlydHVhbCBUeXBlIHR5cGUoKSA9IDA7Cg==