89402 2012-06-18 16:43:48 -0700 RenderLayerBacking sometimes doesn't attach scrollbars to graphics layer tree 2012-06-18 20:05:14 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 enne enne enne eric jamesr jchaffraix simon.fraser webkit.review.bot oldest_to_newest 651872 0 enne 2012-06-18 16:43:48 -0700 RenderLayerBacking sometimes doesn't attach scrollbars to graphics layer tree 651907 1 148208 enne 2012-06-18 17:32:38 -0700 Created attachment 148208 Patch 651911 2 enne 2012-06-18 17:34:23 -0700 In some cases, a scrollbar graphics layer gets created in RenderLayerBacking but it doesn't get attached to the graphics layer tree. This causes the scrollbar to disappear. See: http://code.google.com/p/chromium/issues/detail?id=129186 for a test case, or the test included in the first patch above. 651927 3 simon.fraser 2012-06-18 17:51:58 -0700 I don't think it updates scrollbar geometry properly either. 651933 4 enne 2012-06-18 17:55:30 -0700 (In reply to comment #3) > I don't think it updates scrollbar geometry properly either. I'm not sure I see what you're pointing out. Which code are you referring to? 651940 5 simon.fraser 2012-06-18 18:06:00 -0700 Never mind, thinking of another bug that I can't currently find. 651985 6 148208 webkit.review.bot 2012-06-18 20:05:08 -0700 Comment on attachment 148208 Patch Clearing flags on attachment: 148208 Committed r120661: <http://trac.webkit.org/changeset/120661> 651986 7 webkit.review.bot 2012-06-18 20:05:14 -0700 All reviewed patches have been landed. Closing bug. 148208 2012-06-18 17:32:38 -0700 2012-06-18 20:05:08 -0700 Patch bug-89402-20120618173238.patch text/plain 6622 enne U3VidmVyc2lvbiBSZXZpc2lvbjogMTIwNjA4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggODJhYzhmOTBhOWNhNTdk NDE3N2Q0MWY2ODhjM2NkYzFlYjhmZDhhMy4uOWJmZjQyMzdhZWM0ZTk5ODRlNmQxNTg2MzFmOWYx ZDJjMjVmZjljZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDEyLTA2LTE4ICBBZHJp ZW5uZSBXYWxrZXIgIDxlbm5lQGdvb2dsZS5jb20+CisKKyAgICAgICAgUmVuZGVyTGF5ZXJCYWNr aW5nIHNvbWV0aW1lcyBkb2Vzbid0IGF0dGFjaCBzY3JvbGxiYXJzIHRvIGdyYXBoaWNzIGxheWVy IHRyZWUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTg5 NDAyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUmVu ZGVyTGF5ZXJCYWNraW5nIG9ubHkgYXR0YWNoZXMgc2Nyb2xsYmFyIGxheWVycyB0byB0aGUgZ3Jh cGhpY3MKKyAgICAgICAgbGF5ZXIgdHJlZSBpZiB0aGVyZSdzIGEgY2xpcCBsYXllci4gVGhpcyBp cyB3cm9uZywgYmVjYXVzZSB0aGVzZQorICAgICAgICBzY3JvbGxiYXJzIGJlY29tZSBvcnBoYW5z IGFuZCBvdGhlciBjb2RlIGV4cGVjdHMgdGhlbSB0byBoYW5kbGUKKyAgICAgICAgcmVwYWludGlu ZyB0aGUgc2Nyb2xsYmFycyAod2hpY2ggbm93IGJlY29tZSBpbnZpc2libGUpLiBGaXggYnkgYWx3 YXlzCisgICAgICAgIGF0dGFjaGluZyBzY3JvbGxiYXIgbGF5ZXJzLgorCisgICAgICAgIFRlc3Q6 IGNvbXBvc2l0aW5nL292ZXJmbG93L2ltYWdlLWxvYWQtb3ZlcmZsb3ctc2Nyb2xsYmFycy5odG1s CisKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyTGF5ZXJCYWNraW5nLmNwcDoKKyAgICAgICAg KFdlYkNvcmU6OlJlbmRlckxheWVyQmFja2luZzo6dXBkYXRlSW50ZXJuYWxIaWVyYXJjaHkpOgor CiAyMDEyLTA2LTE4ICBNYXJ0aW4gUm9iaW5zb24gIDxtcm9iaW5zb25AaWdhbGlhLmNvbT4KIAog ICAgICAgICBbVGV4dHVyZU1hcHBlcl0gUmVwbGFjZSB0aGUgc291cmNlIHRyYW5zZm9ybSB3aXRo IGEgZmxpcCB1bmlmb3JtCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVu ZGVyTGF5ZXJCYWNraW5nLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXll ckJhY2tpbmcuY3BwCmluZGV4IGVjZDRkNzJhZDljY2ZjNTMxMmE4M2NhMjBjMDBmYWRlZTk5Mjc5 OGQuLmUyZDc3NTdmNWE1MjFmNTdiM2RlZDEyMTBmY2Q5NTljZDJlZWUxMGUgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXllckJhY2tpbmcuY3BwCisrKyBiL1Nv dXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXllckJhY2tpbmcuY3BwCkBAIC02MTAsMjIg KzYxMCwyMiBAQCB2b2lkIFJlbmRlckxheWVyQmFja2luZzo6dXBkYXRlSW50ZXJuYWxIaWVyYXJj aHkoKQogICAgIGlmIChtX2NsaXBwaW5nTGF5ZXIpIHsKICAgICAgICAgbV9jbGlwcGluZ0xheWVy LT5yZW1vdmVGcm9tUGFyZW50KCk7CiAgICAgICAgIG1fZ3JhcGhpY3NMYXllci0+YWRkQ2hpbGQo bV9jbGlwcGluZ0xheWVyLmdldCgpKTsKKyAgICB9CiAKLSAgICAgICAgLy8gVGhlIGNsaXAgZm9y IGNoaWxkIGxheWVycyBkb2VzIG5vdCBpbmNsdWRlIHNwYWNlIGZvciBvdmVyZmxvdyBjb250cm9s cywgc28gdGhleSBleGlzdCBhcwotICAgICAgICAvLyBzaWJsaW5ncyBvZiB0aGUgY2xpcHBpbmcg bGF5ZXIgaWYgd2UgaGF2ZSBvbmUuIE5vcm1hbCBjaGlsZHJlbiBvZiB0aGlzIGxheWVyIGFyZSBz ZXQgYXMKLSAgICAgICAgLy8gY2hpbGRyZW4gb2YgdGhlIGNsaXBwaW5nIGxheWVyLgotICAgICAg ICBpZiAobV9sYXllckZvckhvcml6b250YWxTY3JvbGxiYXIpIHsKLSAgICAgICAgICAgIG1fbGF5 ZXJGb3JIb3Jpem9udGFsU2Nyb2xsYmFyLT5yZW1vdmVGcm9tUGFyZW50KCk7Ci0gICAgICAgICAg ICBtX2dyYXBoaWNzTGF5ZXItPmFkZENoaWxkKG1fbGF5ZXJGb3JIb3Jpem9udGFsU2Nyb2xsYmFy LmdldCgpKTsKLSAgICAgICAgfQotICAgICAgICBpZiAobV9sYXllckZvclZlcnRpY2FsU2Nyb2xs YmFyKSB7Ci0gICAgICAgICAgICBtX2xheWVyRm9yVmVydGljYWxTY3JvbGxiYXItPnJlbW92ZUZy b21QYXJlbnQoKTsKLSAgICAgICAgICAgIG1fZ3JhcGhpY3NMYXllci0+YWRkQ2hpbGQobV9sYXll ckZvclZlcnRpY2FsU2Nyb2xsYmFyLmdldCgpKTsKLSAgICAgICAgfQotICAgICAgICBpZiAobV9s YXllckZvclNjcm9sbENvcm5lcikgewotICAgICAgICAgICAgbV9sYXllckZvclNjcm9sbENvcm5l ci0+cmVtb3ZlRnJvbVBhcmVudCgpOwotICAgICAgICAgICAgbV9ncmFwaGljc0xheWVyLT5hZGRD aGlsZChtX2xheWVyRm9yU2Nyb2xsQ29ybmVyLmdldCgpKTsKLSAgICAgICAgfQorICAgIC8vIFRo ZSBjbGlwIGZvciBjaGlsZCBsYXllcnMgZG9lcyBub3QgaW5jbHVkZSBzcGFjZSBmb3Igb3ZlcmZs b3cgY29udHJvbHMsIHNvIHRoZXkgZXhpc3QgYXMKKyAgICAvLyBzaWJsaW5ncyBvZiB0aGUgY2xp cHBpbmcgbGF5ZXIgaWYgd2UgaGF2ZSBvbmUuIE5vcm1hbCBjaGlsZHJlbiBvZiB0aGlzIGxheWVy IGFyZSBzZXQgYXMKKyAgICAvLyBjaGlsZHJlbiBvZiB0aGUgY2xpcHBpbmcgbGF5ZXIuCisgICAg aWYgKG1fbGF5ZXJGb3JIb3Jpem9udGFsU2Nyb2xsYmFyKSB7CisgICAgICAgIG1fbGF5ZXJGb3JI b3Jpem9udGFsU2Nyb2xsYmFyLT5yZW1vdmVGcm9tUGFyZW50KCk7CisgICAgICAgIG1fZ3JhcGhp Y3NMYXllci0+YWRkQ2hpbGQobV9sYXllckZvckhvcml6b250YWxTY3JvbGxiYXIuZ2V0KCkpOwor ICAgIH0KKyAgICBpZiAobV9sYXllckZvclZlcnRpY2FsU2Nyb2xsYmFyKSB7CisgICAgICAgIG1f bGF5ZXJGb3JWZXJ0aWNhbFNjcm9sbGJhci0+cmVtb3ZlRnJvbVBhcmVudCgpOworICAgICAgICBt X2dyYXBoaWNzTGF5ZXItPmFkZENoaWxkKG1fbGF5ZXJGb3JWZXJ0aWNhbFNjcm9sbGJhci5nZXQo KSk7CisgICAgfQorICAgIGlmIChtX2xheWVyRm9yU2Nyb2xsQ29ybmVyKSB7CisgICAgICAgIG1f bGF5ZXJGb3JTY3JvbGxDb3JuZXItPnJlbW92ZUZyb21QYXJlbnQoKTsKKyAgICAgICAgbV9ncmFw aGljc0xheWVyLT5hZGRDaGlsZChtX2xheWVyRm9yU2Nyb2xsQ29ybmVyLmdldCgpKTsKICAgICB9 CiB9CiAKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0No YW5nZUxvZwppbmRleCAyOTllNjMxNjM1MDExY2Q4ZGI1MDM5OWNkMzliOGY1NmRlZDcxOGM1Li41 MDM2MWYyNDJjZTExZDIxMjg4OGZiNzZkMjhjMGVjMWJlOWMyODM5IDEwMDY0NAotLS0gYS9MYXlv dXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEs MTYgQEAKKzIwMTItMDYtMTggIEFkcmllbm5lIFdhbGtlciAgPGVubmVAZ29vZ2xlLmNvbT4KKwor ICAgICAgICBSZW5kZXJMYXllckJhY2tpbmcgc29tZXRpbWVzIGRvZXNuJ3QgYXR0YWNoIHNjcm9s bGJhcnMgdG8gZ3JhcGhpY3MgbGF5ZXIgdHJlZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODk0MDIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBBZGQgYSB0ZXN0IHdoZXJlIGFuIGltYWdlIGxvYWQgY3JlYXRl cyBvdmVyZmxvdy4KKworICAgICAgICAqIGNvbXBvc2l0aW5nL292ZXJmbG93L2ltYWdlLWxvYWQt b3ZlcmZsb3ctc2Nyb2xsYmFycy1leHBlY3RlZC5wbmc6IEFkZGVkLgorICAgICAgICAqIGNvbXBv c2l0aW5nL292ZXJmbG93L2ltYWdlLWxvYWQtb3ZlcmZsb3ctc2Nyb2xsYmFycy1leHBlY3RlZC50 eHQ6IEFkZGVkLgorICAgICAgICAqIGNvbXBvc2l0aW5nL292ZXJmbG93L2ltYWdlLWxvYWQtb3Zl cmZsb3ctc2Nyb2xsYmFycy5odG1sOiBBZGRlZC4KKwogMjAxMi0wNi0xOCAgU2hlcmlmZiBCb3Qg IDx3ZWJraXQucmV2aWV3LmJvdEBnbWFpbC5jb20+CiAKICAgICAgICAgVW5yZXZpZXdlZCwgcm9s bGluZyBvdXQgcjEyMDU5OC4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2NvbXBvc2l0aW5nL292 ZXJmbG93L2ltYWdlLWxvYWQtb3ZlcmZsb3ctc2Nyb2xsYmFycy1leHBlY3RlZC5wbmcgYi9MYXlv dXRUZXN0cy9jb21wb3NpdGluZy9vdmVyZmxvdy9pbWFnZS1sb2FkLW92ZXJmbG93LXNjcm9sbGJh cnMtZXhwZWN0ZWQucG5nCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLjA3ZjE2YmE5N2MwOWQ3Mzk3OTA5NjIzMDhkNGZj YTdiZjAwZmU4Y2MKR0lUIGJpbmFyeSBwYXRjaApsaXRlcmFsIDI4ODcKemNtZUFTQE4/KG9sSHlg dVZCcSFpYTB5fnlVeyt2WVYyYT5pMCpaKT1oXmhsQSVAV3MkbEhgb2s8bX0/b1RtfTt9CnpRXlM8 eExeREdSdnQqTmBMfnxmKlhrdzYtbDVCMzJXQCg7Y29ZbUVSb1BtTXNybCpUek5YNEFESCNZSiVJ fCNUcwp6LWQ/blJhbWs3fGNiYn5oV2Yjbj5YcUxCb1RZY14pNlReYmZrK3V2QjQ+RFFBNyN3Xk83 I1dVV0dQWWYxLW0mK3kKek99KUtiQH1HUThoTHskOSstZm0obFB7N0paUUYzJHk2XkcjJEEtdTV3 PW88RHtlaihtPGxCSjUhPW5hYk8kWCEkCnozcGdma2YzTitAIW12WTNVV2NKISNzTWFWNCRlXnFe I1duPF5Fcz17ODVuSDM9Iyk3fXZrclg8IU8/SVk0UUZoWApuR1dtdF5Ybz96NVFBME9IejJTWiZB KChTLT9+RTZ+bU5BMjt0RG5te3ItVVd8RVp+OHQKCmxpdGVyYWwgMApIY21WP2QwMDAwMQoKZGlm ZiAtLWdpdCBhL0xheW91dFRlc3RzL2NvbXBvc2l0aW5nL292ZXJmbG93L2ltYWdlLWxvYWQtb3Zl cmZsb3ctc2Nyb2xsYmFycy1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9jb21wb3NpdGluZy9v dmVyZmxvdy9pbWFnZS1sb2FkLW92ZXJmbG93LXNjcm9sbGJhcnMtZXhwZWN0ZWQudHh0Cm5ldyBm aWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAuLjhiMTM3ODkxNzkxZmU5NjkyN2FkNzhlNjRiMGFhZDdiZGVkMDhiZGMKLS0tIC9kZXYv bnVsbAorKysgYi9MYXlvdXRUZXN0cy9jb21wb3NpdGluZy9vdmVyZmxvdy9pbWFnZS1sb2FkLW92 ZXJmbG93LXNjcm9sbGJhcnMtZXhwZWN0ZWQudHh0CkBAIC0wLDAgKzEgQEAKKwpkaWZmIC0tZ2l0 IGEvTGF5b3V0VGVzdHMvY29tcG9zaXRpbmcvb3ZlcmZsb3cvaW1hZ2UtbG9hZC1vdmVyZmxvdy1z Y3JvbGxiYXJzLmh0bWwgYi9MYXlvdXRUZXN0cy9jb21wb3NpdGluZy9vdmVyZmxvdy9pbWFnZS1s b2FkLW92ZXJmbG93LXNjcm9sbGJhcnMuaHRtbApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi4yNzBiOTEzNGRmNDZhZDgw NDNjMTA1ZmY0ODYwZjljMTM3OWNiOGQ5Ci0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMv Y29tcG9zaXRpbmcvb3ZlcmZsb3cvaW1hZ2UtbG9hZC1vdmVyZmxvdy1zY3JvbGxiYXJzLmh0bWwK QEAgLTAsMCArMSw0MCBAQAorPCFET0NUWVBFIGh0bWw+Cis8aHRtbD4KKzxoZWFkPgorPHN0eWxl IHR5cGU9J3RleHQvY3NzJz4KKyAgI292ZXJmbG93IHsKKyAgICBvdmVyZmxvdzphdXRvOworICAg IHdpZHRoOjIwMHB4OworICAgIGhlaWdodDoyMDBweDsKKyAgICAtd2Via2l0LXRyYW5zZm9ybTp0 cmFuc2xhdGVaKDApOworICB9Cis8L3N0eWxlPgorPHNjcmlwdCB0eXBlPSd0ZXh0L2phdmFzY3Jp cHQnPgorICBmdW5jdGlvbiBkb1Rlc3QoKSB7CisgICAgdmFyIGNhbnZhcyA9IGRvY3VtZW50LmNy ZWF0ZUVsZW1lbnQoJ2NhbnZhcycpOworICAgIGNhbnZhcy53aWR0aCA9IDE7CisgICAgY2FudmFz LmhlaWdodCA9IDQwMDsKKyAgICB2YXIgY29udGVudCA9IGRvY3VtZW50LmdldEVsZW1lbnRCeUlk KCJjb250ZW50Iik7CisgICAgY29udGVudC5vbmxvYWQgPSBmdW5jdGlvbigpIHsKKyAgICAgIHZh ciBvdmVyZmxvdyA9IGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCJvdmVyZmxvdyIpOworICAgICAg ICBvdmVyZmxvdy5zY3JvbGxUb3AgPSA1MDsKKyAgICAgICAgaWYgKHdpbmRvdy5sYXlvdXRUZXN0 Q29udHJvbGxlcikKKyAgICAgICAgICBsYXlvdXRUZXN0Q29udHJvbGxlci5ub3RpZnlEb25lKCk7 CisgICAgfQorICAgIGNvbnRlbnQuc3JjID0gY2FudmFzLnRvRGF0YVVSTCgpOworICB9CisgIHdp bmRvdy5hZGRFdmVudExpc3RlbmVyKCdsb2FkJywgZG9UZXN0LCBmYWxzZSk7CisKKyAgaWYgKHdp bmRvdy5sYXlvdXRUZXN0Q29udHJvbGxlcikgeworICAgIGxheW91dFRlc3RDb250cm9sbGVyLndh aXRVbnRpbERvbmUoKTsKKyAgICBsYXlvdXRUZXN0Q29udHJvbGxlci5kdW1wQXNUZXh0KHRydWUp OworICB9Cis8L3NjcmlwdD4KKzwvaGVhZD4KKzxib2R5PgorICA8IS0tIFRoaXMgdGVzdCBwYXNz ZXMgaWYgYSBwYXJ0aWFsbHkgc2Nyb2xsZWQgc2Nyb2xsYmFyIGFwcGVhcnMgLS0+CisgIDxkaXYg aWQ9Im92ZXJmbG93Ij4KKyAgICA8aW1nIGlkPSJjb250ZW50Ij4KKyAgPC9kaXY+Cis8L2JvZHk+ Cis8L2h0bWw+Cg==