89401 2012-06-18 16:31:14 -0700 WebKitTestRunner: textInputController should support methods for dictation 2014-06-23 23:09:37 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Mac Unspecified ASSIGNED P2 Normal --- 42337 1 enrica cfleizach commit-queue oldest_to_newest 651865 0 enrica 2012-06-18 16:31:14 -0700 Need to add the same level of support available in DumpRenderTree. 1017866 1 233686 cfleizach 2014-06-23 23:06:57 -0700 Created attachment 233686 patch 1017868 2 commit-queue 2014-06-23 23:09:33 -0700 Attachment 233686 did not pass style-queue: ERROR: LayoutTests/ChangeLog:8: Need whitespace between colon and description [changelog/filechangedescriptionwhitespace] [5] Total errors found: 1 in 7 files If any of these errors are false positives, please file a bug against check-webkit-style. 1017869 3 233686 cfleizach 2014-06-23 23:09:37 -0700 Comment on attachment 233686 patch wrong bug. sorry 233686 2014-06-23 23:06:57 -0700 2014-06-23 23:09:36 -0700 patch patch text/plain 7067 cfleizach SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE3MDMzMikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIyIEBACisyMDE0LTA2LTIzICBDaHJpcyBG bGVpemFjaCAgPGNmbGVpemFjaEBhcHBsZS5jb20+CisKKyAgICAgICAgQVg6IENyYXNoIGF0IGNv bS5hcHBsZS5XZWJDb3JlOiBXZWJDb3JlOjpBbHRlcm5hdGl2ZVRleHRDb250cm9sbGVyOjpyZW1v dmVEaWN0YXRpb25BbHRlcm5hdGl2ZXNGb3JNYXJrZXIgKyA0MworICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTM0MjI2CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVW5jaGVja2VkIGFjY2VzcyBvZiBkZXRhaWxz IHBvaW50ZXIgaW4gdGhlIERvY3VtZW50IG1hcmtlciBsZWQgdG8gdGhlIGNyYXNoLgorICAgICAg ICBJdCBzZWVtcyBlcnJvbmVvdXMgdG8gYWxsb3cgY3JlYXRpb24gb2YgYSBEb2N1bWVudE1hcmtl ciB3aXRob3V0IGRldGFpbHMgd2hlbiBvbmUgaXMgZXhwZWN0ZWQsIGJlY2F1c2UgaXQKKyAgICAg ICAgY2FycmllcyB0aGUgZGljdGF0aW9uIGNvbnRleHQgKG5vdCBqdXN0IHRoZSBkZXNjcmlwdGlv bikuCisgICAgICAgIEFsc28sIGFkZCBpbiBBU1NFUlRzIHRvIGNhdGNoIHNjZW5hcmlvcyB3aGVy ZSBhIG51bGxwdHIgbWlnaHQgYmUgcGFzc2VkIGluLgorCisgICAgICAgIFRlc3Q6IHBsYXRmb3Jt L21hYy9lZGl0aW5nL2lucHV0L2NyYXNoLWZvci1lbXB0eS10ZXh0LWFsdGVybmF0aXZlLmh0bWwK KworICAgICAgICAqIGRvbS9Eb2N1bWVudE1hcmtlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpE b2N1bWVudE1hcmtlcjo6RG9jdW1lbnRNYXJrZXIpOgorICAgICAgICAqIGVkaXRpbmcvQWx0ZXJu YXRpdmVUZXh0Q29udHJvbGxlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpBbHRlcm5hdGl2ZVRl eHRDb250cm9sbGVyOjpyZW1vdmVEaWN0YXRpb25BbHRlcm5hdGl2ZXNGb3JNYXJrZXIpOgorCiAy MDE0LTA2LTIzICBDb21taXQgUXVldWUgIDxjb21taXQtcXVldWVAd2Via2l0Lm9yZz4KIAogICAg ICAgICBVbnJldmlld2VkLCByb2xsaW5nIG91dCByMTcwMzIzLgpJbmRleDogU291cmNlL1dlYkNv cmUvZWRpdGluZy9BbHRlcm5hdGl2ZVRleHRDb250cm9sbGVyLmNwcAo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBT b3VyY2UvV2ViQ29yZS9lZGl0aW5nL0FsdGVybmF0aXZlVGV4dENvbnRyb2xsZXIuY3BwCShyZXZp c2lvbiAxNzAxNjApCisrKyBTb3VyY2UvV2ViQ29yZS9lZGl0aW5nL0FsdGVybmF0aXZlVGV4dENv bnRyb2xsZXIuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC03MDIsOSArNzAyLDExIEBACiB2b2lkIEFs dGVybmF0aXZlVGV4dENvbnRyb2xsZXI6OnJlbW92ZURpY3RhdGlvbkFsdGVybmF0aXZlc0Zvck1h cmtlcihjb25zdCBEb2N1bWVudE1hcmtlciogbWFya2VyKQogewogI2lmIFVTRShESUNUQVRJT05f QUxURVJOQVRJVkVTKQotICAgIERpY3RhdGlvbk1hcmtlckRldGFpbHMqIGRldGFpbHMgPSBzdGF0 aWNfY2FzdDxEaWN0YXRpb25NYXJrZXJEZXRhaWxzKj4obWFya2VyLT5kZXRhaWxzKCkpOwotICAg IGlmIChBbHRlcm5hdGl2ZVRleHRDbGllbnQqIGNsaWVudCA9IGFsdGVybmF0aXZlVGV4dENsaWVu dCgpKQotICAgICAgICBjbGllbnQtPnJlbW92ZURpY3RhdGlvbkFsdGVybmF0aXZlcyhkZXRhaWxz LT5kaWN0YXRpb25Db250ZXh0KCkpOworICAgIEFTU0VSVChtYXJrZXItPmRldGFpbHMoKSk7Cisg ICAgaWYgKERpY3RhdGlvbk1hcmtlckRldGFpbHMqIGRldGFpbHMgPSBzdGF0aWNfY2FzdDxEaWN0 YXRpb25NYXJrZXJEZXRhaWxzKj4obWFya2VyLT5kZXRhaWxzKCkpKSB7CisgICAgICAgIGlmIChB bHRlcm5hdGl2ZVRleHRDbGllbnQqIGNsaWVudCA9IGFsdGVybmF0aXZlVGV4dENsaWVudCgpKQor ICAgICAgICAgICAgY2xpZW50LT5yZW1vdmVEaWN0YXRpb25BbHRlcm5hdGl2ZXMoZGV0YWlscy0+ ZGljdGF0aW9uQ29udGV4dCgpKTsKKyAgICB9CiAjZWxzZQogICAgIFVOVVNFRF9QQVJBTShtYXJr ZXIpOwogI2VuZGlmCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9kb20vRG9jdW1lbnRNYXJrZXIuY3Bw Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2RvbS9Eb2N1bWVudE1hcmtlci5jcHAJKHJl dmlzaW9uIDE3MDE2MCkKKysrIFNvdXJjZS9XZWJDb3JlL2RvbS9Eb2N1bWVudE1hcmtlci5jcHAJ KHdvcmtpbmcgY29weSkKQEAgLTExMSw4ICsxMTEsOSBAQAogICAgIDogbV90eXBlKHR5cGUpCiAg ICAgLCBtX3N0YXJ0T2Zmc2V0KHN0YXJ0T2Zmc2V0KQogICAgICwgbV9lbmRPZmZzZXQoZW5kT2Zm c2V0KQotICAgICwgbV9kZXRhaWxzKGRlc2NyaXB0aW9uLmlzRW1wdHkoKSA/IDAgOiBEb2N1bWVu dE1hcmtlckRlc2NyaXB0aW9uOjpjcmVhdGUoZGVzY3JpcHRpb24pKQorICAgICwgbV9kZXRhaWxz KERvY3VtZW50TWFya2VyRGVzY3JpcHRpb246OmNyZWF0ZShkZXNjcmlwdGlvbikpCiB7CisgICAg QVNTRVJUKG1fZGV0YWlscyk7CiB9CiAKIERvY3VtZW50TWFya2VyOjpEb2N1bWVudE1hcmtlcih1 bnNpZ25lZCBzdGFydE9mZnNldCwgdW5zaWduZWQgZW5kT2Zmc2V0LCBib29sIGFjdGl2ZU1hdGNo KQpAQCAtMTIxLDYgKzEyMiw3IEBACiAgICAgLCBtX2VuZE9mZnNldChlbmRPZmZzZXQpCiAgICAg LCBtX2RldGFpbHMoRG9jdW1lbnRNYXJrZXJUZXh0TWF0Y2g6Omluc3RhbmNlRm9yKGFjdGl2ZU1h dGNoKSkKIHsKKyAgICBBU1NFUlQobV9kZXRhaWxzKTsKIH0KIAogRG9jdW1lbnRNYXJrZXI6OkRv Y3VtZW50TWFya2VyKE1hcmtlclR5cGUgdHlwZSwgdW5zaWduZWQgc3RhcnRPZmZzZXQsIHVuc2ln bmVkIGVuZE9mZnNldCwgUGFzc1JlZlB0cjxEb2N1bWVudE1hcmtlckRldGFpbHM+IGRldGFpbHMp CkBAIC0xMjksNiArMTMxLDcgQEAKICAgICAsIG1fZW5kT2Zmc2V0KGVuZE9mZnNldCkKICAgICAs IG1fZGV0YWlscyhkZXRhaWxzKQogeworICAgIEFTU0VSVChtX2RldGFpbHMpOwogfQogCiB2b2lk IERvY3VtZW50TWFya2VyOjpzaGlmdE9mZnNldHMoaW50IGRlbHRhKQpJbmRleDogTGF5b3V0VGVz dHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL0NoYW5nZUxvZwkocmV2aXNp b24gMTcwMzMyKQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0x LDMgKzEsMTUgQEAKKzIwMTQtMDYtMjMgIENocmlzIEZsZWl6YWNoICA8Y2ZsZWl6YWNoQGFwcGxl LmNvbT4KKworICAgICAgICBBWDogQ3Jhc2ggYXQgY29tLmFwcGxlLldlYkNvcmU6IFdlYkNvcmU6 OkFsdGVybmF0aXZlVGV4dENvbnRyb2xsZXI6OnJlbW92ZURpY3RhdGlvbkFsdGVybmF0aXZlc0Zv ck1hcmtlciArIDQzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xMzQyMjYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICAqIHBsYXRmb3JtL21hYy13azIvVGVzdEV4cGVjdGF0aW9ucworICAgICAgICAgICAgU2tp cCB0ZXN0IG9uIHdrMiBiZWNhdXNlIGRpY3RhdGlvbiByZWxhdGVkIHRlc3RzIGFyZSBub3QgeWV0 IHN1cHBvcnRlZCAoODk0MDEpCisgICAgICAgICogcGxhdGZvcm0vbWFjL2VkaXRpbmcvaW5wdXQv Y3Jhc2gtZm9yLWVtcHR5LXRleHQtYWx0ZXJuYXRpdmUtZXhwZWN0ZWQudHh0OiBBZGRlZC4KKyAg ICAgICAgKiBwbGF0Zm9ybS9tYWMvZWRpdGluZy9pbnB1dC9jcmFzaC1mb3ItZW1wdHktdGV4dC1h bHRlcm5hdGl2ZS5odG1sOiBBZGRlZC4KKwogMjAxNC0wNi0xOSAgSmVmZnJleSBQZmF1ICA8anBm YXVAYXBwbGUuY29tPgogCiAgICAgICAgIERhdGFiYXNlIHByb2Nlc3MgY3Jhc2hlcyB3aGVuIG11 bHRpcGxlIHRyYW5zYWN0aW9ucyBhdHRlbXB0IHRvIHJ1biBhdCBvbmNlCkluZGV4OiBMYXlvdXRU ZXN0cy9wbGF0Zm9ybS9tYWMvZWRpdGluZy9pbnB1dC9jcmFzaC1mb3ItZW1wdHktdGV4dC1hbHRl cm5hdGl2ZS1leHBlY3RlZC50eHQKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvcGxhdGZvcm0v bWFjL2VkaXRpbmcvaW5wdXQvY3Jhc2gtZm9yLWVtcHR5LXRleHQtYWx0ZXJuYXRpdmUtZXhwZWN0 ZWQudHh0CShyZXZpc2lvbiAwKQorKysgTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjL2VkaXRpbmcv aW5wdXQvY3Jhc2gtZm9yLWVtcHR5LXRleHQtYWx0ZXJuYXRpdmUtZXhwZWN0ZWQudHh0CSh3b3Jr aW5nIGNvcHkpCkBAIC0wLDAgKzEsNiBAQAorRW5zdXJlIHRoYXQgYSBlbXB0eSB0ZXh0IGFsdGVy bmF0aXZlIGRvZXMgbm90IGxlYWQgdG8gYSBjcmFzaAorCitPbiBzdWNjZXNzLCB5b3Ugd2lsbCBz ZWUgYSBzZXJpZXMgb2YgIlBBU1MiIG1lc3NhZ2VzLCBmb2xsb3dlZCBieSAiVEVTVCBDT01QTEVU RSIuCisKK3Rpc2F0ZXN0CitURVNUIENPTVBMRVRFCkluZGV4OiBMYXlvdXRUZXN0cy9wbGF0Zm9y bS9tYWMvZWRpdGluZy9pbnB1dC9jcmFzaC1mb3ItZW1wdHktdGV4dC1hbHRlcm5hdGl2ZS5odG1s Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL3BsYXRmb3JtL21hYy9lZGl0aW5nL2lucHV0L2Ny YXNoLWZvci1lbXB0eS10ZXh0LWFsdGVybmF0aXZlLmh0bWwJKHJldmlzaW9uIDApCisrKyBMYXlv dXRUZXN0cy9wbGF0Zm9ybS9tYWMvZWRpdGluZy9pbnB1dC9jcmFzaC1mb3ItZW1wdHktdGV4dC1h bHRlcm5hdGl2ZS5odG1sCSh3b3JraW5nIGNvcHkpCkBAIC0wLDAgKzEsNDcgQEAKKzxodG1sPgor PGhlYWQ+Cis8c2NyaXB0IHNyYz0iLi4vLi4vLi4vLi4vZWRpdGluZy9lZGl0aW5nLmpzIiBsYW5n dWFnZT0iSmF2YVNjcmlwdCIgdHlwZT0idGV4dC9KYXZhU2NyaXB0IiA+PC9zY3JpcHQ+Cis8c2Ny aXB0IHNyYz0iLi4vLi4vLi4vLi4vcmVzb3VyY2VzL2pzLXRlc3QtcHJlLmpzIj48L3NjcmlwdD4K KworPHN0eWxlPgorYm9keSB7IG1hcmdpbjogMDsgcGFkZGluZzogMCB9Cis8L3N0eWxlPgorPC9o ZWFkPgorPGJvZHk+Cis8cHJlIGlkPSJkZXNjcmlwdGlvbiI+PC9wcmU+Cis8ZGl2IGlkPSJ0ZXN0 IiBjb250ZW50ZWRpdGFibGU+dGhpc2lzYXRlc3Q8L2Rpdj4KKzxwIGlkPSJjb25zb2xlIj48L3A+ Cis8c2NyaXB0IHR5cGU9InRleHQvamF2YXNjcmlwdCI+CisgICAgZGVzY3JpcHRpb24oIkVuc3Vy ZSB0aGF0IGEgZW1wdHkgdGV4dCBhbHRlcm5hdGl2ZSBkb2VzIG5vdCBsZWFkIHRvIGEgY3Jhc2gi KTsKKworICAgIAorICAgIGlmICh3aW5kb3cudGVzdFJ1bm5lcikgeworICAgICAgICAKKyAgICAg ICAgdHJ5IHsKKworICAgICAgICAgICAgZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoInRlc3QiKS5m b2N1cygpOworCisgICAgICAgICAgICBtb3ZlU2VsZWN0aW9uRm9yd2FyZEJ5Q2hhcmFjdGVyQ29t bWFuZCgpOworICAgICAgICAgICAgbW92ZVNlbGVjdGlvbkZvcndhcmRCeUNoYXJhY3RlckNvbW1h bmQoKTsKKworICAgICAgICAgICAgdmFyIGRpY3RhdGVkU3RyaW5nID0gdGV4dElucHV0Q29udHJv bGxlci5tYWtlRGljdGF0ZWRTdHJpbmcoIiAiLCAiICIsIDAsIDEpOworICAgICAgICAgICAgdGV4 dElucHV0Q29udHJvbGxlci5pbnNlcnRUZXh0KGRpY3RhdGVkU3RyaW5nKTsKKworICAgICAgICAg ICAgbW92ZVNlbGVjdGlvbkZvcndhcmRCeUNoYXJhY3RlckNvbW1hbmQoKTsKKyAgICAgICAgICAg IG1vdmVTZWxlY3Rpb25Gb3J3YXJkQnlDaGFyYWN0ZXJDb21tYW5kKCk7CisKKyAgICAgICAgICAg IGZvciAoIHZhciBrID0gMDsgayA8IDQ7IGsrKykgeworICAgICAgICAgICAgICAgIHRleHRJbnB1 dENvbnRyb2xsZXIuZG9Db21tYW5kKCJkZWxldGVCYWNrd2FyZDoiKTsKKyAgICAgICAgICAgIH0K KworICAgICAgICAgICAgZG9jdW1lbnQud3JpdGUoIlRFU1QgQ09NUExFVEUiKTsKKworICAgICAg ICB9IGNhdGNoIChleCkgeworICAgICAgICAgICAgZG9jdW1lbnQud3JpdGUoIkV4Y2VwdGlvbjog IiArIGV4LmRlc2NyaXB0aW9uKTsKKyAgICAgICAgfQorICAgIH0gZWxzZSB7CisgICAgICAgIGRv Y3VtZW50LndyaXRlKCIoY2Fubm90IHJ1biBpbnRlcmFjdGl2ZWx5KSIpOworICAgIH0KKzwvc2Ny aXB0PgorPC9ib2R5PgorPC9odG1sPgpJbmRleDogTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjLXdr Mi9UZXN0RXhwZWN0YXRpb25zCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL3BsYXRmb3JtL21h Yy13azIvVGVzdEV4cGVjdGF0aW9ucwkocmV2aXNpb24gMTcwMTYwKQorKysgTGF5b3V0VGVzdHMv cGxhdGZvcm0vbWFjLXdrMi9UZXN0RXhwZWN0YXRpb25zCSh3b3JraW5nIGNvcHkpCkBAIC0xODQs NiArMTg0LDcgQEAKICMgTWlzc2luZyBmdW5jdGlvbmFsaXR5IG9mIHRleHRJbnB1dENvbnRyb2xs ZXIKICMgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTg5NDAxCiBwbGF0 Zm9ybS9tYWMvZWRpdGluZy9pbnB1dC9pbnNlcnQtZGljdGF0ZWQtdGV4dC5odG1sCitwbGF0Zm9y bS9tYWMvZWRpdGluZy9pbnB1dC9jcmFzaC1mb3ItZW1wdHktdGV4dC1hbHRlcm5hdGl2ZS5odG1s CiBwbGF0Zm9ybS9tYWMvZWRpdGluZy9pbnB1dC9lZGl0LWRpY3RhdGVkLXRleHQtd2l0aC1hbHRl cm5hdGl2ZS5odG1sCiBwbGF0Zm9ybS9tYWMvZWRpdGluZy9hdHRyaWJ1dGVkLXN0cmluZy8KIAo=