89392 2012-06-18 15:28:41 -0700 [Chromium] Notify the embedder when the page scale changes 2012-09-12 16:42:26 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED LATER P2 Normal --- 66687 1 abarth abarth aelias dglazkov fishd jamesr japhet klobag tkent+wkapi trchen webkit.review.bot oldest_to_newest 651805 0 abarth 2012-06-18 15:28:41 -0700 [Chromium] Notify the embedder when the page scale changes 651811 1 148188 abarth 2012-06-18 15:32:45 -0700 Created attachment 148188 Patch 651812 2 abarth 2012-06-18 15:33:52 -0700 I'm not really sure what this is used for, but it's in the chromium-android branch. trchen might know. 651813 3 webkit.review.bot 2012-06-18 15:37:28 -0700 Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI. 651862 4 148188 jamesr 2012-06-18 16:28:22 -0700 Comment on attachment 148188 Patch What's this for? I wouldn't expect that the embedder needs to know about the page scale factor, generally speaking. 651877 5 abarth 2012-06-18 16:54:01 -0700 If trchen doesn't know off-hand, I can do some more digging in the chromium-android branch to try to find out. 651881 6 jamesr 2012-06-18 16:56:55 -0700 If you can search for callers on the chromium and figure out what they are doing that would be super useful. 651883 7 abarth 2012-06-18 17:04:04 -0700 > If you can search for callers on the chromium and figure out what they are doing that would be super useful. I gets routed up to the browser process and then out to Java. Once in Java, it looks like it's used to update some UI controls for zooming. Maybe there's a scale (like on a map) that shows you how zoomed in you are, possibly relative to what min and max zooms are available? I don't read Java UI code very well. 651885 8 148188 jamesr 2012-06-18 17:07:07 -0700 Comment on attachment 148188 Patch That sounds like a UI that was abandoned a while ago for page zoom - let's get some confirmation about whether this code is still alive or not before adding it. 651886 9 abarth 2012-06-18 17:08:20 -0700 @trchen: Do we still need these notifications? 656187 10 abarth 2012-06-24 01:53:41 -0700 I will attempt to remove this notification from the chromium-android branch to see if folks are still using it. 659794 11 148188 abarth 2012-06-28 13:58:10 -0700 Comment on attachment 148188 Patch I put on my Java thinking cap and figure out what this actually does. It lets the UI keep track of how much page scaling is possible so that it can properly react to various pinch-like gestures. It's also used by the browser UI to adjust the size of various overly elements to scale them commensurate with the page. 661732 12 148188 abarth 2012-07-02 14:43:12 -0700 Comment on attachment 148188 Patch jamesr and I spoke about this patch at length. The approach in this patch isn't great because this patch essentially creates to notification paths for the page scale information to reach the browser's UI thread: 1) These callbacks. 2) The images drawn by the compositor. Having two asynchronous notification paths is problematic because the messages arriving on these two paths will be inconsistent and lead to janky UI. At a better approach is to send this information along the compositor's notification path so that it is synchronized with the images actually being displayed by the compositor. James recommends looking at WebCompositorInputHandler and WebCompositorInputHandlerClient to see how we might follow that approach. 661783 13 trchen 2012-07-02 15:49:23 -0700 (In reply to comment #12) > (From update of attachment 148188 [details]) > jamesr and I spoke about this patch at length. The approach in this patch isn't great because this patch essentially creates to notification paths for the page scale information to reach the browser's UI thread: > > 1) These callbacks. > 2) The images drawn by the compositor. > > Having two asynchronous notification paths is problematic because the messages arriving on these two paths will be inconsistent and lead to janky UI. At a better approach is to send this information along the compositor's notification path so that it is synchronized with the images actually being displayed by the compositor. > > James recommends looking at WebCompositorInputHandler and WebCompositorInputHandlerClient to see how we might follow that approach. In the case of Android, even if we send all these notification from the compositor thread it still won't be synchronous with the rendered images, as the GL commands go through the command buffer pipeline... In our downstream code we used to add a GL extension to pass frame information along with swap buffers, which was essential for glitch-free mixed-mode scrolling. It was later removed with the deprecation of mixed-mode. We deemed that async message is good enough for our use (and synchronous message is expensive). For the long term I think we want to move all the rendering logic of extra decorations (mainly text selection handles) to the compositor so we don't have to deal with scale factor mess from the browser side. Do we still need these IPCs? I'm not very sure. They might still be useful to handle WebView properties from 3rd-party WebView users, but don't quote me on that. Let me add aelias@ and klobag@ to the thread for more inputs. 661831 14 abarth 2012-07-02 17:22:29 -0700 I believe they're needed for some of the WebView APIs, such as canZoomIn(). 661879 15 aelias 2012-07-02 19:02:14 -0700 The latest plan is to bundle this data with ubercompositor frames. Clank is moving to ubercompositor and we recently figured out that to support WebView child views in particular, we'll need accurate, frame-synchronized scroll offset and page scale information for the root layer. So we can delete these lines. 148188 2012-06-18 15:32:45 -0700 2012-07-02 14:43:11 -0700 Patch bug-89392-20120618153245.patch text/plain 3626 abarth SW5kZXg6IFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNv dXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCShyZXZpc2lvbiAxMjA2MzUpCisrKyBTb3Vy Y2UvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIw IEBACisyMDEyLTA2LTE4ICBBZGFtIEJhcnRoICA8YWJhcnRoQHdlYmtpdC5vcmc+CisKKyAgICAg ICAgW0Nocm9taXVtXSBOb3RpZnkgdGhlIGVtYmVkZGVyIHdoZW4gdGhlIHBhZ2Ugc2NhbGUgY2hh bmdlcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODkz OTIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHB1 YmxpYy9XZWJGcmFtZUNsaWVudC5oOgorICAgICAgICAoV2ViRnJhbWVDbGllbnQpOgorICAgICAg ICAoV2ViS2l0OjpXZWJGcmFtZUNsaWVudDo6ZGlkQ2hhbmdlUGFnZVNjYWxlKToKKyAgICAgICAg KiBwdWJsaWMvV2ViVmlld0NsaWVudC5oOgorICAgICAgICAoV2ViVmlld0NsaWVudCk6CisgICAg ICAgIChXZWJLaXQ6OldlYlZpZXdDbGllbnQ6OmRpZENoYW5nZVBhZ2VTY2FsZUZhY3RvckxpbWl0 cyk6CisgICAgICAgICogc3JjL1dlYlZpZXdJbXBsLmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2Vi Vmlld0ltcGw6OnNldFBhZ2VTY2FsZUZhY3Rvcik6CisgICAgICAgIChXZWJLaXQ6OldlYlZpZXdJ bXBsOjpjb21wdXRlUGFnZVNjYWxlRmFjdG9yTGltaXRzKToKKwogMjAxMi0wNi0xOCAgSWFuIFZv bGxpY2sgIDx2b2xsaWNrQGNocm9taXVtLm9yZz4KIAogICAgICAgICBbY2hyb21pdW1dIEVuc3Vy ZSB0aGF0IHNraXBwaW5nIGZyYW1lcyBkdXJpbmcgYW4gYWNjZWxlcmF0ZWQgYW5pbWF0aW9uIGRv ZXNuJ3QgY2F1c2Ugc3RhcnZhdGlvbgpJbmRleDogU291cmNlL1dlYktpdC9jaHJvbWl1bS9wdWJs aWMvV2ViRnJhbWVDbGllbnQuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0L2Nocm9taXVt L3B1YmxpYy9XZWJGcmFtZUNsaWVudC5oCShyZXZpc2lvbiAxMjA2MTYpCisrKyBTb3VyY2UvV2Vi S2l0L2Nocm9taXVtL3B1YmxpYy9XZWJGcmFtZUNsaWVudC5oCSh3b3JraW5nIGNvcHkpCkBAIC0z MTQsNiArMzE0LDggQEAgcHVibGljOgogICAgIC8vIFRoZSBtYWluIGZyYW1lIHNjcm9sbGVkLgog ICAgIHZpcnR1YWwgdm9pZCBkaWRDaGFuZ2VTY3JvbGxPZmZzZXQoV2ViRnJhbWUqKSB7IH0KIAor ICAgIC8vIFRoZSBwYWdlIHNjYWxlIGNoYW5nZWQuCisgICAgdmlydHVhbCB2b2lkIGRpZENoYW5n ZVBhZ2VTY2FsZShXZWJGcmFtZSopIHsgfQogCiAgICAgLy8gRmluZC1pbi1wYWdlIG5vdGlmaWNh dGlvbnMgLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tCiAKSW5kZXg6 IFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYlZpZXdDbGllbnQuaAo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBTb3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJWaWV3Q2xpZW50LmgJKHJldmlz aW9uIDEyMDYxNikKKysrIFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYlZpZXdDbGll bnQuaAkod29ya2luZyBjb3B5KQpAQCAtMTM1LDYgKzEzNSw5IEBAIHB1YmxpYzoKICAgICAvLyBD YWxsZWQgdG8gcmV0cmlldmUgdGhlIHByb3ZpZGVyIG9mIGRlc2t0b3Agbm90aWZpY2F0aW9ucy4K ICAgICB2aXJ0dWFsIFdlYk5vdGlmaWNhdGlvblByZXNlbnRlciogbm90aWZpY2F0aW9uUHJlc2Vu dGVyKCkgeyByZXR1cm4gMDsgfQogCisgICAgLy8gRGlkIHJlY2VpdmUgdGhlIHZpZXdwb3J0IG1l dGEgdGFnLgorICAgIHZpcnR1YWwgdm9pZCBkaWRDaGFuZ2VQYWdlU2NhbGVGYWN0b3JMaW1pdHMo ZmxvYXQgbWluUGFnZVNjYWxlRmFjdG9yLCBmbG9hdCBtYXhQYWdlU2NhbGVGYWN0b3IpIHsgfQor CiAgICAgLy8gQ2FsbGVkIHRvIHJlcXVlc3QgYW4gaWNvbiBmb3IgdGhlIHNwZWNpZmllZCBmaWxl bmFtZXMuCiAgICAgLy8gVGhlIGljb24gaXMgc2hvd24gaW4gYSBmaWxlIHVwbG9hZCBjb250cm9s LgogICAgIHZpcnR1YWwgYm9vbCBxdWVyeUljb25Gb3JGaWxlcyhjb25zdCBXZWJWZWN0b3I8V2Vi U3RyaW5nPiYgZmlsZW5hbWVzLCBXZWJJY29uTG9hZGluZ0NvbXBsZXRpb24qKSB7IHJldHVybiBm YWxzZTsgfQpJbmRleDogU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViVmlld0ltcGwuY3Bw Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYlZpZXdJbXBsLmNw cAkocmV2aXNpb24gMTIwNjE2KQorKysgU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViVmll d0ltcGwuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xMjcsNiArMTI3LDcgQEAKICNpbmNsdWRlICJX ZWJDb21wb3NpdG9ySW1wbC5oIgogI2luY2x1ZGUgIldlYkRldlRvb2xzQWdlbnRJbXBsLmgiCiAj aW5jbHVkZSAiV2ViRGV2VG9vbHNBZ2VudFByaXZhdGUuaCIKKyNpbmNsdWRlICJXZWJGcmFtZUNs aWVudC5oIgogI2luY2x1ZGUgIldlYkZyYW1lSW1wbC5oIgogI2luY2x1ZGUgIldlYkhlbHBlclBs dWdpbkltcGwuaCIKICNpbmNsdWRlICJXZWJJbnB1dEVsZW1lbnQuaCIKQEAgLTI0NjMsNiArMjQ2 NCw3IEBAIHZvaWQgV2ViVmlld0ltcGw6OnNldFBhZ2VTY2FsZUZhY3RvcihmbG8KICAgICBXZWJQ b2ludCBjbGFtcGVkT3JpZ2luID0gY2xhbXBPZmZzZXRBdFNjYWxlKG9yaWdpbiwgc2NhbGVGYWN0 b3IpOwogICAgIHBhZ2UoKS0+c2V0UGFnZVNjYWxlRmFjdG9yKHNjYWxlRmFjdG9yLCBjbGFtcGVk T3JpZ2luKTsKICAgICBtX3BhZ2VTY2FsZUZhY3RvcklzU2V0ID0gdHJ1ZTsKKyAgICBtYWluRnJh bWVJbXBsKCktPmNsaWVudCgpLT5kaWRDaGFuZ2VQYWdlU2NhbGUobWFpbkZyYW1lSW1wbCgpKTsK IH0KIAogZmxvYXQgV2ViVmlld0ltcGw6OmRldmljZVNjYWxlRmFjdG9yKCkgY29uc3QKQEAgLTI1 NjQsNiArMjU2Niw3IEBAIGJvb2wgV2ViVmlld0ltcGw6OmNvbXB1dGVQYWdlU2NhbGVGYWN0b3IK ICAgICAgICAgbV9tYXhpbXVtUGFnZVNjYWxlRmFjdG9yID0gbWF4KG1fbWluaW11bVBhZ2VTY2Fs ZUZhY3RvciwgbV9tYXhpbXVtUGFnZVNjYWxlRmFjdG9yKTsKICAgICB9CiAgICAgQVNTRVJUKG1f bWluaW11bVBhZ2VTY2FsZUZhY3RvciA8PSBtX21heGltdW1QYWdlU2NhbGVGYWN0b3IpOworICAg IG1fY2xpZW50LT5kaWRDaGFuZ2VQYWdlU2NhbGVGYWN0b3JMaW1pdHMobV9taW5pbXVtUGFnZVNj YWxlRmFjdG9yLCBtX21heGltdW1QYWdlU2NhbGVGYWN0b3IpOwogCiAgICAgZmxvYXQgY2xhbXBl ZFNjYWxlID0gY2xhbXBQYWdlU2NhbGVGYWN0b3JUb0xpbWl0cyhwYWdlU2NhbGVGYWN0b3IoKSk7 CiAjaWYgVVNFKEFDQ0VMRVJBVEVEX0NPTVBPU0lUSU5HKQo=