89362 2012-06-18 10:56:51 -0700 [garden-o-matic] Builder names without underscores cause incorrect BuildSelector behavior 2012-06-18 12:04:01 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 zan zan abarth dglazkov simon.fraser webkit.review.bot oldest_to_newest 651535 0 zan 2012-06-18 10:56:51 -0700 Builder names without underscores cause the BuildSelector object to not store the containers in the proper way, displaying all the containers instead of just the one the selected tab is linked with. An example of this is when viewing results for the Apple builders - the container id and hash that's used in the associated tab are just encoded as URI components (the result of the current platform's resultsDirectoryNameFromBuilderName method), which doesn't work. Chromium doesn't have such problems as the builders' results directories are already replacing whitespace, braces and dots with underscores. JQuery documentation[1] suggests something similar. I think it's safe to convert whitespace, braces and dots to underscores for every builder name in ui.results.BuilderSelector.init and use that to link the container with the associated tab. [1] - http://docs.jquery.com/UI/Tabs#Ajax_mode 651542 1 simon.fraser 2012-06-18 11:05:27 -0700 I'm not quite following how to see the actual bug in the garden-o-matic UI. 651543 2 148130 zan 2012-06-18 11:06:03 -0700 Created attachment 148130 Patch 651546 3 148130 simon.fraser 2012-06-18 11:10:49 -0700 Comment on attachment 148130 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=148130&action=review > Tools/ChangeLog:12 > + (.): Remove this. > Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:370 > + var builderHash = builderName.replace(/[ .()]/g, '_'); This looks very similar to config.resultsDirectoryNameFromBuilderName() for chromium. Maybe put a function in base and call it in both places. 651606 4 zan 2012-06-18 12:04:01 -0700 (In reply to comment #3) > > Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:370 > > + var builderHash = builderName.replace(/[ .()]/g, '_'); > > This looks very similar to config.resultsDirectoryNameFromBuilderName() for chromium. Maybe put a function in base and call it in both places. Created base.underscoredBuilderName. Committed http://trac.webkit.org/changeset/120614. 148130 2012-06-18 11:06:03 -0700 2012-06-18 11:10:49 -0700 Patch bug-89362-20120618200603.patch text/plain 2366 zan U3VidmVyc2lvbiBSZXZpc2lvbjogMTIwNjAyCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggZTFlODc3Y2IxNDBhZjFkYTJiOThlNzUwNTNhYmQxMzg4 ZmMzYTI3My4uNmNmNzEwYjQzNTA2M2VhODFlOTYzZTMzNTE2NzRmYjc2ODAzMzU2OSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2 IEBACisyMDEyLTA2LTE4ICBaYW4gRG9iZXJzZWsgIDx6YW5kb2JlcnNla0BnbWFpbC5jb20+CisK KyAgICAgICAgW2dhcmRlbi1vLW1hdGljXSBCdWlsZGVyIG5hbWVzIHdpdGhvdXQgdW5kZXJzY29y ZXMgY2F1c2UgaW5jb3JyZWN0IEJ1aWxkU2VsZWN0b3IgYmVoYXZpb3IKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTg5MzYyCisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUmVwbGFjZSB3aGl0ZSBzcGFjZXMsIGJy YWNlcyBhbmQgZG90cyBpbiB0aGUgYnVpbGRlciBuYW1lIHdpdGggdW5kZXJzY29yZXMuIFRoaXMK KyAgICAgICAgd2F5IHRoZSBKUXVlcnkgdGFicyB3aWxsIGJlIHByb3Blcmx5IG1hdGNoZWQgd2l0 aCB0aGUgYWNjb3JkaW5nIGNvbnRhaW5lci4KKworICAgICAgICAqIEJ1aWxkU2xhdmVTdXBwb3J0 L2J1aWxkLndlYmtpdC5vcmctY29uZmlnL3B1YmxpY19odG1sL1Rlc3RGYWlsdXJlcy9zY3JpcHRz L3VpL3Jlc3VsdHMuanM6CisgICAgICAgICguKToKKwogMjAxMi0wNi0xOCAgTWFyaW8gU2FuY2hl eiBQcmFkYSAgPG1zYW5jaGV6QGlnYWxpYS5jb20+CiAKICAgICAgICAgW0dUS10gR2V0IHJpZCBv ZiBEdW1wUmVuZGVyVHJlZVN1cHBvcnRHdGs6OntpbnxkZX1jcmVtZW50QWNjZXNzaWJpbGl0eVZh bHVlCmRpZmYgLS1naXQgYS9Ub29scy9CdWlsZFNsYXZlU3VwcG9ydC9idWlsZC53ZWJraXQub3Jn LWNvbmZpZy9wdWJsaWNfaHRtbC9UZXN0RmFpbHVyZXMvc2NyaXB0cy91aS9yZXN1bHRzLmpzIGIv VG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvYnVpbGQud2Via2l0Lm9yZy1jb25maWcvcHVibGljX2h0 bWwvVGVzdEZhaWx1cmVzL3NjcmlwdHMvdWkvcmVzdWx0cy5qcwppbmRleCA2ZWYxZjQ4YjJmYzg4 ZmIzZTRkZTcxNjk3ZThkNDI3NzI2YjA1NTRlLi5kY2NmMTQ3MGVkMzM3NDQ2YWI2NTM4OGQ1ZDYy NjAxMzJkYmUzNjRlIDEwMDY0NAotLS0gYS9Ub29scy9CdWlsZFNsYXZlU3VwcG9ydC9idWlsZC53 ZWJraXQub3JnLWNvbmZpZy9wdWJsaWNfaHRtbC9UZXN0RmFpbHVyZXMvc2NyaXB0cy91aS9yZXN1 bHRzLmpzCisrKyBiL1Rvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29u ZmlnL3B1YmxpY19odG1sL1Rlc3RGYWlsdXJlcy9zY3JpcHRzL3VpL3Jlc3VsdHMuanMKQEAgLTM2 NywxNCArMzY3LDE0IEBAIHVpLnJlc3VsdHMuQnVpbGRlclNlbGVjdG9yID0gYmFzZS5leHRlbmRz KCdkaXYnLCB7CiAgICAgICAgIHZhciB0YWJTdHJpcCA9IHRoaXMuYXBwZW5kQ2hpbGQoZG9jdW1l bnQuY3JlYXRlRWxlbWVudCgndWwnKSk7CiAKICAgICAgICAgT2JqZWN0LmtleXMocmVzdWx0c0J5 QnVpbGRlcikuc29ydCgpLmZvckVhY2goZnVuY3Rpb24oYnVpbGRlck5hbWUpIHsKLSAgICAgICAg ICAgIHZhciBidWlsZGVyRGlyZWN0b3J5ID0gcmVzdWx0cy5kaXJlY3RvcnlGb3JCdWlsZGVyKGJ1 aWxkZXJOYW1lKTsKKyAgICAgICAgICAgIHZhciBidWlsZGVySGFzaCA9IGJ1aWxkZXJOYW1lLnJl cGxhY2UoL1sgLigpXS9nLCAnXycpOwogCiAgICAgICAgICAgICB2YXIgbGluayA9IGRvY3VtZW50 LmNyZWF0ZUVsZW1lbnQoJ2EnKTsKLSAgICAgICAgICAgICQobGluaykuYXR0cignaHJlZicsICIj IiArIGJ1aWxkZXJEaXJlY3RvcnkpLnRleHQodWkuZGlzcGxheU5hbWVGb3JCdWlsZGVyKGJ1aWxk ZXJOYW1lKSk7CisgICAgICAgICAgICAkKGxpbmspLmF0dHIoJ2hyZWYnLCAiIyIgKyBidWlsZGVy SGFzaCkudGV4dCh1aS5kaXNwbGF5TmFtZUZvckJ1aWxkZXIoYnVpbGRlck5hbWUpKTsKICAgICAg ICAgICAgIHRhYlN0cmlwLmFwcGVuZENoaWxkKGRvY3VtZW50LmNyZWF0ZUVsZW1lbnQoJ2xpJykp LmFwcGVuZENoaWxkKGxpbmspOwogCiAgICAgICAgICAgICB2YXIgY29udGVudCA9IHRoaXMuX2Rl bGVnYXRlLmNvbnRlbnRGb3JUZXN0QW5kQnVpbGRlcih0ZXN0TmFtZSwgYnVpbGRlck5hbWUpOwot ICAgICAgICAgICAgY29udGVudC5pZCA9IGJ1aWxkZXJEaXJlY3Rvcnk7CisgICAgICAgICAgICBj b250ZW50LmlkID0gYnVpbGRlckhhc2g7CiAgICAgICAgICAgICB0aGlzLmFwcGVuZENoaWxkKGNv bnRlbnQpOwogICAgICAgICB9LCB0aGlzKTsKIAo=