89332 2012-06-17 23:56:50 -0700 REGRESSION(r120546): It made 3 webkitpy tests fail 2012-06-18 13:07:08 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 84642 1 ossy zan abarth cdumez dpranke ojan simon.fraser webkit.review.bot zan oldest_to_newest 651205 0 ossy 2012-06-17 23:56:50 -0700 It broke 3 webkitpy tests. Could you check it, please? ================================================================================ FAILURE: webkitpy.common.checkout.baselineoptimizer_unittest.BaselineOptimizerTest.test_complex_shadowing -------------------------------------------------------------------------------- Traceback (most recent call last): File "/ramdisk/qt-linux-release/build/Tools/Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py", line 169, in test_complex_shadowing 'LayoutTests/platform/chromium-linux': 'f52fcdde9e4be8bd5142171cd859230bd4471036' File "/ramdisk/qt-linux-release/build/Tools/Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py", line 53, in _assertOptimization self.assertEqual(new_results_by_directory, expected_new_results_by_directory) AssertionError: {'LayoutTests/platform/chromium-win': '462d03b9c025db1b0392d7453310dbee5f9a9e74', 'LayoutTests/platform/mac': '5daa78e55f05d9f0d1bb1f32b0cd1bc3a01e9364', 'LayoutTests/platform/win-xp': '5b1253ef4d5094530d5f1bc6cdb95c90b446bec7', 'LayoutTests/platform/chromium-win-xp': '462d03b9c025db1b0392d7453310dbee5f9a9e74', 'LayoutTests/platform/chromium-mac-leopard': '65e7d42f8b4882b29d46dc77bb879dd41bc074dc', 'LayoutTests/platform/chromium-win-vista': 'f83af9732ce74f702b8c9c4a3d9a4c6636b8d3bd', 'LayoutTests/platform/chromium-linux': 'f52fcdde9e4be8bd5142171cd859230bd4471036'} != {'LayoutTests/platform/mac-leopard': '7ad045ece7c030e2283c5d21d9587be22bcba56e', 'LayoutTests/platform/chromium-win-vista': 'f83af9732ce74f702b8c9c4a3d9a4c6636b8d3bd', 'LayoutTests/platform/chromium-win': '462d03b9c025db1b0392d7453310dbee5f9a9e74', 'LayoutTests/platform/mac': '5daa78e55f05d9f0d1bb1f32b0cd1bc3a01e9364', 'LayoutTests/platform/win': '5b1253ef4d5094530d5f1bc6cdb95c90b446bec7', 'LayoutTests/platform/chromium-linux': 'f52fcdde9e4be8bd5142171cd859230bd4471036', 'LayoutTests/platform/chromium-win-xp': '462d03b9c025db1b0392d7453310dbee5f9a9e74', 'LayoutTests/platform/chromium-mac-leopard': '65e7d42f8b4882b29d46dc77bb879dd41bc074dc'} ================================================================================ FAILURE: webkitpy.common.checkout.baselineoptimizer_unittest.BaselineOptimizerTest.test_mac_future -------------------------------------------------------------------------------- Traceback (most recent call last): File "/ramdisk/qt-linux-release/build/Tools/Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py", line 112, in test_mac_future 'LayoutTests/platform/mac-snowleopard': '462d03b9c025db1b0392d7453310dbee5f9a9e74', File "/ramdisk/qt-linux-release/build/Tools/Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py", line 53, in _assertOptimization self.assertEqual(new_results_by_directory, expected_new_results_by_directory) AssertionError: {} != {'LayoutTests/platform/mac-snowleopard': '462d03b9c025db1b0392d7453310dbee5f9a9e74'} ================================================================================ FAILURE: webkitpy.common.checkout.baselineoptimizer_unittest.BaselineOptimizerTest.test_no_add_mac_future -------------------------------------------------------------------------------- Traceback (most recent call last): File "/ramdisk/qt-linux-release/build/Tools/Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py", line 88, in test_no_add_mac_future 'LayoutTests/platform/chromium-mac': 'a9ba153c700a94ae1b206d8e4a75a621a89b4554', File "/ramdisk/qt-linux-release/build/Tools/Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py", line 53, in _assertOptimization self.assertEqual(new_results_by_directory, expected_new_results_by_directory) AssertionError: {'LayoutTests/platform/win-xp': '453e67177a75b2e79905154ece0efba6e5bfb65d', 'LayoutTests/platform/mac': '29a1715a6470d5dd9486a142f609708de84cdac8', 'LayoutTests/platform/chromium-mac': 'a9ba153c700a94ae1b206d8e4a75a621a89b4554'} != {'LayoutTests/platform/chromium-mac': 'a9ba153c700a94ae1b206d8e4a75a621a89b4554', 'LayoutTests/platform/mac': '29a1715a6470d5dd9486a142f609708de84cdac8', 'LayoutTests/platform/win': '453e67177a75b2e79905154ece0efba6e5bfb65d', 'LayoutTests/platform/mac-snowleopard': 'c43eaeb358f49d5e835236ae23b7e49d7f2b089f'} 651541 1 simon.fraser 2012-06-18 11:03:44 -0700 These tests stated failing because I removed old Mac builders from webkitpy/layout_tests/port/builders.py. I'm not sure what the right solution is. 651559 2 148133 zan 2012-06-18 11:22:27 -0700 Created attachment 148133 Patch 651641 3 dpranke 2012-06-18 13:07:08 -0700 Committed r120620: <http://trac.webkit.org/changeset/120620> 148133 2012-06-18 11:22:27 -0700 2012-06-18 11:23:16 -0700 Patch bug-89332-20120618202226.patch text/plain 4833 zan SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDEyMDYwOSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE3IEBACisyMDEyLTA2LTE4ICBaYW4gRG9iZXJzZWsgIDx6YW5kb2JlcnNla0BnbWFpbC5j b20+CisKKyAgICAgICAgUkVHUkVTU0lPTihyMTIwNTQ2KTogSXQgbWFkZSAzIHdlYmtpdHB5IHRl c3RzIGZhaWwKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTg5MzMyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg VXBkYXRlIHRoZSBCYXNlbGluZU9wdGltaXplciB1bml0dGVzdCBhZnRlciByMTIwNTQ2LgorCisg ICAgICAgICogU2NyaXB0cy93ZWJraXRweS9jb21tb24vY2hlY2tvdXQvYmFzZWxpbmVvcHRpbWl6 ZXJfdW5pdHRlc3QucHk6CisgICAgICAgIChCYXNlbGluZU9wdGltaXplclRlc3QudGVzdF9ub19h ZGRfbWFjX2Z1dHVyZSk6CisgICAgICAgIChCYXNlbGluZU9wdGltaXplclRlc3QudGVzdF9tYWNf ZnV0dXJlKToKKyAgICAgICAgKEJhc2VsaW5lT3B0aW1pemVyVGVzdC50ZXN0X2NvbXBsZXhfc2hh ZG93aW5nKToKKwogMjAxMi0wNi0xOCAgWGlhbnpodSBXYW5nICA8d2FuZ3hpYW56aHVAY2hyb21p dW0ub3JnPgogCiAgICAgICAgIFtDaHJvbWl1bV0gQ2hhbmdlIGJhY2sgImxpbnV4aXNoIiB0byAi bGludXgiIGFuZCBpbmNsdWRlIFdlYkZvbnRSZW5kZXJpbmcuY3BwIG9uIEFuZHJvaWQKSW5kZXg6 IFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL2NoZWNrb3V0L2Jhc2VsaW5lb3B0aW1pemVy X3VuaXR0ZXN0LnB5Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9u L2NoZWNrb3V0L2Jhc2VsaW5lb3B0aW1pemVyX3VuaXR0ZXN0LnB5CShyZXZpc2lvbiAxMjA2MDYp CisrKyBUb29scy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9jaGVja291dC9iYXNlbGluZW9wdGlt aXplcl91bml0dGVzdC5weQkod29ya2luZyBjb3B5KQpAQCAtNzgsMTMgKzc4LDEzIEBAIGNsYXNz IEJhc2VsaW5lT3B0aW1pemVyVGVzdCh1bml0dGVzdC5UZXMKICAgICBkZWYgdGVzdF9ub19hZGRf bWFjX2Z1dHVyZShzZWxmKToKICAgICAgICAgc2VsZi5fYXNzZXJ0T3B0aW1pemF0aW9uKHsKICAg ICAgICAgICAgICdMYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMnOiAnMjlhMTcxNWE2NDcwZDVkZDk0 ODZhMTQyZjYwOTcwOGRlODRjZGFjOCcsCi0gICAgICAgICAgICAnTGF5b3V0VGVzdHMvcGxhdGZv cm0vd2luJzogJzQ1M2U2NzE3N2E3NWIyZTc5OTA1MTU0ZWNlMGVmYmE2ZTViZmI2NWQnLAotICAg ICAgICAgICAgJ0xheW91dFRlc3RzL3BsYXRmb3JtL21hYy1zbm93bGVvcGFyZCc6ICdjNDNlYWVi MzU4ZjQ5ZDVlODM1MjM2YWUyM2I3ZTQ5ZDdmMmIwODlmJywKKyAgICAgICAgICAgICdMYXlvdXRU ZXN0cy9wbGF0Zm9ybS93aW4teHAnOiAnNDUzZTY3MTc3YTc1YjJlNzk5MDUxNTRlY2UwZWZiYTZl NWJmYjY1ZCcsCisgICAgICAgICAgICAnTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjLWxpb24nOiAn YzQzZWFlYjM1OGY0OWQ1ZTgzNTIzNmFlMjNiN2U0OWQ3ZjJiMDg5ZicsCiAgICAgICAgICAgICAn TGF5b3V0VGVzdHMvcGxhdGZvcm0vY2hyb21pdW0tbWFjJzogJ2E5YmExNTNjNzAwYTk0YWUxYjIw NmQ4ZTRhNzVhNjIxYTg5YjQ1NTQnLAogICAgICAgICB9LCB7CiAgICAgICAgICAgICAnTGF5b3V0 VGVzdHMvcGxhdGZvcm0vbWFjJzogJzI5YTE3MTVhNjQ3MGQ1ZGQ5NDg2YTE0MmY2MDk3MDhkZTg0 Y2RhYzgnLAotICAgICAgICAgICAgJ0xheW91dFRlc3RzL3BsYXRmb3JtL3dpbic6ICc0NTNlNjcx NzdhNzViMmU3OTkwNTE1NGVjZTBlZmJhNmU1YmZiNjVkJywKLSAgICAgICAgICAgICdMYXlvdXRU ZXN0cy9wbGF0Zm9ybS9tYWMtc25vd2xlb3BhcmQnOiAnYzQzZWFlYjM1OGY0OWQ1ZTgzNTIzNmFl MjNiN2U0OWQ3ZjJiMDg5ZicsCisgICAgICAgICAgICAnTGF5b3V0VGVzdHMvcGxhdGZvcm0vd2lu LXhwJzogJzQ1M2U2NzE3N2E3NWIyZTc5OTA1MTU0ZWNlMGVmYmE2ZTViZmI2NWQnLAorICAgICAg ICAgICAgJ0xheW91dFRlc3RzL3BsYXRmb3JtL21hYy1saW9uJzogJ2M0M2VhZWIzNThmNDlkNWU4 MzUyMzZhZTIzYjdlNDlkN2YyYjA4OWYnLAogICAgICAgICAgICAgJ0xheW91dFRlc3RzL3BsYXRm b3JtL2Nocm9taXVtLW1hYyc6ICdhOWJhMTUzYzcwMGE5NGFlMWIyMDZkOGU0YTc1YTYyMWE4OWI0 NTU0JywKICAgICAgICAgfSkKIApAQCAtMTA3LDkgKzEwNyw5IEBAIGNsYXNzIEJhc2VsaW5lT3B0 aW1pemVyVGVzdCh1bml0dGVzdC5UZXMKIAogICAgIGRlZiB0ZXN0X21hY19mdXR1cmUoc2VsZik6 CiAgICAgICAgIHNlbGYuX2Fzc2VydE9wdGltaXphdGlvbih7Ci0gICAgICAgICAgICAnTGF5b3V0 VGVzdHMvcGxhdGZvcm0vbWFjLXNub3dsZW9wYXJkJzogJzQ2MmQwM2I5YzAyNWRiMWIwMzkyZDc0 NTMzMTBkYmVlNWY5YTllNzQnLAorICAgICAgICAgICAgJ0xheW91dFRlc3RzL3BsYXRmb3JtL21h Yy1saW9uJzogJzQ2MmQwM2I5YzAyNWRiMWIwMzkyZDc0NTMzMTBkYmVlNWY5YTllNzQnLAogICAg ICAgICB9LCB7Ci0gICAgICAgICAgICAnTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjLXNub3dsZW9w YXJkJzogJzQ2MmQwM2I5YzAyNWRiMWIwMzkyZDc0NTMzMTBkYmVlNWY5YTllNzQnLAorICAgICAg ICAgICAgJ0xheW91dFRlc3RzL3BsYXRmb3JtL21hYy1saW9uJzogJzQ2MmQwM2I5YzAyNWRiMWIw MzkyZDc0NTMzMTBkYmVlNWY5YTllNzQnLAogICAgICAgICB9KQogCiAgICAgZGVmIHRlc3RfcXRf dW5rbm93bihzZWxmKToKQEAgLTE1NCwxNyArMTU0LDE3IEBAIGNsYXNzIEJhc2VsaW5lT3B0aW1p emVyVGVzdCh1bml0dGVzdC5UZXMKICAgICAgICAgICAgICdMYXlvdXRUZXN0cy9wbGF0Zm9ybS9t YWMnOiAnNWRhYTc4ZTU1ZjA1ZDlmMGQxYmIxZjMyYjBjZDFiYzNhMDFlOTM2NCcsCiAgICAgICAg ICAgICAnTGF5b3V0VGVzdHMvcGxhdGZvcm0vY2hyb21pdW0td2luLXhwJzogJzQ2MmQwM2I5YzAy NWRiMWIwMzkyZDc0NTMzMTBkYmVlNWY5YTllNzQnLAogICAgICAgICAgICAgJ0xheW91dFRlc3Rz L3BsYXRmb3JtL2Nocm9taXVtLW1hYy1sZW9wYXJkJzogJzY1ZTdkNDJmOGI0ODgyYjI5ZDQ2ZGM3 N2JiODc5ZGQ0MWJjMDc0ZGMnLAotICAgICAgICAgICAgJ0xheW91dFRlc3RzL3BsYXRmb3JtL21h Yy1sZW9wYXJkJzogJzdhZDA0NWVjZTdjMDMwZTIyODNjNWQyMWQ5NTg3YmUyMmJjYmE1NmUnLAor ICAgICAgICAgICAgJ0xheW91dFRlc3RzL3BsYXRmb3JtL21hYy1saW9uJzogJzdhZDA0NWVjZTdj MDMwZTIyODNjNWQyMWQ5NTg3YmUyMmJjYmE1NmUnLAogICAgICAgICAgICAgJ0xheW91dFRlc3Rz L3BsYXRmb3JtL2Nocm9taXVtLXdpbi12aXN0YSc6ICdmODNhZjk3MzJjZTc0ZjcwMmI4YzljNGEz ZDlhNGM2NjM2YjhkM2JkJywKLSAgICAgICAgICAgICdMYXlvdXRUZXN0cy9wbGF0Zm9ybS93aW4n OiAnNWIxMjUzZWY0ZDUwOTQ1MzBkNWYxYmM2Y2RiOTVjOTBiNDQ2YmVjNycsCisgICAgICAgICAg ICAnTGF5b3V0VGVzdHMvcGxhdGZvcm0vd2luLXhwJzogJzViMTI1M2VmNGQ1MDk0NTMwZDVmMWJj NmNkYjk1YzkwYjQ0NmJlYzcnLAogICAgICAgICAgICAgJ0xheW91dFRlc3RzL3BsYXRmb3JtL2No cm9taXVtLWxpbnV4JzogJ2Y1MmZjZGRlOWU0YmU4YmQ1MTQyMTcxY2Q4NTkyMzBiZDQ0NzEwMzYn LAogICAgICAgICB9LCB7CiAgICAgICAgICAgICAnTGF5b3V0VGVzdHMvcGxhdGZvcm0vY2hyb21p dW0td2luJzogJzQ2MmQwM2I5YzAyNWRiMWIwMzkyZDc0NTMzMTBkYmVlNWY5YTllNzQnLAogICAg ICAgICAgICAgJ0xheW91dFRlc3RzL3BsYXRmb3JtL21hYyc6ICc1ZGFhNzhlNTVmMDVkOWYwZDFi YjFmMzJiMGNkMWJjM2EwMWU5MzY0JywKICAgICAgICAgICAgICdMYXlvdXRUZXN0cy9wbGF0Zm9y bS9jaHJvbWl1bS13aW4teHAnOiAnNDYyZDAzYjljMDI1ZGIxYjAzOTJkNzQ1MzMxMGRiZWU1Zjlh OWU3NCcsCiAgICAgICAgICAgICAnTGF5b3V0VGVzdHMvcGxhdGZvcm0vY2hyb21pdW0tbWFjLWxl b3BhcmQnOiAnNjVlN2Q0MmY4YjQ4ODJiMjlkNDZkYzc3YmI4NzlkZDQxYmMwNzRkYycsCi0gICAg ICAgICAgICAnTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjLWxlb3BhcmQnOiAnN2FkMDQ1ZWNlN2Mw MzBlMjI4M2M1ZDIxZDk1ODdiZTIyYmNiYTU2ZScsCisgICAgICAgICAgICAnTGF5b3V0VGVzdHMv cGxhdGZvcm0vbWFjLWxpb24nOiAnN2FkMDQ1ZWNlN2MwMzBlMjI4M2M1ZDIxZDk1ODdiZTIyYmNi YTU2ZScsCiAgICAgICAgICAgICAnTGF5b3V0VGVzdHMvcGxhdGZvcm0vY2hyb21pdW0td2luLXZp c3RhJzogJ2Y4M2FmOTczMmNlNzRmNzAyYjhjOWM0YTNkOWE0YzY2MzZiOGQzYmQnLAotICAgICAg ICAgICAgJ0xheW91dFRlc3RzL3BsYXRmb3JtL3dpbic6ICc1YjEyNTNlZjRkNTA5NDUzMGQ1ZjFi YzZjZGI5NWM5MGI0NDZiZWM3JywKKyAgICAgICAgICAgICdMYXlvdXRUZXN0cy9wbGF0Zm9ybS93 aW4teHAnOiAnNWIxMjUzZWY0ZDUwOTQ1MzBkNWYxYmM2Y2RiOTVjOTBiNDQ2YmVjNycsCiAgICAg ICAgICAgICAnTGF5b3V0VGVzdHMvcGxhdGZvcm0vY2hyb21pdW0tbGludXgnOiAnZjUyZmNkZGU5 ZTRiZThiZDUxNDIxNzFjZDg1OTIzMGJkNDQ3MTAzNicKICAgICAgICAgfSkK