89320 2012-06-17 19:09:17 -0700 Fix Framebuffer restrictions 2012-06-17 23:33:08 -0700 1 1 1 Unclassified WebKit WebGL 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 gman gman kbr webkit.review.bot zmo oldest_to_newest 651092 0 gman 2012-06-17 19:09:17 -0700 Fix Framebuffer restrictions 651094 1 148035 gman 2012-06-17 19:10:52 -0700 Created attachment 148035 Patch 651096 2 gman 2012-06-17 19:12:35 -0700 Honestly I don't know why the LayoutTests didn't catch this. It's the exact same test that failing in the chrome gpu_tests. Maybe they get an INCOMPLETE_FRAMEBUFFER and so don't take a certain path. 651182 3 148035 kbr 2012-06-17 22:56:51 -0700 Comment on attachment 148035 Patch Looks good; thanks for tracking this down. It looks like framebuffer-object-attachment.html was skipped on the Mac platform in https://bugs.webkit.org/show_bug.cgi?id=82805 and this might be why this slipped through the cracks on the Mac platform. Could you take a look through the results of platform/mac/fast/canvas/webgl/framebuffer-object-attachment-expected.txt ? It looks to me like it is returning FRAMEBUFFER_COMPLETE in one case where the platform-independent results in fast/canvas/webgl/framebuffer-object-attachment-expected.txt return FRAMEBUFFER_UNSUPPORTED. Also, there are a couple of platform-specific expected results (platform/chromium-mac-snowleopard, platform/mac-snowleopard) which are identical to the platform-independent results and which could be deleted. 651194 4 148035 webkit.review.bot 2012-06-17 23:33:04 -0700 Comment on attachment 148035 Patch Clearing flags on attachment: 148035 Committed r120571: <http://trac.webkit.org/changeset/120571> 651195 5 webkit.review.bot 2012-06-17 23:33:08 -0700 All reviewed patches have been landed. Closing bug. 148035 2012-06-17 19:10:52 -0700 2012-06-17 23:33:04 -0700 Patch bug-89320-20120617191051.patch text/plain 2576 gman U3VidmVyc2lvbiBSZXZpc2lvbjogMTIwNDgyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMDM4YzVhMzk5NjJjZjhm ZGUxMjU4MmY0MGJkOWRlYTg4ZTc1MTQyNS4uMGRjNjdkOTFhZDcxYTRmY2VlNTUxMmVhZDI1NzU0 Y2Q3OWRjNGM0NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEyLTA2LTE3ICBHcmVn ZyBUYXZhcmVzICA8Z21hbkBnb29nbGUuY29tPgorCisgICAgICAgIEZpeCBGcmFtZWJ1ZmZlciBy ZXN0cmljdGlvbnMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTg5MzIwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgTm8gbmV3IHRlc3RzLCBqdXN0IGZpeGluZyBvbGQgb25lcworCisgICAgICAgICogaHRtbC9j YW52YXMvV2ViR0xGcmFtZWJ1ZmZlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpXZWJHTEZyYW1l YnVmZmVyOjpjaGVja1N0YXR1cyk6CisKIDIwMTItMDYtMTUgIFNpbHZpYSBQZmVpZmZlciAgPHNp bHZpYXBmQGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZW1vdmUgdm9sdW1lIHRodW1iIGZvciB2 aWRlb3Mgd2l0aG91dCBhdWRpbyB0cmFjay4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2h0 bWwvY2FudmFzL1dlYkdMRnJhbWVidWZmZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvaHRtbC9jYW52 YXMvV2ViR0xGcmFtZWJ1ZmZlci5jcHAKaW5kZXggM2EwYjEwNDFmZGE4MTBjM2JiZGQ1Yzc5ZjNh NjI5NzMzNGQ3NDE2My4uMjMzNjRjYTc4YzkxY2MyMGVhMjhhYzNjY2YzZmNjNzUxODQxNGE2NCAx MDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaHRtbC9jYW52YXMvV2ViR0xGcmFtZWJ1ZmZlci5j cHAKKysrIGIvU291cmNlL1dlYkNvcmUvaHRtbC9jYW52YXMvV2ViR0xGcmFtZWJ1ZmZlci5jcHAK QEAgLTIzMyw4ICsyMzMsOSBAQCBuYW1lc3BhY2UgewogICAgIHsKICAgICAgICAgQVNTRVJUKGF0 dGFjaGVkT2JqZWN0ICYmIGF0dGFjaGVkT2JqZWN0LT5pc1ZhbGlkKCkpOwogICAgICAgICBBU1NF UlQocmVhc29uKTsKKyAgICAgICAgR0MzRGVudW0gZm9ybWF0ID0gYXR0YWNoZWRPYmplY3QtPmdl dEZvcm1hdCgpOwogICAgICAgICB1bnNpZ25lZCBuZWVkID0gR3JhcGhpY3NDb250ZXh0M0Q6Omdl dENsZWFyQml0c0J5QXR0YWNobWVudFR5cGUoYXR0YWNobWVudCk7Ci0gICAgICAgIHVuc2lnbmVk IGhhdmUgPSBHcmFwaGljc0NvbnRleHQzRDo6Z2V0Q2xlYXJCaXRzQnlGb3JtYXQoYXR0YWNoZWRP YmplY3QtPmdldEZvcm1hdCgpKTsKKyAgICAgICAgdW5zaWduZWQgaGF2ZSA9IEdyYXBoaWNzQ29u dGV4dDNEOjpnZXRDbGVhckJpdHNCeUZvcm1hdChmb3JtYXQpOwogCiAgICAgICAgIGlmICgobmVl ZCAmIGhhdmUpICE9IG5lZWQpIHsKICAgICAgICAgICAgICpyZWFzb24gPSAiYXR0YWNobWVudCB0 eXBlIGlzIG5vdCBjb3JyZWN0IGZvciBhdHRhY2htZW50IjsKQEAgLTI0NCw2ICsyNDUsMTEgQEAg bmFtZXNwYWNlIHsKICAgICAgICAgICAgICpyZWFzb24gPSAiYXR0YWNobWVudCBoYXMgYSAwIGRp bWVuc2lvbiI7CiAgICAgICAgICAgICByZXR1cm4gZmFsc2U7CiAgICAgICAgIH0KKyAgICAgICAg aWYgKChhdHRhY2htZW50ID09IEdyYXBoaWNzQ29udGV4dDNEOjpERVBUSF9BVFRBQ0hNRU5UIHx8 IGF0dGFjaG1lbnQgPT0gR3JhcGhpY3NDb250ZXh0M0Q6OlNURU5DSUxfQVRUQUNITUVOVCkKKyAg ICAgICAgICAgICYmIGZvcm1hdCA9PSBHcmFwaGljc0NvbnRleHQzRDo6REVQVEhfU1RFTkNJTCkg eworICAgICAgICAgICpyZWFzb24gPSAiYXR0YWNobWVudCBERVBUSF9TVEVOQ0lMIG5vdCBhbGxv d2VkIG9uIERFUFRIIG9yIFNURU5DSUwgYXR0YWNobWVudCI7CisgICAgICAgICAgcmV0dXJuIGZh bHNlOworICAgICAgICB9CiAgICAgICAgIHJldHVybiB0cnVlOwogICAgIH0KIApAQCAtNDQwLDcg KzQ0Niw3IEBAIEdDM0RlbnVtIFdlYkdMRnJhbWVidWZmZXI6OmNoZWNrU3RhdHVzKGNvbnN0IGNo YXIqKiByZWFzb24pIGNvbnN0CiAgICAgICAgIHJldHVybiBHcmFwaGljc0NvbnRleHQzRDo6RlJB TUVCVUZGRVJfSU5DT01QTEVURV9BVFRBQ0hNRU5UOwogICAgIH0KICAgICAvLyBXZWJHTCBzcGVj aWZpYzogbm8gY29uZmxpY3RpbmcgREVQVEgvU1RFTkNJTC9ERVBUSF9TVEVOQ0lMIGF0dGFjaG1l bnRzLgotICAgIGlmIChoYXZlRGVwdGhTdGVuY2lsICYmIChoYXZlRGVwdGggfHwgaGF2ZVN0ZW5j aWwpKSB7CisgICAgaWYgKChoYXZlRGVwdGhTdGVuY2lsICYmIChoYXZlRGVwdGggfHwgaGF2ZVN0 ZW5jaWwpKSB8fCAoaGF2ZURlcHRoICYmIGhhdmVTdGVuY2lsKSkgewogICAgICAgICAqcmVhc29u ID0gImNvbmZsaWN0aW5nIERFUFRIL1NURU5DSUwvREVQVEhfU1RFTkNJTCBhdHRhY2htZW50cyI7 CiAgICAgICAgIHJldHVybiBHcmFwaGljc0NvbnRleHQzRDo6RlJBTUVCVUZGRVJfVU5TVVBQT1JU RUQ7CiAgICAgfQo=