89307 2012-06-17 09:16:41 -0700 Web Inspector: Make text in WebSocket Frames tab selectable 2012-06-19 07:08:48 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 me me apavlov bweinstein joepeck keishi kpiascik loislo pfeldman pmuellr rik timothy webkit.review.bot yurys oldest_to_newest 650989 0 me 2012-06-17 09:16:41 -0700 Cannot copy text form WebSocket Frames tab introduced in https://bugs.webkit.org/show_bug.cgi?id=83282. 650990 1 148012 me 2012-06-17 09:23:47 -0700 Created attachment 148012 A fix 650996 2 148012 me 2012-06-17 09:32:04 -0700 Comment on attachment 148012 A fix View in context: https://bugs.webkit.org/attachment.cgi?id=148012&action=review > Source/WebCore/inspector/front-end/ResourceWebSocketFrameView.js:-26 > - this.element.addStyleClass("html"); "html" class doesn’t seem to be used. Should I use classList.add instead of addStyleClass? The latter is just a shortcut for the former but it has the same amount of characters. There is a bug related to it https://bugs.webkit.org/show_bug.cgi?id=72803 651209 3 148012 yurys 2012-06-18 00:00:12 -0700 Comment on attachment 148012 A fix View in context: https://bugs.webkit.org/attachment.cgi?id=148012&action=review >> Source/WebCore/inspector/front-end/ResourceWebSocketFrameView.js:-26 >> - this.element.addStyleClass("html"); > > "html" class doesn’t seem to be used. > > Should I use classList.add instead of addStyleClass? The latter is just a shortcut for the former but it has the same amount of characters. There is a bug related to it https://bugs.webkit.org/show_bug.cgi?id=72803 It is OK to use addStyleClass here at the moment for consistency, we will switch the whole file to classList.add at once. 652331 4 me 2012-06-19 04:59:46 -0700 Is there any reason why the patch still not in commit-queue? 652382 5 pfeldman 2012-06-19 06:43:49 -0700 (In reply to comment #4) > Is there any reason why the patch still not in commit-queue? The reason is that auto-commit was not requested via commit-queue=? 652407 6 148012 webkit.review.bot 2012-06-19 07:06:38 -0700 Comment on attachment 148012 A fix Clearing flags on attachment: 148012 Committed r120710: <http://trac.webkit.org/changeset/120710> 652408 7 webkit.review.bot 2012-06-19 07:06:43 -0700 All reviewed patches have been landed. Closing bug. 652409 8 me 2012-06-19 07:08:48 -0700 Pavel, totally forgot it. Thanks! 148012 2012-06-17 09:23:47 -0700 2012-06-19 07:06:38 -0700 A fix copyable-text.patch text/plain 1786 me ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBiMjcxMjYzLi5iNmY1MzYxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUg QEAKKzIwMTItMDYtMTcgIE5pa2l0YSBWYXNpbHlldiAgPG1lQGVsdjFzLnJ1PgorCisgICAgICAg IFdlYiBJbnNwZWN0b3I6IE1ha2UgdGV4dCBpbiBXZWJTb2NrZXQgRnJhbWVzIHRhYiBzZWxlY3Rh YmxlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04OTMw NworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogaW5z cGVjdG9yL2Zyb250LWVuZC9SZXNvdXJjZVdlYlNvY2tldEZyYW1lVmlldy5qczoKKyAgICAgICAg KFdlYkluc3BlY3Rvci5SZXNvdXJjZVdlYlNvY2tldEZyYW1lVmlldyk6CisgICAgICAgICogaW5z cGVjdG9yL2Zyb250LWVuZC9uZXR3b3JrUGFuZWwuY3NzOgorICAgICAgICAoLnJlc291cmNlLXdl YnNvY2tldC1mcmFtZS12aWV3KToKKwogMjAxMi0wNi0xNCAgUGF2ZWwgRmVsZG1hbiAgPHBmZWxk bWFuQGNocm9taXVtLm9yZz4KIAogICAgICAgICBXZWIgSW5zcGVjdG9yOiBjbGVhciBleGVjdXRp b24gbGl2ZSBiZWZvcmUgdGhlIHRleHQgZWRpdC4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3Jl L2luc3BlY3Rvci9mcm9udC1lbmQvUmVzb3VyY2VXZWJTb2NrZXRGcmFtZVZpZXcuanMgYi9Tb3Vy Y2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1Jlc291cmNlV2ViU29ja2V0RnJhbWVWaWV3 LmpzCmluZGV4IDNmNTczOWQuLmRlMjc3YjAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2lu c3BlY3Rvci9mcm9udC1lbmQvUmVzb3VyY2VXZWJTb2NrZXRGcmFtZVZpZXcuanMKKysrIGIvU291 cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9SZXNvdXJjZVdlYlNvY2tldEZyYW1lVmll dy5qcwpAQCAtMjMsNyArMjMsNyBAQAogV2ViSW5zcGVjdG9yLlJlc291cmNlV2ViU29ja2V0RnJh bWVWaWV3ID0gZnVuY3Rpb24ocmVzb3VyY2UpCiB7CiAgICAgV2ViSW5zcGVjdG9yLlZpZXcuY2Fs bCh0aGlzKTsKLSAgICB0aGlzLmVsZW1lbnQuYWRkU3R5bGVDbGFzcygiaHRtbCIpOworICAgIHRo aXMuZWxlbWVudC5hZGRTdHlsZUNsYXNzKCJyZXNvdXJjZS13ZWJzb2NrZXQtZnJhbWUtdmlldyIp OwogICAgIHRoaXMucmVzb3VyY2UgPSByZXNvdXJjZTsKICAgICB0aGlzLmVsZW1lbnQucmVtb3Zl Q2hpbGRyZW4oKTsKICAgICB2YXIgdGFibGUgPSBkb2N1bWVudC5jcmVhdGVFbGVtZW50KCJ0YWJs ZSIpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9uZXR3 b3JrUGFuZWwuY3NzIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9uZXR3b3Jr UGFuZWwuY3NzCmluZGV4IDI3YTcxYTAuLmY5YzAxYjQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD b3JlL2luc3BlY3Rvci9mcm9udC1lbmQvbmV0d29ya1BhbmVsLmNzcworKysgYi9Tb3VyY2UvV2Vi Q29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL25ldHdvcmtQYW5lbC5jc3MKQEAgLTI3OSwzICsyNzks NyBAQAogLnJlc291cmNlLXRpbWluZy12aWV3LnZpc2libGUgewogICAgIGRpc3BsYXk6IGJsb2Nr OwogfQorCisucmVzb3VyY2Utd2Vic29ja2V0LWZyYW1lLXZpZXcgeworICAgIC13ZWJraXQtdXNl ci1zZWxlY3Q6IHRleHQ7Cit9Cg==