89304 2012-06-17 07:47:59 -0700 Touch events with default actions should be handled. 2012-06-18 08:07:05 -0700 1 1 1 Unclassified WebKit UI Events 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 88807 1 rjkroege rjkroege kevers tkent webkit.review.bot oldest_to_newest 650981 0 rjkroege 2012-06-17 07:47:59 -0700 The implementation of https://bugs.webkit.org/show_bug.cgi?id=88807 showed the implementation of EventHandler::handleTouchEvent overlooks the status of Event::defaultHandled on a TouchEvent when computing its "event was swallowed" return value. This should be corrected. 650982 1 148010 rjkroege 2012-06-17 08:17:53 -0700 Created attachment 148010 Patch 650983 2 rjkroege 2012-06-17 08:18:50 -0700 tkent@: Could you take a look please? 651074 3 148010 tkent 2012-06-17 17:55:56 -0700 Comment on attachment 148010 Patch Looks reasonable. 651393 4 148010 webkit.review.bot 2012-06-18 08:07:01 -0700 Comment on attachment 148010 Patch Clearing flags on attachment: 148010 Committed r120597: <http://trac.webkit.org/changeset/120597> 651394 5 webkit.review.bot 2012-06-18 08:07:05 -0700 All reviewed patches have been landed. Closing bug. 148010 2012-06-17 08:17:53 -0700 2012-06-18 08:07:01 -0700 Patch bug-89304-20120617111752.patch text/plain 2376 rjkroege U3VidmVyc2lvbiBSZXZpc2lvbjogMTIwNTUwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYmQwMTc2MTZhZDE4ZGU5 YTEzNjRmZjE2NTU2MGU1MWNjM2MxODYzNC4uNjg0MTlkNzA0ODZiMGIxZTJlMmMwYmE2YzY2MDM1 ZTZjOTQ2N2IyMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEyLTA2LTE3ICBSb2Jl cnQgS3JvZWdlciAgPHJqa3JvZWdlQGNocm9taXVtLm9yZz4KKworICAgICAgICBUb3VjaCBldmVu dHMgd2l0aCBkZWZhdWx0IGFjdGlvbnMgc2hvdWxkIGJlIGhhbmRsZWQuCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04OTMwNC4KKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBDb3ZlcmVkIGJ5IGV4aXN0aW5nIHRl c3RzIGFuZCB0ZXN0cyBpbiBibG9ja2VkIGJ1ZworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODg4MDcKKworICAgICAgICAqIHBhZ2UvRXZlbnRIYW5kbGVy LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkV2ZW50SGFuZGxlcjo6aGFuZGxlVG91Y2hFdmVudCk6 IFJldHVybiB0cnVlIHRoYXQgdGhlIHRvdWNoIGV2ZW50CisgICAgICAgIHdhcyBoYW5kbGVkIGZv ciBlaXRoZXIgcHJldmVudERlZmF1bHQgb3IgZGVmYXVsdEhhbmRsZWQuCisKIDIwMTItMDYtMTcg IEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9yZz4KIAogICAgICAgICBBdHRlbXB0IHRvIGZp eCBhIGxhcmdlIG51bWJlciBvZiB0ZXN0cyBJIGJyb2tlIHdpdGggaHR0cDovL3RyYWMud2Via2l0 Lm9yZy9jaGFuZ2VzZXQvMTIwNTQ3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL0V2 ZW50SGFuZGxlci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL0V2ZW50SGFuZGxlci5jcHAKaW5k ZXggOWM1MWIyOTc0ZTMwM2VjYmE1ZWYxMzdkNTcyNzk3NmQxMDlkNDljNy4uZDFiOGMxMmEzYjgx Y2ExZTNhNWZkYTNiZjJmYjRmOWZhM2VlYjc0NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUv cGFnZS9FdmVudEhhbmRsZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRXZlbnRIYW5k bGVyLmNwcApAQCAtMzU5MSw3ICszNTkxLDcgQEAgYm9vbCBFdmVudEhhbmRsZXI6OmhhbmRsZVRv dWNoRXZlbnQoY29uc3QgUGxhdGZvcm1Ub3VjaEV2ZW50JiBldmVudCkKICAgICBtX3RvdWNoUHJl c3NlZCA9IHRvdWNoZXMtPmxlbmd0aCgpID4gMDsKIAogICAgIC8vIE5vdyBpdGVyYXRlIHRoZSBj aGFuZ2VkVG91Y2hlcyBsaXN0IGFuZCBtX3RhcmdldHMgd2l0aGluIGl0LCBzZW5kaW5nIGV2ZW50 cyB0byB0aGUgdGFyZ2V0cyBhcyByZXF1aXJlZC4KLSAgICBib29sIGRlZmF1bHRQcmV2ZW50ZWQg PSBmYWxzZTsKKyAgICBib29sIHN3YWxsb3dlZEV2ZW50ID0gZmFsc2U7CiAgICAgUmVmUHRyPFRv dWNoTGlzdD4gZW1wdHlMaXN0ID0gVG91Y2hMaXN0OjpjcmVhdGUoKTsKICAgICBmb3IgKHVuc2ln bmVkIHN0YXRlID0gMDsgc3RhdGUgIT0gUGxhdGZvcm1Ub3VjaFBvaW50OjpUb3VjaFN0YXRlRW5k OyArK3N0YXRlKSB7CiAgICAgICAgIGlmICghY2hhbmdlZFRvdWNoZXNbc3RhdGVdLm1fdG91Y2hl cykKQEAgLTM2MTQsMTEgKzM2MTQsMTEgQEAgYm9vbCBFdmVudEhhbmRsZXI6OmhhbmRsZVRvdWNo RXZlbnQoY29uc3QgUGxhdGZvcm1Ub3VjaEV2ZW50JiBldmVudCkKICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgMCwgMCwgMCwgMCwgZXZlbnQuY3RybEtleSgpLCBldmVudC5hbHRL ZXkoKSwgZXZlbnQuc2hpZnRLZXkoKSwgZXZlbnQubWV0YUtleSgpKTsKICAgICAgICAgICAgIEV4 Y2VwdGlvbkNvZGUgZWMgPSAwOwogICAgICAgICAgICAgdG91Y2hFdmVudFRhcmdldC0+ZGlzcGF0 Y2hFdmVudCh0b3VjaEV2ZW50LmdldCgpLCBlYyk7Ci0gICAgICAgICAgICBkZWZhdWx0UHJldmVu dGVkIHw9IHRvdWNoRXZlbnQtPmRlZmF1bHRQcmV2ZW50ZWQoKTsKKyAgICAgICAgICAgIHN3YWxs b3dlZEV2ZW50ID0gc3dhbGxvd2VkRXZlbnQgfHwgdG91Y2hFdmVudC0+ZGVmYXVsdFByZXZlbnRl ZCgpIHx8IHRvdWNoRXZlbnQtPmRlZmF1bHRIYW5kbGVkKCk7CiAgICAgICAgIH0KICAgICB9CiAK LSAgICByZXR1cm4gZGVmYXVsdFByZXZlbnRlZDsKKyAgICByZXR1cm4gc3dhbGxvd2VkRXZlbnQ7 CiB9CiAKIGJvb2wgRXZlbnRIYW5kbGVyOjpkaXNwYXRjaFN5bnRoZXRpY1RvdWNoRXZlbnRJZkVu YWJsZWQoY29uc3QgUGxhdGZvcm1Nb3VzZUV2ZW50JiBldmVudCkK