89299 2012-06-16 22:25:10 -0700 Fix RebaselineTest python to work with webkit.org builders 2012-09-07 10:13:29 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 simon.fraser webkit-unassigned abarth dpranke eric ojan ossy simon.fraser oldest_to_newest 650950 0 simon.fraser 2012-06-16 22:25:10 -0700 In rebaseline.py: help_text = "Rebaseline a single test from a buildbot. (Currently works only with build.chromium.org buildbots.)" I presume this breaks rebaselining in garden-o-matic for non-chromium ports. 650951 1 abarth 2012-06-16 22:42:40 -0700 Yeah. I think this should be relatively easy to fix. The way this works is that the front-end calls rebaselineall in gardeningserver.py via HTTP. That process the HTTP request and calls "webkit-patch rebaseline-test". If you get rebaseline-test working with the Apple ports, the rest of the machinery should fall into place. rebaseline-test is in rebaseline.py. My guess is that this command uses the accumulated results directory too, so you'll need to teach it how to find the most recent results directory, similar to what you did in the front-end: def _results_url(self, builder_name): # FIXME: Generalize this command to work with non-build.chromium.org builders. builder = self._tool.chromium_buildbot().builder_with_name(builder_name) return builder.accumulated_results_url() Rather than getting the chromium_buildbot off the tool, you probably want something like the following: self._tool.buildbot.builder_with_name(builder_name).latest_cached_build().results_url() 650952 2 abarth 2012-06-16 22:51:53 -0700 Playing with the code you landed, it looks like we'll need to work in the "results" view a bit. That view uses the accumulated results directory too, so we'll need to teach it to find the a results directory as well. (Note: That's probably something for a separate bug since it's an issue with the front end.) 650994 3 simon.fraser 2012-06-17 09:29:16 -0700 Results panel: bug 89310 GOM parameter: bug 89309 714647 4 simon.fraser 2012-09-07 10:06:25 -0700 Didn't someone fix this? 714666 5 ojan 2012-09-07 10:13:29 -0700 I did. :)