89272 2012-06-15 21:10:13 -0700 Settings::devicePixelRatio doesn't do anything and is confusing 2012-06-16 15:36:20 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 abarth abarth aelias bdakin cmarcelo danakj fsamuel jamesr kenneth menard simon.fraser webkit.review.bot zoltan oldest_to_newest 650719 0 abarth 2012-06-15 21:10:13 -0700 Settings::devicePixelRatio doesn't do anything and is confusing 650720 1 147946 abarth 2012-06-15 21:13:09 -0700 Created attachment 147946 Patch 650733 2 147946 jamesr 2012-06-15 22:06:32 -0700 Comment on attachment 147946 Patch Out, vile jelly! 650874 3 147946 webkit.review.bot 2012-06-16 15:35:59 -0700 Comment on attachment 147946 Patch Clearing flags on attachment: 147946 Committed r120534: <http://trac.webkit.org/changeset/120534> 650876 4 webkit.review.bot 2012-06-16 15:36:20 -0700 All reviewed patches have been landed. Closing bug. 147946 2012-06-15 21:13:09 -0700 2012-06-16 15:35:57 -0700 Patch bug-89272-20120615211308.patch text/plain 7169 abarth SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEyMDUyMikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIwIEBACisyMDEyLTA2LTE1ICBBZGFtIEJh cnRoICA8YWJhcnRoQHdlYmtpdC5vcmc+CisKKyAgICAgICAgU2V0dGluZ3M6OmRldmljZVBpeGVs UmF0aW8gZG9lc24ndCBkbyBhbnl0aGluZyBhbmQgaXMgY29uZnVzaW5nCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04OTI3MgorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFNldHRpbmdzOjpkZXZpY2VQaXhlbFJh dGlvIGlzIHlldCBhbm90aGVyIHBpZWNlIG9mIHN0YXRlIHRyeWluZyB0bworICAgICAgICByZXBy ZXNlbnQgdGhlIGRldmljZSBzY2FsZSBmYWN0b3IuIFRoZSBjYW5vbmljYWwgcGxhY2UgdG8gc3Rv cmUgdGhpcworICAgICAgICBzdGF0ZSBpcyBQYWdlOjptX2RldmljZVNjYWxlRmFjdG9yLiBOb3Ro aW5nIGluIFdlYkNvcmUgcmVmZXJlbmNlcworICAgICAgICBTZXR0aW5nczo6ZGV2aWNlUGl4ZWxS YXRpbyBhbnltb3JlLCBzbyB3ZSBjYW4gcmVtb3ZlIGl0LgorCisgICAgICAgICogcGFnZS9TZXR0 aW5ncy5jcHA6CisgICAgICAgIChXZWJDb3JlOjpTZXR0aW5nczo6U2V0dGluZ3MpOgorICAgICAg ICAqIHBhZ2UvU2V0dGluZ3MuaDoKKyAgICAgICAgKFNldHRpbmdzKToKKwogMjAxMi0wNi0xNSAg U2hlcmlmZiBCb3QgIDx3ZWJraXQucmV2aWV3LmJvdEBnbWFpbC5jb20+CiAKICAgICAgICAgVW5y ZXZpZXdlZCwgcm9sbGluZyBvdXQgcjEyMDUxMS4KSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3BhZ2Uv U2V0dGluZ3MuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3BhZ2UvU2V0dGluZ3Mu Y3BwCShyZXZpc2lvbiAxMjA1MTQpCisrKyBTb3VyY2UvV2ViQ29yZS9wYWdlL1NldHRpbmdzLmNw cAkod29ya2luZyBjb3B5KQpAQCAtMTMyLDcgKzEzMiw2IEBAIFNldHRpbmdzOjpTZXR0aW5ncyhQ YWdlKiBwYWdlKQogICAgICwgbV92YWxpZGF0aW9uTWVzc2FnZVRpbWVyTWFnbmlmaWNhdGlvbig1 MCkKICAgICAsIG1fbWluaW11bUFjY2VsZXJhdGVkMmRDYW52YXNTaXplKDI1NyAqIDI1NikKICAg ICAsIG1fbGF5b3V0RmFsbGJhY2tXaWR0aCg5ODApCi0gICAgLCBtX2RldmljZVBpeGVsUmF0aW8o MS4wKQogICAgICwgbV9tYXhpbXVtRGVjb2RlZEltYWdlU2l6ZShudW1lcmljX2xpbWl0czxzaXpl X3Q+OjptYXgoKSkKICAgICAsIG1fZGV2aWNlV2lkdGgoMCkKICAgICAsIG1fZGV2aWNlSGVpZ2h0 KDApCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9wYWdlL1NldHRpbmdzLmgKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g U291cmNlL1dlYkNvcmUvcGFnZS9TZXR0aW5ncy5oCShyZXZpc2lvbiAxMjA1MTQpCisrKyBTb3Vy Y2UvV2ViQ29yZS9wYWdlL1NldHRpbmdzLmgJKHdvcmtpbmcgY29weSkKQEAgLTQ3Miw5ICs0NzIs NiBAQCBuYW1lc3BhY2UgV2ViQ29yZSB7CiAgICAgICAgIHZvaWQgc2V0RGV2aWNlSGVpZ2h0KGlu dCBoZWlnaHQpIHsgbV9kZXZpY2VIZWlnaHQgPSBoZWlnaHQ7IH0KICAgICAgICAgaW50IGRldmlj ZUhlaWdodCgpIGNvbnN0IHsgcmV0dXJuIG1fZGV2aWNlSGVpZ2h0OyB9CiAKLSAgICAgICAgdm9p ZCBzZXREZXZpY2VQaXhlbFJhdGlvKGRvdWJsZSBkZXZpY2VQaXhlbFJhdGlvKSB7IG1fZGV2aWNl UGl4ZWxSYXRpbyA9IGRldmljZVBpeGVsUmF0aW87IH0KLSAgICAgICAgZG91YmxlIGRldmljZVBp eGVsUmF0aW8oKSBjb25zdCB7IHJldHVybiBtX2RldmljZVBpeGVsUmF0aW87IH0KLQogICAgICAg ICB2b2lkIHNldEZvcmNlQ29tcG9zaXRpbmdNb2RlKGJvb2wgZmxhZykgeyBtX2ZvcmNlQ29tcG9z aXRpbmdNb2RlID0gZmxhZzsgfQogICAgICAgICBib29sIGZvcmNlQ29tcG9zaXRpbmdNb2RlKCkg eyByZXR1cm4gbV9mb3JjZUNvbXBvc2l0aW5nTW9kZTsgfQogCkBAIC02MTcsNyArNjE0LDYgQEAg bmFtZXNwYWNlIFdlYkNvcmUgewogICAgICAgICBpbnQgbV92YWxpZGF0aW9uTWVzc2FnZVRpbWVy TWFnbmlmaWNhdGlvbjsKICAgICAgICAgaW50IG1fbWluaW11bUFjY2VsZXJhdGVkMmRDYW52YXNT aXplOwogICAgICAgICBpbnQgbV9sYXlvdXRGYWxsYmFja1dpZHRoOwotICAgICAgICBkb3VibGUg bV9kZXZpY2VQaXhlbFJhdGlvOwogICAgICAgICBzaXplX3QgbV9tYXhpbXVtRGVjb2RlZEltYWdl U2l6ZTsKICAgICAgICAgaW50IG1fZGV2aWNlV2lkdGg7CiAgICAgICAgIGludCBtX2RldmljZUhl aWdodDsKSW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3Vy Y2UvV2ViS2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDEyMDUyMikKKysrIFNvdXJjZS9XZWJLaXQy L0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIzIEBACisyMDEyLTA2LTE1ICBB ZGFtIEJhcnRoICA8YWJhcnRoQHdlYmtpdC5vcmc+CisKKyAgICAgICAgU2V0dGluZ3M6OmRldmlj ZVBpeGVsUmF0aW8gZG9lc24ndCBkbyBhbnl0aGluZyBhbmQgaXMgY29uZnVzaW5nCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04OTI3MgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogU2hhcmVkL1dlYlByZWZl cmVuY2VzU3RvcmUuaDoKKyAgICAgICAgKFdlYktpdCk6CisgICAgICAgICAgICAtIFJlbW92ZSBi b2lsZXJwbGF0ZSBjb2RlIGZvciB0aGUgc2V0dGluZy4KKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJ L3F0L3FxdWlja3dlYnZpZXcuY3BwOgorICAgICAgICAoUVF1aWNrV2ViVmlld0V4cGVyaW1lbnRh bDo6ZGV2aWNlUGl4ZWxSYXRpbyk6CisgICAgICAgIChRUXVpY2tXZWJWaWV3RXhwZXJpbWVudGFs OjpzZXREZXZpY2VQaXhlbFJhdGlvKToKKyAgICAgICAgICAgIC0gQ2hhbmdlIHRoZXNlIGZ1bmN0 aW9ucyB0byBnZXQgYW5kIHNldCB0aGUgcmVhbCBkZXZpY2Ugc2NhbGUgZmFjdG9yLgorICAgICAg ICAqIFdlYlByb2Nlc3MvV2ViUGFnZS9XZWJQYWdlLmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2Vi UGFnZTo6c2VuZFZpZXdwb3J0QXR0cmlidXRlc0NoYW5nZWQpOgorICAgICAgICAgICAgLSBVc2Ug dGhlIHJlYWwgZGV2aWNlIHNjYWxlIGZhY3RvciBmb3IgdGhlIHZpZXdwb3J0IGNhbGN1bGF0aW9u LgorICAgICAgICAoV2ViS2l0OjpXZWJQYWdlOjp1cGRhdGVQcmVmZXJlbmNlcyk6CisgICAgICAg ICAgICAtIFJlbW92ZSBib2lsZXJwbGF0ZSBjb2RlIGZvciB0aGUgc2V0dGluZy4KKwogMjAxMi0w Ni0xNSAgQ2hyaXN0b3BoZSBEdW1leiAgPGNocmlzdG9waGUuZHVtZXpAaW50ZWwuY29tPgogCiAg ICAgICAgIFtXSzJdIEFkZCBzdXBwb3J0IGZvciBleHBsaWNpdCBpbnRlbnRzCkluZGV4OiBTb3Vy Y2UvV2ViS2l0Mi9TaGFyZWQvV2ViUHJlZmVyZW5jZXNTdG9yZS5oCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNv dXJjZS9XZWJLaXQyL1NoYXJlZC9XZWJQcmVmZXJlbmNlc1N0b3JlLmgJKHJldmlzaW9uIDEyMDUx NCkKKysrIFNvdXJjZS9XZWJLaXQyL1NoYXJlZC9XZWJQcmVmZXJlbmNlc1N0b3JlLmgJKHdvcmtp bmcgY29weSkKQEAgLTExNyw3ICsxMTcsNiBAQCBuYW1lc3BhY2UgV2ViS2l0IHsKICAgICBcCiAK ICNkZWZpbmUgRk9SX0VBQ0hfV0VCS0lUX0RPVUJMRV9QUkVGRVJFTkNFKG1hY3JvKSBcCi0gICAg bWFjcm8oRGV2aWNlUGl4ZWxSYXRpbywgZGV2aWNlUGl4ZWxSYXRpbywgRG91YmxlLCBkb3VibGUs IDEuMCkgXAogICAgIG1hY3JvKFBERlNjYWxlRmFjdG9yLCBwZGZTY2FsZUZhY3RvciwgRG91Ymxl LCBkb3VibGUsIDApIFwKICAgICBcCiAKSW5kZXg6IFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9B UEkvcXQvcXF1aWNrd2Vidmlldy5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdDIvVUlQ cm9jZXNzL0FQSS9xdC9xcXVpY2t3ZWJ2aWV3LmNwcAkocmV2aXNpb24gMTIwNTE0KQorKysgU291 cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9xdC9xcXVpY2t3ZWJ2aWV3LmNwcAkod29ya2luZyBj b3B5KQpAQCAtMTIwMiw3ICsxMjAyLDcgQEAgdm9pZCBRUXVpY2tXZWJWaWV3RXhwZXJpbWVudGFs OjpzZXRVc2VyQQogZG91YmxlIFFRdWlja1dlYlZpZXdFeHBlcmltZW50YWw6OmRldmljZVBpeGVs UmF0aW8oKSBjb25zdAogewogICAgIFFfRChjb25zdCBRUXVpY2tXZWJWaWV3KTsKLSAgICByZXR1 cm4gZC0+d2ViUGFnZVByb3h5LT5wYWdlR3JvdXAoKS0+cHJlZmVyZW5jZXMoKS0+ZGV2aWNlUGl4 ZWxSYXRpbygpOworICAgIHJldHVybiBkLT53ZWJQYWdlUHJveHktPmRldmljZVNjYWxlRmFjdG9y KCk7CiB9CiAKIHZvaWQgUVF1aWNrV2ViVmlld0V4cGVyaW1lbnRhbDo6c2V0RGV2aWNlUGl4ZWxS YXRpbyhkb3VibGUgZGV2aWNlUGl4ZWxSYXRpbykKQEAgLTEyMTEsNyArMTIxMSw3IEBAIHZvaWQg UVF1aWNrV2ViVmlld0V4cGVyaW1lbnRhbDo6c2V0RGV2aWMKICAgICBpZiAoZGV2aWNlUGl4ZWxS YXRpbyA9PSB0aGlzLT5kZXZpY2VQaXhlbFJhdGlvKCkpCiAgICAgICAgIHJldHVybjsKIAotICAg IGQtPndlYlBhZ2VQcm94eS0+cGFnZUdyb3VwKCktPnByZWZlcmVuY2VzKCktPnNldERldmljZVBp eGVsUmF0aW8oZGV2aWNlUGl4ZWxSYXRpbyk7CisgICAgZC0+d2ViUGFnZVByb3h5LT5zZXRDdXN0 b21EZXZpY2VTY2FsZUZhY3RvcihkZXZpY2VQaXhlbFJhdGlvKTsKICAgICBlbWl0IGRldmljZVBp eGVsUmF0aW9DaGFuZ2VkKCk7CiB9CiAKSW5kZXg6IFNvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3Mv V2ViUGFnZS9XZWJQYWdlLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9XZWJQcm9j ZXNzL1dlYlBhZ2UvV2ViUGFnZS5jcHAJKHJldmlzaW9uIDEyMDUxNCkKKysrIFNvdXJjZS9XZWJL aXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9XZWJQYWdlLmNwcAkod29ya2luZyBjb3B5KQpAQCAtOTAy LDcgKzkwMiw3IEBAIHZvaWQgV2ViUGFnZTo6c2VuZFZpZXdwb3J0QXR0cmlidXRlc0NoYW4KICAg ICBpbnQgZGV2aWNlV2lkdGggPSAoc2V0dGluZ3MtPmRldmljZVdpZHRoKCkgPiAwKSA/IHNldHRp bmdzLT5kZXZpY2VXaWR0aCgpIDogbV92aWV3cG9ydFNpemUud2lkdGgoKTsKICAgICBpbnQgZGV2 aWNlSGVpZ2h0ID0gKHNldHRpbmdzLT5kZXZpY2VIZWlnaHQoKSA+IDApID8gc2V0dGluZ3MtPmRl dmljZUhlaWdodCgpIDogbV92aWV3cG9ydFNpemUuaGVpZ2h0KCk7CiAKLSAgICBWaWV3cG9ydEF0 dHJpYnV0ZXMgYXR0ciA9IGNvbXB1dGVWaWV3cG9ydEF0dHJpYnV0ZXMobV9wYWdlLT52aWV3cG9y dEFyZ3VtZW50cygpLCBtaW5pbXVtTGF5b3V0RmFsbGJhY2tXaWR0aCwgZGV2aWNlV2lkdGgsIGRl dmljZUhlaWdodCwgc3RhdGljX2Nhc3Q8aW50PigxNjAgKiBzZXR0aW5ncy0+ZGV2aWNlUGl4ZWxS YXRpbygpKSwgbV92aWV3cG9ydFNpemUpOworICAgIFZpZXdwb3J0QXR0cmlidXRlcyBhdHRyID0g Y29tcHV0ZVZpZXdwb3J0QXR0cmlidXRlcyhtX3BhZ2UtPnZpZXdwb3J0QXJndW1lbnRzKCksIG1p bmltdW1MYXlvdXRGYWxsYmFja1dpZHRoLCBkZXZpY2VXaWR0aCwgZGV2aWNlSGVpZ2h0LCBzdGF0 aWNfY2FzdDxpbnQ+KDE2MCAqIG1fcGFnZS0+ZGV2aWNlU2NhbGVGYWN0b3IoKSksIG1fdmlld3Bv cnRTaXplKTsKIAogICAgIHNldFJlc2l6ZXNUb0NvbnRlbnRzVXNpbmdMYXlvdXRTaXplKEludFNp emUoc3RhdGljX2Nhc3Q8aW50PihhdHRyLmxheW91dFNpemUud2lkdGgoKSksIHN0YXRpY19jYXN0 PGludD4oYXR0ci5sYXlvdXRTaXplLmhlaWdodCgpKSkpOwogICAgIHNlbmQoTWVzc2FnZXM6Oldl YlBhZ2VQcm94eTo6RGlkQ2hhbmdlVmlld3BvcnRQcm9wZXJ0aWVzKGF0dHIpKTsKQEAgLTE5NzQs NyArMTk3NCw2IEBAIHZvaWQgV2ViUGFnZTo6dXBkYXRlUHJlZmVyZW5jZXMoY29uc3QgV2UKICAg ICBzZXR0aW5ncy0+c2V0RGVmYXVsdEZvbnRTaXplKHN0b3JlLmdldFVJbnQzMlZhbHVlRm9yS2V5 KFdlYlByZWZlcmVuY2VzS2V5OjpkZWZhdWx0Rm9udFNpemVLZXkoKSkpOwogICAgIHNldHRpbmdz LT5zZXREZWZhdWx0Rml4ZWRGb250U2l6ZShzdG9yZS5nZXRVSW50MzJWYWx1ZUZvcktleShXZWJQ cmVmZXJlbmNlc0tleTo6ZGVmYXVsdEZpeGVkRm9udFNpemVLZXkoKSkpOwogICAgIHNldHRpbmdz LT5zZXRMYXlvdXRGYWxsYmFja1dpZHRoKHN0b3JlLmdldFVJbnQzMlZhbHVlRm9yS2V5KFdlYlBy ZWZlcmVuY2VzS2V5OjpsYXlvdXRGYWxsYmFja1dpZHRoS2V5KCkpKTsKLSAgICBzZXR0aW5ncy0+ c2V0RGV2aWNlUGl4ZWxSYXRpbyhzdG9yZS5nZXREb3VibGVWYWx1ZUZvcktleShXZWJQcmVmZXJl bmNlc0tleTo6ZGV2aWNlUGl4ZWxSYXRpb0tleSgpKSk7CiAgICAgc2V0dGluZ3MtPnNldERldmlj ZVdpZHRoKHN0b3JlLmdldFVJbnQzMlZhbHVlRm9yS2V5KFdlYlByZWZlcmVuY2VzS2V5OjpkZXZp Y2VXaWR0aEtleSgpKSk7CiAgICAgc2V0dGluZ3MtPnNldERldmljZUhlaWdodChzdG9yZS5nZXRV SW50MzJWYWx1ZUZvcktleShXZWJQcmVmZXJlbmNlc0tleTo6ZGV2aWNlSGVpZ2h0S2V5KCkpKTsK ICAgICBzZXR0aW5ncy0+c2V0RWRpdGFibGVMaW5rQmVoYXZpb3Ioc3RhdGljX2Nhc3Q8V2ViQ29y ZTo6RWRpdGFibGVMaW5rQmVoYXZpb3I+KHN0b3JlLmdldFVJbnQzMlZhbHVlRm9yS2V5KFdlYlBy ZWZlcmVuY2VzS2V5OjplZGl0YWJsZUxpbmtCZWhhdmlvcktleSgpKSkpOwo=