89249 2012-06-15 14:53:58 -0700 nrwt: metered output doesn't handle ^C cleanly 2012-06-18 11:45:54 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 dpranke dpranke abarth ap eric ojan rniwa tony webkit.review.bot oldest_to_newest 650539 0 dpranke 2012-06-15 14:53:58 -0700 nrwt: metered output doesn't handle ^C cleanly 650542 1 147906 dpranke 2012-06-15 14:55:30 -0700 Created attachment 147906 Patch 650565 2 147906 tony 2012-06-15 15:19:16 -0700 Comment on attachment 147906 Patch Should there be a test for flush()? 650569 3 dpranke 2012-06-15 15:21:48 -0700 (In reply to comment #2) > (From update of attachment 147906 [details]) > Should there be a test for flush()? it's covered by the integration tests that test interrupt handling. 650578 4 tony 2012-06-15 15:32:09 -0700 (In reply to comment #3) > (In reply to comment #2) > > (From update of attachment 147906 [details] [details]) > > Should there be a test for flush()? > > it's covered by the integration tests that test interrupt handling. Might be worth mentioning that in the changelog like we do when making webcore changes. 650633 5 dpranke 2012-06-15 17:07:23 -0700 (In reply to comment #4) > Might be worth mentioning that in the changelog like we do when making webcore changes. good point. will do. 651590 6 dpranke 2012-06-18 11:45:54 -0700 Committed r120611: <http://trac.webkit.org/changeset/120611> 147906 2012-06-15 14:55:30 -0700 2012-06-15 15:19:16 -0700 Patch bug-89249-20120615145530.patch text/plain 3476 dpranke U3VidmVyc2lvbiBSZXZpc2lvbjogMTIwNDg4CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggY2E0OGEwM2Q2MDI2OWNmNzc4OTgxZjEwNjE3NDY3MTll ODIzM2FhNS4uNDE5MDRjYjgyZDdlODE4ZmM2YTcxYWZmMmE0NWU5MzZhNGU1NWM2NCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDI4 IEBACiAyMDEyLTA2LTE1ICBEaXJrIFByYW5rZSAgPGRwcmFua2VAY2hyb21pdW0ub3JnPgogCisg ICAgICAgIG5yd3Q6IG1ldGVyZWQgb3V0cHV0IGRvZXNuJ3QgaGFuZGxlIF5DIGNsZWFubHkKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTg5MjQ5CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgSWYgeW91IGN0cmwt YyBhIHJ1bm5pbmcgbnJ3dCAody9vIC0tdmVyYm9zZSksIHRoZW4gYWxsIGJ1dAorICAgICAgICB0 d28gY2hhcmFjdGVycyBvZiB0aGUgbGFzdCB1cGRhdGUgYXJlIGVyYXNlZCwgYW5kIHRoZW4gd2Ug cHJpbnQKKyAgICAgICAgImludGVycnVwdGVkLCBleGl0aW5nIiBhcyBhbiB1cGRhdGUsIHdoaWNo IGl0c2VsZiB0aGVuIGdldHMKKyAgICAgICAgZXJhc2VkLiBGaXggdGhpcyBzbyB0aGF0IHdlIGZs dXNoIHRoZSBtZXRlciAobWFraW5nIHRoZSBsYXN0CisgICAgICAgIHVwZGF0ZSBwZXJzaXN0ZW50 LCBzbyB0aGF0IHdlIHByaW50IHRoZSBeQyBmb3IgYSB2aXN1YWwgY2x1ZSksCisgICAgICAgIHBy aW50IHRoZSBpbnRlcnJ1cHQgbWVzc2FnZSwgYW5kIG1vdmUgb24gLi4uCisKKyAgICAgICAgKiBT Y3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9jb250cm9sbGVycy9tYW5hZ2VyLnB5OgorICAg ICAgICAoTWFuYWdlci5fcnVuX3Rlc3RzKToKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L2xh eW91dF90ZXN0cy92aWV3cy9tZXRlcmVkX3N0cmVhbS5weToKKyAgICAgICAgKE1ldGVyZWRTdHJl YW0uZmx1c2gpOgorICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3ZpZXdz L3ByaW50aW5nLnB5OgorICAgICAgICAoUHJpbnRlci5fd3JpdGUpOgorICAgICAgICAoUHJpbnRl cik6CisgICAgICAgIChQcmludGVyLmZsdXNoKToKKworMjAxMi0wNi0xNSAgRGlyayBQcmFua2Ug IDxkcHJhbmtlQGNocm9taXVtLm9yZz4KKwogICAgICAgICB3ZWJraXRweTogcmVtb3ZlIER1bW15 T3B0aW9ucyBhbmQgY2xlYW4gdXAgdGhlIGNvZGUgaW4gUG9ydC5nZXRfb3B0aW9uKCkgYW5kIFBv cnQuc2V0X29wdGlvbl9kZWZhdWx0KCkKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTg5MTM1CiAKZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0 cHkvbGF5b3V0X3Rlc3RzL2NvbnRyb2xsZXJzL21hbmFnZXIucHkgYi9Ub29scy9TY3JpcHRzL3dl YmtpdHB5L2xheW91dF90ZXN0cy9jb250cm9sbGVycy9tYW5hZ2VyLnB5CmluZGV4IDBiMzM1ZGIx MGQ0NTM3YzRjZmU0OWQyMzdlZDI2YjE4NjE5NDA2MzkuLmVlNmQ1YWZjOTYyNjc4ZjYwNDM2Y2Q2 N2JlNDRhZWJlZmM0YTMxN2YgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5 b3V0X3Rlc3RzL2NvbnRyb2xsZXJzL21hbmFnZXIucHkKKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJr aXRweS9sYXlvdXRfdGVzdHMvY29udHJvbGxlcnMvbWFuYWdlci5weQpAQCAtODE0LDcgKzgxNCw4 IEBAIGNsYXNzIE1hbmFnZXIob2JqZWN0KToKICAgICAgICAgICAgICAgICAgICAgICAgIF9sb2cu ZXJyb3IoJ1dvcmtlciAlZCBkaWQgbm90IGV4aXQgaW4gdGltZS4nICUgd29ya2VyX3N0YXRlLm51 bWJlcikKIAogICAgICAgICBleGNlcHQgS2V5Ym9hcmRJbnRlcnJ1cHQ6Ci0gICAgICAgICAgICBz ZWxmLl9wcmludGVyLnByaW50X3VwZGF0ZSgnSW50ZXJydXB0ZWQsIGV4aXRpbmcgLi4uJykKKyAg ICAgICAgICAgIHNlbGYuX3ByaW50ZXIuZmx1c2goKQorICAgICAgICAgICAgc2VsZi5fcHJpbnRl ci53cml0ZSgnSW50ZXJydXB0ZWQsIGV4aXRpbmcgLi4uJykKICAgICAgICAgICAgIHNlbGYuY2Fu Y2VsX3dvcmtlcnMoKQogICAgICAgICAgICAga2V5Ym9hcmRfaW50ZXJydXB0ZWQgPSBUcnVlCiAg ICAgICAgIGV4Y2VwdCBUZXN0UnVuSW50ZXJydXB0ZWRFeGNlcHRpb24sIGU6CmRpZmYgLS1naXQg YS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy92aWV3cy9tZXRlcmVkX3N0cmVh bS5weSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3ZpZXdzL21ldGVyZWRf c3RyZWFtLnB5CmluZGV4IDQ5YTUwN2VkNjNkZTE0YTc2ZTUyZGI2NGNjZmY3NDhjYWQ4NjA2ZTUu LjVhZmE2YWY0YWQzMDU4YTkwNWExMzc5OTc1NGU5ZDAyMjZmMmI3MjcgMTAwNjQ0Ci0tLSBhL1Rv b2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3ZpZXdzL21ldGVyZWRfc3RyZWFtLnB5 CisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3ZpZXdzL21ldGVyZWRf c3RyZWFtLnB5CkBAIC0xMTQsNiArMTE0LDExIEBAIGNsYXNzIE1ldGVyZWRTdHJlYW0ob2JqZWN0 KToKICAgICAgICAgc2VsZi5fc3RyZWFtLndyaXRlKHNlbGYuX2VyYXN1cmUoc2VsZi5fbGFzdF9w YXJ0aWFsX2xpbmUpKQogICAgICAgICBzZWxmLl9sYXN0X3BhcnRpYWxfbGluZSA9ICcnCiAKKyAg ICBkZWYgZmx1c2goc2VsZik6CisgICAgICAgIGlmIHNlbGYuX2xhc3RfcGFydGlhbF9saW5lOgor ICAgICAgICAgICAgc2VsZi5fc3RyZWFtLndyaXRlKCdcbicpCisgICAgICAgICAgICBzZWxmLl9s YXN0X3BhcnRpYWxfbGluZSA9ICcnCisgICAgICAgICAgICBzZWxmLl9zdHJlYW0uZmx1c2goKQog CiBjbGFzcyBfTG9nSGFuZGxlcihsb2dnaW5nLkhhbmRsZXIpOgogICAgIGRlZiBfX2luaXRfXyhz ZWxmLCBtZXRlcik6CmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90 ZXN0cy92aWV3cy9wcmludGluZy5weSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rl c3RzL3ZpZXdzL3ByaW50aW5nLnB5CmluZGV4IDNkZjI5NTZjMTgyNjE4ZWQwZGNmMTNlZDZmMTg1 ZTUxMGU0ODdmYmEuLjUwOWEzNGEwYzIxNDJiZmE3YzlmN2NjNDdhYzFhOTI0YWNlMGYyNmQgMTAw NjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3ZpZXdzL3ByaW50 aW5nLnB5CisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3ZpZXdzL3By aW50aW5nLnB5CkBAIC00MDksMyArNDA5LDYgQEAgY2xhc3MgUHJpbnRlcihvYmplY3QpOgogCiAg ICAgZGVmIF93cml0ZShzZWxmLCBtc2cpOgogICAgICAgICBzZWxmLl9tZXRlci53cml0ZWxuKG1z ZykKKworICAgIGRlZiBmbHVzaChzZWxmKToKKyAgICAgICAgc2VsZi5fbWV0ZXIuZmx1c2goKQo=