89247 2012-06-15 14:32:38 -0700 [chromium] Fix composited scrollbars with transparent thumbs 2012-06-15 16:33:40 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 enne enne cc-bugs enne jamesr webkit.review.bot oldest_to_newest 650513 0 enne 2012-06-15 14:32:38 -0700 [chromium] Fix composited scrollbars with transparent thumbs 650515 1 147900 enne 2012-06-15 14:34:13 -0700 Created attachment 147900 Patch 650526 2 enne 2012-06-15 14:37:35 -0700 See: http://code.google.com/p/chromium/issues/detail?id=132995 ChromeOS's scrollbar native theme expects the thumb to be transparent, so if blending isn't turned on then it renders incorrectly as black. I tried making a test for this, but unfortunately render theme scrollbars don't appear to respect opacity. I'll take suggestions for testing. 650527 3 147900 jamesr 2012-06-15 14:41:00 -0700 Comment on attachment 147900 Patch Re testing: have a setter on the mock scrollbar theme? 650568 4 147900 enne 2012-06-15 15:20:38 -0700 Comment on attachment 147900 Patch I'm going to just CQ+ this since it fixes an issue. Once ScrollbarLayerChromium supports native Mac scrollbars, compositing layout tests can cover this naturally, without awkwardly plumbing a setting down to ScrollbarThemeMock just for this one regression. 650620 5 147900 webkit.review.bot 2012-06-15 16:33:36 -0700 Comment on attachment 147900 Patch Clearing flags on attachment: 147900 Committed r120509: <http://trac.webkit.org/changeset/120509> 650621 6 webkit.review.bot 2012-06-15 16:33:40 -0700 All reviewed patches have been landed. Closing bug. 147900 2012-06-15 14:34:13 -0700 2012-06-15 16:33:36 -0700 Patch bug-89247-20120615143412.patch text/plain 3627 enne U3VidmVyc2lvbiBSZXZpc2lvbjogMTIwNDY4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNTJmYTc3YTRiZGNmNzA0 ZDczN2QwOGUxNDI1NDIxZDMwMTc4MjA4MC4uMTBmYmE5ZmZhNjkyZDk5OGMzZWNjY2JhN2U3MTk3 Mzk5ZmQ1ZjkyYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDEyLTA2LTE1ICBBZHJp ZW5uZSBXYWxrZXIgIDxlbm5lQGdvb2dsZS5jb20+CisKKyAgICAgICAgW2Nocm9taXVtXSBGaXgg Y29tcG9zaXRlZCBzY3JvbGxiYXJzIHdpdGggdHJhbnNwYXJlbnQgdGh1bWJzCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04OTI0NworCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE9uIHNvbWUgcGxhdGZvcm1zLCB0 aGUgdGh1bWIgb2YgYSBzY3JvbGxiYXIgY2FuIGJlIHRyYW5zcGFyZW50LiBGaXggYnkKKyAgICAg ICAgYWx3YXlzIGRyYXdpbmcgdGhlIHRodW1iIHF1YWQgd2l0aCBibGVuZGluZy4KKworICAgICAg ICAqIHBsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL2NjL0NDU2Nyb2xsYmFyTGF5ZXJJbXBsLmNw cDoKKyAgICAgICAgKFdlYkNvcmU6OkNDU2Nyb2xsYmFyTGF5ZXJJbXBsOjphcHBlbmRRdWFkcyk6 CisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vY2MvQ0NUZXh0dXJlRHJhd1F1 YWQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6Q0NUZXh0dXJlRHJhd1F1YWQ6OnNldE5lZWRzQmxl bmRpbmcpOgorICAgICAgICAoV2ViQ29yZSk6CisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3Mv Y2hyb21pdW0vY2MvQ0NUZXh0dXJlRHJhd1F1YWQuaDoKKyAgICAgICAgKENDVGV4dHVyZURyYXdR dWFkKToKKwogMjAxMi0wNi0xNSAgUGF2ZWwgRmVsZG1hbiAgPHBmZWxkbWFuQGNocm9taXVtLm9y Zz4KIAogICAgICAgICBXZWIgSW5zcGVjdG9yOiBMb25nIGZyYW1lIHVybHMgbWFrZSBhbGwvZXJy b3JzL3dhcm5pbmdzL2xvZ3MgYnV0dG9ucyBpbmFjY2Vzc2libGUuCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9jYy9DQ1Njcm9sbGJhckxheWVy SW1wbC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9jYy9D Q1Njcm9sbGJhckxheWVySW1wbC5jcHAKaW5kZXggNDViMTZmYTViY2MxMDk1ZTk2YWY1OWI2Nzll MzY1MWQwNzNlNmVmZS4uMWZkMGM3OWJjZDQ0NzlkZjkzZDgwN2RlOTBlNTVhNGE0MWM5MTg2ZCAx MDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vY2Mv Q0NTY3JvbGxiYXJMYXllckltcGwuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dy YXBoaWNzL2Nocm9taXVtL2NjL0NDU2Nyb2xsYmFyTGF5ZXJJbXBsLmNwcApAQCAtNjUsOCArNjUs MTIgQEAgdm9pZCBDQ1Njcm9sbGJhckxheWVySW1wbDo6YXBwZW5kUXVhZHMoQ0NRdWFkQ3VsbGVy JiBxdWFkTGlzdCwgY29uc3QgQ0NTaGFyZWRRdWEKIAogICAgIEludFJlY3QgdGh1bWJSZWN0ID0g dGhlbWUtPnRodW1iUmVjdCgmbV9zY3JvbGxiYXIpOwogICAgIHRodW1iUmVjdC5tb3ZlKC1tX3Nj cm9sbGJhci54KCksIC1tX3Njcm9sbGJhci55KCkpOwotICAgIGlmIChtX3RodW1iVGV4dHVyZUlk ICYmIHRoZW1lLT5oYXNUaHVtYigmbV9zY3JvbGxiYXIpICYmICF0aHVtYlJlY3QuaXNFbXB0eSgp KQotICAgICAgICBxdWFkTGlzdC5hcHBlbmQoQ0NUZXh0dXJlRHJhd1F1YWQ6OmNyZWF0ZShzaGFy ZWRRdWFkU3RhdGUsIHRodW1iUmVjdCwgbV90aHVtYlRleHR1cmVJZCwgcHJlbXVsdGlwbGVkQWxw aGEsIHV2UmVjdCwgZmxpcHBlZCkpOworICAgIGlmIChtX3RodW1iVGV4dHVyZUlkICYmIHRoZW1l LT5oYXNUaHVtYigmbV9zY3JvbGxiYXIpICYmICF0aHVtYlJlY3QuaXNFbXB0eSgpKSB7CisgICAg ICAgIE93blB0cjxDQ1RleHR1cmVEcmF3UXVhZD4gcXVhZCA9IENDVGV4dHVyZURyYXdRdWFkOjpj cmVhdGUoc2hhcmVkUXVhZFN0YXRlLCB0aHVtYlJlY3QsIG1fdGh1bWJUZXh0dXJlSWQsIHByZW11 bHRpcGxlZEFscGhhLCB1dlJlY3QsIGZsaXBwZWQpOworICAgICAgICBxdWFkLT5zZXROZWVkc0Js ZW5kaW5nKCk7CisgICAgICAgIHF1YWRMaXN0LmFwcGVuZChxdWFkLnJlbGVhc2UoKSk7CisgICAg fQorCiAgICAgaWYgKCFtX2JhY2tncm91bmRUZXh0dXJlSWQpCiAgICAgICAgIHJldHVybjsKIApk aWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vY2Mv Q0NUZXh0dXJlRHJhd1F1YWQuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mv Y2hyb21pdW0vY2MvQ0NUZXh0dXJlRHJhd1F1YWQuY3BwCmluZGV4IDg1OWU5ZDlkMzlmZjA5N2Nm YjNiZWY2YjA3ZDIwMzRjZTBlN2E5ZTMuLmJkYmNhOTVmYmU4ZTYxODFkNjM5MjYxOTEzZDE0ZGUx MmIyOWM5ZDQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2No cm9taXVtL2NjL0NDVGV4dHVyZURyYXdRdWFkLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9jYy9DQ1RleHR1cmVEcmF3UXVhZC5jcHAKQEAgLTQzLDQg KzQzLDkgQEAgQ0NUZXh0dXJlRHJhd1F1YWQ6OkNDVGV4dHVyZURyYXdRdWFkKGNvbnN0IENDU2hh cmVkUXVhZFN0YXRlKiBzaGFyZWRRdWFkU3RhdGUsIGMKIHsKIH0KIAordm9pZCBDQ1RleHR1cmVE cmF3UXVhZDo6c2V0TmVlZHNCbGVuZGluZygpCit7CisgICAgbV9uZWVkc0JsZW5kaW5nID0gdHJ1 ZTsKK30KKwogfQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mv Y2hyb21pdW0vY2MvQ0NUZXh0dXJlRHJhd1F1YWQuaCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L2dyYXBoaWNzL2Nocm9taXVtL2NjL0NDVGV4dHVyZURyYXdRdWFkLmgKaW5kZXggNTkxMDAxYmM4 NmEzNWQxZjA1NDFkNzZmYWEwM2I1YTI4MTVjODdmNy4uYTRiYWVmYTEzM2FmNGEwMjEzZThlNWY3 ZjkxZGM5MmFhMGQ0M2E4NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3Jh cGhpY3MvY2hyb21pdW0vY2MvQ0NUZXh0dXJlRHJhd1F1YWQuaAorKysgYi9Tb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9jYy9DQ1RleHR1cmVEcmF3UXVhZC5oCkBAIC00 MSw2ICs0MSw4IEBAIHB1YmxpYzoKICAgICBGbG9hdFJlY3QgdXZSZWN0KCkgY29uc3QgeyByZXR1 cm4gbV91dlJlY3Q7IH0KICAgICBib29sIGZsaXBwZWQoKSBjb25zdCB7IHJldHVybiBtX2ZsaXBw ZWQ7IH0KIAorICAgIHZvaWQgc2V0TmVlZHNCbGVuZGluZygpOworCiBwcml2YXRlOgogICAgIEND VGV4dHVyZURyYXdRdWFkKGNvbnN0IENDU2hhcmVkUXVhZFN0YXRlKiwgY29uc3QgSW50UmVjdCYs IHVuc2lnbmVkIHRleHR1cmVfaWQsIGJvb2wgcHJlbXVsdGlwbGllZEFscGhhLCBjb25zdCBGbG9h dFJlY3QmIHV2UmVjdCwgYm9vbCBmbGlwcGVkKTsKICAgICAK