89245 2012-06-15 13:57:51 -0700 [BlackBerry] Remove touch events handling hook for popup 2012-06-15 16:05:36 -0700 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 haizhang webkit-unassigned tonikitoo webkit.review.bot oldest_to_newest 650474 0 haizhang 2012-06-15 13:57:51 -0700 In the old patches we create a new WebPage for popup, so we need to hook up our own touch handling functions, since we don't use our own WebPage any more, no need to keep the touch handling code, because it just does nothing other than passing out the events which might cause the touch events being handled twice. 650489 1 147896 haizhang 2012-06-15 14:07:39 -0700 Created attachment 147896 patch 650494 2 147896 rwlbuis 2012-06-15 14:13:25 -0700 Comment on attachment 147896 patch Looks good. 650597 3 147896 webkit.review.bot 2012-06-15 16:05:32 -0700 Comment on attachment 147896 patch Clearing flags on attachment: 147896 Committed r120505: <http://trac.webkit.org/changeset/120505> 650598 4 webkit.review.bot 2012-06-15 16:05:36 -0700 All reviewed patches have been landed. Closing bug. 147896 2012-06-15 14:07:39 -0700 2012-06-15 16:05:32 -0700 patch 0001-2012-06-15-Crystal-Zhang-haizhang-rim.com.patch text/plain 4731 haizhang RnJvbSAwYTI0ZjVlZGQzYmUyMTk1OTM1YzczMThiMTNhMTY2MmViYzUyOWNlIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBDcnlzdGFsIFpoYW5nIDxoYWl6aGFuZ0ByaW0uY29tPgpEYXRl OiBGcmksIDE1IEp1biAyMDEyIDE3OjA0OjU5IC0wNDAwClN1YmplY3Q6IFtQQVRDSF0gMjAxMi0w Ni0xNSAgQ3J5c3RhbCBaaGFuZyAgPGhhaXpoYW5nQHJpbS5jb20+CgogICAgICAgIFtCbGFja0Jl cnJ5XSBSZW1vdmUgdG91Y2ggZXZlbnRzIGhhbmRsaW5nIGhvb2sgZm9yIHBvcHVwCiAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTg5MjQ1CgogICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgoKICAgICAgICBJbiB0aGUgb2xkIHBhdGNoZXMgd2Ug Y3JlYXRlIG91ciBvd24gV2ViUGFnZSBmb3IgcG9wdXAsIHNvIHdlIG5lZWQgdG8gaG9vayB1cCBv dXIgb3duCiAgICAgICAgdG91Y2ggaGFuZGxpbmcgZnVuY3Rpb25zLCBzaW5jZSB3ZSBkb24ndCB1 c2Ugb3VyIG93biBXZWJQYWdlIGFueSBtb3JlLCBubyBuZWVkIHRvIGtlZXAKICAgICAgICB0aGUg dG91Y2ggaGFuZGxpbmcgY29kZSwgYmVjYXVzZSBpdCBqdXN0IGRvZXMgbm90aGluZyBvdGhlciB0 aGFuIHBhc3Npbmcgb3V0IHRoZSBldmVudHMKICAgICAgICB3aGljaCBtaWdodCBjYXVzZSB0aGUg dG91Y2ggZXZlbnRzIGJlaW5nIGhhbmRsZWQgdHdpY2UuCgogICAgICAgICogQXBpL1dlYlBhZ2Uu Y3BwOgogICAgICAgIChCbGFja0JlcnJ5OjpXZWJLaXQ6OldlYlBhZ2VQcml2YXRlOjpoYW5kbGVN b3VzZUV2ZW50KToKICAgICAgICAqIFdlYkNvcmVTdXBwb3J0L1BhZ2VQb3B1cEJsYWNrQmVycnku Y3BwOgogICAgICAgICogV2ViQ29yZVN1cHBvcnQvUGFnZVBvcHVwQmxhY2tCZXJyeS5oOgogICAg ICAgIChQYWdlUG9wdXBCbGFja0JlcnJ5KToKLS0tCiBTb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkv QXBpL1dlYlBhZ2UuY3BwICAgICAgICAgICAgIHwgICAgMyAtLS0KIFNvdXJjZS9XZWJLaXQvYmxh Y2tiZXJyeS9DaGFuZ2VMb2cgICAgICAgICAgICAgICAgICAgfCAgIDE4ICsrKysrKysrKysrKysr KysrKwogLi4uL1dlYkNvcmVTdXBwb3J0L1BhZ2VQb3B1cEJsYWNrQmVycnkuY3BwICAgICAgICAg ICB8ICAgMTQgLS0tLS0tLS0tLS0tLS0KIC4uLi9ibGFja2JlcnJ5L1dlYkNvcmVTdXBwb3J0L1Bh Z2VQb3B1cEJsYWNrQmVycnkuaCAgfCAgICAzIC0tLQogNCBmaWxlcyBjaGFuZ2VkLCAxOCBpbnNl cnRpb25zKCspLCAyMCBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Js YWNrYmVycnkvQXBpL1dlYlBhZ2UuY3BwIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0FwaS9X ZWJQYWdlLmNwcAppbmRleCBhNTFkOTY3Li41M2Q2OTkwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi S2l0L2JsYWNrYmVycnkvQXBpL1dlYlBhZ2UuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvYmxhY2ti ZXJyeS9BcGkvV2ViUGFnZS5jcHAKQEAgLTM5MzgsOSArMzkzOCw2IEBAIGJvb2wgV2ViUGFnZVBy aXZhdGU6OmhhbmRsZU1vdXNlRXZlbnQoUGxhdGZvcm1Nb3VzZUV2ZW50JiBtb3VzZUV2ZW50KQog ICAgIGlmIChtb3VzZUV2ZW50LnR5cGUoKSA9PSBXZWJDb3JlOjpQbGF0Zm9ybUV2ZW50OjpNb3Vz ZVNjcm9sbCkKICAgICAgICAgcmV0dXJuIHRydWU7CiAKLSAgICBpZiAobV9wYXJlbnRQb3B1cCkK LSAgICAgICAgbV9wYXJlbnRQb3B1cC0+aGFuZGxlTW91c2VFdmVudChtb3VzZUV2ZW50KTsKLQog ICAgIE5vZGUqIG5vZGUgPSAwOwogICAgIGlmIChtb3VzZUV2ZW50LmlucHV0TWV0aG9kKCkgPT0g VG91Y2hTY3JlZW4pIHsKICAgICAgICAgY29uc3QgRmF0RmluZ2Vyc1Jlc3VsdCBsYXN0RmF0Rmlu Z2Vyc1Jlc3VsdCA9IG1fdG91Y2hFdmVudEhhbmRsZXItPmxhc3RGYXRGaW5nZXJzUmVzdWx0KCk7 CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvQ2hhbmdlTG9nIGIvU291cmNl L1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZwppbmRleCA2MWFkZjdiLi42ZDFkYzA1IDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9X ZWJLaXQvYmxhY2tiZXJyeS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMSBAQAorMjAxMi0wNi0xNSAg Q3J5c3RhbCBaaGFuZyAgPGhhaXpoYW5nQHJpbS5jb20+CisKKyAgICAgICAgW0JsYWNrQmVycnld IFJlbW92ZSB0b3VjaCBldmVudHMgaGFuZGxpbmcgaG9vayBmb3IgcG9wdXAKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTg5MjQ1CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgSW4gdGhlIG9sZCBwYXRjaGVzIHdl IGNyZWF0ZSBvdXIgb3duIFdlYlBhZ2UgZm9yIHBvcHVwLCBzbyB3ZSBuZWVkIHRvIGhvb2sgdXAg b3VyIG93bgorICAgICAgICB0b3VjaCBoYW5kbGluZyBmdW5jdGlvbnMsIHNpbmNlIHdlIGRvbid0 IHVzZSBvdXIgb3duIFdlYlBhZ2UgYW55IG1vcmUsIG5vIG5lZWQgdG8ga2VlcAorICAgICAgICB0 aGUgdG91Y2ggaGFuZGxpbmcgY29kZSwgYmVjYXVzZSBpdCBqdXN0IGRvZXMgbm90aGluZyBvdGhl ciB0aGFuIHBhc3Npbmcgb3V0IHRoZSBldmVudHMKKyAgICAgICAgd2hpY2ggbWlnaHQgY2F1c2Ug dGhlIHRvdWNoIGV2ZW50cyBiZWluZyBoYW5kbGVkIHR3aWNlLgorCisgICAgICAgICogQXBpL1dl YlBhZ2UuY3BwOgorICAgICAgICAoQmxhY2tCZXJyeTo6V2ViS2l0OjpXZWJQYWdlUHJpdmF0ZTo6 aGFuZGxlTW91c2VFdmVudCk6CisgICAgICAgICogV2ViQ29yZVN1cHBvcnQvUGFnZVBvcHVwQmxh Y2tCZXJyeS5jcHA6CisgICAgICAgICogV2ViQ29yZVN1cHBvcnQvUGFnZVBvcHVwQmxhY2tCZXJy eS5oOgorICAgICAgICAoUGFnZVBvcHVwQmxhY2tCZXJyeSk6CisKIDIwMTItMDYtMTUgIEphY2t5 IEppYW5nICA8emhhamlhbmdAcmltLmNvbT4KIAogICAgICAgICBbQmxhY2tCZXJyeV0gQ2VydGFp biB3ZWIgcGFnZXMgKGkuZS4sIGh0dHA6Ly93d3cuY2xvdWR0d2Vha3MuY29tLykgYXJlIGFsbG93 ZWQgdG8gYmUgd2lkZXIgdGhhbiB0aGUgc2NyZWVuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0 L2JsYWNrYmVycnkvV2ViQ29yZVN1cHBvcnQvUGFnZVBvcHVwQmxhY2tCZXJyeS5jcHAgYi9Tb3Vy Y2UvV2ViS2l0L2JsYWNrYmVycnkvV2ViQ29yZVN1cHBvcnQvUGFnZVBvcHVwQmxhY2tCZXJyeS5j cHAKaW5kZXggMmFiZTQzNS4uMDFmN2JjOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9ibGFj a2JlcnJ5L1dlYkNvcmVTdXBwb3J0L1BhZ2VQb3B1cEJsYWNrQmVycnkuY3BwCisrKyBiL1NvdXJj ZS9XZWJLaXQvYmxhY2tiZXJyeS9XZWJDb3JlU3VwcG9ydC9QYWdlUG9wdXBCbGFja0JlcnJ5LmNw cApAQCAtMTU5LDIwICsxNTksNiBAQCB2b2lkIFBhZ2VQb3B1cEJsYWNrQmVycnk6Omluc3RhbGxE b21GdW5jdGlvbihGcmFtZSogZnJhbWUpCiAgICAgSlNDbGFzc1JlbGVhc2UoY2xpZW50Q2xhc3Mp OwogfQogCi1ib29sIFBhZ2VQb3B1cEJsYWNrQmVycnk6OmhhbmRsZU1vdXNlRXZlbnQoUGxhdGZv cm1Nb3VzZUV2ZW50JiBldmVudCkKLXsKLSAgICBzd2l0Y2ggKGV2ZW50LnR5cGUoKSkgewotICAg IGNhc2UgUGxhdGZvcm1FdmVudDo6TW91c2VNb3ZlZDoKLSAgICAgICAgcmV0dXJuIG1fd2ViUGFn ZVByaXZhdGUtPm1haW5GcmFtZSgpLT5ldmVudEhhbmRsZXIoKS0+aGFuZGxlTW91c2VNb3ZlRXZl bnQoZXZlbnQpOwotICAgIGNhc2UgUGxhdGZvcm1FdmVudDo6TW91c2VQcmVzc2VkOgotICAgICAg ICByZXR1cm4gbV93ZWJQYWdlUHJpdmF0ZS0+bWFpbkZyYW1lKCktPmV2ZW50SGFuZGxlcigpLT5o YW5kbGVNb3VzZVByZXNzRXZlbnQoZXZlbnQpOwotICAgIGNhc2UgUGxhdGZvcm1FdmVudDo6TW91 c2VSZWxlYXNlZDoKLSAgICAgICAgcmV0dXJuIG1fd2ViUGFnZVByaXZhdGUtPm1haW5GcmFtZSgp LT5ldmVudEhhbmRsZXIoKS0+aGFuZGxlTW91c2VSZWxlYXNlRXZlbnQoZXZlbnQpOwotICAgIGRl ZmF1bHQ6Ci0gICAgICAgIHJldHVybiBmYWxzZTsKLSAgICB9Ci19Ci0KIHZvaWQgUGFnZVBvcHVw QmxhY2tCZXJyeTo6Y2xvc2VQb3B1cCgpCiB7CiAgICAgbV9jbGllbnQtPmRpZENsb3NlUG9wdXAo KTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9XZWJDb3JlU3VwcG9ydC9Q YWdlUG9wdXBCbGFja0JlcnJ5LmggYi9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvV2ViQ29yZVN1 cHBvcnQvUGFnZVBvcHVwQmxhY2tCZXJyeS5oCmluZGV4IGQ2ZjhmM2IuLjQ3NzRmMWUgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9XZWJDb3JlU3VwcG9ydC9QYWdlUG9wdXBC bGFja0JlcnJ5LmgKKysrIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L1dlYkNvcmVTdXBwb3J0 L1BhZ2VQb3B1cEJsYWNrQmVycnkuaApAQCAtNDcsOSArNDcsNiBAQCBwdWJsaWM6CiAgICAgdm9p ZCBpbnN0YWxsRG9tRnVuY3Rpb24oRnJhbWUqKTsKICAgICB2b2lkIHNldFJlY3QoKTsKIAotICAg IGJvb2wgaGFuZGxlTW91c2VFdmVudChQbGF0Zm9ybU1vdXNlRXZlbnQmKTsKLQotCiBwcml2YXRl OgogICAgIEJsYWNrQmVycnk6OldlYktpdDo6V2ViUGFnZVByaXZhdGUqIG1fd2ViUGFnZVByaXZh dGU7CiAgICAgT3duUHRyPFBhZ2VQb3B1cENsaWVudD4gbV9jbGllbnQ7Ci0tIAoxLjcuMTAuMQoK