89236 2012-06-15 11:49:13 -0700 [BlackBerry] Put platform-specific GC policy in GCActivityCallback 2012-06-15 15:32:14 -0700 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 yong.li.webkit webkit-unassigned ggaren rakuco tonikitoo webkit.review.bot oldest_to_newest 650374 0 yong.li.webkit 2012-06-15 11:49:13 -0700 to add a GCActivityCallbackBlackBerry.cpp, and put our low memory GC policy into didAllocate(). 650396 1 147874 yong.li.webkit 2012-06-15 12:23:59 -0700 Created attachment 147874 the patch Geoffrey, the patch adds one line to Heap.h: bool isSafeToCollect() const { return m_isSafeToCollect; } Do you think it is OK? 650401 2 webkit.review.bot 2012-06-15 12:28:46 -0700 Attachment 147874 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1 Source/JavaScriptCore/runtime/GCActivityCallbackBlackBerry.cpp:22: Alphabetical sorting problem. [build/include_order] [4] Source/JavaScriptCore/runtime/GCActivityCallbackBlackBerry.cpp:28: Missing space inside { }. [whitespace/braces] [5] Total errors found: 2 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style. 650409 3 147878 yong.li.webkit 2012-06-15 12:41:47 -0700 Created attachment 147878 fix the style error 650520 4 147878 rwlbuis 2012-06-15 14:35:09 -0700 Comment on attachment 147878 fix the style error Looks good. 650528 5 ggaren 2012-06-15 14:44:00 -0700 > bool isSafeToCollect() const { return m_isSafeToCollect; } This is fine. Seriously, though, you're making GC on Blackberry O(n^2). 650531 6 yong.li.webkit 2012-06-15 14:47:34 -0700 (In reply to comment #5) > > bool isSafeToCollect() const { return m_isSafeToCollect; } > > This is fine. > > Seriously, though, you're making GC on Blackberry O(n^2). It is still using a limit which is just the small one (1MB). I commented the isMemoryLow check and tested it on some heavy sites. It is a bit slower, but seems still OK. 650577 7 147878 webkit.review.bot 2012-06-15 15:32:09 -0700 Comment on attachment 147878 fix the style error Clearing flags on attachment: 147878 Committed r120502: <http://trac.webkit.org/changeset/120502> 650579 8 webkit.review.bot 2012-06-15 15:32:14 -0700 All reviewed patches have been landed. Closing bug. 147874 2012-06-15 12:23:59 -0700 2012-06-15 12:41:57 -0700 the patch 89236.patch text/plain 4568 yong.li.webkit ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IDYzODdlYjYuLmE4ZjBlY2EgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI3IEBACisyMDEyLTA2LTE1ICBZb25nIExpICA8eW9s aUByaW0uY29tPgorCisgICAgICAgIFtCbGFja0JlcnJ5XSBQdXQgcGxhdGZvcm0tc3BlY2lmaWMg R0MgcG9saWN5IGluIEdDQWN0aXZpdHlDYWxsYmFjaworICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODkyMzYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBBZGQgR0NBY3Rpdml0eUNhbGxiYWNrQmxhY2tCZXJyeS5j cHAgYW5kIGltcGxlbWVudCBwbGF0Zm9ybS1zcGVjaWZpYworICAgICAgICBsb3cgbWVtb3J5IEdD IHBvbGljeSB0aGVyZS4KKworICAgICAgICAqIFBsYXRmb3JtQmxhY2tCZXJyeS5jbWFrZToKKyAg ICAgICAgKiBoZWFwL0hlYXAuaDoKKyAgICAgICAgKEpTQzo6SGVhcDo6aXNTYWZlVG9Db2xsZWN0 KTogQWRkZWQuCisgICAgICAgICogcnVudGltZS9HQ0FjdGl2aXR5Q2FsbGJhY2tCbGFja0JlcnJ5 LmNwcDogQWRkZWQuCisgICAgICAgIChKU0MpOgorICAgICAgICAoSlNDOjpEZWZhdWx0R0NBY3Rp dml0eUNhbGxiYWNrUGxhdGZvcm1EYXRhOjpEZWZhdWx0R0NBY3Rpdml0eUNhbGxiYWNrUGxhdGZv cm1EYXRhKToKKyAgICAgICAgKERlZmF1bHRHQ0FjdGl2aXR5Q2FsbGJhY2tQbGF0Zm9ybURhdGEp OgorICAgICAgICAoSlNDOjpEZWZhdWx0R0NBY3Rpdml0eUNhbGxiYWNrOjpEZWZhdWx0R0NBY3Rp dml0eUNhbGxiYWNrKToKKyAgICAgICAgKEpTQzo6RGVmYXVsdEdDQWN0aXZpdHlDYWxsYmFjazo6 fkRlZmF1bHRHQ0FjdGl2aXR5Q2FsbGJhY2spOgorICAgICAgICAoSlNDOjpEZWZhdWx0R0NBY3Rp dml0eUNhbGxiYWNrOjpkaWRBbGxvY2F0ZSk6CisgICAgICAgIChKU0M6OkRlZmF1bHRHQ0FjdGl2 aXR5Q2FsbGJhY2s6OndpbGxDb2xsZWN0KToKKyAgICAgICAgKEpTQzo6RGVmYXVsdEdDQWN0aXZp dHlDYWxsYmFjazo6c3luY2hyb25pemUpOgorICAgICAgICAoSlNDOjpEZWZhdWx0R0NBY3Rpdml0 eUNhbGxiYWNrOjpjYW5jZWwpOgorCiAyMDEyLTA2LTEzICBGaWxpcCBQaXpsbyAgPGZwaXpsb0Bh cHBsZS5jb20+CiAKICAgICAgICAgREZHIHNob3VsZCBiZSBhYmxlIHRvIHNldCB3YXRjaHBvaW50 cyBvbiBnbG9iYWwgdmFyaWFibGVzCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUv UGxhdGZvcm1CbGFja0JlcnJ5LmNtYWtlIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL1BsYXRmb3Jt QmxhY2tCZXJyeS5jbWFrZQppbmRleCBhYmZhZTg1Li5jYzNjZmVhIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvSmF2YVNjcmlwdENvcmUvUGxhdGZvcm1CbGFja0JlcnJ5LmNtYWtlCisrKyBiL1NvdXJjZS9K YXZhU2NyaXB0Q29yZS9QbGF0Zm9ybUJsYWNrQmVycnkuY21ha2UKQEAgLTIsNCArMiwxMiBAQCBM SVNUKElOU0VSVCBKYXZhU2NyaXB0Q29yZV9JTkNMVURFX0RJUkVDVE9SSUVTIDAKICAgICAiJHtC TEFDS0JFUlJZX1RISVJEX1BBUlRZX0RJUn0vaWN1IgogKQogCitMSVNUKFJFTU9WRV9JVEVNIEph dmFTY3JpcHRDb3JlX1NPVVJDRVMKKyAgICBydW50aW1lL0dDQWN0aXZpdHlDYWxsYmFjay5jcHAK KykKKworTElTVChBUFBFTkQgSmF2YVNjcmlwdENvcmVfU09VUkNFUworICAgIHJ1bnRpbWUvR0NB Y3Rpdml0eUNhbGxiYWNrQmxhY2tCZXJyeS5jcHAKKykKKwogSU5TVEFMTChGSUxFUyAid3RmL0Zv cndhcmQuaCIgREVTVElOQVRJT04gdXNyL2luY2x1ZGUvYnJvd3Nlci93ZWJraXQvd3RmKQpkaWZm IC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2hlYXAvSGVhcC5oIGIvU291cmNlL0phdmFT Y3JpcHRDb3JlL2hlYXAvSGVhcC5oCmluZGV4IDIyZTQ4OTAuLjI0MDBiZmUgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9oZWFwL0hlYXAuaAorKysgYi9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvaGVhcC9IZWFwLmgKQEAgLTExOSw2ICsxMTksNyBAQCBuYW1lc3BhY2UgSlNDIHsKICAg ICAgICAgdm9pZCBhZGRDb21waWxlZENvZGUoRXhlY3V0YWJsZUJhc2UqKTsKIAogICAgICAgICB2 b2lkIG5vdGlmeUlzU2FmZVRvQ29sbGVjdCgpIHsgbV9pc1NhZmVUb0NvbGxlY3QgPSB0cnVlOyB9 CisgICAgICAgIGJvb2wgaXNTYWZlVG9Db2xsZWN0KCkgY29uc3QgeyByZXR1cm4gbV9pc1NhZmVU b0NvbGxlY3Q7IH0KIAogICAgICAgICBKU19FWFBPUlRfUFJJVkFURSB2b2lkIGNvbGxlY3RBbGxH YXJiYWdlKCk7CiAgICAgICAgIGVudW0gU3dlZXBUb2dnbGUgeyBEb05vdFN3ZWVwLCBEb1N3ZWVw IH07CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9HQ0FjdGl2aXR5 Q2FsbGJhY2tCbGFja0JlcnJ5LmNwcCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0dD QWN0aXZpdHlDYWxsYmFja0JsYWNrQmVycnkuY3BwCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4 IDAwMDAwMDAuLjFmYzQzOTQKLS0tIC9kZXYvbnVsbAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvcnVudGltZS9HQ0FjdGl2aXR5Q2FsbGJhY2tCbGFja0JlcnJ5LmNwcApAQCAtMCwwICsxLDY3 IEBACisvKgorICogQ29weXJpZ2h0IChDKSAyMDEyIFJlc2VhcmNoIEluIE1vdGlvbiBMaW1pdGVk LiBBbGwgcmlnaHRzIHJlc2VydmVkLgorICoKKyAqIFRoaXMgbGlicmFyeSBpcyBmcmVlIHNvZnR3 YXJlOyB5b3UgY2FuIHJlZGlzdHJpYnV0ZSBpdCBhbmQvb3IKKyAqIG1vZGlmeSBpdCB1bmRlciB0 aGUgdGVybXMgb2YgdGhlIEdOVSBMZXNzZXIgR2VuZXJhbCBQdWJsaWMKKyAqIExpY2Vuc2UgYXMg cHVibGlzaGVkIGJ5IHRoZSBGcmVlIFNvZnR3YXJlIEZvdW5kYXRpb247IGVpdGhlcgorICogdmVy c2lvbiAyIG9mIHRoZSBMaWNlbnNlLCBvciAoYXQgeW91ciBvcHRpb24pIGFueSBsYXRlciB2ZXJz aW9uLgorICoKKyAqIFRoaXMgbGlicmFyeSBpcyBkaXN0cmlidXRlZCBpbiB0aGUgaG9wZSB0aGF0 IGl0IHdpbGwgYmUgdXNlZnVsLAorICogYnV0IFdJVEhPVVQgQU5ZIFdBUlJBTlRZOyB3aXRob3V0 IGV2ZW4gdGhlIGltcGxpZWQgd2FycmFudHkgb2YKKyAqIE1FUkNIQU5UQUJJTElUWSBvciBGSVRO RVNTIEZPUiBBIFBBUlRJQ1VMQVIgUFVSUE9TRS4gIFNlZSB0aGUgR05VCisgKiBMZXNzZXIgR2Vu ZXJhbCBQdWJsaWMgTGljZW5zZSBmb3IgbW9yZSBkZXRhaWxzLgorICoKKyAqIFlvdSBzaG91bGQg aGF2ZSByZWNlaXZlZCBhIGNvcHkgb2YgdGhlIEdOVSBMZXNzZXIgR2VuZXJhbCBQdWJsaWMKKyAq IExpY2Vuc2UgYWxvbmcgd2l0aCB0aGlzIGxpYnJhcnk7IGlmIG5vdCwgd3JpdGUgdG8gdGhlIEZy ZWUgU29mdHdhcmUKKyAqIEZvdW5kYXRpb24sIEluYy4sIDUxIEZyYW5rbGluIFN0cmVldCwgRmlm dGggRmxvb3IsIEJvc3RvbiwgTUEgIDAyMTEwLTEzMDEgIFVTQQorICovCisKKyNpbmNsdWRlICJj b25maWcuaCIKKyNpbmNsdWRlICJHQ0FjdGl2aXR5Q2FsbGJhY2suaCIKKworI2luY2x1ZGUgPEJs YWNrQmVycnlQbGF0Zm9ybU1lbW9yeS5oPgorI2luY2x1ZGUgIkhlYXAuaCIKKworbmFtZXNwYWNl IEpTQyB7CisKK3N0cnVjdCBEZWZhdWx0R0NBY3Rpdml0eUNhbGxiYWNrUGxhdGZvcm1EYXRhIHsK KyAgICBleHBsaWNpdCBEZWZhdWx0R0NBY3Rpdml0eUNhbGxiYWNrUGxhdGZvcm1EYXRhKEhlYXAq IGhlYXApIDogbV9oZWFwKGhlYXApIHt9CisgICAgSGVhcCogbV9oZWFwOworfTsKKworRGVmYXVs dEdDQWN0aXZpdHlDYWxsYmFjazo6RGVmYXVsdEdDQWN0aXZpdHlDYWxsYmFjayhIZWFwKiBoZWFw KQorICAgIDogZChhZG9wdFB0cihuZXcgRGVmYXVsdEdDQWN0aXZpdHlDYWxsYmFja1BsYXRmb3Jt RGF0YShoZWFwKSkpCit7Cit9CisKK0RlZmF1bHRHQ0FjdGl2aXR5Q2FsbGJhY2s6On5EZWZhdWx0 R0NBY3Rpdml0eUNhbGxiYWNrKCkKK3sKK30KKwordm9pZCBEZWZhdWx0R0NBY3Rpdml0eUNhbGxi YWNrOjpkaWRBbGxvY2F0ZShzaXplX3QgYnl0ZXNBbGxvY2F0ZWQpCit7CisgICAgaWYgKCFCbGFj a0JlcnJ5OjpQbGF0Zm9ybTo6aXNNZW1vcnlMb3coKSkKKyAgICAgICAgcmV0dXJuOworCisgICAg aWYgKGJ5dGVzQWxsb2NhdGVkIDwgMSAqIDEwMjQgKiAxMDI0KQorICAgICAgICByZXR1cm47CisK KyAgICBpZiAoZC0+bV9oZWFwLT5pc0J1c3koKSB8fCAhZC0+bV9oZWFwLT5pc1NhZmVUb0NvbGxl Y3QoKSkKKyAgICAgICAgcmV0dXJuOworCisgICAgZC0+bV9oZWFwLT5jb2xsZWN0KEhlYXA6OkRv Tm90U3dlZXApOworfQorCit2b2lkIERlZmF1bHRHQ0FjdGl2aXR5Q2FsbGJhY2s6OndpbGxDb2xs ZWN0KCkKK3sKK30KKwordm9pZCBEZWZhdWx0R0NBY3Rpdml0eUNhbGxiYWNrOjpzeW5jaHJvbml6 ZSgpCit7Cit9CisKK3ZvaWQgRGVmYXVsdEdDQWN0aXZpdHlDYWxsYmFjazo6Y2FuY2VsKCkKK3sK K30KKworfQo= 147878 2012-06-15 12:41:47 -0700 2012-06-15 15:32:08 -0700 fix the style error 89236.patch text/plain 4569 yong.li.webkit ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IDYzODdlYjYuLmE4ZjBlY2EgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI3IEBACisyMDEyLTA2LTE1ICBZb25nIExpICA8eW9s aUByaW0uY29tPgorCisgICAgICAgIFtCbGFja0JlcnJ5XSBQdXQgcGxhdGZvcm0tc3BlY2lmaWMg R0MgcG9saWN5IGluIEdDQWN0aXZpdHlDYWxsYmFjaworICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODkyMzYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBBZGQgR0NBY3Rpdml0eUNhbGxiYWNrQmxhY2tCZXJyeS5j cHAgYW5kIGltcGxlbWVudCBwbGF0Zm9ybS1zcGVjaWZpYworICAgICAgICBsb3cgbWVtb3J5IEdD IHBvbGljeSB0aGVyZS4KKworICAgICAgICAqIFBsYXRmb3JtQmxhY2tCZXJyeS5jbWFrZToKKyAg ICAgICAgKiBoZWFwL0hlYXAuaDoKKyAgICAgICAgKEpTQzo6SGVhcDo6aXNTYWZlVG9Db2xsZWN0 KTogQWRkZWQuCisgICAgICAgICogcnVudGltZS9HQ0FjdGl2aXR5Q2FsbGJhY2tCbGFja0JlcnJ5 LmNwcDogQWRkZWQuCisgICAgICAgIChKU0MpOgorICAgICAgICAoSlNDOjpEZWZhdWx0R0NBY3Rp dml0eUNhbGxiYWNrUGxhdGZvcm1EYXRhOjpEZWZhdWx0R0NBY3Rpdml0eUNhbGxiYWNrUGxhdGZv cm1EYXRhKToKKyAgICAgICAgKERlZmF1bHRHQ0FjdGl2aXR5Q2FsbGJhY2tQbGF0Zm9ybURhdGEp OgorICAgICAgICAoSlNDOjpEZWZhdWx0R0NBY3Rpdml0eUNhbGxiYWNrOjpEZWZhdWx0R0NBY3Rp dml0eUNhbGxiYWNrKToKKyAgICAgICAgKEpTQzo6RGVmYXVsdEdDQWN0aXZpdHlDYWxsYmFjazo6 fkRlZmF1bHRHQ0FjdGl2aXR5Q2FsbGJhY2spOgorICAgICAgICAoSlNDOjpEZWZhdWx0R0NBY3Rp dml0eUNhbGxiYWNrOjpkaWRBbGxvY2F0ZSk6CisgICAgICAgIChKU0M6OkRlZmF1bHRHQ0FjdGl2 aXR5Q2FsbGJhY2s6OndpbGxDb2xsZWN0KToKKyAgICAgICAgKEpTQzo6RGVmYXVsdEdDQWN0aXZp dHlDYWxsYmFjazo6c3luY2hyb25pemUpOgorICAgICAgICAoSlNDOjpEZWZhdWx0R0NBY3Rpdml0 eUNhbGxiYWNrOjpjYW5jZWwpOgorCiAyMDEyLTA2LTEzICBGaWxpcCBQaXpsbyAgPGZwaXpsb0Bh cHBsZS5jb20+CiAKICAgICAgICAgREZHIHNob3VsZCBiZSBhYmxlIHRvIHNldCB3YXRjaHBvaW50 cyBvbiBnbG9iYWwgdmFyaWFibGVzCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUv UGxhdGZvcm1CbGFja0JlcnJ5LmNtYWtlIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL1BsYXRmb3Jt QmxhY2tCZXJyeS5jbWFrZQppbmRleCBhYmZhZTg1Li5jYzNjZmVhIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvSmF2YVNjcmlwdENvcmUvUGxhdGZvcm1CbGFja0JlcnJ5LmNtYWtlCisrKyBiL1NvdXJjZS9K YXZhU2NyaXB0Q29yZS9QbGF0Zm9ybUJsYWNrQmVycnkuY21ha2UKQEAgLTIsNCArMiwxMiBAQCBM SVNUKElOU0VSVCBKYXZhU2NyaXB0Q29yZV9JTkNMVURFX0RJUkVDVE9SSUVTIDAKICAgICAiJHtC TEFDS0JFUlJZX1RISVJEX1BBUlRZX0RJUn0vaWN1IgogKQogCitMSVNUKFJFTU9WRV9JVEVNIEph dmFTY3JpcHRDb3JlX1NPVVJDRVMKKyAgICBydW50aW1lL0dDQWN0aXZpdHlDYWxsYmFjay5jcHAK KykKKworTElTVChBUFBFTkQgSmF2YVNjcmlwdENvcmVfU09VUkNFUworICAgIHJ1bnRpbWUvR0NB Y3Rpdml0eUNhbGxiYWNrQmxhY2tCZXJyeS5jcHAKKykKKwogSU5TVEFMTChGSUxFUyAid3RmL0Zv cndhcmQuaCIgREVTVElOQVRJT04gdXNyL2luY2x1ZGUvYnJvd3Nlci93ZWJraXQvd3RmKQpkaWZm IC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2hlYXAvSGVhcC5oIGIvU291cmNlL0phdmFT Y3JpcHRDb3JlL2hlYXAvSGVhcC5oCmluZGV4IDIyZTQ4OTAuLjI0MDBiZmUgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9oZWFwL0hlYXAuaAorKysgYi9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvaGVhcC9IZWFwLmgKQEAgLTExOSw2ICsxMTksNyBAQCBuYW1lc3BhY2UgSlNDIHsKICAg ICAgICAgdm9pZCBhZGRDb21waWxlZENvZGUoRXhlY3V0YWJsZUJhc2UqKTsKIAogICAgICAgICB2 b2lkIG5vdGlmeUlzU2FmZVRvQ29sbGVjdCgpIHsgbV9pc1NhZmVUb0NvbGxlY3QgPSB0cnVlOyB9 CisgICAgICAgIGJvb2wgaXNTYWZlVG9Db2xsZWN0KCkgY29uc3QgeyByZXR1cm4gbV9pc1NhZmVU b0NvbGxlY3Q7IH0KIAogICAgICAgICBKU19FWFBPUlRfUFJJVkFURSB2b2lkIGNvbGxlY3RBbGxH YXJiYWdlKCk7CiAgICAgICAgIGVudW0gU3dlZXBUb2dnbGUgeyBEb05vdFN3ZWVwLCBEb1N3ZWVw IH07CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9HQ0FjdGl2aXR5 Q2FsbGJhY2tCbGFja0JlcnJ5LmNwcCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0dD QWN0aXZpdHlDYWxsYmFja0JsYWNrQmVycnkuY3BwCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4 IDAwMDAwMDAuLjFmYzQzOTQKLS0tIC9kZXYvbnVsbAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvcnVudGltZS9HQ0FjdGl2aXR5Q2FsbGJhY2tCbGFja0JlcnJ5LmNwcApAQCAtMCwwICsxLDY3 IEBACisvKgorICogQ29weXJpZ2h0IChDKSAyMDEyIFJlc2VhcmNoIEluIE1vdGlvbiBMaW1pdGVk LiBBbGwgcmlnaHRzIHJlc2VydmVkLgorICoKKyAqIFRoaXMgbGlicmFyeSBpcyBmcmVlIHNvZnR3 YXJlOyB5b3UgY2FuIHJlZGlzdHJpYnV0ZSBpdCBhbmQvb3IKKyAqIG1vZGlmeSBpdCB1bmRlciB0 aGUgdGVybXMgb2YgdGhlIEdOVSBMZXNzZXIgR2VuZXJhbCBQdWJsaWMKKyAqIExpY2Vuc2UgYXMg cHVibGlzaGVkIGJ5IHRoZSBGcmVlIFNvZnR3YXJlIEZvdW5kYXRpb247IGVpdGhlcgorICogdmVy c2lvbiAyIG9mIHRoZSBMaWNlbnNlLCBvciAoYXQgeW91ciBvcHRpb24pIGFueSBsYXRlciB2ZXJz aW9uLgorICoKKyAqIFRoaXMgbGlicmFyeSBpcyBkaXN0cmlidXRlZCBpbiB0aGUgaG9wZSB0aGF0 IGl0IHdpbGwgYmUgdXNlZnVsLAorICogYnV0IFdJVEhPVVQgQU5ZIFdBUlJBTlRZOyB3aXRob3V0 IGV2ZW4gdGhlIGltcGxpZWQgd2FycmFudHkgb2YKKyAqIE1FUkNIQU5UQUJJTElUWSBvciBGSVRO RVNTIEZPUiBBIFBBUlRJQ1VMQVIgUFVSUE9TRS4gIFNlZSB0aGUgR05VCisgKiBMZXNzZXIgR2Vu ZXJhbCBQdWJsaWMgTGljZW5zZSBmb3IgbW9yZSBkZXRhaWxzLgorICoKKyAqIFlvdSBzaG91bGQg aGF2ZSByZWNlaXZlZCBhIGNvcHkgb2YgdGhlIEdOVSBMZXNzZXIgR2VuZXJhbCBQdWJsaWMKKyAq IExpY2Vuc2UgYWxvbmcgd2l0aCB0aGlzIGxpYnJhcnk7IGlmIG5vdCwgd3JpdGUgdG8gdGhlIEZy ZWUgU29mdHdhcmUKKyAqIEZvdW5kYXRpb24sIEluYy4sIDUxIEZyYW5rbGluIFN0cmVldCwgRmlm dGggRmxvb3IsIEJvc3RvbiwgTUEgIDAyMTEwLTEzMDEgIFVTQQorICovCisKKyNpbmNsdWRlICJj b25maWcuaCIKKyNpbmNsdWRlICJHQ0FjdGl2aXR5Q2FsbGJhY2suaCIKKworI2luY2x1ZGUgIkhl YXAuaCIKKyNpbmNsdWRlIDxCbGFja0JlcnJ5UGxhdGZvcm1NZW1vcnkuaD4KKworbmFtZXNwYWNl IEpTQyB7CisKK3N0cnVjdCBEZWZhdWx0R0NBY3Rpdml0eUNhbGxiYWNrUGxhdGZvcm1EYXRhIHsK KyAgICBleHBsaWNpdCBEZWZhdWx0R0NBY3Rpdml0eUNhbGxiYWNrUGxhdGZvcm1EYXRhKEhlYXAq IGhlYXApIDogbV9oZWFwKGhlYXApIHsgfQorICAgIEhlYXAqIG1faGVhcDsKK307CisKK0RlZmF1 bHRHQ0FjdGl2aXR5Q2FsbGJhY2s6OkRlZmF1bHRHQ0FjdGl2aXR5Q2FsbGJhY2soSGVhcCogaGVh cCkKKyAgICA6IGQoYWRvcHRQdHIobmV3IERlZmF1bHRHQ0FjdGl2aXR5Q2FsbGJhY2tQbGF0Zm9y bURhdGEoaGVhcCkpKQoreworfQorCitEZWZhdWx0R0NBY3Rpdml0eUNhbGxiYWNrOjp+RGVmYXVs dEdDQWN0aXZpdHlDYWxsYmFjaygpCit7Cit9CisKK3ZvaWQgRGVmYXVsdEdDQWN0aXZpdHlDYWxs YmFjazo6ZGlkQWxsb2NhdGUoc2l6ZV90IGJ5dGVzQWxsb2NhdGVkKQoreworICAgIGlmICghQmxh Y2tCZXJyeTo6UGxhdGZvcm06OmlzTWVtb3J5TG93KCkpCisgICAgICAgIHJldHVybjsKKworICAg IGlmIChieXRlc0FsbG9jYXRlZCA8IDEgKiAxMDI0ICogMTAyNCkKKyAgICAgICAgcmV0dXJuOwor CisgICAgaWYgKGQtPm1faGVhcC0+aXNCdXN5KCkgfHwgIWQtPm1faGVhcC0+aXNTYWZlVG9Db2xs ZWN0KCkpCisgICAgICAgIHJldHVybjsKKworICAgIGQtPm1faGVhcC0+Y29sbGVjdChIZWFwOjpE b05vdFN3ZWVwKTsKK30KKwordm9pZCBEZWZhdWx0R0NBY3Rpdml0eUNhbGxiYWNrOjp3aWxsQ29s bGVjdCgpCit7Cit9CisKK3ZvaWQgRGVmYXVsdEdDQWN0aXZpdHlDYWxsYmFjazo6c3luY2hyb25p emUoKQoreworfQorCit2b2lkIERlZmF1bHRHQ0FjdGl2aXR5Q2FsbGJhY2s6OmNhbmNlbCgpCit7 Cit9CisKK30K