89233 2012-06-15 11:03:59 -0700 [chromium] WebFrameClient::userAgentOverride() should take in a WebFrame* as its first argument 2012-06-16 02:22:02 -0700 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 dfalcantara dfalcantara abarth dglazkov fishd jamesr tkent+wkapi webkit.review.bot oldest_to_newest 650343 0 dfalcantara 2012-06-15 11:03:59 -0700 Missed this the first time, but the function needs to take in a WebFrame* pointer to be consistent with the API. Adding it now. 650477 1 147891 dfalcantara 2012-06-15 13:59:39 -0700 Created attachment 147891 Patch 650483 2 webkit.review.bot 2012-06-15 14:02:31 -0700 Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI. 650524 3 abarth 2012-06-15 14:36:08 -0700 Sounds like I should let fishd give the r+ on this one since I goofed it up twice already. :) 650734 4 147891 fishd 2012-06-15 22:14:03 -0700 Comment on attachment 147891 Patch Thanks! 650754 5 147891 webkit.review.bot 2012-06-16 00:28:23 -0700 Comment on attachment 147891 Patch Rejecting attachment 147891 from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1 Last 500 characters of output: return self.open(self.click(*args, **kwds)) File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/thirdparty/autoinstalled/mechanize/_mechanize.py", line 203, in open return self._mech_open(url, data, timeout=timeout) File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/thirdparty/autoinstalled/mechanize/_mechanize.py", line 255, in _mech_open raise response webkitpy.thirdparty.autoinstalled.mechanize._response.httperror_seek_wrapper: HTTP Error 500: Internal Server Error Full output: http://queues.webkit.org/results/12966609 650767 6 147891 webkit.review.bot 2012-06-16 02:21:56 -0700 Comment on attachment 147891 Patch Clearing flags on attachment: 147891 Committed r120526: <http://trac.webkit.org/changeset/120526> 650768 7 webkit.review.bot 2012-06-16 02:22:02 -0700 All reviewed patches have been landed. Closing bug. 147891 2012-06-15 13:59:39 -0700 2012-06-16 02:21:56 -0700 Patch bug-89233-20120615135939.patch text/plain 2935 dfalcantara SW5kZXg6IFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNv dXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCShyZXZpc2lvbiAxMjA0OTApCisrKyBTb3Vy Y2UvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4 IEBACisyMDEyLTA2LTE1ICBEYW4gQWxjYW50YXJhICA8ZGZhbGNhbnRhcmFAY2hyb21pdW0ub3Jn PgorCisgICAgICAgIFtjaHJvbWl1bV0gV2ViRnJhbWVDbGllbnQ6OnVzZXJBZ2VudE92ZXJyaWRl KCkgc2hvdWxkIHRha2UgaW4gYSBXZWJGcmFtZSogYXMgaXRzIGZpcnN0IGFyZ3VtZW50CisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04OTIzMworCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFkZHMgYSBXZWJGcmFt ZSogdG8gdGhlIFdlYkZyYW1lQ2xpZW50Ojp1c2VyQWdlbnRPdmVycmlkZSgpIGZ1bmN0aW9uLgor CisgICAgICAgICogcHVibGljL1dlYkZyYW1lQ2xpZW50Lmg6CisgICAgICAgIChXZWJLaXQ6Oldl YkZyYW1lQ2xpZW50Ojp1c2VyQWdlbnRPdmVycmlkZSk6CisgICAgICAgICogc3JjL0ZyYW1lTG9h ZGVyQ2xpZW50SW1wbC5jcHA6CisgICAgICAgIChXZWJLaXQ6OkZyYW1lTG9hZGVyQ2xpZW50SW1w bDo6dXNlckFnZW50KToKKyAgICAgICAgKiB0ZXN0cy9GcmFtZUxvYWRlckNsaWVudEltcGxUZXN0 LmNwcDoKKwogMjAxMi0wNi0xNSAgQmlsbCBCdWRnZSAgPGJidWRnZUBjaHJvbWl1bS5vcmc+CiAK ICAgICAgICAgQXNzb2NpYXRlZFVSTExvYWRlciBzaG91bGQgYWxsb3cgdHJ1c3RlZCBjbGllbnRz IHRvIHJlYWQgYWxsIGhlYWRlcnMsIG5vdCBqdXN0IGV4cG9zZWQgb25lcy4KSW5kZXg6IFNvdXJj ZS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYkZyYW1lQ2xpZW50LmgKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g U291cmNlL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViRnJhbWVDbGllbnQuaAkocmV2aXNpb24g MTIwNDg3KQorKysgU291cmNlL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViRnJhbWVDbGllbnQu aAkod29ya2luZyBjb3B5KQpAQCAtNDAwLDcgKzQwMCw3IEBAIHB1YmxpYzoKICAgICAvLyBBc2tz IHRoZSBlbWJlZGRlciBpZiBhIHNwZWNpZmljIHVzZXIgYWdlbnQgc2hvdWxkIGJlIHVzZWQgZm9y IHRoZSBnaXZlbgogICAgIC8vIFVSTC4gTm9uLWVtcHR5IHN0cmluZ3MgaW5kaWNhdGUgYW4gb3Zl cnJpZGUgc2hvdWxkIGJlIHVzZWQuIE90aGVyd2lzZSwKICAgICAvLyBXZWJLaXRQbGF0Zm9ybVN1 cHBvcnQ6OnVzZXJBZ2VudCgpIHdpbGwgYmUgY2FsbGVkIHRvIHByb3ZpZGUgb25lLgotICAgIHZp cnR1YWwgV2ViU3RyaW5nIHVzZXJBZ2VudE92ZXJyaWRlKGNvbnN0IFdlYlVSTCYgdXJsKSB7IHJl dHVybiBXZWJTdHJpbmcoKTsgfQorICAgIHZpcnR1YWwgV2ViU3RyaW5nIHVzZXJBZ2VudE92ZXJy aWRlKFdlYkZyYW1lKiwgY29uc3QgV2ViVVJMJiB1cmwpIHsgcmV0dXJuIFdlYlN0cmluZygpOyB9 CiAKIHByb3RlY3RlZDoKICAgICB+V2ViRnJhbWVDbGllbnQoKSB7IH0KSW5kZXg6IFNvdXJjZS9X ZWJLaXQvY2hyb21pdW0vc3JjL0ZyYW1lTG9hZGVyQ2xpZW50SW1wbC5jcHAKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvRnJhbWVMb2FkZXJDbGllbnRJbXBsLmNwcAko cmV2aXNpb24gMTIwNDg3KQorKysgU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvRnJhbWVMb2Fk ZXJDbGllbnRJbXBsLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTM4Myw3ICsxMzgzLDcgQEAgdm9p ZCBGcmFtZUxvYWRlckNsaWVudEltcGw6OnNldFRpdGxlKGNvbgogCiBTdHJpbmcgRnJhbWVMb2Fk ZXJDbGllbnRJbXBsOjp1c2VyQWdlbnQoY29uc3QgS1VSTCYgdXJsKQogewotICAgIFdlYlN0cmlu ZyBvdmVycmlkZSA9IG1fd2ViRnJhbWUtPmNsaWVudCgpLT51c2VyQWdlbnRPdmVycmlkZShXZWJV UkwodXJsKSk7CisgICAgV2ViU3RyaW5nIG92ZXJyaWRlID0gbV93ZWJGcmFtZS0+Y2xpZW50KCkt PnVzZXJBZ2VudE92ZXJyaWRlKG1fd2ViRnJhbWUsIFdlYlVSTCh1cmwpKTsKICAgICBpZiAoIW92 ZXJyaWRlLmlzRW1wdHkoKSkKICAgICAgICAgcmV0dXJuIG92ZXJyaWRlOwogCkluZGV4OiBTb3Vy Y2UvV2ViS2l0L2Nocm9taXVtL3Rlc3RzL0ZyYW1lTG9hZGVyQ2xpZW50SW1wbFRlc3QuY3BwCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vdGVzdHMvRnJhbWVMb2FkZXJDbGll bnRJbXBsVGVzdC5jcHAJKHJldmlzaW9uIDEyMDQ4NykKKysrIFNvdXJjZS9XZWJLaXQvY2hyb21p dW0vdGVzdHMvRnJhbWVMb2FkZXJDbGllbnRJbXBsVGVzdC5jcHAJKHdvcmtpbmcgY29weSkKQEAg LTQ2LDcgKzQ2LDcgQEAgbmFtZXNwYWNlIHsKIAogY2xhc3MgVGVzdFdlYkZyYW1lQ2xpZW50IDog cHVibGljIFdlYkZyYW1lQ2xpZW50IHsKIHB1YmxpYzoKLSAgICBXZWJTdHJpbmcgdXNlckFnZW50 T3ZlcnJpZGUoY29uc3QgV2ViVVJMJiB1cmwpIE9WRVJSSURFCisgICAgV2ViU3RyaW5nIHVzZXJB Z2VudE92ZXJyaWRlKFdlYkZyYW1lKiBmcmFtZSwgY29uc3QgV2ViVVJMJiB1cmwpIE9WRVJSSURF CiAgICAgewogICAgICAgICBpZiAobV91c2VyQWdlbnRPdmVycmlkZS5pc0VtcHR5KCkpCiAgICAg ICAgICAgICByZXR1cm4gV2ViU3RyaW5nKCk7Cg==