89227 2012-06-15 09:45:20 -0700 [BlackBerry] Disable WebCore::EventHandler synthesized mouse events during touch scrolling 2012-06-15 11:55:00 -0700 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 tonikitoo tonikitoo tonikitoo oldest_to_newest 650262 0 tonikitoo 2012-06-15 09:45:20 -0700 ++++++++++++++++++++++++++++++++++++ FROM PRzilla: I was looking at some odd pattern and discovered that the WebCore::EventHandler will periodically synthesize mouse events while you scroll. On the desktop, the mouse cursor remains still while you scroll using mouse wheel, so this seems correct (the.cursor is moving relative to the page while scrolling, so mouse move events are in order). But for touch scrolling it seems not only a waste of battery but also completely wrong, because your finger does not move relative to the page during touch scrolling, and the synthesized events have the wrong position. -------------------------------------- 650364 1 147864 tonikitoo 2012-06-15 11:32:48 -0700 Created attachment 147864 (committed r120482, r=rbuis) patch 650367 2 147864 rwlbuis 2012-06-15 11:35:40 -0700 Comment on attachment 147864 (committed r120482, r=rbuis) patch View in context: https://bugs.webkit.org/attachment.cgi?id=147864&action=review Looks good. > Source/WebKit/blackberry/Api/WebSettings.h:76 > + bool doesDeviceSupportMouse() const; Instead of doesDeviceSupportMouse you can just do deviceSupportsMouse. 650379 3 147864 tonikitoo 2012-06-15 11:54:53 -0700 Comment on attachment 147864 (committed r120482, r=rbuis) patch Committed <http://trac.webkit.org/changeset/120482> 147864 2012-06-15 11:32:48 -0700 2012-06-15 11:54:53 -0700 (committed r120482, r=rbuis) patch 0001-BlackBerry-Disable-WebCore-EventHandler-synthesized-.patch text/plain 5537 tonikitoo RnJvbSBhNjk4NTMzYzMzZjc5YjgxNzIyMjViM2U4Njc0Y2RkOWYxNDQyOTY3IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBbnRvbmlvIEdvbWVzIDxhZ29tZXNAcmltLmNvbT4KRGF0ZTog RnJpLCAxNSBKdW4gMjAxMiAxMjo1MzowNyAtMDQwMApTdWJqZWN0OiBbUEFUQ0hdIFtCbGFja0Jl cnJ5XSBEaXNhYmxlIFdlYkNvcmU6OkV2ZW50SGFuZGxlciBzeW50aGVzaXplZCBtb3VzZQogZXZl bnRzIGR1cmluZyB0b3VjaCBzY3JvbGxpbmcKIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD04OTIyNyBQUiAjMTQ2NjQyCgpSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K UGF0Y2ggYnkgQW50b25pbyBHb21lcyA8YWdvbWVzQHJpbS5jb20+CgpNYWtlIHVzZSBvZiB0aGUg U2V0dGluZ3M6OnN1cHBvcnRzTW91c2VEZXZpY2Ugc2V0dGluZyBpbiBvcmRlciB0bwpwcmV2ZW50 IG1vdXNlIG1vdmUgZXZlbnQgdG8gZmlyZSBhcyBhIHJlc3BvbnNlIHRvIGEgc2Nyb2xsIGFjdGlv bi4KV2UgbWlnaHQgc3RpbGwgd2FudCB0byBkeW5hbWljYWxseSB0b2dnbGUgdGhpcyBzZXR0aW5n IE9OLCBpbiBjYXNlIGZvcgpleGFtcGxlIG9mIGEgbW91c2Ugd2hlZWwgZHJpdmVuIHNjcm9sbCBh Y3Rpb24sIGJ1dCB3ZSBjYW4gcmV2aXNpdCBpdAp3aGVuIGl0IGJlY29tZXMgYSBmdWxseSBzdXBw b3J0ZWQvcHJpbWFyeSB1c2UgY2FzZS4KCkludGVybmFsbHkgcmV2aWV3ZWQgYnkgRWxpIEZpZGxl ci4KCiogQXBpL1dlYlBhZ2UuY3BwOgooQmxhY2tCZXJyeTo6V2ViS2l0OjpXZWJQYWdlUHJpdmF0 ZTo6ZGlkQ2hhbmdlU2V0dGluZ3MpOgoqIEFwaS9XZWJTZXR0aW5ncy5jcHA6CihXZWJLaXQpOgoo QmxhY2tCZXJyeTo6V2ViS2l0OjpXZWJTZXR0aW5nczo6aXNEZXZpY2VTdXBwb3J0c01vdXNlRW5h YmxlZCk6CihCbGFja0JlcnJ5OjpXZWJLaXQ6OldlYlNldHRpbmdzOjpzZXREZXZpY2VTdXBwb3J0 c01vdXNlRW5hYmxlZCk6CiogQXBpL1dlYlNldHRpbmdzLmg6Ci0tLQogU291cmNlL1dlYktpdC9i bGFja2JlcnJ5L0FwaS9XZWJQYWdlLmNwcCAgICAgfCAgICAxICsKIFNvdXJjZS9XZWJLaXQvYmxh Y2tiZXJyeS9BcGkvV2ViU2V0dGluZ3MuY3BwIHwgICAxMSArKysrKysrKysrKwogU291cmNlL1dl YktpdC9ibGFja2JlcnJ5L0FwaS9XZWJTZXR0aW5ncy5oICAgfCAgICAzICsrKwogU291cmNlL1dl YktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZyAgICAgICAgICAgfCAgIDI0ICsrKysrKysrKysrKysr KysrKysrKysrKwogNCBmaWxlcyBjaGFuZ2VkLCAzOSBpbnNlcnRpb25zKCspLCAwIGRlbGV0aW9u cygtKQoKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9BcGkvV2ViUGFnZS5j cHAgYi9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvQXBpL1dlYlBhZ2UuY3BwCmluZGV4IDFlYmVj OTMuLmZkYjhlNGYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9BcGkvV2Vi UGFnZS5jcHAKKysrIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0FwaS9XZWJQYWdlLmNwcApA QCAtNjI3Nyw2ICs2Mjc3LDcgQEAgdm9pZCBXZWJQYWdlUHJpdmF0ZTo6ZGlkQ2hhbmdlU2V0dGlu Z3MoV2ViU2V0dGluZ3MqIHdlYlNldHRpbmdzKQogICAgIGNvcmVTZXR0aW5ncy0+c2V0U2hvdWxk RHJhd0JvcmRlcldoaWxlTG9hZGluZ0ltYWdlcyh3ZWJTZXR0aW5ncy0+c2hvdWxkRHJhd0JvcmRl cldoaWxlTG9hZGluZ0ltYWdlcygpKTsKICAgICBjb3JlU2V0dGluZ3MtPnNldFNjcmlwdEVuYWJs ZWQod2ViU2V0dGluZ3MtPmlzSmF2YVNjcmlwdEVuYWJsZWQoKSk7CiAgICAgY29yZVNldHRpbmdz LT5zZXRQcml2YXRlQnJvd3NpbmdFbmFibGVkKHdlYlNldHRpbmdzLT5pc1ByaXZhdGVCcm93c2lu Z0VuYWJsZWQoKSk7CisgICAgY29yZVNldHRpbmdzLT5zZXREZXZpY2VTdXBwb3J0c01vdXNlKHdl YlNldHRpbmdzLT5kb2VzRGV2aWNlU3VwcG9ydE1vdXNlKCkpOwogICAgIGNvcmVTZXR0aW5ncy0+ c2V0RGVmYXVsdEZpeGVkRm9udFNpemUod2ViU2V0dGluZ3MtPmRlZmF1bHRGaXhlZEZvbnRTaXpl KCkpOwogICAgIGNvcmVTZXR0aW5ncy0+c2V0RGVmYXVsdEZvbnRTaXplKHdlYlNldHRpbmdzLT5k ZWZhdWx0Rm9udFNpemUoKSk7CiAgICAgY29yZVNldHRpbmdzLT5zZXRNaW5pbXVtTG9naWNhbEZv bnRTaXplKHdlYlNldHRpbmdzLT5taW5pbXVtRm9udFNpemUoKSk7CmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViS2l0L2JsYWNrYmVycnkvQXBpL1dlYlNldHRpbmdzLmNwcCBiL1NvdXJjZS9XZWJLaXQv YmxhY2tiZXJyeS9BcGkvV2ViU2V0dGluZ3MuY3BwCmluZGV4IGQ0OTU4NzcuLjE4NTY4Y2MgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9BcGkvV2ViU2V0dGluZ3MuY3BwCisr KyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9BcGkvV2ViU2V0dGluZ3MuY3BwCkBAIC04Myw2 ICs4Myw3IEBAIERFRklORV9TVEFUSUNfTE9DQUwoU3RyaW5nLCBXZWJLaXRPZmZsaW5lV2ViQXBw bGljYXRpb25DYWNoZVBhdGgsICgiV2ViS2l0T2ZmbGluCiBERUZJTkVfU1RBVElDX0xPQ0FMKFN0 cmluZywgV2ViS2l0UGFnZUdyb3VwTmFtZSwgKCJXZWJLaXRQYWdlR3JvdXBOYW1lIikpOwogREVG SU5FX1NUQVRJQ19MT0NBTChTdHJpbmcsIFdlYktpdFBsdWdpbnNFbmFibGVkLCAoIldlYktpdFBs dWdpbnNFbmFibGVkIikpOwogREVGSU5FX1NUQVRJQ19MT0NBTChTdHJpbmcsIFdlYktpdFByaXZh dGVCcm93c2luZ0VuYWJsZWQsICgiV2ViS2l0UHJpdmF0ZUJyb3dzaW5nRW5hYmxlZCIpKTsKK0RF RklORV9TVEFUSUNfTE9DQUwoU3RyaW5nLCBXZWJLaXREZXZpY2VTdXBwb3J0c01vdXNlLCAoIldl YktpdERldmljZVN1cHBvcnRzTW91c2UiKSk7CiBERUZJTkVfU1RBVElDX0xPQ0FMKFN0cmluZywg V2ViS2l0U2Fuc1NlcmlmZkZvbnRGYW1pbHksICgiV2ViS2l0U2Fuc1NlcmlmZkZvbnRGYW1pbHki KSk7CiBERUZJTkVfU1RBVElDX0xPQ0FMKFN0cmluZywgV2ViS2l0U2VyaWZmRm9udEZhbWlseSwg KCJXZWJLaXRTZXJpZmZGb250RmFtaWx5IikpOwogREVGSU5FX1NUQVRJQ19MT0NBTChTdHJpbmcs IFdlYktpdFN0YW5kYXJkRm9udEZhbWlseSwgKCJXZWJLaXRTdGFuZGFyZEZvbnRGYW1pbHkiKSk7 CkBAIC0yNjYsNiArMjY3LDE2IEBAIHZvaWQgV2ViU2V0dGluZ3M6OnNldFByaXZhdGVCcm93c2lu Z0VuYWJsZWQoYm9vbCBlbmFibGVkKQogICAgIG1fcHJpdmF0ZS0+c2V0Qm9vbGVhbihXZWJLaXRQ cml2YXRlQnJvd3NpbmdFbmFibGVkLCBlbmFibGVkKTsKIH0KIAorYm9vbCBXZWJTZXR0aW5nczo6 ZG9lc0RldmljZVN1cHBvcnRNb3VzZSgpIGNvbnN0Cit7CisgICAgcmV0dXJuIG1fcHJpdmF0ZS0+ Z2V0Qm9vbGVhbihXZWJLaXREZXZpY2VTdXBwb3J0c01vdXNlKTsKK30KKwordm9pZCBXZWJTZXR0 aW5nczo6c2V0RGV2aWNlU3VwcG9ydHNNb3VzZShib29sIGVuYWJsZWQpCit7CisgICAgbV9wcml2 YXRlLT5zZXRCb29sZWFuKFdlYktpdERldmljZVN1cHBvcnRzTW91c2UsIGVuYWJsZWQpOworfQor CiBpbnQgV2ViU2V0dGluZ3M6OmRlZmF1bHRGaXhlZEZvbnRTaXplKCkgY29uc3QKIHsKICAgICBy ZXR1cm4gbV9wcml2YXRlLT5nZXRJbnRlZ2VyKFdlYktpdERlZmF1bHRGaXhlZEZvbnRTaXplKTsK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9BcGkvV2ViU2V0dGluZ3MuaCBi L1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9BcGkvV2ViU2V0dGluZ3MuaAppbmRleCA5NjE3MWFh Li5jNjEzZjE1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvQXBpL1dlYlNl dHRpbmdzLmgKKysrIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0FwaS9XZWJTZXR0aW5ncy5o CkBAIC03Miw2ICs3Miw5IEBAIHB1YmxpYzoKICAgICBib29sIGlzUHJpdmF0ZUJyb3dzaW5nRW5h YmxlZCgpIGNvbnN0OwogICAgIHZvaWQgc2V0UHJpdmF0ZUJyb3dzaW5nRW5hYmxlZChib29sKTsK IAorICAgIHZvaWQgc2V0RGV2aWNlU3VwcG9ydHNNb3VzZShib29sKTsKKyAgICBib29sIGRvZXNE ZXZpY2VTdXBwb3J0TW91c2UoKSBjb25zdDsKKwogICAgIGludCBkZWZhdWx0Rml4ZWRGb250U2l6 ZSgpIGNvbnN0OwogICAgIHZvaWQgc2V0RGVmYXVsdEZpeGVkRm9udFNpemUoaW50KTsKIApkaWZm IC0tZ2l0IGEvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJL aXQvYmxhY2tiZXJyeS9DaGFuZ2VMb2cKaW5kZXggZmQ3MjAxMi4uODdmMWM0ZSAxMDA2NDQKLS0t IGEvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViS2l0 L2JsYWNrYmVycnkvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjcgQEAKKzIwMTItMDYtMTUgIEFudG9u aW8gR29tZXMgIDxhZ29tZXNAcmltLmNvbT4KKworICAgICAgICBbQmxhY2tCZXJyeV0gRGlzYWJs ZSBXZWJDb3JlOjpFdmVudEhhbmRsZXIgc3ludGhlc2l6ZWQgbW91c2UgZXZlbnRzIGR1cmluZyB0 b3VjaCBzY3JvbGxpbmcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTg5MjI3CisgICAgICAgIFBSICMxNDY2NDIKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBNYWtlIHVzZSBvZiB0aGUgU2V0dGluZ3M6OnN1cHBv cnRzTW91c2VEZXZpY2Ugc2V0dGluZyBpbiBvcmRlciB0bworICAgICAgICBwcmV2ZW50IG1vdXNl IG1vdmUgZXZlbnQgdG8gZmlyZSBhcyBhIHJlc3BvbnNlIHRvIGEgc2Nyb2xsIGFjdGlvbi4KKyAg ICAgICAgV2UgbWlnaHQgc3RpbGwgd2FudCB0byBkeW5hbWljYWxseSB0b2dnbGUgdGhpcyBzZXR0 aW5nIE9OLCBpbiBjYXNlIGZvcgorICAgICAgICBleGFtcGxlIG9mIGEgbW91c2Ugd2hlZWwgZHJp dmVuIHNjcm9sbCBhY3Rpb24sIGJ1dCB3ZSBjYW4gcmV2aXNpdCBpdAorICAgICAgICB3aGVuIGl0 IGJlY29tZXMgYSBmdWxseSBzdXBwb3J0ZWQvcHJpbWFyeSB1c2UgY2FzZS4KKworICAgICAgICBJ bnRlcm5hbGx5IHJldmlld2VkIGJ5IEVsaSBGaWRsZXIuCisKKyAgICAgICAgKiBBcGkvV2ViUGFn ZS5jcHA6CisgICAgICAgIChCbGFja0JlcnJ5OjpXZWJLaXQ6OldlYlBhZ2VQcml2YXRlOjpkaWRD aGFuZ2VTZXR0aW5ncyk6CisgICAgICAgICogQXBpL1dlYlNldHRpbmdzLmNwcDoKKyAgICAgICAg KFdlYktpdCk6CisgICAgICAgIChCbGFja0JlcnJ5OjpXZWJLaXQ6OldlYlNldHRpbmdzOjppc0Rl dmljZVN1cHBvcnRzTW91c2VFbmFibGVkKToKKyAgICAgICAgKEJsYWNrQmVycnk6OldlYktpdDo6 V2ViU2V0dGluZ3M6OnNldERldmljZVN1cHBvcnRzTW91c2VFbmFibGVkKToKKyAgICAgICAgKiBB cGkvV2ViU2V0dGluZ3MuaDoKKwogMjAxMi0wNi0xNCAgU2VhbiBXYW5nICA8WHVld2VuLldhbmdA dG9yY2htb2JpbGUuY29tLmNuPgogCiAgICAgICAgIFtCbGFja0JlcnJ5XSBTZWxlY3Rpb24gLSBD cmFzaCB3aGVuIG1hbmlwdWxhdGluZyBzZWxlY3Rpb24gYnkgZHJhZ2dpbmcgaGFuZGxlCi0tIAox LjcuNS40Cgo=