89215 2012-06-15 08:11:41 -0700 master.cfg cleanup: Pass CheckOutSource instance instead of class to BuildStep.addStep 2012-06-26 08:03:29 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 89001 1 ossy ossy lforschler ossy rniwa tony oldest_to_newest 650197 0 ossy 2012-06-15 08:11:41 -0700 because it is deprecated and will be dropped in buildbot 0.8.7 650200 1 147822 ossy 2012-06-15 08:14:12 -0700 Created attachment 147822 Patch Tested on a local test buildmaster (same as build.webkit.org) 653949 2 147822 tony 2012-06-20 15:41:15 -0700 Comment on attachment 147822 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=147822&action=review > Tools/ChangeLog:6 > + > + Reviewed by NOBODY (OOPS!). Nit: Can you include the 'why' (what you wrote in comment #0) in the changelog? > Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg:117 > + def __init__(self, **kwargs): Nit: Do we need **kwargs here? I only see one caller for CheckOutSource and it doesn't pass any flags. 657608 3 147822 ossy 2012-06-26 07:57:24 -0700 Comment on attachment 147822 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=147822&action=review >> Tools/ChangeLog:6 >> + Reviewed by NOBODY (OOPS!). > > Nit: Can you include the 'why' (what you wrote in comment #0) in the changelog? Sure, will do. >> Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg:117 >> + def __init__(self, **kwargs): > > Nit: Do we need **kwargs here? I only see one caller for CheckOutSource and it doesn't pass any flags. Yes, we need. Buildbot will instantiate CheckOutSource too, we should pass through kwargs to the parent class always. "Keep a **kwargs argument on the end of your options, and pass that up to the parent class's constructor." http://buildbot.net/buildbot/docs/0.8.6p1/manual/customization.html#writing-buildstep-constructors 657610 4 147822 ossy 2012-06-26 08:01:40 -0700 Comment on attachment 147822 Patch Landed in http://trac.webkit.org/changeset/121263 with additional comment. 147822 2012-06-15 08:14:12 -0700 2012-06-26 08:01:40 -0700 Patch bug-89215-20120615171411.patch text/plain 2340 ossy U3VidmVyc2lvbiBSZXZpc2lvbjogMTIwNDU3CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggYTRhMGE5NWQ5ODc3ZmZlZGU1OTcwNTYwNzJkN2FhMDk3 Y2VhZWJkOC4uMTk2OWQwYzQ2NmJiZDZhNmY0MmVhMmVmMzFmNWUyZTFlYjc1MWU5MiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE2 IEBACiAyMDEyLTA2LTE1ICBDc2FiYSBPc3p0cm9nb27DoWMgIDxvc3N5QHdlYmtpdC5vcmc+CiAK KyAgICAgICAgbWFzdGVyLmNmZyBjbGVhbnVwOiBQYXNzIENoZWNrT3V0U291cmNlIGluc3RhbmNl IGluc3RlYWQgb2YgY2xhc3MgdG8gQnVpbGRTdGVwLmFkZFN0ZXAKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTg5MjE1CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBCdWlsZFNsYXZlU3VwcG9ydC9idWlsZC53 ZWJraXQub3JnLWNvbmZpZy9tYXN0ZXIuY2ZnOgorICAgICAgICAoQ2hlY2tPdXRTb3VyY2UuX19p bml0X18pOgorICAgICAgICAoRmFjdG9yeS5fX2luaXRfXyk6CisKKzIwMTItMDYtMTUgIENzYWJh IE9zenRyb2dvbsOhYyAgPG9zc3lAd2Via2l0Lm9yZz4KKwogICAgICAgICBtYXN0ZXIuY2ZnIGNs ZWFudXAsIHJlbW92ZSB1bm5lY2Vzc2FyeSB3b3JrYXJvdW5kCiAgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04ODk5NAogCmRpZmYgLS1naXQgYS9Ub29scy9C dWlsZFNsYXZlU3VwcG9ydC9idWlsZC53ZWJraXQub3JnLWNvbmZpZy9tYXN0ZXIuY2ZnIGIvVG9v bHMvQnVpbGRTbGF2ZVN1cHBvcnQvYnVpbGQud2Via2l0Lm9yZy1jb25maWcvbWFzdGVyLmNmZwpp bmRleCBjMDBhMTgwNzIxMjc3M2E5MjNhNTc0M2VlMTVjMzRkMjg0MWJmMmQ5Li44YTJhOWZmNzk4 YmE5NmYzMjdkOTVkNzEyMjNiZDdiYWNmNWNhODEwIDEwMDY0NAotLS0gYS9Ub29scy9CdWlsZFNs YXZlU3VwcG9ydC9idWlsZC53ZWJraXQub3JnLWNvbmZpZy9tYXN0ZXIuY2ZnCisrKyBiL1Rvb2xz L0J1aWxkU2xhdmVTdXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29uZmlnL21hc3Rlci5jZmcKQEAg LTExNCw4ICsxMTQsMTIgQEAgY2xhc3MgQ29uZmlndXJlQnVpbGQoYnVpbGRzdGVwLkJ1aWxkU3Rl cCk6CiBjbGFzcyBDaGVja091dFNvdXJjZShzb3VyY2UuU1ZOKToKICAgICBiYXNlVVJMID0gImh0 dHA6Ly9zdm4ud2Via2l0Lm9yZy9yZXBvc2l0b3J5L3dlYmtpdC8iCiAgICAgbW9kZSA9ICJ1cGRh dGUiCi0gICAgZGVmIF9faW5pdF9fKHNlbGYsICphcmdzLCAqKmt3YXJncyk6Ci0gICAgICAgIHNv dXJjZS5TVk4uX19pbml0X18oc2VsZiwgYmFzZVVSTD1zZWxmLmJhc2VVUkwsIGRlZmF1bHRCcmFu Y2g9InRydW5rIiwgbW9kZT1zZWxmLm1vZGUsICphcmdzLCAqKmt3YXJncykKKyAgICBkZWYgX19p bml0X18oc2VsZiwgKiprd2FyZ3MpOgorICAgICAgICBrd2FyZ3NbJ2Jhc2VVUkwnXSA9IHNlbGYu YmFzZVVSTAorICAgICAgICBrd2FyZ3NbJ2RlZmF1bHRCcmFuY2gnXSA9ICJ0cnVuayIKKyAgICAg ICAga3dhcmdzWydtb2RlJ10gPSBzZWxmLm1vZGUKKyAgICAgICAgc291cmNlLlNWTi5fX2luaXRf XyhzZWxmLCAqKmt3YXJncykKKwogCiAKIGNsYXNzIEluc3RhbGxXaW4zMkRlcGVuZGVuY2llcyhz aGVsbC5Db21waWxlKToKQEAgLTY2Myw3ICs2NjcsNyBAQCBjbGFzcyBGYWN0b3J5KGZhY3Rvcnku QnVpbGRGYWN0b3J5KToKICAgICBkZWYgX19pbml0X18oc2VsZiwgcGxhdGZvcm0sIGNvbmZpZ3Vy YXRpb24sIGFyY2hpdGVjdHVyZXMsIGJ1aWxkT25seSk6CiAgICAgICAgIGZhY3RvcnkuQnVpbGRG YWN0b3J5Ll9faW5pdF9fKHNlbGYpCiAgICAgICAgIHNlbGYuYWRkU3RlcChDb25maWd1cmVCdWls ZCwgcGxhdGZvcm09cGxhdGZvcm0sIGNvbmZpZ3VyYXRpb249Y29uZmlndXJhdGlvbiwgYXJjaGl0 ZWN0dXJlPSIgIi5qb2luKGFyY2hpdGVjdHVyZXMpLCBidWlsZE9ubHk9YnVpbGRPbmx5KQotICAg ICAgICBzZWxmLmFkZFN0ZXAoQ2hlY2tPdXRTb3VyY2UpCisgICAgICAgIHNlbGYuYWRkU3RlcChD aGVja091dFNvdXJjZSgpKQogICAgICAgICAjIFRoZXJlIGFyZSBtdWx0aXBsZSBRdCBzbGF2ZXMg cnVubmluZyBvbiBzYW1lIG1hY2hpbmVzLCBzbyBidWlsZHNsYXZlcyBzaG91bGRuJ3Qga2lsbCB0 aGUgcHJvY2Vzc2VzIG9mIG90aGVyIHNsYXZlcy4KICAgICAgICAgaWYgbm90IHBsYXRmb3JtLnN0 YXJ0c3dpdGgoInF0Iik6CiAgICAgICAgICAgICBzZWxmLmFkZFN0ZXAoS2lsbE9sZFByb2Nlc3Nl cykK