89211 2012-06-15 07:39:37 -0700 [BlackBerry] Certain web pages (i.e., http://www.cloudtweaks.com/) are allowed to be wider than the screen 2012-06-26 10:19:49 -0700 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 jkjiang jkjiang anilsson manyoso rwlbuis staikos tonikitoo oldest_to_newest 650171 0 jkjiang 2012-06-15 07:39:37 -0700 Steps to Reproduce: *Open Browse *Go to http://www.cloudtweaks.com/ *Observe that the information are not fitted to the screen - able to scroll left and right, instead of just up and down Expected: *All web pages should fit in to the screen 650225 1 147828 jkjiang 2012-06-15 08:49:08 -0700 Created attachment 147828 Patch 650226 2 147828 jkjiang 2012-06-15 08:49:46 -0700 Comment on attachment 147828 Patch Will update the internal reviewer. 650230 3 147829 jkjiang 2012-06-15 08:53:38 -0700 Created attachment 147829 committed, r=rwlbuis 650247 4 147829 rwlbuis 2012-06-15 09:26:06 -0700 Comment on attachment 147829 committed, r=rwlbuis View in context: https://bugs.webkit.org/attachment.cgi?id=147829&action=review LGTM. > Source/WebKit/blackberry/Api/WebPage.cpp:1683 > + return zoomToFitScale < minimumZoomToFitScale ? minimumZoomToFitScale : zoomToFitScale; Using std:min is better here as it is clearer what you are doing. 650254 5 147829 jkjiang 2012-06-15 09:33:28 -0700 Comment on attachment 147829 committed, r=rwlbuis View in context: https://bugs.webkit.org/attachment.cgi?id=147829&action=review >> Source/WebKit/blackberry/Api/WebPage.cpp:1683 >> + return zoomToFitScale < minimumZoomToFitScale ? minimumZoomToFitScale : zoomToFitScale; > > Using std:min is better here as it is clearer what you are doing. Thanks for catching this! Should use std::max instead of std:min actually. 650291 6 147829 jkjiang 2012-06-15 10:15:55 -0700 Comment on attachment 147829 committed, r=rwlbuis Committed r120473: <http://trac.webkit.org/changeset/120473>. 147828 2012-06-15 08:49:08 -0700 2012-06-15 08:49:46 -0700 Patch bug-89211-20120615114904.patch text/plain 4556 jkjiang U3VidmVyc2lvbiBSZXZpc2lvbjogMTIwNDYzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Js YWNrYmVycnkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZwpp bmRleCAxMTY4MzhhZjhiNTVkNTVmMDY0NmFjMjYyNjkzNTc5NGJlZGUxYzNkLi40YzEyMzAyYjU3 YWI1YjJkNDliNTUwOTk0ZjczYmMwNWVlYmVhYmMyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 L2JsYWNrYmVycnkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFu Z2VMb2cKQEAgLTEsMyArMSwyOCBAQAorMjAxMi0wNi0xNSAgSmFja3kgSmlhbmcgIDx6aGFqaWFu Z0ByaW0uY29tPgorCisgICAgICAgIFtCbGFja0JlcnJ5XSBDZXJ0YWluIHdlYiBwYWdlcyAoaS5l LiwgaHR0cDovL3d3dy5jbG91ZHR3ZWFrcy5jb20vKSBhcmUgYWxsb3dlZCB0byBiZSB3aWRlciB0 aGFuIHRoZSBzY3JlZW4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTg5MjExCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisgICAg ICAgIFBhdGNoIGJ5IEphY2t5IEppYW5nIDx6aGFqaWFuZ0ByaW0uY29tPgorCisgICAgICAgIFBS OiAxMzUyMTUKKyAgICAgICAgTWFrZSBzaW1wbGVyIHJ1bGVzIGZvciB6b29tIHRvIGZpdCBzY2Fs ZToKKyAgICAgICAgLSBab29tIHRvIGZpdCBob3Jpem9udGFsbHkgZmlyc3Qgd2l0aG91dCBjbGFt cGluZyB0aGUgY29udGVudHMgd2lkdGguCisgICAgICAgIC0gWm9vbSB0byBmaXQgdmVydGljYWxs eSBpbnN0ZWFkIHdpdGhvdXQgY2xhbXBpbmcgdGhlIGNvbnRlbnRzIGhlaWdodAorICAgICAgICAg IGlmIHRoZSBob3Jpem9udGFsIHpvb20gdG8gZml0IGNhbiBjYXVzZSBhIGdyZXkgYXJlYSBiZWxv dyB0aGUgd2ViCisgICAgICAgICAgcGFnZS4gR2V0IHJpZCBvZiB0aGUgdmlydHVhbCB2aWV3cG9y dCBndWFyZCBhcyB0aGVyZSBtYXkgYmUgY2FzZXMKKyAgICAgICAgICB0aGF0IHpvb21pbmcgY2Fu IGNhdXNlIGEgZ3JleSBhcmVhIHdpdGhvdXQgYSB2aXJ0dWFsIHZpZXdwb3J0LgorICAgICAgICAt IENsYW1wIHRoZSBzY2FsZSBieSB0aGUgbWluaW11bSB6b29tIHRvIGZpdCBzY2FsZSAwLjI1IGFu ZCBhcHBseQorICAgICAgICAgIHRoaXMgcnVsZSB0byBpbWFnZSBkb2N1bWVudHMgYXMgd2VsbC4g VGhpcyBtaW5pbXVtIHNjYWxlIGNhbiBiZQorICAgICAgICAgIGNoYW5nZWQgaWYgdGhlcmUgaXMg YSBiZXR0ZXIgdmF1bGUgaW4gdGhlIGZ1dHVyZS4KKyAgICAgICAgSW4gdGhpcyB3YXksIHdlIGNh biBnZXQgcmlkIG9mIHRoZSBpc3N1ZSB0aGF0IG1hbnkgd2ViIHBhZ2VzIGRvbid0IGZpdAorICAg ICAgICB0aGUgc2NyZWVuLgorCisgICAgICAgICogQXBpL1dlYlBhZ2UuY3BwOgorICAgICAgICAo V2ViS2l0KToKKyAgICAgICAgKEJsYWNrQmVycnk6OldlYktpdDo6V2ViUGFnZVByaXZhdGU6Onpv b21Ub0ZpdFNjYWxlKToKKwogMjAxMi0wNi0xNSAgWW9uZyBMaSAgPHlvbGlAcmltLmNvbT4KIAog ICAgICAgICBbQmxhY2tCZXJyeV0gUmVtb3ZlIEJhY2tpbmdTdG9yZUNsaWVudDo6c2Nyb2xsc0hv cml6b250YWxseS9zY3JvbGxzVmVyaXRpY2FsbHkoKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktp dC9ibGFja2JlcnJ5L0FwaS9XZWJQYWdlLmNwcCBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9B cGkvV2ViUGFnZS5jcHAKaW5kZXggOWU3N2NkYWUyMzYzYTg3YzdmMDBiNGNjYmY2NDc1MjQ4ZmEx MzczYy4uZGI1YTU2MWFiYjYwZDUwNzFmMWY3MDU0ZjczZGE0ZTEwMDBmYmI3MyAxMDA2NDQKLS0t IGEvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0FwaS9XZWJQYWdlLmNwcAorKysgYi9Tb3VyY2Uv V2ViS2l0L2JsYWNrYmVycnkvQXBpL1dlYlBhZ2UuY3BwCkBAIC0yMDcsNiArMjA3LDggQEAgY29u c3QgSW50U2l6ZSBtaW5pbXVtTGF5b3V0U2l6ZSgxMCwgMTApOyAvLyBOZWVkcyB0byBiZSBhIHNt YWxsIHNpemUsIGdyZWF0ZXIgdGgKIAogY29uc3QgZG91YmxlIG1pbmltdW1FeHBhbmRpbmdSYXRp byA9IDAuMTU7CiAKK2NvbnN0IGludCBtaW5pbXVtWm9vbVRvRml0U2NhbGUgPSAwLjI1OworCiAv LyBIZWxwZXIgZnVuY3Rpb24gdG8gcGFyc2UgYSBVUkwgYW5kIGZpbGwgaW4gbWlzc2luZyBwYXJ0 cy4KIHN0YXRpYyBLVVJMIHBhcnNlVXJsKGNvbnN0IFN0cmluZyYgdXJsKQogewpAQCAtMTY3Miwz MSArMTY3NCwxMyBAQCB2b2lkIFdlYlBhZ2VQcml2YXRlOjp6b29tVG9Jbml0aWFsU2NhbGVPbkxv YWQoKQogCiBkb3VibGUgV2ViUGFnZVByaXZhdGU6Onpvb21Ub0ZpdFNjYWxlKCkgY29uc3QKIHsK LSAgICAvLyBXZSBtdXN0IGNsYW1wIHRoZSBjb250ZW50cyBmb3IgdGhpcyBjYWxjdWxhdGlvbiBz byB0aGF0IHdlIGRvIG5vdCBhbGxvdyBhbgotICAgIC8vIGFyYml0cmFyaWx5IHNtYWxsIHpvb21U b0ZpdFNjYWxlIG11Y2ggbGlrZSB3ZSBjbGFtcCB0aGUgZml4ZWRMYXlvdXRTaXplKCkKLSAgICAv LyBzbyB0aGF0IHdlIGRvIG5vdCBoYXZlIGFyYml0cmFyaWx5IGxhcmdlIGxheW91dCBzaXplLgot ICAgIC8vIElmIHdlIGhhdmUgYSBzcGVjaWZpZWQgdmlld3BvcnQsIHdlIG1heSBuZWVkIHRvIGJl IGFibGUgdG8gem9vbSBvdXQgbW9yZS4KLSAgICBpbnQgY29udGVudFdpZHRoID0gc3RkOjptaW4o Y29udGVudHNTaXplKCkud2lkdGgoKSwgc3RkOjptYXgobV92aXJ0dWFsVmlld3BvcnRXaWR0aCwg c3RhdGljX2Nhc3Q8aW50PihkZWZhdWx0TWF4TGF5b3V0U2l6ZSgpLndpZHRoKCkpKSk7Ci0KLSAg ICAvLyBkZWZhdWx0TWF4TGF5b3V0U2l6ZSgpLndpZHRoKCkgaXMgYSBzYWZlZ3VhcmQgZm9yIGV4 Y2Vzc2l2ZWx5IGxhcmdlIHBhZ2UgbGF5b3V0cyB0aGF0Ci0gICAgLy8gaXMgdG9vIHJlc3RyaWN0 aXZlIGZvciBpbWFnZSBkb2N1bWVudHMuIEluIHRoaXMgY2FzZSwgdGhlIGRvY3VtZW50IHdpZHRo IGlzIHN1ZmZpY2llbnQuCi0gICAgRG9jdW1lbnQqIGRvYyA9IG1fcGFnZS0+bWFpbkZyYW1lKCkt PmRvY3VtZW50KCk7Ci0gICAgaWYgKGRvYyAmJiBkb2MtPmlzSW1hZ2VEb2N1bWVudCgpKQotICAg ICAgIGNvbnRlbnRXaWR0aCA9IGNvbnRlbnRzU2l6ZSgpLndpZHRoKCk7Ci0KLSAgICAvLyBJZiB3 ZSBoYXZlIGEgdmlydHVhbCB2aWV3cG9ydCBhbmQgaXRzIGFzcGVjdCByYXRpbyBjYXVzZWQgY29u dGVudCB0byBsYXlvdXQKLSAgICAvLyB3aWRlciB0aGFuIHRoZSBkZWZhdWx0IGxheW91dCBhc3Bl Y3QgcmF0aW8gd2UgbmVlZCB0byB6b29tIHRvIGZpdCB0aGUgY29udGVudCBoZWlnaHQKLSAgICAv LyBpbiBvcmRlciB0byBhdm9pZCBzaG93aW5nIGEgZ3JleSBhcmVhIGJlbG93IHRoZSB3ZWIgcGFn ZS4KLSAgICAvLyBXaXRob3V0IHZpcnR1YWwgdmlld3BvcnQgd2UgY2FuIG5ldmVyIGdldCBpbnRv IHRoaXMgc2l0dWF0aW9uLgotICAgIGlmIChoYXNWaXJ0dWFsVmlld3BvcnQoKSkgewotICAgICAg ICBpbnQgY29udGVudEhlaWdodCA9IHN0ZDo6bWluKGNvbnRlbnRzU2l6ZSgpLmhlaWdodCgpLCBz dGQ6Om1heChtX3ZpcnR1YWxWaWV3cG9ydEhlaWdodCwgc3RhdGljX2Nhc3Q8aW50PihkZWZhdWx0 TWF4TGF5b3V0U2l6ZSgpLmhlaWdodCgpKSkpOwotCi0gICAgICAgIC8vIEFzcGVjdCByYXRpbyBj aGVjayB3aXRob3V0IGRpdmlzaW9uLgotICAgICAgICBpZiAoY29udGVudFdpZHRoICogbV9kZWZh dWx0TGF5b3V0U2l6ZS5oZWlnaHQoKSA+IGNvbnRlbnRIZWlnaHQgKiBtX2RlZmF1bHRMYXlvdXRT aXplLndpZHRoKCkpCi0gICAgICAgICAgICByZXR1cm4gY29udGVudEhlaWdodCA+IDAgPyBzdGF0 aWNfY2FzdDxkb3VibGU+KG1fZGVmYXVsdExheW91dFNpemUuaGVpZ2h0KCkpIC8gY29udGVudEhl aWdodCA6IDEuMDsKLSAgICB9CisgICAgaW50IGNvbnRlbnRXaWR0aCA9IGNvbnRlbnRzU2l6ZSgp LndpZHRoKCk7CisgICAgaW50IGNvbnRlbnRIZWlnaHQgPSBjb250ZW50c1NpemUoKS5oZWlnaHQo KTsKKyAgICBkb3VibGUgem9vbVRvRml0U2NhbGUgPSBjb250ZW50V2lkdGggPiAwLjAgPyBzdGF0 aWNfY2FzdDxkb3VibGU+KG1fYWN0dWFsVmlzaWJsZVdpZHRoKSAvIGNvbnRlbnRXaWR0aCA6IDEu MDsKKyAgICBpZiAoY29udGVudEhlaWdodCAqIHpvb21Ub0ZpdFNjYWxlIDwgc3RhdGljX2Nhc3Q8 ZG91YmxlPihtX2RlZmF1bHRMYXlvdXRTaXplLmhlaWdodCgpKSkKKyAgICAgICAgem9vbVRvRml0 U2NhbGUgPSBjb250ZW50SGVpZ2h0ID4gMCA/IHN0YXRpY19jYXN0PGRvdWJsZT4obV9kZWZhdWx0 TGF5b3V0U2l6ZS5oZWlnaHQoKSkgLyBjb250ZW50SGVpZ2h0IDogMS4wOwogCi0gICAgcmV0dXJu IGNvbnRlbnRXaWR0aCA+IDAuMCA/IHN0YXRpY19jYXN0PGRvdWJsZT4obV9hY3R1YWxWaXNpYmxl V2lkdGgpIC8gY29udGVudFdpZHRoIDogMS4wOworICAgIHJldHVybiB6b29tVG9GaXRTY2FsZSA8 IG1pbmltdW1ab29tVG9GaXRTY2FsZSA/IG1pbmltdW1ab29tVG9GaXRTY2FsZSA6IHpvb21Ub0Zp dFNjYWxlOwogfQogCiBkb3VibGUgV2ViUGFnZTo6em9vbVRvRml0U2NhbGUoKSBjb25zdAo= 147829 2012-06-15 08:53:38 -0700 2012-06-15 10:15:55 -0700 committed, r=rwlbuis bug-89211-20120615115337.patch text/plain 4605 jkjiang U3VidmVyc2lvbiBSZXZpc2lvbjogMTIwNDYzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Js YWNrYmVycnkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZwpp bmRleCAxMTY4MzhhZjhiNTVkNTVmMDY0NmFjMjYyNjkzNTc5NGJlZGUxYzNkLi5kZThlOGZkMjBm YWUwZDMxZGE5MTY4YWZmNDhmZWZjNDI2MGQwZGMxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 L2JsYWNrYmVycnkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFu Z2VMb2cKQEAgLTEsMyArMSwzMCBAQAorMjAxMi0wNi0xNSAgSmFja3kgSmlhbmcgIDx6aGFqaWFu Z0ByaW0uY29tPgorCisgICAgICAgIFtCbGFja0JlcnJ5XSBDZXJ0YWluIHdlYiBwYWdlcyAoaS5l LiwgaHR0cDovL3d3dy5jbG91ZHR3ZWFrcy5jb20vKSBhcmUgYWxsb3dlZCB0byBiZSB3aWRlciB0 aGFuIHRoZSBzY3JlZW4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTg5MjExCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisgICAg ICAgIFBhdGNoIGJ5IEphY2t5IEppYW5nIDx6aGFqaWFuZ0ByaW0uY29tPgorCisgICAgICAgIFBS OiAxMzUyMTUKKyAgICAgICAgTWFrZSBzaW1wbGVyIHJ1bGVzIGZvciB6b29tIHRvIGZpdCBzY2Fs ZToKKyAgICAgICAgLSBab29tIHRvIGZpdCBob3Jpem9udGFsbHkgZmlyc3Qgd2l0aG91dCBjbGFt cGluZyB0aGUgY29udGVudHMgd2lkdGguCisgICAgICAgIC0gWm9vbSB0byBmaXQgdmVydGljYWxs eSBpbnN0ZWFkIHdpdGhvdXQgY2xhbXBpbmcgdGhlIGNvbnRlbnRzIGhlaWdodAorICAgICAgICAg IGlmIHRoZSBob3Jpem9udGFsIHpvb20gdG8gZml0IGNhbiBjYXVzZSBhIGdyZXkgYXJlYSBiZWxv dyB0aGUgd2ViCisgICAgICAgICAgcGFnZS4gR2V0IHJpZCBvZiB0aGUgdmlydHVhbCB2aWV3cG9y dCBndWFyZCBhcyB0aGVyZSBtYXkgYmUgY2FzZXMKKyAgICAgICAgICB0aGF0IHpvb21pbmcgY2Fu IGNhdXNlIGEgZ3JleSBhcmVhIHdpdGhvdXQgYSB2aXJ0dWFsIHZpZXdwb3J0LgorICAgICAgICAt IENsYW1wIHRoZSBzY2FsZSBieSB0aGUgbWluaW11bSB6b29tIHRvIGZpdCBzY2FsZSAwLjI1IGFu ZCBhcHBseQorICAgICAgICAgIHRoaXMgcnVsZSB0byBpbWFnZSBkb2N1bWVudHMgYXMgd2VsbC4g VGhpcyBtaW5pbXVtIHNjYWxlIGNhbiBiZQorICAgICAgICAgIGNoYW5nZWQgaWYgdGhlcmUgaXMg YSBiZXR0ZXIgdmF1bGUgaW4gdGhlIGZ1dHVyZS4KKyAgICAgICAgSW4gdGhpcyB3YXksIHdlIGNh biBnZXQgcmlkIG9mIHRoZSBpc3N1ZSB0aGF0IG1hbnkgd2ViIHBhZ2VzIGRvbid0IGZpdAorICAg ICAgICB0aGUgc2NyZWVuLgorCisgICAgICAgIFJldmlld2VkIGludGVybmFsbHkgYnkgQXJ2aWQg Tmlsc3Nvbi4KKworICAgICAgICAqIEFwaS9XZWJQYWdlLmNwcDoKKyAgICAgICAgKFdlYktpdCk6 CisgICAgICAgIChCbGFja0JlcnJ5OjpXZWJLaXQ6OldlYlBhZ2VQcml2YXRlOjp6b29tVG9GaXRT Y2FsZSk6CisKIDIwMTItMDYtMTUgIFlvbmcgTGkgIDx5b2xpQHJpbS5jb20+CiAKICAgICAgICAg W0JsYWNrQmVycnldIFJlbW92ZSBCYWNraW5nU3RvcmVDbGllbnQ6OnNjcm9sbHNIb3Jpem9udGFs bHkvc2Nyb2xsc1Zlcml0aWNhbGx5KCkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvYmxhY2ti ZXJyeS9BcGkvV2ViUGFnZS5jcHAgYi9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvQXBpL1dlYlBh Z2UuY3BwCmluZGV4IDllNzdjZGFlMjM2M2E4N2M3ZjAwYjRjY2JmNjQ3NTI0OGZhMTM3M2MuLmRi NWE1NjFhYmI2MGQ1MDcxZjFmNzA1NGY3M2RhNGUxMDAwZmJiNzMgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJLaXQvYmxhY2tiZXJyeS9BcGkvV2ViUGFnZS5jcHAKKysrIGIvU291cmNlL1dlYktpdC9i bGFja2JlcnJ5L0FwaS9XZWJQYWdlLmNwcApAQCAtMjA3LDYgKzIwNyw4IEBAIGNvbnN0IEludFNp emUgbWluaW11bUxheW91dFNpemUoMTAsIDEwKTsgLy8gTmVlZHMgdG8gYmUgYSBzbWFsbCBzaXpl LCBncmVhdGVyIHRoCiAKIGNvbnN0IGRvdWJsZSBtaW5pbXVtRXhwYW5kaW5nUmF0aW8gPSAwLjE1 OwogCitjb25zdCBpbnQgbWluaW11bVpvb21Ub0ZpdFNjYWxlID0gMC4yNTsKKwogLy8gSGVscGVy IGZ1bmN0aW9uIHRvIHBhcnNlIGEgVVJMIGFuZCBmaWxsIGluIG1pc3NpbmcgcGFydHMuCiBzdGF0 aWMgS1VSTCBwYXJzZVVybChjb25zdCBTdHJpbmcmIHVybCkKIHsKQEAgLTE2NzIsMzEgKzE2NzQs MTMgQEAgdm9pZCBXZWJQYWdlUHJpdmF0ZTo6em9vbVRvSW5pdGlhbFNjYWxlT25Mb2FkKCkKIAog ZG91YmxlIFdlYlBhZ2VQcml2YXRlOjp6b29tVG9GaXRTY2FsZSgpIGNvbnN0CiB7Ci0gICAgLy8g V2UgbXVzdCBjbGFtcCB0aGUgY29udGVudHMgZm9yIHRoaXMgY2FsY3VsYXRpb24gc28gdGhhdCB3 ZSBkbyBub3QgYWxsb3cgYW4KLSAgICAvLyBhcmJpdHJhcmlseSBzbWFsbCB6b29tVG9GaXRTY2Fs ZSBtdWNoIGxpa2Ugd2UgY2xhbXAgdGhlIGZpeGVkTGF5b3V0U2l6ZSgpCi0gICAgLy8gc28gdGhh dCB3ZSBkbyBub3QgaGF2ZSBhcmJpdHJhcmlseSBsYXJnZSBsYXlvdXQgc2l6ZS4KLSAgICAvLyBJ ZiB3ZSBoYXZlIGEgc3BlY2lmaWVkIHZpZXdwb3J0LCB3ZSBtYXkgbmVlZCB0byBiZSBhYmxlIHRv IHpvb20gb3V0IG1vcmUuCi0gICAgaW50IGNvbnRlbnRXaWR0aCA9IHN0ZDo6bWluKGNvbnRlbnRz U2l6ZSgpLndpZHRoKCksIHN0ZDo6bWF4KG1fdmlydHVhbFZpZXdwb3J0V2lkdGgsIHN0YXRpY19j YXN0PGludD4oZGVmYXVsdE1heExheW91dFNpemUoKS53aWR0aCgpKSkpOwotCi0gICAgLy8gZGVm YXVsdE1heExheW91dFNpemUoKS53aWR0aCgpIGlzIGEgc2FmZWd1YXJkIGZvciBleGNlc3NpdmVs eSBsYXJnZSBwYWdlIGxheW91dHMgdGhhdAotICAgIC8vIGlzIHRvbyByZXN0cmljdGl2ZSBmb3Ig aW1hZ2UgZG9jdW1lbnRzLiBJbiB0aGlzIGNhc2UsIHRoZSBkb2N1bWVudCB3aWR0aCBpcyBzdWZm aWNpZW50LgotICAgIERvY3VtZW50KiBkb2MgPSBtX3BhZ2UtPm1haW5GcmFtZSgpLT5kb2N1bWVu dCgpOwotICAgIGlmIChkb2MgJiYgZG9jLT5pc0ltYWdlRG9jdW1lbnQoKSkKLSAgICAgICBjb250 ZW50V2lkdGggPSBjb250ZW50c1NpemUoKS53aWR0aCgpOwotCi0gICAgLy8gSWYgd2UgaGF2ZSBh IHZpcnR1YWwgdmlld3BvcnQgYW5kIGl0cyBhc3BlY3QgcmF0aW8gY2F1c2VkIGNvbnRlbnQgdG8g bGF5b3V0Ci0gICAgLy8gd2lkZXIgdGhhbiB0aGUgZGVmYXVsdCBsYXlvdXQgYXNwZWN0IHJhdGlv IHdlIG5lZWQgdG8gem9vbSB0byBmaXQgdGhlIGNvbnRlbnQgaGVpZ2h0Ci0gICAgLy8gaW4gb3Jk ZXIgdG8gYXZvaWQgc2hvd2luZyBhIGdyZXkgYXJlYSBiZWxvdyB0aGUgd2ViIHBhZ2UuCi0gICAg Ly8gV2l0aG91dCB2aXJ0dWFsIHZpZXdwb3J0IHdlIGNhbiBuZXZlciBnZXQgaW50byB0aGlzIHNp dHVhdGlvbi4KLSAgICBpZiAoaGFzVmlydHVhbFZpZXdwb3J0KCkpIHsKLSAgICAgICAgaW50IGNv bnRlbnRIZWlnaHQgPSBzdGQ6Om1pbihjb250ZW50c1NpemUoKS5oZWlnaHQoKSwgc3RkOjptYXgo bV92aXJ0dWFsVmlld3BvcnRIZWlnaHQsIHN0YXRpY19jYXN0PGludD4oZGVmYXVsdE1heExheW91 dFNpemUoKS5oZWlnaHQoKSkpKTsKLQotICAgICAgICAvLyBBc3BlY3QgcmF0aW8gY2hlY2sgd2l0 aG91dCBkaXZpc2lvbi4KLSAgICAgICAgaWYgKGNvbnRlbnRXaWR0aCAqIG1fZGVmYXVsdExheW91 dFNpemUuaGVpZ2h0KCkgPiBjb250ZW50SGVpZ2h0ICogbV9kZWZhdWx0TGF5b3V0U2l6ZS53aWR0 aCgpKQotICAgICAgICAgICAgcmV0dXJuIGNvbnRlbnRIZWlnaHQgPiAwID8gc3RhdGljX2Nhc3Q8 ZG91YmxlPihtX2RlZmF1bHRMYXlvdXRTaXplLmhlaWdodCgpKSAvIGNvbnRlbnRIZWlnaHQgOiAx LjA7Ci0gICAgfQorICAgIGludCBjb250ZW50V2lkdGggPSBjb250ZW50c1NpemUoKS53aWR0aCgp OworICAgIGludCBjb250ZW50SGVpZ2h0ID0gY29udGVudHNTaXplKCkuaGVpZ2h0KCk7CisgICAg ZG91YmxlIHpvb21Ub0ZpdFNjYWxlID0gY29udGVudFdpZHRoID4gMC4wID8gc3RhdGljX2Nhc3Q8 ZG91YmxlPihtX2FjdHVhbFZpc2libGVXaWR0aCkgLyBjb250ZW50V2lkdGggOiAxLjA7CisgICAg aWYgKGNvbnRlbnRIZWlnaHQgKiB6b29tVG9GaXRTY2FsZSA8IHN0YXRpY19jYXN0PGRvdWJsZT4o bV9kZWZhdWx0TGF5b3V0U2l6ZS5oZWlnaHQoKSkpCisgICAgICAgIHpvb21Ub0ZpdFNjYWxlID0g Y29udGVudEhlaWdodCA+IDAgPyBzdGF0aWNfY2FzdDxkb3VibGU+KG1fZGVmYXVsdExheW91dFNp emUuaGVpZ2h0KCkpIC8gY29udGVudEhlaWdodCA6IDEuMDsKIAotICAgIHJldHVybiBjb250ZW50 V2lkdGggPiAwLjAgPyBzdGF0aWNfY2FzdDxkb3VibGU+KG1fYWN0dWFsVmlzaWJsZVdpZHRoKSAv IGNvbnRlbnRXaWR0aCA6IDEuMDsKKyAgICByZXR1cm4gem9vbVRvRml0U2NhbGUgPCBtaW5pbXVt Wm9vbVRvRml0U2NhbGUgPyBtaW5pbXVtWm9vbVRvRml0U2NhbGUgOiB6b29tVG9GaXRTY2FsZTsK IH0KIAogZG91YmxlIFdlYlBhZ2U6Onpvb21Ub0ZpdFNjYWxlKCkgY29uc3QK