89210 2012-06-15 07:34:41 -0700 [BlackBerry] Remove BackingStoreClient::scrollsHorizontally() 2012-06-15 08:30:06 -0700 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 yong.li.webkit webkit-unassigned tonikitoo webkit.review.bot oldest_to_newest 650164 0 yong.li.webkit 2012-06-15 07:34:41 -0700 Remove BackingStoreClient::scrollsHorizontally() and BackingStoreClient::scrollsVertically(), because calling them in BackingStore::blitContents() is unnecessary but unsafe. 650174 1 147809 yong.li.webkit 2012-06-15 07:45:58 -0700 Created attachment 147809 the patch 650212 2 147809 webkit.review.bot 2012-06-15 08:30:01 -0700 Comment on attachment 147809 the patch Clearing flags on attachment: 147809 Committed r120463: <http://trac.webkit.org/changeset/120463> 650213 3 webkit.review.bot 2012-06-15 08:30:06 -0700 All reviewed patches have been landed. Closing bug. 147809 2012-06-15 07:45:58 -0700 2012-06-15 08:30:01 -0700 the patch 89210.patch text/plain 3677 yong.li.webkit ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9BcGkvQmFja2luZ1N0b3JlLmNw cCBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9BcGkvQmFja2luZ1N0b3JlLmNwcAppbmRleCBj ZjI1MDI0Li45YjgxZTZiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvQXBp L0JhY2tpbmdTdG9yZS5jcHAKKysrIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0FwaS9CYWNr aW5nU3RvcmUuY3BwCkBAIC0xNTU3LDEwICsxNTU3LDggQEAgdm9pZCBCYWNraW5nU3RvcmVQcml2 YXRlOjpibGl0Q29udGVudHMoY29uc3QgUGxhdGZvcm06OkludFJlY3QmIGRzdFJlY3QsCiAKICNp ZiBFTkFCTEVfU0NST0xMQkFSUwogICAgIGlmIChpc1Njcm9sbGluZ09yWm9vbWluZygpICYmIG1f Y2xpZW50LT5pc01haW5GcmFtZSgpKSB7Ci0gICAgICAgIGlmIChtX2NsaWVudC0+c2Nyb2xsc0hv cml6b250YWxseSgpKQotICAgICAgICAgICAgYmxpdEhvcml6b250YWxTY3JvbGxiYXIob3JpZ2lu KTsKLSAgICAgICAgaWYgKG1fY2xpZW50LT5zY3JvbGxzVmVydGljYWxseSgpKQotICAgICAgICAg ICAgYmxpdFZlcnRpY2FsU2Nyb2xsYmFyKG9yaWdpbik7CisgICAgICAgIGJsaXRIb3Jpem9udGFs U2Nyb2xsYmFyKG9yaWdpbik7CisgICAgICAgIGJsaXRWZXJ0aWNhbFNjcm9sbGJhcihvcmlnaW4p OwogICAgIH0KICNlbmRpZgogCkBAIC0xODAwLDggKzE3OTgsNiBAQCB2b2lkIEJhY2tpbmdTdG9y ZVByaXZhdGU6OmJsaXRIb3Jpem9udGFsU2Nyb2xsYmFyKGNvbnN0IFBsYXRmb3JtOjpJbnRQb2lu dCYgc2NybwogICAgIGlmICghbV93ZWJQYWdlLT5pc1Zpc2libGUoKSkKICAgICAgICAgcmV0dXJu OwogCi0gICAgQVNTRVJUKG1fY2xpZW50LT5zY3JvbGxzSG9yaXpvbnRhbGx5KCkpOwotCiAgICAg bV93ZWJQYWdlLT5jbGllbnQoKS0+ZHJhd0hvcml6b250YWxTY3JvbGxiYXIoKTsKIH0KIApAQCAt MTgxMCw4ICsxODA2LDYgQEAgdm9pZCBCYWNraW5nU3RvcmVQcml2YXRlOjpibGl0VmVydGljYWxT Y3JvbGxiYXIoY29uc3QgUGxhdGZvcm06OkludFBvaW50JiBzY3JvbGwKICAgICBpZiAoIW1fd2Vi UGFnZS0+aXNWaXNpYmxlKCkpCiAgICAgICAgIHJldHVybjsKIAotICAgIEFTU0VSVChtX2NsaWVu dC0+c2Nyb2xsc1ZlcnRpY2FsbHkoKSk7Ci0KICAgICBtX3dlYlBhZ2UtPmNsaWVudCgpLT5kcmF3 VmVydGljYWxTY3JvbGxiYXIoKTsKIH0KIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9ibGFj a2JlcnJ5L0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFuZ2VMb2cKaW5k ZXggMTc1YmQ0My4uYWFhMjJjNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5 L0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvQ2hhbmdlTG9nCkBAIC0x LDMgKzEsMjEgQEAKKzIwMTItMDYtMTUgIFlvbmcgTGkgIDx5b2xpQHJpbS5jb20+CisKKyAgICAg ICAgW0JsYWNrQmVycnldIFJlbW92ZSBCYWNraW5nU3RvcmVDbGllbnQ6OnNjcm9sbHNIb3Jpem9u dGFsbHkvc2Nyb2xsc1Zlcml0aWNhbGx5KCkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTg5MjEwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgUmVtb3ZlIEJhY2tpbmdTdG9yZUNsaWVudDo6c2Nyb2xsc0hvcml6 b250YWxseSgpL3Njcm9sbHNWZXJpdGljYWxseSgpLCBiZWNhdXNlCisgICAgICAgIGNhbGxpbmcg dGhlbSBpcyBuZWl0aGVyIG5lc3Nhcnkgbm9yIHNhZmUuCisKKyAgICAgICAgKiBBcGkvQmFja2lu Z1N0b3JlLmNwcDoKKyAgICAgICAgKEJsYWNrQmVycnk6OldlYktpdDo6QmFja2luZ1N0b3JlUHJp dmF0ZTo6YmxpdENvbnRlbnRzKToKKyAgICAgICAgKEJsYWNrQmVycnk6OldlYktpdDo6QmFja2lu Z1N0b3JlUHJpdmF0ZTo6YmxpdEhvcml6b250YWxTY3JvbGxiYXIpOgorICAgICAgICAoQmxhY2tC ZXJyeTo6V2ViS2l0OjpCYWNraW5nU3RvcmVQcml2YXRlOjpibGl0VmVydGljYWxTY3JvbGxiYXIp OgorICAgICAgICAqIFdlYktpdFN1cHBvcnQvQmFja2luZ1N0b3JlQ2xpZW50LmNwcDoKKyAgICAg ICAgKiBXZWJLaXRTdXBwb3J0L0JhY2tpbmdTdG9yZUNsaWVudC5oOgorICAgICAgICAoQmFja2lu Z1N0b3JlQ2xpZW50KToKKwogMjAxMi0wNi0xNCAgQ2hyaXMgR3VhbiAgPGNocmlzLmd1YW5AdG9y Y2htb2JpbGUuY29tLmNuPgogCiAgICAgICAgIFtCbGFja2JlcnJ5XSBhZGQgYSBuZXcgQXBpIG5h bWVkIHNldEFsbG93Tm90aWZpY2F0aW9uCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2JsYWNr YmVycnkvV2ViS2l0U3VwcG9ydC9CYWNraW5nU3RvcmVDbGllbnQuY3BwIGIvU291cmNlL1dlYktp dC9ibGFja2JlcnJ5L1dlYktpdFN1cHBvcnQvQmFja2luZ1N0b3JlQ2xpZW50LmNwcAppbmRleCBl N2U0ZDY1Li40ZDM4OWNkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvV2Vi S2l0U3VwcG9ydC9CYWNraW5nU3RvcmVDbGllbnQuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvYmxh Y2tiZXJyeS9XZWJLaXRTdXBwb3J0L0JhY2tpbmdTdG9yZUNsaWVudC5jcHAKQEAgLTM4MCwxNiAr MzgwLDYgQEAgYm9vbCBCYWNraW5nU3RvcmVDbGllbnQ6OmlzRm9jdXNlZCgpIGNvbnN0CiAgICAg ICAgICYmIG1fZnJhbWUtPnBhZ2UoKS0+Zm9jdXNDb250cm9sbGVyKCktPmZvY3VzZWRGcmFtZSgp ID09IG1fZnJhbWU7CiB9CiAKLWJvb2wgQmFja2luZ1N0b3JlQ2xpZW50OjpzY3JvbGxzSG9yaXpv bnRhbGx5KCkgY29uc3QKLXsKLSAgICByZXR1cm4gdHJhbnNmb3JtZWRBY3R1YWxWaXNpYmxlU2l6 ZSgpLndpZHRoKCkgPCB0cmFuc2Zvcm1lZENvbnRlbnRzU2l6ZSgpLndpZHRoKCk7Ci19Ci0KLWJv b2wgQmFja2luZ1N0b3JlQ2xpZW50OjpzY3JvbGxzVmVydGljYWxseSgpIGNvbnN0Ci17Ci0gICAg cmV0dXJuIHRyYW5zZm9ybWVkQWN0dWFsVmlzaWJsZVNpemUoKS5oZWlnaHQoKSA8IHRyYW5zZm9y bWVkQ29udGVudHNTaXplKCkuaGVpZ2h0KCk7Ci19Ci0KIGJvb2wgQmFja2luZ1N0b3JlQ2xpZW50 Ojppc0NsaWVudEdlbmVyYXRlZFNjcm9sbCgpIGNvbnN0CiB7CiAgICAgcmV0dXJuIG1faXNDbGll bnRHZW5lcmF0ZWRTY3JvbGw7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkv V2ViS2l0U3VwcG9ydC9CYWNraW5nU3RvcmVDbGllbnQuaCBiL1NvdXJjZS9XZWJLaXQvYmxhY2ti ZXJyeS9XZWJLaXRTdXBwb3J0L0JhY2tpbmdTdG9yZUNsaWVudC5oCmluZGV4IDQyYjU3MjEuLjY5 YWVlOWEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9XZWJLaXRTdXBwb3J0 L0JhY2tpbmdTdG9yZUNsaWVudC5oCisrKyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9XZWJL aXRTdXBwb3J0L0JhY2tpbmdTdG9yZUNsaWVudC5oCkBAIC05NCw5ICs5NCw2IEBAIHB1YmxpYzoK IAogICAgIGJvb2wgaXNGb2N1c2VkKCkgY29uc3Q7CiAKLSAgICBib29sIHNjcm9sbHNIb3Jpem9u dGFsbHkoKSBjb25zdDsKLSAgICBib29sIHNjcm9sbHNWZXJ0aWNhbGx5KCkgY29uc3Q7Ci0KICAg ICBib29sIGlzQ2xpZW50R2VuZXJhdGVkU2Nyb2xsKCkgY29uc3Q7CiAgICAgdm9pZCBzZXRJc0Ns aWVudEdlbmVyYXRlZFNjcm9sbChib29sKTsKIAo=