89189 2012-06-15 01:53:00 -0700 [chromium] Compositor should be aware of |flipped| status of video textures per-platform 2012-07-17 18:15:47 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 fischman fischman ananta cc-bugs eric.carlson feature-media-reviews fischman jamesr shaochangbin webkit.review.bot oldest_to_newest 650017 0 fischman 2012-06-15 01:53:00 -0700 Migrated from http://code.google.com/p/chromium/issues/detail?id=130106 Today CCVideoLayerImpl::appendQuads assumes all video textures are "not flipped", but the orientation (0-on-top vs. 0-on-bottom) actually varies by VDA implementation, which can be determined by the OS/platform the binary is built for. Set |flipped| accordingly. 650019 1 147773 fischman 2012-06-15 01:54:02 -0700 Created attachment 147773 Patch 650170 2 147773 danakj 2012-06-15 07:37:43 -0700 Comment on attachment 147773 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=147773&action=review LGTM otherwise. > Source/WebCore/platform/graphics/chromium/cc/CCVideoLayerImpl.cpp:214 > +#else // OS_CHROMEOS && __ARMEL__ This comment confuses me, the first case is OS_CHROMEOS && __ARMEL__. Isn't this case non-windows and (non-chromeos or non-armel)? Since there's a comment on the flipped var already, maybe this one could just go away? 650185 3 147813 fischman 2012-06-15 07:56:42 -0700 Created attachment 147813 Patch 650186 4 fischman 2012-06-15 07:56:51 -0700 (In reply to comment #2) > (From update of attachment 147773 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=147773&action=review > > LGTM otherwise. > > > Source/WebCore/platform/graphics/chromium/cc/CCVideoLayerImpl.cpp:214 > > +#else // OS_CHROMEOS && __ARMEL__ > > This comment confuses me, the first case is OS_CHROMEOS && __ARMEL__. Isn't this case non-windows and (non-chromeos or non-armel)? Since there's a comment on the flipped var already, maybe this one could just go away? Sure; I hate these comments but put them in for style-guide compliance. Gone. 650491 5 147813 jamesr 2012-06-15 14:08:14 -0700 Comment on attachment 147813 Patch Fun stuff! 650544 6 147813 webkit.review.bot 2012-06-15 15:00:44 -0700 Comment on attachment 147813 Patch Clearing flags on attachment: 147813 Committed r120497: <http://trac.webkit.org/changeset/120497> 650545 7 webkit.review.bot 2012-06-15 15:00:49 -0700 All reviewed patches have been landed. Closing bug. 656859 8 ananta 2012-06-25 14:24:57 -0700 The ifdef for the win32 platform in the CCVideoLayerImpl::appendQuads function is wrong. 656869 9 jamesr 2012-06-25 14:34:32 -0700 Which way do you want the bool set on windows? Before this patch the bool was unconditionally false, this patch (attempted) to make it be true on windows - I'm assuming because somebody (Ami?) thought that DXVA wants it to be true. Are videos upside down? 656874 10 ananta 2012-06-25 14:37:48 -0700 the bool for windows should be true. I will upload a change fixing the ifdef in a bit. 656882 11 jamesr 2012-06-25 14:42:14 -0700 OK great. Please open a new bug and attach the patch to that ("Tools/Scripts/webkit-patch upload" will automate this process for you). 668527 12 shaochangbin 2012-07-12 19:40:00 -0700 I have made a test, the bool should be false for Windows(Sandy Bridge). Is this patch updated by yet? (In reply to comment #10) > the bool for windows should be true. I will upload a change fixing the ifdef in a bit. 671843 13 ananta 2012-07-17 18:15:47 -0700 The elif defined(OS_WINDOWS) was wrong in that CL. For webkit we need to use OS(WINDOWS) 147773 2012-06-15 01:54:02 -0700 2012-06-15 07:56:39 -0700 Patch bug-89189-20120615015402.patch text/plain 2083 fischman U3VidmVyc2lvbiBSZXZpc2lvbjogMTIwNDI0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNDA4ZGQzYjc5OTI1N2Iw YjllZjM5YjQ2MGIyNWMwZGQzMmYwMWI0My4uZDdjZmE0ZmQyOWU4ODA3MjAxMmRhOTY1ZmFjZGZj NGVhNjEyYTU3NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEyLTA2LTE1ICBBbWkg RmlzY2htYW4gIDxmaXNjaG1hbkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgW2Nocm9taXVtXSBD b21wb3NpdG9yIHNob3VsZCBiZSBhd2FyZSBvZiB8ZmxpcHBlZHwgc3RhdHVzIG9mIHZpZGVvIHRl eHR1cmVzIHBlci1wbGF0Zm9ybQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9ODkxODkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBObyBuZXcgdGVzdHMgKHNhZGx5IEhXIHZpZGVvIGRlY29kZSBpcyBzdGlsbCBv bmx5IGJlaW5nIHRlc3RlZCBtYW51YWxseSBmb3Igb3JpZW50YXRpb24pLgorCisgICAgICAgICog cGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vY2MvQ0NWaWRlb0xheWVySW1wbC5jcHA6CisgICAg ICAgIChXZWJDb3JlOjpDQ1ZpZGVvTGF5ZXJJbXBsOjphcHBlbmRRdWFkcyk6CisKIDIwMTItMDYt MTUgIEhpcm9ub3JpIEJvbm8gIDxoYm9ub0BjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgQWxsb3cg cGxhdGZvcm1zIHRvIGNob29zZSB3aGV0aGVyIHRvIHJlbW92ZSBtYXJrZXJzIG9uIGVkaXRpbmcK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL2Nj L0NDVmlkZW9MYXllckltcGwuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mv Y2hyb21pdW0vY2MvQ0NWaWRlb0xheWVySW1wbC5jcHAKaW5kZXggOTFhYmNkZGFhNmVmODhkMzUy NjFlNmZiYTExN2Y4MGRmZDljZjMxYi4uYzAzNWUyYTUyNGVlMTM1NTBkYzFlODM2MTRjNGQ0OWI5 MmZjNjg3NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hy b21pdW0vY2MvQ0NWaWRlb0xheWVySW1wbC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vZ3JhcGhpY3MvY2hyb21pdW0vY2MvQ0NWaWRlb0xheWVySW1wbC5jcHAKQEAgLTIwNyw3ICsy MDcsMTMgQEAgdm9pZCBDQ1ZpZGVvTGF5ZXJJbXBsOjphcHBlbmRRdWFkcyhDQ1F1YWRDdWxsZXIm IHF1YWRMaXN0LCBjb25zdCBDQ1NoYXJlZFF1YWRTdGEKICAgICAgICAgLy8gTmF0aXZlVGV4dHVy ZSBoYXJkd2FyZSBkZWNvZGVyLgogICAgICAgICBib29sIHByZW11bHRpcGxpZWRBbHBoYSA9IHRy dWU7CiAgICAgICAgIEZsb2F0UmVjdCB1dlJlY3QoMCwgMCwgMSwgMSk7Ci0gICAgICAgIGJvb2wg ZmxpcHBlZCA9IGZhbHNlOworI2lmIGRlZmluZWQoT1NfQ0hST01FT1MpICYmIGRlZmluZWQoX19B Uk1FTF9fKQorICAgICAgICBib29sIGZsaXBwZWQgPSB0cnVlOyAvLyBVbmRlciB0aGUgY292ZXJz LCBpbXBsZW1lbnRlZCBieSBPcGVuTUFYIElMLgorI2VsaWYgZGVmaW5lZChPU19XSU5ET1dTKQor ICAgICAgICBib29sIGZsaXBwZWQgPSB0cnVlOyAvLyBVbmRlciB0aGUgY292ZXJzLCBpbXBsZW1l bnRlZCBieSBEWFZBLgorI2Vsc2UgLy8gT1NfQ0hST01FT1MgJiYgX19BUk1FTF9fCisgICAgICAg IGJvb2wgZmxpcHBlZCA9IGZhbHNlOyAvLyBMaWJWQSAoY3Jvcy9pbnRlbCksIE1hY09TLgorI2Vu ZGlmIC8vIE9TX0NIUk9NRU9TICYmIF9fQVJNRUxfXwogICAgICAgICBPd25QdHI8Q0NUZXh0dXJl RHJhd1F1YWQ+IHRleHR1cmVRdWFkID0gQ0NUZXh0dXJlRHJhd1F1YWQ6OmNyZWF0ZShzaGFyZWRR dWFkU3RhdGUsIHF1YWRSZWN0LCBtX2ZyYW1lLT50ZXh0dXJlSWQoKSwgcHJlbXVsdGlwbGllZEFs cGhhLCB1dlJlY3QsIGZsaXBwZWQpOwogICAgICAgICBxdWFkTGlzdC5hcHBlbmQodGV4dHVyZVF1 YWQucmVsZWFzZSgpKTsKICAgICAgICAgYnJlYWs7Cg== 147813 2012-06-15 07:56:42 -0700 2012-06-15 15:00:44 -0700 Patch bug-89189-20120615075642.patch text/plain 2027 fischman U3VidmVyc2lvbiBSZXZpc2lvbjogMTIwNDI0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNDA4ZGQzYjc5OTI1N2Iw YjllZjM5YjQ2MGIyNWMwZGQzMmYwMWI0My4uZDdjZmE0ZmQyOWU4ODA3MjAxMmRhOTY1ZmFjZGZj NGVhNjEyYTU3NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEyLTA2LTE1ICBBbWkg RmlzY2htYW4gIDxmaXNjaG1hbkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgW2Nocm9taXVtXSBD b21wb3NpdG9yIHNob3VsZCBiZSBhd2FyZSBvZiB8ZmxpcHBlZHwgc3RhdHVzIG9mIHZpZGVvIHRl eHR1cmVzIHBlci1wbGF0Zm9ybQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9ODkxODkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBObyBuZXcgdGVzdHMgKHNhZGx5IEhXIHZpZGVvIGRlY29kZSBpcyBzdGlsbCBv bmx5IGJlaW5nIHRlc3RlZCBtYW51YWxseSBmb3Igb3JpZW50YXRpb24pLgorCisgICAgICAgICog cGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vY2MvQ0NWaWRlb0xheWVySW1wbC5jcHA6CisgICAg ICAgIChXZWJDb3JlOjpDQ1ZpZGVvTGF5ZXJJbXBsOjphcHBlbmRRdWFkcyk6CisKIDIwMTItMDYt MTUgIEhpcm9ub3JpIEJvbm8gIDxoYm9ub0BjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgQWxsb3cg cGxhdGZvcm1zIHRvIGNob29zZSB3aGV0aGVyIHRvIHJlbW92ZSBtYXJrZXJzIG9uIGVkaXRpbmcK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL2Nj L0NDVmlkZW9MYXllckltcGwuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mv Y2hyb21pdW0vY2MvQ0NWaWRlb0xheWVySW1wbC5jcHAKaW5kZXggOTFhYmNkZGFhNmVmODhkMzUy NjFlNmZiYTExN2Y4MGRmZDljZjMxYi4uYmI1ZDNmMmFhOTkzNjZlYjkxNTkxMTEzMDMzMDViYmRk MmI3MGY2MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hy b21pdW0vY2MvQ0NWaWRlb0xheWVySW1wbC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vZ3JhcGhpY3MvY2hyb21pdW0vY2MvQ0NWaWRlb0xheWVySW1wbC5jcHAKQEAgLTIwNyw3ICsy MDcsMTMgQEAgdm9pZCBDQ1ZpZGVvTGF5ZXJJbXBsOjphcHBlbmRRdWFkcyhDQ1F1YWRDdWxsZXIm IHF1YWRMaXN0LCBjb25zdCBDQ1NoYXJlZFF1YWRTdGEKICAgICAgICAgLy8gTmF0aXZlVGV4dHVy ZSBoYXJkd2FyZSBkZWNvZGVyLgogICAgICAgICBib29sIHByZW11bHRpcGxpZWRBbHBoYSA9IHRy dWU7CiAgICAgICAgIEZsb2F0UmVjdCB1dlJlY3QoMCwgMCwgMSwgMSk7Ci0gICAgICAgIGJvb2wg ZmxpcHBlZCA9IGZhbHNlOworI2lmIGRlZmluZWQoT1NfQ0hST01FT1MpICYmIGRlZmluZWQoX19B Uk1FTF9fKQorICAgICAgICBib29sIGZsaXBwZWQgPSB0cnVlOyAvLyBVbmRlciB0aGUgY292ZXJz LCBpbXBsZW1lbnRlZCBieSBPcGVuTUFYIElMLgorI2VsaWYgZGVmaW5lZChPU19XSU5ET1dTKQor ICAgICAgICBib29sIGZsaXBwZWQgPSB0cnVlOyAvLyBVbmRlciB0aGUgY292ZXJzLCBpbXBsZW1l bnRlZCBieSBEWFZBLgorI2Vsc2UKKyAgICAgICAgYm9vbCBmbGlwcGVkID0gZmFsc2U7IC8vIExp YlZBIChjcm9zL2ludGVsKSwgTWFjT1MuCisjZW5kaWYKICAgICAgICAgT3duUHRyPENDVGV4dHVy ZURyYXdRdWFkPiB0ZXh0dXJlUXVhZCA9IENDVGV4dHVyZURyYXdRdWFkOjpjcmVhdGUoc2hhcmVk UXVhZFN0YXRlLCBxdWFkUmVjdCwgbV9mcmFtZS0+dGV4dHVyZUlkKCksIHByZW11bHRpcGxpZWRB bHBoYSwgdXZSZWN0LCBmbGlwcGVkKTsKICAgICAgICAgcXVhZExpc3QuYXBwZW5kKHRleHR1cmVR dWFkLnJlbGVhc2UoKSk7CiAgICAgICAgIGJyZWFrOwo=