89185 2012-06-15 01:22:51 -0700 AssociatedURLLoader should allow trusted clients to read all headers, not just exposed ones 2012-06-15 13:49:17 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 fischman webkit-unassigned abarth bbudge dglazkov fishd jamesr tkent+wkapi webkit.review.bot oldest_to_newest 650008 0 fischman 2012-06-15 01:22:51 -0700 Today AssociatedURLLoader::ClientAdapter::didReceiveResponse() copies the response for the benefit of its client, stripping out blocked headers. This makes it impossible for any code, trusted or not, to inspect such headers. An example problem this raises: chromium's media loading code specifies Range: in its request header, so it requests [origin, accept-encoding, referer, range] in the CORS pre-flight request (Access-Control-Request-Headers). When it receives a 206 response, it wants to use the Content-Range, Content-Length, and Accept-Ranges headers, but it can't do so because these are not "simple headers" (in CORS-speak) and are not explicitly included in Access-Control-Expose-Headers because the server doesn't necessarily know the client requires them, so AssociatedURLLoader::ClientAdapter::didReceiveResponse() strips them out of the response copy handed to BufferedResourceLoader. Instead, there should be an API for trusted code to side-step this header-stripping. 650141 1 147805 bbudge 2012-06-15 07:10:22 -0700 Created attachment 147805 Proposed patch 650142 2 webkit.review.bot 2012-06-15 07:11:58 -0700 Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI. 650143 3 147806 bbudge 2012-06-15 07:12:06 -0700 Created attachment 147806 Proposed patch 650145 4 bbudge 2012-06-15 07:14:06 -0700 Ignore the first patch - it doesn't build. 650153 5 bbudge 2012-06-15 07:21:24 -0700 Adam, this new WebURLLoaderOption field completely turns off response header filtering. Therefore this would expose "set-cookie" headers to the client. I'm assuming this is OK since it's trusted. 650332 6 147806 abarth 2012-06-15 10:52:27 -0700 Comment on attachment 147806 Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=147806&action=review Interesting approach. I was expecting you to add another function for grabbing the headers, but I see why you've taken this approach. > Source/WebKit/chromium/public/WebURLLoaderOptions.h:57 > + bool allowResponseHeaders; // If policy is to use access control, whether to allow non-simple response headers. I wonder if we should name this something like exposeAllResponseHeaders to mimic the name of Access-Control-Expose-Headers ? 650342 7 147859 bbudge 2012-06-15 11:03:16 -0700 Created attachment 147859 Proposed Patch 'exposeAllResponseHeaders' is a much better name. Thanks. 650466 8 147859 webkit.review.bot 2012-06-15 13:49:11 -0700 Comment on attachment 147859 Proposed Patch Clearing flags on attachment: 147859 Committed r120490: <http://trac.webkit.org/changeset/120490> 650467 9 webkit.review.bot 2012-06-15 13:49:17 -0700 All reviewed patches have been landed. Closing bug. 147805 2012-06-15 07:10:22 -0700 2012-06-15 07:12:06 -0700 Proposed patch aul.txt text/plain 5087 bbudge SW5kZXg6IFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNv dXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCShyZXZpc2lvbiAxMjA0NDEpCisrKyBTb3Vy Y2UvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIy IEBACisyMDEyLTA2LTE1ICBCaWxsIEJ1ZGdlICA8YmJ1ZGdlQGNocm9taXVtLm9yZz4KKworICAg ICAgICBBc3NvY2lhdGVkVVJMTG9hZGVyIHNob3VsZCBhbGxvdyB0cnVzdGVkIGNsaWVudHMgdG8g cmVhZCBhbGwgaGVhZGVycywgbm90IGp1c3QgZXhwb3NlZCBvbmVzLgorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODkxODUKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGlzIGNoYW5nZSBhZGRzIGFuIG9wdGlv biB0byB0dXJuIG9mZiB3aGl0ZWxpc3QgZmlsdGVyaW5nIG9mIHJlc3BvbnNlIGhlYWRlcnMgZm9y IENPUlMgbG9hZHMsCisgICAgICAgIGFuZCBtb2RpZmllcyBBc3NvY2lhdGVkVVJMTG9hZGVyIGNo ZWNrIGZvciB0aGF0IGJlZm9yZSBmaWx0ZXJpbmcuCisKKyAgICAgICAgKiBwdWJsaWMvV2ViVVJM TG9hZGVyT3B0aW9ucy5oOgorICAgICAgICAoV2ViS2l0OjpXZWJVUkxMb2FkZXJPcHRpb25zOjpX ZWJVUkxMb2FkZXJPcHRpb25zKToKKyAgICAgICAgKFdlYlVSTExvYWRlck9wdGlvbnMpOgorICAg ICAgICAqIHNyYy9Bc3NvY2lhdGVkVVJMTG9hZGVyLmNwcDoKKyAgICAgICAgKFdlYktpdDo6QXNz b2NpYXRlZFVSTExvYWRlcjo6Q2xpZW50QWRhcHRlcjo6ZGlkUmVjZWl2ZVJlc3BvbnNlKToKKyAg ICAgICAgKiB0ZXN0cy9Bc3NvY2lhdGVkVVJMTG9hZGVyVGVzdC5jcHA6CisgICAgICAgIChXZWJL aXQpOgorICAgICAgICAoV2ViS2l0OjpURVNUX0YpOgorCiAyMDEyLTA2LTE1ICBIaXJvbm9yaSBC b25vICA8aGJvbm9AY2hyb21pdW0ub3JnPgogCiAgICAgICAgIEFsbG93IHBsYXRmb3JtcyB0byBj aG9vc2Ugd2hldGhlciB0byByZW1vdmUgbWFya2VycyBvbiBlZGl0aW5nCkluZGV4OiBTb3VyY2Uv V2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJVUkxMb2FkZXJPcHRpb25zLmgKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gU291cmNlL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViVVJMTG9hZGVyT3B0aW9ucy5oCShy ZXZpc2lvbiAxMjA0MzgpCisrKyBTb3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJVUkxM b2FkZXJPcHRpb25zLmgJKHdvcmtpbmcgY29weSkKQEAgLTQ2LDYgKzQ2LDcgQEAgc3RydWN0IFdl YlVSTExvYWRlck9wdGlvbnMgewogICAgICAgICAsIHNuaWZmQ29udGVudChmYWxzZSkKICAgICAg ICAgLCBhbGxvd0NyZWRlbnRpYWxzKGZhbHNlKQogICAgICAgICAsIGZvcmNlUHJlZmxpZ2h0KGZh bHNlKQorICAgICAgICAsIGFsbG93UmVzcG9uc2VIZWFkZXJzKGZhbHNlKQogICAgICAgICAsIGNy b3NzT3JpZ2luUmVxdWVzdFBvbGljeShDcm9zc09yaWdpblJlcXVlc3RQb2xpY3lEZW55KQogICAg ICAgICB7IH0KIApAQCAtNTMsNiArNTQsNyBAQCBzdHJ1Y3QgV2ViVVJMTG9hZGVyT3B0aW9ucyB7 CiAgICAgYm9vbCBzbmlmZkNvbnRlbnQ7IC8vIFdoZXRoZXIgdG8gc25pZmYgY29udGVudC4KICAg ICBib29sIGFsbG93Q3JlZGVudGlhbHM7IC8vIFdoZXRoZXIgdG8gc2VuZCBIVFRQIGNyZWRlbnRp YWxzIGFuZCBjb29raWVzIHdpdGggdGhlIHJlcXVlc3QuCiAgICAgYm9vbCBmb3JjZVByZWZsaWdo dDsgLy8gSWYgcG9saWN5IGlzIHRvIHVzZSBhY2Nlc3MgY29udHJvbCwgd2hldGhlciB0byBmb3Jj ZSBhIHByZWZsaWdodCBmb3IgR0VULCBIRUFELCBhbmQgUE9TVCByZXF1ZXN0cy4KKyAgICBib29s IGFsbG93UmVzcG9uc2VIZWFkZXJzOyAvLyBJZiBwb2xpY3kgaXMgdG8gdXNlIGFjY2VzcyBjb250 cm9sLCB3aGV0aGVyIHRvIGFsbG93IG5vbi1zaW1wbGUgcmVzcG9uc2UgaGVhZGVycy4KICAgICBD cm9zc09yaWdpblJlcXVlc3RQb2xpY3kgY3Jvc3NPcmlnaW5SZXF1ZXN0UG9saWN5OwogfTsKIApJ bmRleDogU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvQXNzb2NpYXRlZFVSTExvYWRlci5jcHAK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvQXNzb2NpYXRlZFVSTExv YWRlci5jcHAJKHJldmlzaW9uIDEyMDQzOCkKKysrIFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3Jj L0Fzc29jaWF0ZWRVUkxMb2FkZXIuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0yMDgsOCArMjA4LDEw IEBAIHZvaWQgQXNzb2NpYXRlZFVSTExvYWRlcjo6Q2xpZW50QWRhcHRlcjoKIHsKICAgICAvLyBU cnkgdG8gdXNlIHRoZSBvcmlnaW5hbCBSZXNvdXJjZVJlc3BvbnNlIGlmIHBvc3NpYmxlLgogICAg IFdlYlVSTFJlc3BvbnNlIHZhbGlkYXRlZFJlc3BvbnNlID0gV3JhcHBlZFJlc291cmNlUmVzcG9u c2UocmVzcG9uc2UpOwotICAgIEhUVFBSZXNwb25zZUhlYWRlclZhbGlkYXRvciB2YWxpZGF0b3Io bV9vcHRpb25zLmNyb3NzT3JpZ2luUmVxdWVzdFBvbGljeSA9PSBXZWJVUkxMb2FkZXJPcHRpb25z OjpDcm9zc09yaWdpblJlcXVlc3RQb2xpY3lVc2VBY2Nlc3NDb250cm9sKTsKLSAgICB2YWxpZGF0 ZWRSZXNwb25zZS52aXNpdEhUVFBIZWFkZXJGaWVsZHMoJnZhbGlkYXRvcik7CisgICAgaWYgKCFt X29wdGlvbnMuYWxsb3dSZXNwb25zZUhlYWRlcnMpIHsKKyAgICAgICAgSFRUUFJlc3BvbnNlSGVh ZGVyVmFsaWRhdG9yIHZhbGlkYXRvcihtX29wdGlvbnMuY3Jvc3NPcmlnaW5SZXF1ZXN0UG9saWN5 ID09IFdlYlVSTExvYWRlck9wdGlvbnM6OkNyb3NzT3JpZ2luUmVxdWVzdFBvbGljeVVzZUFjY2Vz c0NvbnRyb2wpOworICAgICAgICB2YWxpZGF0ZWRSZXNwb25zZS52aXNpdEhUVFBIZWFkZXJGaWVs ZHMoJnZhbGlkYXRvcik7CisgICAgfQogICAgIC8vIElmIHRoZXJlIGFyZSBibG9ja2VkIGhlYWRl cnMsIGNvcHkgdGhlIHJlc3BvbnNlIHNvIHdlIGNhbiByZW1vdmUgdGhlbS4KICAgICBjb25zdCBI VFRQSGVhZGVyU2V0JiBibG9ja2VkSGVhZGVycyA9IHZhbGlkYXRvci5ibG9ja2VkSGVhZGVycygp OwogICAgIGlmICghYmxvY2tlZEhlYWRlcnMuaXNFbXB0eSgpKSB7CkluZGV4OiBTb3VyY2UvV2Vi S2l0L2Nocm9taXVtL3Rlc3RzL0Fzc29jaWF0ZWRVUkxMb2FkZXJUZXN0LmNwcAo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBTb3VyY2UvV2ViS2l0L2Nocm9taXVtL3Rlc3RzL0Fzc29jaWF0ZWRVUkxMb2FkZXJUZXN0 LmNwcAkocmV2aXNpb24gMTIwNDM4KQorKysgU291cmNlL1dlYktpdC9jaHJvbWl1bS90ZXN0cy9B c3NvY2lhdGVkVVJMTG9hZGVyVGVzdC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTU4NSw0ICs1ODUs MzQgQEAgVEVTVF9GKEFzc29jaWF0ZWRVUkxMb2FkZXJUZXN0LCBDcm9zc09yaQogICAgIEVYUEVD VF9GQUxTRShDaGVja0FjY2Vzc0NvbnRyb2xIZWFkZXJzKCJTZXQtQ29va2llIiwgdHJ1ZSkpOwog fQogCisvLyBUZXN0IHRoYXQgdGhlIGxvYWRlciBjYW4gYWxsb3cgbm9uLXdoaXRlbGlzdGVkIHJl c3BvbnNlIGhlYWRlcnMgZm9yIHRydXN0ZWQgQ09SUyBsb2Fkcy4KK1RFU1RfRihBc3NvY2lhdGVk VVJMTG9hZGVyVGVzdCwgQ3Jvc3NPcmlnaW5IZWFkZXJBbGxvd1Jlc3BvbnNlSGVhZGVycykKK3sK KyAgICBXZWJVUkxSZXF1ZXN0IHJlcXVlc3Q7CisgICAgcmVxdWVzdC5pbml0aWFsaXplKCk7Cisg ICAgR1VSTCB1cmwgPSBHVVJMKCJodHRwOi8vd3d3Lm90aGVyLmNvbS9Dcm9zc09yaWdpbkhlYWRl ckFsbG93UmVzcG9uc2VIZWFkZXJzLmh0bWwiKTsKKyAgICByZXF1ZXN0LnNldFVSTCh1cmwpOwor CisgICAgV2ViU3RyaW5nIGhlYWRlck5hbWVTdHJpbmcoV2ViU3RyaW5nOjpmcm9tVVRGOCgibm9u LXdoaXRlbGlzdGVkIikpOworICAgIG1fZXhwZWN0ZWRSZXNwb25zZSA9IFdlYlVSTFJlc3BvbnNl KCk7CisgICAgbV9leHBlY3RlZFJlc3BvbnNlLmluaXRpYWxpemUoKTsKKyAgICBtX2V4cGVjdGVk UmVzcG9uc2Uuc2V0TUlNRVR5cGUoInRleHQvaHRtbCIpOworICAgIG1fZXhwZWN0ZWRSZXNwb25z ZS5hZGRIVFRQSGVhZGVyRmllbGQoIkFjY2Vzcy1Db250cm9sLUFsbG93LU9yaWdpbiIsICIqIik7 CisgICAgbV9leHBlY3RlZFJlc3BvbnNlLmFkZEhUVFBIZWFkZXJGaWVsZChoZWFkZXJOYW1lU3Ry aW5nLCAiZm9vIik7CisgICAgd2Via2l0X3N1cHBvcnQ6OlJlZ2lzdGVyTW9ja2VkVVJMKHVybCwg bV9leHBlY3RlZFJlc3BvbnNlLCBtX2ZyYW1lRmlsZVBhdGgpOworCisgICAgV2ViVVJMTG9hZGVy T3B0aW9ucyBvcHRpb25zOworICAgIG9wdGlvbnMuYWxsb3dSZXNwb25zZUhlYWRlcnMgPSB0cnVl OyAvLyBUaGlzIHR1cm5zIG9mZiByZXNwb25zZSB3aGl0ZWxpc3RpbmcuCisgICAgb3B0aW9ucy5j cm9zc09yaWdpblJlcXVlc3RQb2xpY3kgPSBXZWJVUkxMb2FkZXJPcHRpb25zOjpDcm9zc09yaWdp blJlcXVlc3RQb2xpY3lVc2VBY2Nlc3NDb250cm9sOworICAgIG1fZXhwZWN0ZWRMb2FkZXIgPSBj cmVhdGVBc3NvY2lhdGVkVVJMTG9hZGVyKG9wdGlvbnMpOworICAgIEVYUEVDVF9UUlVFKG1fZXhw ZWN0ZWRMb2FkZXIpOworICAgIG1fZXhwZWN0ZWRMb2FkZXItPmxvYWRBc3luY2hyb25vdXNseShy ZXF1ZXN0LCB0aGlzKTsKKyAgICBzZXJ2ZVJlcXVlc3RzKCk7CisgICAgRVhQRUNUX1RSVUUobV9k aWRSZWNlaXZlUmVzcG9uc2UpOworICAgIEVYUEVDVF9UUlVFKG1fZGlkUmVjZWl2ZURhdGEpOwor ICAgIEVYUEVDVF9UUlVFKG1fZGlkRmluaXNoTG9hZGluZyk7CisKKyAgICBFWFBFQ1RfRkFMU0Uo bV9hY3R1YWxSZXNwb25zZS5odHRwSGVhZGVyRmllbGQoaGVhZGVyTmFtZVN0cmluZykuaXNFbXB0 eSgpKTsKK30KKwogfQo= 147806 2012-06-15 07:12:06 -0700 2012-06-15 11:03:16 -0700 Proposed patch aul.txt text/plain 4927 bbudge SW5kZXg6IFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNv dXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCShyZXZpc2lvbiAxMjA0NDEpCisrKyBTb3Vy Y2UvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIy IEBACisyMDEyLTA2LTE1ICBCaWxsIEJ1ZGdlICA8YmJ1ZGdlQGNocm9taXVtLm9yZz4KKworICAg ICAgICBBc3NvY2lhdGVkVVJMTG9hZGVyIHNob3VsZCBhbGxvdyB0cnVzdGVkIGNsaWVudHMgdG8g cmVhZCBhbGwgaGVhZGVycywgbm90IGp1c3QgZXhwb3NlZCBvbmVzLgorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODkxODUKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGlzIGNoYW5nZSBhZGRzIGFuIG9wdGlv biB0byB0dXJuIG9mZiB3aGl0ZWxpc3QgZmlsdGVyaW5nIG9mIHJlc3BvbnNlIGhlYWRlcnMgZm9y IENPUlMgbG9hZHMsCisgICAgICAgIGFuZCBtb2RpZmllcyBBc3NvY2lhdGVkVVJMTG9hZGVyIGNo ZWNrIGZvciB0aGF0IGJlZm9yZSBmaWx0ZXJpbmcuCisKKyAgICAgICAgKiBwdWJsaWMvV2ViVVJM TG9hZGVyT3B0aW9ucy5oOgorICAgICAgICAoV2ViS2l0OjpXZWJVUkxMb2FkZXJPcHRpb25zOjpX ZWJVUkxMb2FkZXJPcHRpb25zKToKKyAgICAgICAgKFdlYlVSTExvYWRlck9wdGlvbnMpOgorICAg ICAgICAqIHNyYy9Bc3NvY2lhdGVkVVJMTG9hZGVyLmNwcDoKKyAgICAgICAgKFdlYktpdDo6QXNz b2NpYXRlZFVSTExvYWRlcjo6Q2xpZW50QWRhcHRlcjo6ZGlkUmVjZWl2ZVJlc3BvbnNlKToKKyAg ICAgICAgKiB0ZXN0cy9Bc3NvY2lhdGVkVVJMTG9hZGVyVGVzdC5jcHA6CisgICAgICAgIChXZWJL aXQpOgorICAgICAgICAoV2ViS2l0OjpURVNUX0YpOgorCiAyMDEyLTA2LTE1ICBIaXJvbm9yaSBC b25vICA8aGJvbm9AY2hyb21pdW0ub3JnPgogCiAgICAgICAgIEFsbG93IHBsYXRmb3JtcyB0byBj aG9vc2Ugd2hldGhlciB0byByZW1vdmUgbWFya2VycyBvbiBlZGl0aW5nCkluZGV4OiBTb3VyY2Uv V2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJVUkxMb2FkZXJPcHRpb25zLmgKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gU291cmNlL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViVVJMTG9hZGVyT3B0aW9ucy5oCShy ZXZpc2lvbiAxMjA0MzgpCisrKyBTb3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJVUkxM b2FkZXJPcHRpb25zLmgJKHdvcmtpbmcgY29weSkKQEAgLTQ2LDYgKzQ2LDcgQEAgc3RydWN0IFdl YlVSTExvYWRlck9wdGlvbnMgewogICAgICAgICAsIHNuaWZmQ29udGVudChmYWxzZSkKICAgICAg ICAgLCBhbGxvd0NyZWRlbnRpYWxzKGZhbHNlKQogICAgICAgICAsIGZvcmNlUHJlZmxpZ2h0KGZh bHNlKQorICAgICAgICAsIGFsbG93UmVzcG9uc2VIZWFkZXJzKGZhbHNlKQogICAgICAgICAsIGNy b3NzT3JpZ2luUmVxdWVzdFBvbGljeShDcm9zc09yaWdpblJlcXVlc3RQb2xpY3lEZW55KQogICAg ICAgICB7IH0KIApAQCAtNTMsNiArNTQsNyBAQCBzdHJ1Y3QgV2ViVVJMTG9hZGVyT3B0aW9ucyB7 CiAgICAgYm9vbCBzbmlmZkNvbnRlbnQ7IC8vIFdoZXRoZXIgdG8gc25pZmYgY29udGVudC4KICAg ICBib29sIGFsbG93Q3JlZGVudGlhbHM7IC8vIFdoZXRoZXIgdG8gc2VuZCBIVFRQIGNyZWRlbnRp YWxzIGFuZCBjb29raWVzIHdpdGggdGhlIHJlcXVlc3QuCiAgICAgYm9vbCBmb3JjZVByZWZsaWdo dDsgLy8gSWYgcG9saWN5IGlzIHRvIHVzZSBhY2Nlc3MgY29udHJvbCwgd2hldGhlciB0byBmb3Jj ZSBhIHByZWZsaWdodCBmb3IgR0VULCBIRUFELCBhbmQgUE9TVCByZXF1ZXN0cy4KKyAgICBib29s IGFsbG93UmVzcG9uc2VIZWFkZXJzOyAvLyBJZiBwb2xpY3kgaXMgdG8gdXNlIGFjY2VzcyBjb250 cm9sLCB3aGV0aGVyIHRvIGFsbG93IG5vbi1zaW1wbGUgcmVzcG9uc2UgaGVhZGVycy4KICAgICBD cm9zc09yaWdpblJlcXVlc3RQb2xpY3kgY3Jvc3NPcmlnaW5SZXF1ZXN0UG9saWN5OwogfTsKIApJ bmRleDogU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvQXNzb2NpYXRlZFVSTExvYWRlci5jcHAK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvQXNzb2NpYXRlZFVSTExv YWRlci5jcHAJKHJldmlzaW9uIDEyMDQzOCkKKysrIFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3Jj L0Fzc29jaWF0ZWRVUkxMb2FkZXIuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0yMDksNyArMjA5LDkg QEAgdm9pZCBBc3NvY2lhdGVkVVJMTG9hZGVyOjpDbGllbnRBZGFwdGVyOgogICAgIC8vIFRyeSB0 byB1c2UgdGhlIG9yaWdpbmFsIFJlc291cmNlUmVzcG9uc2UgaWYgcG9zc2libGUuCiAgICAgV2Vi VVJMUmVzcG9uc2UgdmFsaWRhdGVkUmVzcG9uc2UgPSBXcmFwcGVkUmVzb3VyY2VSZXNwb25zZShy ZXNwb25zZSk7CiAgICAgSFRUUFJlc3BvbnNlSGVhZGVyVmFsaWRhdG9yIHZhbGlkYXRvcihtX29w dGlvbnMuY3Jvc3NPcmlnaW5SZXF1ZXN0UG9saWN5ID09IFdlYlVSTExvYWRlck9wdGlvbnM6OkNy b3NzT3JpZ2luUmVxdWVzdFBvbGljeVVzZUFjY2Vzc0NvbnRyb2wpOwotICAgIHZhbGlkYXRlZFJl c3BvbnNlLnZpc2l0SFRUUEhlYWRlckZpZWxkcygmdmFsaWRhdG9yKTsKKyAgICBpZiAoIW1fb3B0 aW9ucy5hbGxvd1Jlc3BvbnNlSGVhZGVycykKKyAgICAgICAgdmFsaWRhdGVkUmVzcG9uc2Uudmlz aXRIVFRQSGVhZGVyRmllbGRzKCZ2YWxpZGF0b3IpOworCiAgICAgLy8gSWYgdGhlcmUgYXJlIGJs b2NrZWQgaGVhZGVycywgY29weSB0aGUgcmVzcG9uc2Ugc28gd2UgY2FuIHJlbW92ZSB0aGVtLgog ICAgIGNvbnN0IEhUVFBIZWFkZXJTZXQmIGJsb2NrZWRIZWFkZXJzID0gdmFsaWRhdG9yLmJsb2Nr ZWRIZWFkZXJzKCk7CiAgICAgaWYgKCFibG9ja2VkSGVhZGVycy5pc0VtcHR5KCkpIHsKSW5kZXg6 IFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vdGVzdHMvQXNzb2NpYXRlZFVSTExvYWRlclRlc3QuY3Bw Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vdGVzdHMvQXNzb2NpYXRlZFVS TExvYWRlclRlc3QuY3BwCShyZXZpc2lvbiAxMjA0MzgpCisrKyBTb3VyY2UvV2ViS2l0L2Nocm9t aXVtL3Rlc3RzL0Fzc29jaWF0ZWRVUkxMb2FkZXJUZXN0LmNwcAkod29ya2luZyBjb3B5KQpAQCAt NTg1LDQgKzU4NSwzNCBAQCBURVNUX0YoQXNzb2NpYXRlZFVSTExvYWRlclRlc3QsIENyb3NzT3Jp CiAgICAgRVhQRUNUX0ZBTFNFKENoZWNrQWNjZXNzQ29udHJvbEhlYWRlcnMoIlNldC1Db29raWUi LCB0cnVlKSk7CiB9CiAKKy8vIFRlc3QgdGhhdCB0aGUgbG9hZGVyIGNhbiBhbGxvdyBub24td2hp dGVsaXN0ZWQgcmVzcG9uc2UgaGVhZGVycyBmb3IgdHJ1c3RlZCBDT1JTIGxvYWRzLgorVEVTVF9G KEFzc29jaWF0ZWRVUkxMb2FkZXJUZXN0LCBDcm9zc09yaWdpbkhlYWRlckFsbG93UmVzcG9uc2VI ZWFkZXJzKQoreworICAgIFdlYlVSTFJlcXVlc3QgcmVxdWVzdDsKKyAgICByZXF1ZXN0LmluaXRp YWxpemUoKTsKKyAgICBHVVJMIHVybCA9IEdVUkwoImh0dHA6Ly93d3cub3RoZXIuY29tL0Nyb3Nz T3JpZ2luSGVhZGVyQWxsb3dSZXNwb25zZUhlYWRlcnMuaHRtbCIpOworICAgIHJlcXVlc3Quc2V0 VVJMKHVybCk7CisKKyAgICBXZWJTdHJpbmcgaGVhZGVyTmFtZVN0cmluZyhXZWJTdHJpbmc6OmZy b21VVEY4KCJub24td2hpdGVsaXN0ZWQiKSk7CisgICAgbV9leHBlY3RlZFJlc3BvbnNlID0gV2Vi VVJMUmVzcG9uc2UoKTsKKyAgICBtX2V4cGVjdGVkUmVzcG9uc2UuaW5pdGlhbGl6ZSgpOworICAg IG1fZXhwZWN0ZWRSZXNwb25zZS5zZXRNSU1FVHlwZSgidGV4dC9odG1sIik7CisgICAgbV9leHBl Y3RlZFJlc3BvbnNlLmFkZEhUVFBIZWFkZXJGaWVsZCgiQWNjZXNzLUNvbnRyb2wtQWxsb3ctT3Jp Z2luIiwgIioiKTsKKyAgICBtX2V4cGVjdGVkUmVzcG9uc2UuYWRkSFRUUEhlYWRlckZpZWxkKGhl YWRlck5hbWVTdHJpbmcsICJmb28iKTsKKyAgICB3ZWJraXRfc3VwcG9ydDo6UmVnaXN0ZXJNb2Nr ZWRVUkwodXJsLCBtX2V4cGVjdGVkUmVzcG9uc2UsIG1fZnJhbWVGaWxlUGF0aCk7CisKKyAgICBX ZWJVUkxMb2FkZXJPcHRpb25zIG9wdGlvbnM7CisgICAgb3B0aW9ucy5hbGxvd1Jlc3BvbnNlSGVh ZGVycyA9IHRydWU7IC8vIFRoaXMgdHVybnMgb2ZmIHJlc3BvbnNlIHdoaXRlbGlzdGluZy4KKyAg ICBvcHRpb25zLmNyb3NzT3JpZ2luUmVxdWVzdFBvbGljeSA9IFdlYlVSTExvYWRlck9wdGlvbnM6 OkNyb3NzT3JpZ2luUmVxdWVzdFBvbGljeVVzZUFjY2Vzc0NvbnRyb2w7CisgICAgbV9leHBlY3Rl ZExvYWRlciA9IGNyZWF0ZUFzc29jaWF0ZWRVUkxMb2FkZXIob3B0aW9ucyk7CisgICAgRVhQRUNU X1RSVUUobV9leHBlY3RlZExvYWRlcik7CisgICAgbV9leHBlY3RlZExvYWRlci0+bG9hZEFzeW5j aHJvbm91c2x5KHJlcXVlc3QsIHRoaXMpOworICAgIHNlcnZlUmVxdWVzdHMoKTsKKyAgICBFWFBF Q1RfVFJVRShtX2RpZFJlY2VpdmVSZXNwb25zZSk7CisgICAgRVhQRUNUX1RSVUUobV9kaWRSZWNl aXZlRGF0YSk7CisgICAgRVhQRUNUX1RSVUUobV9kaWRGaW5pc2hMb2FkaW5nKTsKKworICAgIEVY UEVDVF9GQUxTRShtX2FjdHVhbFJlc3BvbnNlLmh0dHBIZWFkZXJGaWVsZChoZWFkZXJOYW1lU3Ry aW5nKS5pc0VtcHR5KCkpOworfQorCiB9Cg== 147859 2012-06-15 11:03:16 -0700 2012-06-15 13:49:11 -0700 Proposed Patch aul.txt text/plain 4963 bbudge SW5kZXg6IFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNv dXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCShyZXZpc2lvbiAxMjA0NDEpCisrKyBTb3Vy Y2UvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIy IEBACisyMDEyLTA2LTE1ICBCaWxsIEJ1ZGdlICA8YmJ1ZGdlQGNocm9taXVtLm9yZz4KKworICAg ICAgICBBc3NvY2lhdGVkVVJMTG9hZGVyIHNob3VsZCBhbGxvdyB0cnVzdGVkIGNsaWVudHMgdG8g cmVhZCBhbGwgaGVhZGVycywgbm90IGp1c3QgZXhwb3NlZCBvbmVzLgorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODkxODUKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGlzIGNoYW5nZSBhZGRzIGFuIG9wdGlv biB0byB0dXJuIG9mZiB3aGl0ZWxpc3QgZmlsdGVyaW5nIG9mIHJlc3BvbnNlIGhlYWRlcnMgZm9y IENPUlMgbG9hZHMsCisgICAgICAgIGFuZCBtb2RpZmllcyBBc3NvY2lhdGVkVVJMTG9hZGVyIGNo ZWNrIGZvciB0aGF0IGJlZm9yZSBmaWx0ZXJpbmcuCisKKyAgICAgICAgKiBwdWJsaWMvV2ViVVJM TG9hZGVyT3B0aW9ucy5oOgorICAgICAgICAoV2ViS2l0OjpXZWJVUkxMb2FkZXJPcHRpb25zOjpX ZWJVUkxMb2FkZXJPcHRpb25zKToKKyAgICAgICAgKFdlYlVSTExvYWRlck9wdGlvbnMpOgorICAg ICAgICAqIHNyYy9Bc3NvY2lhdGVkVVJMTG9hZGVyLmNwcDoKKyAgICAgICAgKFdlYktpdDo6QXNz b2NpYXRlZFVSTExvYWRlcjo6Q2xpZW50QWRhcHRlcjo6ZGlkUmVjZWl2ZVJlc3BvbnNlKToKKyAg ICAgICAgKiB0ZXN0cy9Bc3NvY2lhdGVkVVJMTG9hZGVyVGVzdC5jcHA6CisgICAgICAgIChXZWJL aXQpOgorICAgICAgICAoV2ViS2l0OjpURVNUX0YpOgorCiAyMDEyLTA2LTE1ICBIaXJvbm9yaSBC b25vICA8aGJvbm9AY2hyb21pdW0ub3JnPgogCiAgICAgICAgIEFsbG93IHBsYXRmb3JtcyB0byBj aG9vc2Ugd2hldGhlciB0byByZW1vdmUgbWFya2VycyBvbiBlZGl0aW5nCkluZGV4OiBTb3VyY2Uv V2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJVUkxMb2FkZXJPcHRpb25zLmgKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gU291cmNlL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViVVJMTG9hZGVyT3B0aW9ucy5oCShy ZXZpc2lvbiAxMjA0MzgpCisrKyBTb3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJVUkxM b2FkZXJPcHRpb25zLmgJKHdvcmtpbmcgY29weSkKQEAgLTQ2LDYgKzQ2LDcgQEAgc3RydWN0IFdl YlVSTExvYWRlck9wdGlvbnMgewogICAgICAgICAsIHNuaWZmQ29udGVudChmYWxzZSkKICAgICAg ICAgLCBhbGxvd0NyZWRlbnRpYWxzKGZhbHNlKQogICAgICAgICAsIGZvcmNlUHJlZmxpZ2h0KGZh bHNlKQorICAgICAgICAsIGV4cG9zZUFsbFJlc3BvbnNlSGVhZGVycyhmYWxzZSkKICAgICAgICAg LCBjcm9zc09yaWdpblJlcXVlc3RQb2xpY3koQ3Jvc3NPcmlnaW5SZXF1ZXN0UG9saWN5RGVueSkK ICAgICAgICAgeyB9CiAKQEAgLTUzLDYgKzU0LDcgQEAgc3RydWN0IFdlYlVSTExvYWRlck9wdGlv bnMgewogICAgIGJvb2wgc25pZmZDb250ZW50OyAvLyBXaGV0aGVyIHRvIHNuaWZmIGNvbnRlbnQu CiAgICAgYm9vbCBhbGxvd0NyZWRlbnRpYWxzOyAvLyBXaGV0aGVyIHRvIHNlbmQgSFRUUCBjcmVk ZW50aWFscyBhbmQgY29va2llcyB3aXRoIHRoZSByZXF1ZXN0LgogICAgIGJvb2wgZm9yY2VQcmVm bGlnaHQ7IC8vIElmIHBvbGljeSBpcyB0byB1c2UgYWNjZXNzIGNvbnRyb2wsIHdoZXRoZXIgdG8g Zm9yY2UgYSBwcmVmbGlnaHQgZm9yIEdFVCwgSEVBRCwgYW5kIFBPU1QgcmVxdWVzdHMuCisgICAg Ym9vbCBleHBvc2VBbGxSZXNwb25zZUhlYWRlcnM7IC8vIElmIHBvbGljeSBpcyB0byB1c2UgYWNj ZXNzIGNvbnRyb2wsIHdoZXRoZXIgdG8gZXhwb3NlIG5vbi13aGl0ZWxpc3RlZCByZXNwb25zZSBo ZWFkZXJzIHRvIHRoZSBjbGllbnQuCiAgICAgQ3Jvc3NPcmlnaW5SZXF1ZXN0UG9saWN5IGNyb3Nz T3JpZ2luUmVxdWVzdFBvbGljeTsKIH07CiAKSW5kZXg6IFNvdXJjZS9XZWJLaXQvY2hyb21pdW0v c3JjL0Fzc29jaWF0ZWRVUkxMb2FkZXIuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQv Y2hyb21pdW0vc3JjL0Fzc29jaWF0ZWRVUkxMb2FkZXIuY3BwCShyZXZpc2lvbiAxMjA0MzgpCisr KyBTb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9Bc3NvY2lhdGVkVVJMTG9hZGVyLmNwcAkod29y a2luZyBjb3B5KQpAQCAtMjA5LDcgKzIwOSw5IEBAIHZvaWQgQXNzb2NpYXRlZFVSTExvYWRlcjo6 Q2xpZW50QWRhcHRlcjoKICAgICAvLyBUcnkgdG8gdXNlIHRoZSBvcmlnaW5hbCBSZXNvdXJjZVJl c3BvbnNlIGlmIHBvc3NpYmxlLgogICAgIFdlYlVSTFJlc3BvbnNlIHZhbGlkYXRlZFJlc3BvbnNl ID0gV3JhcHBlZFJlc291cmNlUmVzcG9uc2UocmVzcG9uc2UpOwogICAgIEhUVFBSZXNwb25zZUhl YWRlclZhbGlkYXRvciB2YWxpZGF0b3IobV9vcHRpb25zLmNyb3NzT3JpZ2luUmVxdWVzdFBvbGlj eSA9PSBXZWJVUkxMb2FkZXJPcHRpb25zOjpDcm9zc09yaWdpblJlcXVlc3RQb2xpY3lVc2VBY2Nl c3NDb250cm9sKTsKLSAgICB2YWxpZGF0ZWRSZXNwb25zZS52aXNpdEhUVFBIZWFkZXJGaWVsZHMo JnZhbGlkYXRvcik7CisgICAgaWYgKCFtX29wdGlvbnMuZXhwb3NlQWxsUmVzcG9uc2VIZWFkZXJz KQorICAgICAgICB2YWxpZGF0ZWRSZXNwb25zZS52aXNpdEhUVFBIZWFkZXJGaWVsZHMoJnZhbGlk YXRvcik7CisKICAgICAvLyBJZiB0aGVyZSBhcmUgYmxvY2tlZCBoZWFkZXJzLCBjb3B5IHRoZSBy ZXNwb25zZSBzbyB3ZSBjYW4gcmVtb3ZlIHRoZW0uCiAgICAgY29uc3QgSFRUUEhlYWRlclNldCYg YmxvY2tlZEhlYWRlcnMgPSB2YWxpZGF0b3IuYmxvY2tlZEhlYWRlcnMoKTsKICAgICBpZiAoIWJs b2NrZWRIZWFkZXJzLmlzRW1wdHkoKSkgewpJbmRleDogU291cmNlL1dlYktpdC9jaHJvbWl1bS90 ZXN0cy9Bc3NvY2lhdGVkVVJMTG9hZGVyVGVzdC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dl YktpdC9jaHJvbWl1bS90ZXN0cy9Bc3NvY2lhdGVkVVJMTG9hZGVyVGVzdC5jcHAJKHJldmlzaW9u IDEyMDQzOCkKKysrIFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vdGVzdHMvQXNzb2NpYXRlZFVSTExv YWRlclRlc3QuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC01ODUsNCArNTg1LDM0IEBAIFRFU1RfRihB c3NvY2lhdGVkVVJMTG9hZGVyVGVzdCwgQ3Jvc3NPcmkKICAgICBFWFBFQ1RfRkFMU0UoQ2hlY2tB Y2Nlc3NDb250cm9sSGVhZGVycygiU2V0LUNvb2tpZSIsIHRydWUpKTsKIH0KIAorLy8gVGVzdCB0 aGF0IHRoZSBsb2FkZXIgY2FuIGFsbG93IG5vbi13aGl0ZWxpc3RlZCByZXNwb25zZSBoZWFkZXJz IGZvciB0cnVzdGVkIENPUlMgbG9hZHMuCitURVNUX0YoQXNzb2NpYXRlZFVSTExvYWRlclRlc3Qs IENyb3NzT3JpZ2luSGVhZGVyQWxsb3dSZXNwb25zZUhlYWRlcnMpCit7CisgICAgV2ViVVJMUmVx dWVzdCByZXF1ZXN0OworICAgIHJlcXVlc3QuaW5pdGlhbGl6ZSgpOworICAgIEdVUkwgdXJsID0g R1VSTCgiaHR0cDovL3d3dy5vdGhlci5jb20vQ3Jvc3NPcmlnaW5IZWFkZXJBbGxvd1Jlc3BvbnNl SGVhZGVycy5odG1sIik7CisgICAgcmVxdWVzdC5zZXRVUkwodXJsKTsKKworICAgIFdlYlN0cmlu ZyBoZWFkZXJOYW1lU3RyaW5nKFdlYlN0cmluZzo6ZnJvbVVURjgoIm5vbi13aGl0ZWxpc3RlZCIp KTsKKyAgICBtX2V4cGVjdGVkUmVzcG9uc2UgPSBXZWJVUkxSZXNwb25zZSgpOworICAgIG1fZXhw ZWN0ZWRSZXNwb25zZS5pbml0aWFsaXplKCk7CisgICAgbV9leHBlY3RlZFJlc3BvbnNlLnNldE1J TUVUeXBlKCJ0ZXh0L2h0bWwiKTsKKyAgICBtX2V4cGVjdGVkUmVzcG9uc2UuYWRkSFRUUEhlYWRl ckZpZWxkKCJBY2Nlc3MtQ29udHJvbC1BbGxvdy1PcmlnaW4iLCAiKiIpOworICAgIG1fZXhwZWN0 ZWRSZXNwb25zZS5hZGRIVFRQSGVhZGVyRmllbGQoaGVhZGVyTmFtZVN0cmluZywgImZvbyIpOwor ICAgIHdlYmtpdF9zdXBwb3J0OjpSZWdpc3Rlck1vY2tlZFVSTCh1cmwsIG1fZXhwZWN0ZWRSZXNw b25zZSwgbV9mcmFtZUZpbGVQYXRoKTsKKworICAgIFdlYlVSTExvYWRlck9wdGlvbnMgb3B0aW9u czsKKyAgICBvcHRpb25zLmV4cG9zZUFsbFJlc3BvbnNlSGVhZGVycyA9IHRydWU7IC8vIFRoaXMg dHVybnMgb2ZmIHJlc3BvbnNlIHdoaXRlbGlzdGluZy4KKyAgICBvcHRpb25zLmNyb3NzT3JpZ2lu UmVxdWVzdFBvbGljeSA9IFdlYlVSTExvYWRlck9wdGlvbnM6OkNyb3NzT3JpZ2luUmVxdWVzdFBv bGljeVVzZUFjY2Vzc0NvbnRyb2w7CisgICAgbV9leHBlY3RlZExvYWRlciA9IGNyZWF0ZUFzc29j aWF0ZWRVUkxMb2FkZXIob3B0aW9ucyk7CisgICAgRVhQRUNUX1RSVUUobV9leHBlY3RlZExvYWRl cik7CisgICAgbV9leHBlY3RlZExvYWRlci0+bG9hZEFzeW5jaHJvbm91c2x5KHJlcXVlc3QsIHRo aXMpOworICAgIHNlcnZlUmVxdWVzdHMoKTsKKyAgICBFWFBFQ1RfVFJVRShtX2RpZFJlY2VpdmVS ZXNwb25zZSk7CisgICAgRVhQRUNUX1RSVUUobV9kaWRSZWNlaXZlRGF0YSk7CisgICAgRVhQRUNU X1RSVUUobV9kaWRGaW5pc2hMb2FkaW5nKTsKKworICAgIEVYUEVDVF9GQUxTRShtX2FjdHVhbFJl c3BvbnNlLmh0dHBIZWFkZXJGaWVsZChoZWFkZXJOYW1lU3RyaW5nKS5pc0VtcHR5KCkpOworfQor CiB9Cg==