89180 2012-06-15 00:11:07 -0700 Event dispatcher should use InsertionPoint::hasDistribution instead of InsertinPoint::isActive in re-targeting. 2012-06-18 12:18:36 -0700 1 1 1 Unclassified WebKit UI Events 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 89073 1 hayato hayato dglazkov dominicc morrita shinyak tasak webkit.review.bot oldest_to_newest 649949 0 hayato 2012-06-15 00:11:07 -0700 Event dispatcher should use InsertionPoint::hasDistribution() instead of InsertionPoint::isActive() in re-targeting. InsertionPoint::isActive() returns true even when the insertion point does not select any nodes and has fallback elements. That causes a wrong re-targeting result. 649993 1 147767 hayato 2012-06-15 01:00:10 -0700 Created attachment 147767 fix 651614 2 147767 webkit.review.bot 2012-06-18 12:18:30 -0700 Comment on attachment 147767 fix Clearing flags on attachment: 147767 Committed r120615: <http://trac.webkit.org/changeset/120615> 651615 3 webkit.review.bot 2012-06-18 12:18:36 -0700 All reviewed patches have been landed. Closing bug. 147767 2012-06-15 01:00:10 -0700 2012-06-18 12:18:30 -0700 fix bug-89180-20120615170009.patch text/plain 5491 hayato U3VidmVyc2lvbiBSZXZpc2lvbjogMTIwMzk4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggODMwYTVjZTcwNzBkMWFj YWQ5ZDUxZTU2YTQzM2QyZWU2MTc3YTk3YS4uY2RhNmFmOGZkNzkzN2FmNDlkNWU0NzkwMDI4NzI5 NWNjYmM5ZDJkMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDEyLTA2LTE1ICBIYXlh dG8gSXRvICA8aGF5YXRvQGNocm9taXVtLm9yZz4KKworICAgICAgICBFdmVudCBkaXNwYXRjaGVy IHNob3VsZCB1c2UgSW5zZXJ0aW9uUG9pbnQ6Omhhc0Rpc3RyaWJ1dGlvbiBpbnN0ZWFkIG9mIElu c2VydGluUG9pbnQ6OmlzQWN0aXZlIGluIHJlLXRhcmdldGluZy4KKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTg5MTgwCisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgSWYgYW4gZXZlbnQgaXMgZmlyZWQgb24gYSBm YWxsYmFjayBlbGVtZW50IHdpdGhpbiBhIGluc2VydGlvbgorICAgICAgICBwb2ludCB3aGljaCBk b2VzIG5vdCBzZWxlY3QgYW55IG5vZGVzLCB0aGUgcmVzdWx0IG9mIGV2ZW50J3MKKyAgICAgICAg cmUtdGFyZ2V0aW5nIHdpbGwgYmUgd3Jvbmcgc2luY2UgaXQgdXNlcworICAgICAgICBJbnNlcnRp b25Qb2ludDo6aXNBY3RpdmUoKSB0byBqdWRnZSBhbiBleGlzdGVuY2Ugb2YgYSBsb3dlciBib3Vu ZGFyeS4KKyAgICAgICAgVGhhdCBtdXN0IHVzZSBJbnNlcnRpb25Qb2ludDo6aGFzRGlzdHJpYnV0 aW9uKCkuCisKKyAgICAgICAgVGVzdDogZmFzdC9kb20vc2hhZG93L3NoYWRvdy1kb20tZXZlbnQt ZGlzcGF0Y2hpbmcuaHRtbAorCisgICAgICAgICogZG9tL0V2ZW50RGlzcGF0Y2hlci5jcHA6Cisg ICAgICAgIChXZWJDb3JlOjpFdmVudERpc3BhdGNoZXI6OmVuc3VyZUV2ZW50QW5jZXN0b3JzKToK KwogMjAxMi0wNi0xNCAgQWRyaWVubmUgV2Fsa2VyICA8ZW5uZUBnb29nbGUuY29tPgogCiAgICAg ICAgIFtjaHJvbWl1bV0gTWFrZSBUaWxlZExheWVyQ2hyb21pdW0gcm9idXN0IHRvIHVuZXhwZWN0 ZWQgbnVsbCB0aWxlcwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvZG9tL0V2ZW50RGlzcGF0 Y2hlci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9kb20vRXZlbnREaXNwYXRjaGVyLmNwcAppbmRleCBi NTRiYmJlZTYxOGRhMzJhNDA3NzRhZWYxMWUyMjA2NmI4OGFhMTMwLi41ODBiMDBiN2Q3NTJhMGE0 YjVmNWFjMjIwNWMyZDYzZWNjODMxMTI0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9kb20v RXZlbnREaXNwYXRjaGVyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9kb20vRXZlbnREaXNwYXRj aGVyLmNwcApAQCAtMjA1LDcgKzIwNSw3IEBAIHZvaWQgRXZlbnREaXNwYXRjaGVyOjplbnN1cmVF dmVudEFuY2VzdG9ycyhFdmVudCogZXZlbnQpCiAgICAgVmVjdG9yPEV2ZW50VGFyZ2V0Kj4gdGFy Z2V0U3RhY2s7CiAgICAgZm9yIChDb21wb3NlZFNoYWRvd1RyZWVQYXJlbnRXYWxrZXIgd2Fsa2Vy KG1fbm9kZS5nZXQoKSk7IHdhbGtlci5nZXQoKTsgd2Fsa2VyLnBhcmVudEluY2x1ZGluZ0luc2Vy dGlvblBvaW50QW5kU2hhZG93Um9vdCgpKSB7CiAgICAgICAgIE5vZGUqIG5vZGUgPSB3YWxrZXIu Z2V0KCk7Ci0gICAgICAgIGlmIChpc0FjdGl2ZUluc2VydGlvblBvaW50KG5vZGUpIHx8IHRhcmdl dFN0YWNrLmlzRW1wdHkoKSkKKyAgICAgICAgaWYgKChpc0luc2VydGlvblBvaW50KG5vZGUpICYm IHRvSW5zZXJ0aW9uUG9pbnQobm9kZSktPmhhc0Rpc3RyaWJ1dGlvbigpKSB8fCB0YXJnZXRTdGFj ay5pc0VtcHR5KCkpCiAgICAgICAgICAgICB0YXJnZXRTdGFjay5hcHBlbmQoZXZlbnRUYXJnZXRS ZXNwZWN0aW5nU1ZHVGFyZ2V0UnVsZXMobm9kZSkpOwogICAgICAgICBtX2FuY2VzdG9ycy5hcHBl bmQoRXZlbnRDb250ZXh0KG5vZGUsIGV2ZW50VGFyZ2V0UmVzcGVjdGluZ1NWR1RhcmdldFJ1bGVz KG5vZGUpLCB0YXJnZXRTdGFjay5sYXN0KCkpKTsKICAgICAgICAgaWYgKCFpbkRvY3VtZW50KQpk aWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9n CmluZGV4IDUxNjMzZWVjYWM0YzRhMTcwMDAwZTM3ODU1ZDc4NTg2Njk2MDlhNmUuLjMwMzkxM2Zl OGFkMzczMDNlY2Q2ZTU5N2NlNGYzMmE2MTBmZTZiOGIgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3Rz L0NoYW5nZUxvZworKysgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAor MjAxMi0wNi0xNSAgSGF5YXRvIEl0byAgPGhheWF0b0BjaHJvbWl1bS5vcmc+CisKKyAgICAgICAg RXZlbnQgZGlzcGF0Y2hlciBzaG91bGQgdXNlIEluc2VydGlvblBvaW50OjpoYXNEaXN0cmlidXRp b24gaW5zdGVhZCBvZiBJbnNlcnRpblBvaW50Ojppc0FjdGl2ZSBpbiByZS10YXJnZXRpbmcuCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04OTE4MAorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogZmFzdC9kb20v c2hhZG93L3NoYWRvdy1kb20tZXZlbnQtZGlzcGF0Y2hpbmctZXhwZWN0ZWQudHh0OgorICAgICAg ICAqIGZhc3QvZG9tL3NoYWRvdy9zaGFkb3ctZG9tLWV2ZW50LWRpc3BhdGNoaW5nLmh0bWw6CisK IDIwMTItMDYtMTQgIEtlbnQgVGFtdXJhICA8dGtlbnRAY2hyb21pdW0ub3JnPgogCiAgICAgICAg IFZhbGlkYXRlIGZvcm0gc3RhdGUgc3RyaW5ncyBpbiBGb3JtQ29udHJvbGxlcjo6c2V0U3RhdGVG b3JOZXdGb3JtRWxlbWVudHMoKQpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9kb20vc2hh ZG93L3NoYWRvdy1kb20tZXZlbnQtZGlzcGF0Y2hpbmctZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVz dHMvZmFzdC9kb20vc2hhZG93L3NoYWRvdy1kb20tZXZlbnQtZGlzcGF0Y2hpbmctZXhwZWN0ZWQu dHh0CmluZGV4IGZmMmYxNGJkNjc1ZGFhZTc4YzI1NjNmZThhMGNlYzQyNjEyMDRmNDEuLmNlZTk4 ODlhZjNmZmJlYjhjNTcwYzExNzI3NjE4YmI5ZjlkYTkxMmYgMTAwNjQ0Ci0tLSBhL0xheW91dFRl c3RzL2Zhc3QvZG9tL3NoYWRvdy9zaGFkb3ctZG9tLWV2ZW50LWRpc3BhdGNoaW5nLWV4cGVjdGVk LnR4dAorKysgYi9MYXlvdXRUZXN0cy9mYXN0L2RvbS9zaGFkb3cvc2hhZG93LWRvbS1ldmVudC1k aXNwYXRjaGluZy1leHBlY3RlZC50eHQKQEAgLTM5OSw2ICszOTksMzIgQEAgQ2xpY2sgbm9uLWRp c3RyaWJ1dGVkLW5vZGUKICAgICAgQG5vbi1kaXN0cmlidXRlZC1ub2RlICh0YXJnZXQ6IG5vbi1k aXN0cmlidXRlZC1ub2RlKQogICAgICBAQSAodGFyZ2V0OiBub24tZGlzdHJpYnV0ZWQtbm9kZSkK ICAgICAgQHRvcCAodGFyZ2V0OiBub24tZGlzdHJpYnV0ZWQtbm9kZSkKKworCitDb21wb3NlZCBT aGFkb3cgVHJlZSB3aWxsIGJlOgorRElWCSBpZD1zYW5kYm94CisJRElWCSBpZD10b3AKKwkJRElW CSBpZD1BCisJCQlESVYJIGlkPWZhbGxiYWNrCisKKworTW92aW5nIG1vdXNlIGZyb20gQS9mYWxs YmFjayB0byBBCisKKyAgbW91c2VvdXQKKyAgICAgQGZhbGxiYWNrICh0YXJnZXQ6IGZhbGxiYWNr KSAocmVsYXRlZDogQSkKKyAgICAgQGNvbnRlbnQgKHRhcmdldDogZmFsbGJhY2spIChyZWxhdGVk OiBBKQorICAgICBAc2hhZG93LXJvb3QgKHRhcmdldDogZmFsbGJhY2spIChyZWxhdGVkOiBBKQor CisgIG1vdXNlb3ZlcgorCitNb3ZpbmcgbW91c2UgZnJvbSBBIHRvIEEvZmFsbGJhY2sKKworICBt b3VzZW91dAorCisgIG1vdXNlb3ZlcgorICAgICBAZmFsbGJhY2sgKHRhcmdldDogZmFsbGJhY2sp IChyZWxhdGVkOiBBKQorICAgICBAY29udGVudCAodGFyZ2V0OiBmYWxsYmFjaykgKHJlbGF0ZWQ6 IEEpCisgICAgIEBzaGFkb3ctcm9vdCAodGFyZ2V0OiBmYWxsYmFjaykgKHJlbGF0ZWQ6IEEpCiBQ QVNTIHN1Y2Nlc3NmdWxseVBhcnNlZCBpcyB0cnVlCiAKIFRFU1QgQ09NUExFVEUKZGlmZiAtLWdp dCBhL0xheW91dFRlc3RzL2Zhc3QvZG9tL3NoYWRvdy9zaGFkb3ctZG9tLWV2ZW50LWRpc3BhdGNo aW5nLmh0bWwgYi9MYXlvdXRUZXN0cy9mYXN0L2RvbS9zaGFkb3cvc2hhZG93LWRvbS1ldmVudC1k aXNwYXRjaGluZy5odG1sCmluZGV4IGM0Mjc3ODE4NDg5ZjI1NjMwOWQ5YzgxMWUxNDk5OWIzZjUy MDhlNTAuLjM0ZGQ1NDc3ZTBkM2ZhOWI5NjBhMjJkMTlkZGNmNzgwYWNmOWViZTYgMTAwNjQ0Ci0t LSBhL0xheW91dFRlc3RzL2Zhc3QvZG9tL3NoYWRvdy9zaGFkb3ctZG9tLWV2ZW50LWRpc3BhdGNo aW5nLmh0bWwKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9kb20vc2hhZG93L3NoYWRvdy1kb20tZXZl bnQtZGlzcGF0Y2hpbmcuaHRtbApAQCAtMzUyLDYgKzM1MiwyNSBAQCBmdW5jdGlvbiB0ZXN0RXZl bnRzT25Ob25EaXN0cmlidXRlZE5vZGVzKCkKICAgICBkZWJ1Z0Rpc3BhdGNoZWRFdmVudCgnY2xp Y2snKTsKIH0KIAorZnVuY3Rpb24gdGVzdEV2ZW50c09uRmFsbGJhY2tFbGVtZW50cygpCit7Cisg ICAgc2FuZGJveC5pbm5lckhUTUwgPSAnJzsKKyAgICBzYW5kYm94LmFwcGVuZENoaWxkKAorICAg ICAgICBjcmVhdGVET00oJ2RpdicsIHsnaWQnOiAndG9wJ30sCisgICAgICAgICAgICAgICAgICBj cmVhdGVET00oJ2RpdicsIHsnaWQnOiAnQSd9LAorICAgICAgICAgICAgICAgICAgICAgICAgICAg IGNyZWF0ZVNoYWRvd1Jvb3QoCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGNyZWF0 ZURPTSgnY29udGVudCcsIHsnaWQnOiAnY29udGVudCcsICdzZWxlY3QnOiAnI25vbmUnfSwKKyAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGNyZWF0ZURPTSgnZGl2Jywg eydpZCc6ICdmYWxsYmFjayd9KSkpLAorICAgICAgICAgICAgICAgICAgICAgICAgICAgIGNyZWF0 ZURPTSgnZGl2JywgeydpZCc6ICdCJ30pKSkpOworCisgICAgYWRkRXZlbnRMaXN0ZW5lcnMoWyd0 b3AnLCAnQScsICdCJywgJ0EvJywgJ0EvY29udGVudCcsICdBL2ZhbGxiYWNrJ10pOworICAgIGdl dE5vZGVJblNoYWRvd1RyZWVTdGFjaygnQS8nKS5pZCA9ICdzaGFkb3ctcm9vdCc7CisgICAgc2hv d1NhbmRib3hUcmVlKCk7CisKKyAgICBtb3ZlTW91c2UoJ0EvZmFsbGJhY2snLCAnQScpOworICAg IG1vdmVNb3VzZSgnQScsICdBL2ZhbGxiYWNrJyk7Cit9CisKIGZ1bmN0aW9uIHRlc3QoKQogewog ICAgIGlmICh3aW5kb3cubGF5b3V0VGVzdENvbnRyb2xsZXIpCkBAIC0zNjYsNiArMzg1LDcgQEAg ZnVuY3Rpb24gdGVzdCgpCiAgICAgdGVzdEV2ZW50c09uQ2hpbGRPZkluYWN0aXZlQ29udGVudCgp OwogICAgIHRlc3RFdmVudHNPbk11bHRpcGxlU2hhZG93Um9vdHMoKTsKICAgICB0ZXN0RXZlbnRz T25Ob25EaXN0cmlidXRlZE5vZGVzKCk7CisgICAgdGVzdEV2ZW50c09uRmFsbGJhY2tFbGVtZW50 cygpOwogfQogCiB0ZXN0KCk7Cg==