<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>89177</bug_id>
          
          <creation_ts>2012-06-14 23:45:02 -0700</creation_ts>
          <short_desc>CompositeShadowTreeWalker should use InsertionPoint::hasDistribution instead of InsertionPoint::isActive</short_desc>
          <delta_ts>2012-06-28 16:06:23 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>DOM</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          <blocked>78585</blocked>
    
    <blocked>89732</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Hayato Ito">hayato</reporter>
          <assigned_to name="Hayato Ito">hayato</assigned_to>
          <cc>dglazkov</cc>
    
    <cc>dominicc</cc>
    
    <cc>morrita</cc>
    
    <cc>shinyak</cc>
    
    <cc>tasak</cc>
    
    <cc>webkit.review.bot</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>649929</commentid>
    <comment_count>0</comment_count>
    <who name="Hayato Ito">hayato</who>
    <bug_when>2012-06-14 23:45:02 -0700</bug_when>
    <thetext>Currently, CompositeShadowTreeWalker uses InsertionPoint::isActive() to judge whether there are distributed nodes into the insertion point.
But that is wrong. That should use InsertionPoint::hasDistribution() since InsertionPoint::isActive() return true when the insertion point which does not select any node and has fallback elements.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>649945</commentid>
    <comment_count>1</comment_count>
    <who name="Hayato Ito">hayato</who>
    <bug_when>2012-06-15 00:05:37 -0700</bug_when>
    <thetext>WONTFIX. CompositeShadowTreeWalker is innocent.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>650062</commentid>
    <comment_count>2</comment_count>
    <who name="Hayato Ito">hayato</who>
    <bug_when>2012-06-15 03:33:40 -0700</bug_when>
    <thetext>Reopened. ComposedShadowTreeWalker wrongly traverses nodes in the following case:

&lt;div&gt;
     #shadow-root
        &lt;content&gt;
            &lt;div id=fallback&gt;
    &lt;div id=distributed-node&gt;

If ComposendShadowTreeWalker traverses this tree, starting with #fallback element, it wrongly *escapes* out of the parent &lt;content&gt; element. Since a #fallback element is not used in composed shadow dom tree, it should be treated as orphaned subtree.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>650073</commentid>
    <comment_count>3</comment_count>
      <attachid>147789</attachid>
    <who name="Hayato Ito">hayato</who>
    <bug_when>2012-06-15 03:59:20 -0700</bug_when>
    <thetext>Created attachment 147789
fix</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>659921</commentid>
    <comment_count>4</comment_count>
      <attachid>147789</attachid>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2012-06-28 16:06:15 -0700</bug_when>
    <thetext>Comment on attachment 147789
fix

Clearing flags on attachment: 147789

Committed r121481: &lt;http://trac.webkit.org/changeset/121481&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>659922</commentid>
    <comment_count>5</comment_count>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2012-06-28 16:06:23 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>147789</attachid>
            <date>2012-06-15 03:59:20 -0700</date>
            <delta_ts>2012-06-28 16:06:15 -0700</delta_ts>
            <desc>fix</desc>
            <filename>bug-89177-20120615195919.patch</filename>
            <type>text/plain</type>
            <size>6195</size>
            <attacher name="Hayato Ito">hayato</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMTIwMzk4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggODMwYTVjZTcwNzBkMWFj
YWQ5ZDUxZTU2YTQzM2QyZWU2MTc3YTk3YS4uZmUyMjVhMTg5MTg3MTFlMjJjOTQ1ZTVkYjVmZjU3
OTFmYjFkOTc2OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDEyLTA2LTE1ICBIYXlh
dG8gSXRvICA8aGF5YXRvQGNocm9taXVtLm9yZz4KKworICAgICAgICBDb21wb3NpdGVTaGFkb3dU
cmVlV2Fsa2VyIHNob3VsZCB1c2UgSW5zZXJ0aW9uUG9pbnQ6Omhhc0Rpc3RyaWJ1dGlvbigpIGlu
c3RlYWQgb2YgSW5zZXJ0aW9uUG9pbnQ6OmlzQWN0aXZlKCkuCisgICAgICAgIGh0dHBzOi8vYnVn
cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04OTE3NworCisgICAgICAgIFJldmlld2VkIGJ5
IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFByZXZlbnRzIENvbXBvc2VkU2hhZG93VHJlZVdh
bGtlciBmcm9tIGVzY2FwaW5nIG91dCBvZiBhbgorICAgICAgICBpbnNlcnRpb24gcG9pbnQgKHdo
aWNoIGhhcyBkaXN0cmlidXRlZCBub2RlcykgZnJvbSBhIG5vbi11c2VkCisgICAgICAgIGZhbGxi
YWNrIGVsZW1lbnQgaW4gdGhlIGluc2VydGlvbiBwb2ludC4gIFN1Y2ggYSBmYWxsYmFjayBlbGVt
ZW50CisgICAgICAgIHNob3VsZCBiZSB0cmVhdGVkIGFzIGluIGFuIG9ycGhhbmVkIHN1YnRyZWUu
CisKKyAgICAgICAgQ29tcG9zZWRTaGFkb3dUcmVlUGFyZW50V2Fsa2VyIHdpbGwgYmUgYWxzbyBm
aXhlZCBpbiBhIGZvbGxvdy11cCBwYXRjaC4KKworICAgICAgICBUZXN0OiBmYXN0L2RvbS9zaGFk
b3cvY29tcG9zZWQtc2hhZG93LXRyZWUtd2Fsa2VyLmh0bWwKKworICAgICAgICAqIGRvbS9Db21w
b3NlZFNoYWRvd1RyZWVXYWxrZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6Q29tcG9zZWRTaGFk
b3dUcmVlV2Fsa2VyOjp0cmF2ZXJzZU5vZGVFc2NhcGluZ0ZhbGxiYWNrQ29udGVudHMpOgorCiAy
MDEyLTA2LTE0ICBBZHJpZW5uZSBXYWxrZXIgIDxlbm5lQGdvb2dsZS5jb20+CiAKICAgICAgICAg
W2Nocm9taXVtXSBNYWtlIFRpbGVkTGF5ZXJDaHJvbWl1bSByb2J1c3QgdG8gdW5leHBlY3RlZCBu
dWxsIHRpbGVzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9kb20vQ29tcG9zZWRTaGFkb3dU
cmVlV2Fsa2VyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2RvbS9Db21wb3NlZFNoYWRvd1RyZWVXYWxr
ZXIuY3BwCmluZGV4IGE0ODM0NWFiNmM2MzhhNGRhMmQzZDBkNmJlZDA0ZjZiOTQxMmUzNWYuLjdm
YWFmOGFkYzVkY2RmNjlmYzE0NDE3ZTlmYWJlOTU3OTQ5NjJjOWEgMTAwNjQ0Ci0tLSBhL1NvdXJj
ZS9XZWJDb3JlL2RvbS9Db21wb3NlZFNoYWRvd1RyZWVXYWxrZXIuY3BwCisrKyBiL1NvdXJjZS9X
ZWJDb3JlL2RvbS9Db21wb3NlZFNoYWRvd1RyZWVXYWxrZXIuY3BwCkBAIC0xODgsOSArMTg4LDEx
IEBAIE5vZGUqIENvbXBvc2VkU2hhZG93VHJlZVdhbGtlcjo6ZXNjYXBlRmFsbGJhY2tDb250ZW50
RWxlbWVudChjb25zdCBOb2RlKiBub2RlLCBUCiBOb2RlKiBDb21wb3NlZFNoYWRvd1RyZWVXYWxr
ZXI6OnRyYXZlcnNlTm9kZUVzY2FwaW5nRmFsbGJhY2tDb250ZW50cyhjb25zdCBOb2RlKiBub2Rl
KSBjb25zdAogewogICAgIEFTU0VSVChub2RlKTsKLSAgICBpZiAoaXNBY3RpdmVJbnNlcnRpb25Q
b2ludChub2RlKSkKLSAgICAgICAgcmV0dXJuIHRyYXZlcnNlUGFyZW50KG5vZGUpOwotICAgIHJl
dHVybiBjb25zdF9jYXN0PE5vZGUqPihub2RlKTsKKyAgICBpZiAoIWlzSW5zZXJ0aW9uUG9pbnQo
bm9kZSkpCisgICAgICAgIHJldHVybiBjb25zdF9jYXN0PE5vZGUqPihub2RlKTsKKyAgICBjb25z
dCBJbnNlcnRpb25Qb2ludCogaW5zZXJ0aW9uUG9pbnQgPSB0b0luc2VydGlvblBvaW50KG5vZGUp
OworICAgIHJldHVybiBpbnNlcnRpb25Qb2ludC0+aGFzRGlzdHJpYnV0aW9uKCkgPyAwIDoKKyAg
ICAgICAgaW5zZXJ0aW9uUG9pbnQtPmlzQWN0aXZlKCkgPyB0cmF2ZXJzZVBhcmVudChub2RlKSA6
IGNvbnN0X2Nhc3Q8Tm9kZSo+KG5vZGUpOwogfQogCiB2b2lkIENvbXBvc2VkU2hhZG93VHJlZVdh
bGtlcjo6cGFyZW50KCkKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91
dFRlc3RzL0NoYW5nZUxvZwppbmRleCA1MTYzM2VlY2FjNGM0YTE3MDAwMGUzNzg1NWQ3ODU4NjY5
NjA5YTZlLi40MGI4YThkZGNkMGYwMGJkMmFiOWI1MzFhNThmN2MwZWFjYTdhMjhkIDEwMDY0NAot
LS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBA
IC0xLDMgKzEsMTMgQEAKKzIwMTItMDYtMTUgIEhheWF0byBJdG8gIDxoYXlhdG9AY2hyb21pdW0u
b3JnPgorCisgICAgICAgIENvbXBvc2l0ZVNoYWRvd1RyZWVXYWxrZXIgc2hvdWxkIHVzZSBJbnNl
cnRpb25Qb2ludDo6aGFzRGlzdHJpYnV0aW9uKCkgaW5zdGVhZCBvZiBJbnNlcnRpb25Qb2ludDo6
aXNBY3RpdmUoKS4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp
P2lkPTg5MTc3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg
ICAgKiBmYXN0L2RvbS9zaGFkb3cvY29tcG9zZWQtc2hhZG93LXRyZWUtd2Fsa2VyLWV4cGVjdGVk
LnR4dDoKKyAgICAgICAgKiBmYXN0L2RvbS9zaGFkb3cvY29tcG9zZWQtc2hhZG93LXRyZWUtd2Fs
a2VyLmh0bWw6CisKIDIwMTItMDYtMTQgIEtlbnQgVGFtdXJhICA8dGtlbnRAY2hyb21pdW0ub3Jn
PgogCiAgICAgICAgIFZhbGlkYXRlIGZvcm0gc3RhdGUgc3RyaW5ncyBpbiBGb3JtQ29udHJvbGxl
cjo6c2V0U3RhdGVGb3JOZXdGb3JtRWxlbWVudHMoKQpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMv
ZmFzdC9kb20vc2hhZG93L2NvbXBvc2VkLXNoYWRvdy10cmVlLXdhbGtlci1leHBlY3RlZC50eHQg
Yi9MYXlvdXRUZXN0cy9mYXN0L2RvbS9zaGFkb3cvY29tcG9zZWQtc2hhZG93LXRyZWUtd2Fsa2Vy
LWV4cGVjdGVkLnR4dAppbmRleCBiNWZlOWU1Y2U3NDk2MDg2NDllYWRjYTljMjljZGEyOGFmYzll
YzQ5Li41ZmUzMDNhOTdiODhkNjM4NzUzMjM2YjAzMDVkYjUzYTQ1ZjQwYTczIDEwMDY0NAotLS0g
YS9MYXlvdXRUZXN0cy9mYXN0L2RvbS9zaGFkb3cvY29tcG9zZWQtc2hhZG93LXRyZWUtd2Fsa2Vy
LWV4cGVjdGVkLnR4dAorKysgYi9MYXlvdXRUZXN0cy9mYXN0L2RvbS9zaGFkb3cvY29tcG9zZWQt
c2hhZG93LXRyZWUtd2Fsa2VyLWV4cGVjdGVkLnR4dApAQCAtODcsNyArODcsNyBAQCBESVYJIGlk
PWYxCiBESVYJIGlkPWIKIERJVgkgaWQ9YQogCi1GYWxsYmFjayBlbGVtZW50cyBzaG91bGQgbm90
IGJlIHVzZWQgaWYgIGVsZW1lbnQgc2VsZWN0cyBhbnkgZWxlbWVudHMuCitGYWxsYmFjayBlbGVt
ZW50cyBzaG91bGQgbm90IGJlIHVzZWQgaWYgYSBjb250ZW50IGVsZW1lbnQgc2VsZWN0cyBhbiBl
bGVtZW50LgogQ29tcG9zZWQgU2hhZG93IFRyZWU6CiBESVYJIGlkPWEKIAlESVYJIGlkPWIKQEAg
LTEwMiw2ICsxMDIsMjEgQEAgRElWCSBpZD1jCiBESVYJIGlkPWIKIERJVgkgaWQ9YQogCitUZXN0
IGZvciB0cmF2ZXJzYWwsIHN0YXJ0aW5nIHdpdGggYSBmYWxsYmFjayBlbGVtZW50IHdoaWNoIGlz
IG5vdCB1c2VkLgorQ29tcG9zZWQgU2hhZG93IFRyZWU6CitESVYJIGlkPWYxCisJRElWCSBpZD1m
MgorCitUcmF2ZXJzZSBpbiBmb3J3YXJkLgorRElWCSBpZD1mMQorRElWCSBpZD1mMgorVHJhdmVy
c2UgaW4gYmFja3dhcmQuCitESVYJIGlkPWYyCitESVYJIGlkPWYxCisKK05leHQgbm9kZSBvZiBb
RElWCSBpZD1mMV0gaXMgW0RJVgkgaWQ9ZjJdCitOZXh0IG5vZGUgb2YgW0RJVgkgaWQ9ZjJdIGlz
IFsobnVsbCldCisKIFRlc3QgZm9yIE5lc3RlZCBTaGFkb3dSb290cy4KIENvbXBvc2VkIFNoYWRv
dyBUcmVlOgogRElWCSBpZD1hCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L2RvbS9zaGFk
b3cvY29tcG9zZWQtc2hhZG93LXRyZWUtd2Fsa2VyLmh0bWwgYi9MYXlvdXRUZXN0cy9mYXN0L2Rv
bS9zaGFkb3cvY29tcG9zZWQtc2hhZG93LXRyZWUtd2Fsa2VyLmh0bWwKaW5kZXggYmE5YTRkZDll
MTE1MjFhZmQ2MTlkODNkZTdlZGNiZTk2OTg1YTQ2ZC4uODk1NzJmNDBmYmYyZmUwY2MzODhjOWVk
MTU1ZTI4MDNkNmQwMzk3YiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvZmFzdC9kb20vc2hhZG93
L2NvbXBvc2VkLXNoYWRvdy10cmVlLXdhbGtlci5odG1sCisrKyBiL0xheW91dFRlc3RzL2Zhc3Qv
ZG9tL3NoYWRvdy9jb21wb3NlZC1zaGFkb3ctdHJlZS13YWxrZXIuaHRtbApAQCAtMTUsNiArMTUs
OCBAQCBpZiAod2luZG93LmxheW91dFRlc3RDb250cm9sbGVyKQogCiBmdW5jdGlvbiBkdW1wTm9k
ZShub2RlKQogeworICAgIGlmICghbm9kZSkKKyAgICAgICAgcmV0dXJuICcobnVsbCknCiAgICAg
dmFyIG91dHB1dCA9IG5vZGUubm9kZU5hbWUgKyAiXHQiOwogICAgIGlmIChub2RlLmlkKQogICAg
ICAgICBvdXRwdXQgKz0gJyBpZD0nICsgbm9kZS5pZDsKQEAgLTc4LDYgKzgwLDExIEBAIGZ1bmN0
aW9uIHNob3dDb21wb3NlZFNoYWRvd1RyZWUobm9kZSkKICAgICBkZWJ1ZygnJyk7CiB9CiAKK2Z1
bmN0aW9uIHNob3dOZXh0Tm9kZShub2RlKSB7CisgICAgdmFyIG5leHQgPSBpbnRlcm5hbHMubmV4
dE5vZGVCeVdhbGtlcihub2RlKTsKKyAgICBkZWJ1ZygnTmV4dCBub2RlIG9mIFsnICsgZHVtcE5v
ZGUobm9kZSkgKyAnXSBpcyBbJyArIGR1bXBOb2RlKG5leHQpICsgJ10nKTsKK30KKwogZnVuY3Rp
b24gdGVzdENvbXBvc2VkU2hhZG93VHJlZShub2RlKQogewogICAgIHZhciBzYW5kYm94ID0gZG9j
dW1lbnQuZ2V0RWxlbWVudEJ5SWQoJ3NhbmRib3gnKTsKQEAgLTEyOSwxNSArMTM2LDIxIEBAIHRl
c3RDb21wb3NlZFNoYWRvd1RyZWUoCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgIGNyZWF0ZURPTSgnZGl2JywgeydpZCc6ICdmMid9KSkpLAogICAgICAgICAgICAgICBj
cmVhdGVET00oJ2RpdicsIHsnaWQnOiAnYyd9KSkpOwogCi1kZWJ1ZygnRmFsbGJhY2sgZWxlbWVu
dHMgc2hvdWxkIG5vdCBiZSB1c2VkIGlmIDxjb250ZW50PiBlbGVtZW50IHNlbGVjdHMgYW55IGVs
ZW1lbnRzLicpOworZGVidWcoJ0ZhbGxiYWNrIGVsZW1lbnRzIHNob3VsZCBub3QgYmUgdXNlZCBp
ZiBhIGNvbnRlbnQgZWxlbWVudCBzZWxlY3RzIGFuIGVsZW1lbnQuJyk7CiB0ZXN0Q29tcG9zZWRT
aGFkb3dUcmVlKAogICAgIGNyZWF0ZURPTSgnZGl2JywgeydpZCc6ICdhJ30sCiAgICAgICAgICAg
ICAgIGNyZWF0ZVNoYWRvd1Jvb3QoY3JlYXRlRE9NKCdkaXYnLCB7J2lkJzogJ2InfSksCiAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgY3JlYXRlRE9NKCdjb250ZW50JywgeydzZWxlY3Qn
OiAnI2MnfSwKLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgY3JlYXRl
RE9NKCdkaXYnLCB7J2lkJzogJ2YxJ30pLAotICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICBjcmVhdGVET00oJ2RpdicsIHsnaWQnOiAnZjInfSkpKSwKKyAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgY3JlYXRlRE9NKCdkaXYnLCB7J2lkJzogJ2Yx
J30sCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBj
cmVhdGVET00oJ2RpdicsIHsnaWQnOiAnZjInfSkpKSksCiAgICAgICAgICAgICAgIGNyZWF0ZURP
TSgnZGl2JywgeydpZCc6ICdjJ30pKSk7CiAKK2RlYnVnKCdUZXN0IGZvciB0cmF2ZXJzYWwsIHN0
YXJ0aW5nIHdpdGggYSBmYWxsYmFjayBlbGVtZW50IHdoaWNoIGlzIG5vdCB1c2VkLicpOworc2hv
d0NvbXBvc2VkU2hhZG93VHJlZShnZXROb2RlSW5TaGFkb3dUcmVlU3RhY2soJ2EvZjEnKSk7Citz
aG93TmV4dE5vZGUoZ2V0Tm9kZUluU2hhZG93VHJlZVN0YWNrKCdhL2YxJykpOworc2hvd05leHRO
b2RlKGdldE5vZGVJblNoYWRvd1RyZWVTdGFjaygnYS9mMicpKTsKK2RlYnVnKCcnKTsKKwogZGVi
dWcoJ1Rlc3QgZm9yIE5lc3RlZCBTaGFkb3dSb290cy4nKTsKIHRlc3RDb21wb3NlZFNoYWRvd1Ry
ZWUoCiAgICAgY3JlYXRlRE9NKCdkaXYnLCB7J2lkJzogJ2EnfSwK
</data>

          </attachment>
      

    </bug>

</bugzilla>