89165 2012-06-14 22:10:53 -0700 [BlackBerry] media volume slider in wrong position (master_38 regression) 2012-11-02 12:45:55 -0700 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Other Other CLOSED FIXED P2 Normal --- 1 mfeil mfeil jonathan.dong.webkit tonikitoo webkit.review.bot oldest_to_newest 649869 0 mfeil 2012-06-14 22:10:53 -0700 Due to upstream simplification of the volume slider (bug 82150) it now appears in the wrong location below the media controls. The programmatic controls sizing we do in RenderThemeBlackBerry.cpp relies on absolute positioning of the volume slider container, so the best way to fix this is to set the bottom offset. 649873 1 147731 mfeil 2012-06-14 22:14:04 -0700 Created attachment 147731 Patch 650150 2 147731 webkit.review.bot 2012-06-15 07:17:45 -0700 Comment on attachment 147731 Patch Clearing flags on attachment: 147731 Committed r120453: <http://trac.webkit.org/changeset/120453> 650151 3 webkit.review.bot 2012-06-15 07:17:50 -0700 All reviewed patches have been landed. Closing bug. 757486 4 mfeil 2012-11-02 12:45:55 -0700 Closing bug for patch that landed a long time ago. 147731 2012-06-14 22:14:04 -0700 2012-06-15 07:17:45 -0700 Patch bug-89165-20120615011403.patch text/plain 1918 mfeil U3VidmVyc2lvbiBSZXZpc2lvbjogMTIwMzk4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggODMwYTVjZTcwNzBkMWFj YWQ5ZDUxZTU2YTQzM2QyZWU2MTc3YTk3YS4uNjVmMGFiMGZkNjM4MWExODcyOTZjYWM2Mjc2N2Mz MDBkZTM1YThhYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDEyLTA2LTE0ICBNYXgg RmVpbCAgPG1mZWlsQHJpbS5jb20+CisKKyAgICAgICAgW0JsYWNrQmVycnldIG1lZGlhIHZvbHVt ZSBzbGlkZXIgaW4gd3JvbmcgcG9zaXRpb24gKG1hc3Rlcl8zOCByZWdyZXNzaW9uKQorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODkxNjUKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBEdWUgdG8gdXBzdHJlYW0g c2ltcGxpZmljYXRpb24gb2YgdGhlIHZvbHVtZSBzbGlkZXIgKHdlYmtpdC5vcmcKKyAgICAgICAg YnVnIDgyMTUwKSBpdCBub3cgYXBwZWFycyBpbiB0aGUgd3JvbmcgbG9jYXRpb24gYmVsb3cgdGhl CisgICAgICAgIG1lZGlhIGNvbnRyb2xzLiBUaGUgcHJvZ3JhbW1hdGljIGNvbnRyb2xzIHNpemlu ZyB3ZSBkbyBpbgorICAgICAgICBSZW5kZXJUaGVtZUJsYWNrQmVycnkuY3BwIHJlbGllcyBvbiBh YnNvbHV0ZSBwb3NpdGlvbmluZyBvZiB0aGUKKyAgICAgICAgdm9sdW1lIHNsaWRlciBjb250YWlu ZXIsIHNvIHRoZSBiZXN0IHdheSB0byBmaXggdGhpcyBpcyB0byBzZXQKKyAgICAgICAgdGhlIGJv dHRvbSBvZmZzZXQuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzIHNpbmNlIHRoaXMgaXMgYSByZWdy ZXNzaW9uIGZpeC4gQmxhY2tCZXJyeSBtZWRpYQorICAgICAgICBjb250cm9scyBhcmUgbWFudWFs bHkgdGVzdGVkLgorCisgICAgICAgICogcGxhdGZvcm0vYmxhY2tiZXJyeS9SZW5kZXJUaGVtZUJs YWNrQmVycnkuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyVGhlbWVCbGFja0JlcnJ5Ojph ZGp1c3RNZWRpYUNvbnRyb2xTdHlsZSk6CisKIDIwMTItMDYtMTQgIEFkcmllbm5lIFdhbGtlciAg PGVubmVAZ29vZ2xlLmNvbT4KIAogICAgICAgICBbY2hyb21pdW1dIE1ha2UgVGlsZWRMYXllckNo cm9taXVtIHJvYnVzdCB0byB1bmV4cGVjdGVkIG51bGwgdGlsZXMKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL2JsYWNrYmVycnkvUmVuZGVyVGhlbWVCbGFja0JlcnJ5LmNwcCBi L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2JsYWNrYmVycnkvUmVuZGVyVGhlbWVCbGFja0JlcnJ5 LmNwcAppbmRleCBhYmZhNWYwOWRhNWVmMjAzNTIwOWZhMTU0NGVkZjU4YWNkYzRiMjdlLi43ZTI1 ODgxNmZhNjdiYzFjMzU0OWExMTk4ODkzYjc0YTc2YTEwYjA2IDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9ibGFja2JlcnJ5L1JlbmRlclRoZW1lQmxhY2tCZXJyeS5jcHAKKysr IGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vYmxhY2tiZXJyeS9SZW5kZXJUaGVtZUJsYWNrQmVy cnkuY3BwCkBAIC03NzYsNiArNzc2LDcgQEAgdm9pZCBSZW5kZXJUaGVtZUJsYWNrQmVycnk6OmFk anVzdE1lZGlhQ29udHJvbFN0eWxlKFN0eWxlUmVzb2x2ZXIqLCBSZW5kZXJTdHlsZSoKICAgICBj YXNlIE1lZGlhVm9sdW1lU2xpZGVyQ29udGFpbmVyUGFydDoKICAgICAgICAgc3R5bGUtPnNldFdp ZHRoKGNvbnRyb2xzSGVpZ2h0KTsKICAgICAgICAgc3R5bGUtPnNldEhlaWdodCh2b2x1bWVIZWln aHQpOworICAgICAgICBzdHlsZS0+c2V0Qm90dG9tKGNvbnRyb2xzSGVpZ2h0KTsKICAgICAgICAg YnJlYWs7CiAgICAgZGVmYXVsdDoKICAgICAgICAgYnJlYWs7Cg==